From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Lee Jones <lee.jones@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] rtc: max77686: Do not allow interrupt to fire before system resume
Date: Thu, 16 Jul 2020 11:15:24 +0200 [thread overview]
Message-ID: <159489082551.8339.14774575575042463785.b4-ty@bootlin.com> (raw)
In-Reply-To: <20200615161455.4420-1-krzk@kernel.org>
On Mon, 15 Jun 2020 18:14:55 +0200, Krzysztof Kozlowski wrote:
> The rtc-max77686 device shares the main interrupt line with parent MFD
> device (max77686 driver). During the system suspend, the parent MFD
> device disables this IRQ to prevent an early event happening before
> resuming I2C bus controller.
>
> The same should be done by rtc-max77686 driver because otherwise the
> interrupt handler max77686_rtc_alarm_irq() will be called before its
> resume function (max77686_rtc_resume()). Such issue is not fatal but
> disabling shared IRQ by all users ensures correct behavior.
Applied, thanks!
[1/1] rtc: max77686: Do not allow interrupt to fire before system resume
commit: d8f090dbeafdcc3d30761aa0062f19d1adf9ef08
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
prev parent reply other threads:[~2020-07-16 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 16:14 [PATCH] rtc: max77686: Do not allow interrupt to fire before system resume Krzysztof Kozlowski
2020-06-29 22:23 ` Alexandre Belloni
2020-06-30 6:28 ` Krzysztof Kozlowski
2020-07-16 9:15 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159489082551.8339.14774575575042463785.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.