diff for duplicates of <1595450030.5211.53.camel@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 1b66c57..4b0f094 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,8 +3,8 @@ On Fri, 2020-07-17 at 16:57 -0400, Lachlan Sneff wrote: > validating the key measurement performed by IMA is needed. Isn't the main purpose of this patch to verify the certificate being -loaded onto a keyring is properly measured. The rest is just details. - Please update the Subject line accordingly. +loaded onto a keyring is properly measured. ?The rest is just details. +?Please update the Subject line accordingly. > Add an IMA measurement test that verifies that an x509 certificate > can be imported into a custom keyring and measured correctly. @@ -17,11 +17,11 @@ loaded onto a keyring is properly measured. The rest is just details. > key in certain kernel configurations. > -First describe the problem, then provide the solution. In this case, +First describe the problem, then provide the solution. ?In this case, perhaps something like: There may be restrictions importing a certificate onto a builtin -trusted keyring. For example ... For this reason, this test defines +trusted keyring. ?For example ... ? For this reason, this test defines a userspace keyring. (Please remember to limit the patch description line width to 72 @@ -67,7 +67,7 @@ chars.) > -As well as what's required for the IMA tests, the following are also required This patch adds a new test, that shouldn't affect the existing test. - If test1 changes, then it needs to be highlighted in the patch +?If test1 changes, then it needs to be highlighted in the patch description. > +As well as what's required for the IMA tests, the following is also required @@ -82,7 +82,7 @@ description. > -Test also requires loaded policy with `func=KEY_CHECK`, see example in `keycheck.policy`. > +You must also add the following line to /etc/ima/ima-policy and reboot. -Documentation should be written in the third person. For example, +Documentation should be written in the third person. ?For example, instead of "you must", "A key measurement rule must be defined in the IMA policy. For example, ...." @@ -120,7 +120,7 @@ This change doesn't look right. > -include $(top_srcdir)/include/mk/env_pre.mk > +include $(top_srcdir)/include/mk/env_pre.mk -Please review the actual patch before posting it. Changes like this +Please review the actual patch before posting it. ?Changes like this are unnecessary. > @@ -133,7 +133,7 @@ are unnecessary. > +include $(top_srcdir)/include/mk/generic_trunk_target.mk When making changes to someone else's code, please Cc them on the -change. Use "git blame" to get the commit author. +change. ?Use "git blame" to get the commit author. > diff --git a/testcases/kernel/security/integrity/ima/datafiles/keys/Makefile b/testcases/kernel/security/integrity/ima/datafiles/keys/Makefile > new file mode 100644 @@ -146,8 +146,8 @@ change. Use "git blame" to get the commit author. > +# > +# Copyright (C) 2009, Cisco Systems Inc. -Hm, aren't you working for Microsoft? If you're moving existing code, -please move that code separately from any other changes. Newer files +Hm, aren't you working for Microsoft? ?If you're moving existing code, +please move that code separately from any other changes. ?Newer files probably use the SPDX format. > +# @@ -271,13 +271,13 @@ probably use the SPDX format. > > +# Create a custom keyring and import a certficate to that -What is a custom keyring? Try inverting the sentence - "Import a +What is a custom keyring? ?Try inverting the sentence - "Import a certificate onto a newly created keyring." > +test2() { The patch description should mention this patch defines an additional -ima_keys.sh test. Another difference between test1 and test2 is that +ima_keys.sh test. ?Another difference between test1 and test2 is that doesn't require root privileges. diff --git a/a/content_digest b/N1/content_digest index a38aa17..f44c0cd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,8 @@ "ref\020200717205721.18173-1-t-josne@linux.microsoft.com\0" "From\0Mimi Zohar <zohar@linux.ibm.com>\0" - "Subject\0Re: [PATCH] IMA: Add a test to verify importing a certificate into custom keyring\0" + "Subject\0[LTP] [PATCH] IMA: Add a test to verify importing a certificate into custom keyring\0" "Date\0Wed, 22 Jul 2020 16:33:50 -0400\0" - "To\0Lachlan Sneff <t-josne@linux.microsoft.com>" - pvorel@suse.cz - " ltp@lists.linux.it\0" - "Cc\0nramas@linux.microsoft.com" - balajib@linux.microsoft.com - " linux-integrity@vger.kernel.org\0" + "To\0ltp@lists.linux.it\0" "\00:1\0" "b\0" "On Fri, 2020-07-17 at 16:57 -0400, Lachlan Sneff wrote:\n" @@ -15,8 +10,8 @@ "> validating the key measurement performed by IMA is needed.\n" "\n" "Isn't the main purpose of this patch to verify the certificate being\n" - "loaded onto a keyring is properly measured. \302\240The rest is just details.\n" - "\302\240Please update the Subject line accordingly.\n" + "loaded onto a keyring is properly measured. ?The rest is just details.\n" + "?Please update the Subject line accordingly.\n" "\n" "> Add an IMA measurement test that verifies that an x509 certificate\n" "> can be imported into a custom keyring and measured correctly.\n" @@ -29,11 +24,11 @@ "> key in certain kernel configurations.\n" "> \n" "\n" - "First describe the problem, then provide the solution. \302\240In this case,\n" + "First describe the problem, then provide the solution. ?In this case,\n" "perhaps something like:\n" "\n" "There may be restrictions importing a certificate onto a builtin\n" - "trusted keyring. \302\240For example ... \302\240 For this reason, this test defines\n" + "trusted keyring. ?For example ... ? For this reason, this test defines\n" "a userspace keyring.\n" "\n" "(Please remember to limit the patch description line width to 72\n" @@ -79,7 +74,7 @@ "> -As well as what's required for the IMA tests, the following are also required\n" "\n" "This patch adds a new test, that shouldn't affect the existing test.\n" - "\302\240If test1 changes, then it needs to be highlighted in the patch\n" + "?If test1 changes, then it needs to be highlighted in the patch\n" "description.\n" "\n" "> +As well as what's required for the IMA tests, the following is also required\n" @@ -94,7 +89,7 @@ "> -Test also requires loaded policy with `func=KEY_CHECK`, see example in `keycheck.policy`.\n" "> +You must also add the following line to /etc/ima/ima-policy and reboot.\n" "\n" - "Documentation should be written in the third person. \302\240For example,\n" + "Documentation should be written in the third person. ?For example,\n" "instead of \"you must\", \"A key measurement rule must be defined in the\n" "IMA policy. For example, ....\"\n" "\n" @@ -132,7 +127,7 @@ "> -include\t$(top_srcdir)/include/mk/env_pre.mk\n" "> +include $(top_srcdir)/include/mk/env_pre.mk\n" "\n" - "Please review the actual patch before posting it. \302\240Changes like this\n" + "Please review the actual patch before posting it. ?Changes like this\n" "are unnecessary.\n" "\n" "> \n" @@ -145,7 +140,7 @@ "> +include $(top_srcdir)/include/mk/generic_trunk_target.mk\n" "\n" "When making changes to someone else's code, please Cc them on the\n" - "change. \302\240Use \"git blame\" to get the commit author.\n" + "change. ?Use \"git blame\" to get the commit author.\n" "\n" "> diff --git a/testcases/kernel/security/integrity/ima/datafiles/keys/Makefile b/testcases/kernel/security/integrity/ima/datafiles/keys/Makefile\n" "> new file mode 100644\n" @@ -158,8 +153,8 @@ "> +#\n" "> +# Copyright (C) 2009, Cisco Systems Inc.\n" "\n" - "Hm, aren't you working for Microsoft? \302\240If you're moving existing code,\n" - "please move that code separately from any other changes. \302\240Newer files\n" + "Hm, aren't you working for Microsoft? ?If you're moving existing code,\n" + "please move that code separately from any other changes. ?Newer files\n" "probably use the SPDX format.\n" "\n" "> +#\n" @@ -283,13 +278,13 @@ "> \n" "> +# Create a custom keyring and import a certficate to that\n" "\n" - "What is a custom keyring? \302\240Try inverting the sentence - \"Import a\n" + "What is a custom keyring? ?Try inverting the sentence - \"Import a\n" "certificate onto a newly created keyring.\"\n" "\n" "> +test2() {\n" "\n" "The patch description should mention this patch defines an additional\n" - "ima_keys.sh test. \302\240Another difference between test1 and test2 is that\n" + "ima_keys.sh test. ?Another difference between test1 and test2 is that\n" "doesn't require root privileges.\n" "\n" "\n" @@ -339,4 +334,4 @@ "\n" Mimi -eabd5d0bc7b32625bbeff66d1085bf280127819c5a643673fa37e43a41ff4676 +a90a8d0bf0bcd85e1493c5dbf35714540ab7579c16fb7a31011135ea1c70e938
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.