diff for duplicates of <1595567665.24550.0.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index 263e364..7bf29bc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,32 @@ -T24gVGh1LCAyMDIwLTA3LTIzIGF0IDE3OjMyICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG -cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gVGhl -IHZhcmlhYmxlcyBhbnRfbnVtIGFuZCBzaW5nbGVfYW50X3BhdGggYXJlIGJlaW5nIGluaXRpYWxp -emVkIHdpdGggYQ0KPiB2YWx1ZSB0aGF0IGlzIG5ldmVyIHJlYWQgYW5kIGFyZSBiZWluZyB1cGRh -dGVkIGxhdGVyIHdpdGggYSBuZXcgdmFsdWUuDQo+IFRoZSBpbml0aWFsaXphdGlvbnMgYXJlIHJl -ZHVuZGFudCBhbmQgY2FuIGJlIHJlbW92ZWQuDQo+IA0KPiBBZGRyZXNzZXMtQ292ZXJpdHk6ICgi -VW51c2VkIHZhbHVlIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtp -bmdAY2Fub25pY2FsLmNvbT4NCg0KQWNrZWQtYnk6IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0 -ZWsuY29tPg0KDQpUaGFuayB5b3UNCg0KPiAtLS0NCj4gwqBkcml2ZXJzL25ldC93aXJlbGVzcy9y -ZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Y291dHNyYy5jIHwgMiArLQ0KPiDCoDEgZmls -ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdp -dCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnRsd2lmaS9idGNvZXhpc3QvaGFsYnRj -b3V0c3JjLmMNCj4gYi9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4 -aXN0L2hhbGJ0Y291dHNyYy5jDQo+IGluZGV4IGE0OTQwYTM4NDJkZS4uNDk0OWY5OTg0NGI1IDEw -MDY0NA0KPiAtLS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4 -aXN0L2hhbGJ0Y291dHNyYy5jDQo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsv -cnRsd2lmaS9idGNvZXhpc3QvaGFsYnRjb3V0c3JjLmMNCj4gQEAgLTEzMTgsNyArMTMxOCw3IEBA -IGJvb2wgZXhoYWxidGNfYmluZF9idF9jb2V4X3dpdGhhZGFwdGVyKHZvaWQgKmFkYXB0ZXIpDQo+ -IMKgew0KPiDCoAlzdHJ1Y3QgcnRsX3ByaXYgKnJ0bHByaXYgPSBhZGFwdGVyOw0KPiDCoAlzdHJ1 -Y3QgYnRjX2NvZXhpc3QgKmJ0Y29leGlzdCA9IHJ0bF9idGNfY29leGlzdChydGxwcml2KTsNCj4g -LQl1OCBhbnRfbnVtID0gMiwgY2hpcF90eXBlLCBzaW5nbGVfYW50X3BhdGggPSAwOw0KPiArCXU4 -IGFudF9udW0sIGNoaXBfdHlwZSwgc2luZ2xlX2FudF9wYXRoOw0KPiDCoA0KPiDCoAlpZiAoIWJ0 -Y29leGlzdCkNCj4gwqAJCXJldHVybiBmYWxzZTsNCg0KDQo +On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote: +> From: Colin Ian King <colin.king@canonical.com> +> +> The variables ant_num and single_ant_path are being initialized with a +> value that is never read and are being updated later with a new value. +> The initializations are redundant and can be removed. +> +> Addresses-Coverity: ("Unused value") +> Signed-off-by: Colin Ian King <colin.king@canonical.com> + +Acked-by: Ping-Ke Shih <pkshih@realtek.com> + +Thank you + +> --- +> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +> index a4940a3842de..4949f99844b5 100644 +> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +> @@ -1318,7 +1318,7 @@ bool exhalbtc_bind_bt_coex_withadapter(void *adapter) +> { +> struct rtl_priv *rtlpriv = adapter; +> struct btc_coexist *btcoexist = rtl_btc_coexist(rtlpriv); +> - u8 ant_num = 2, chip_type, single_ant_path = 0; +> + u8 ant_num, chip_type, single_ant_path; +> +> if (!btcoexist) +> return false; diff --git a/a/content_digest b/N1/content_digest index a1cc3de..e36ad07 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "ref\020200723163214.995226-1-colin.king@canonical.com\0" "From\0Pkshih <pkshih@realtek.com>\0" - "Subject\0Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_pat\0" + "Subject\0Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path\0" "Date\0Fri, 24 Jul 2020 05:14:25 +0000\0" "To\0linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org>" colin.king@canonical.com <colin.king@canonical.com> @@ -12,28 +12,37 @@ " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDIwLTA3LTIzIGF0IDE3OjMyICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG\n" - "cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gVGhl\n" - "IHZhcmlhYmxlcyBhbnRfbnVtIGFuZCBzaW5nbGVfYW50X3BhdGggYXJlIGJlaW5nIGluaXRpYWxp\n" - "emVkIHdpdGggYQ0KPiB2YWx1ZSB0aGF0IGlzIG5ldmVyIHJlYWQgYW5kIGFyZSBiZWluZyB1cGRh\n" - "dGVkIGxhdGVyIHdpdGggYSBuZXcgdmFsdWUuDQo+IFRoZSBpbml0aWFsaXphdGlvbnMgYXJlIHJl\n" - "ZHVuZGFudCBhbmQgY2FuIGJlIHJlbW92ZWQuDQo+IA0KPiBBZGRyZXNzZXMtQ292ZXJpdHk6ICgi\n" - "VW51c2VkIHZhbHVlIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtp\n" - "bmdAY2Fub25pY2FsLmNvbT4NCg0KQWNrZWQtYnk6IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0\n" - "ZWsuY29tPg0KDQpUaGFuayB5b3UNCg0KPiAtLS0NCj4gwqBkcml2ZXJzL25ldC93aXJlbGVzcy9y\n" - "ZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Y291dHNyYy5jIHwgMiArLQ0KPiDCoDEgZmls\n" - "ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdp\n" - "dCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnRsd2lmaS9idGNvZXhpc3QvaGFsYnRj\n" - "b3V0c3JjLmMNCj4gYi9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4\n" - "aXN0L2hhbGJ0Y291dHNyYy5jDQo+IGluZGV4IGE0OTQwYTM4NDJkZS4uNDk0OWY5OTg0NGI1IDEw\n" - "MDY0NA0KPiAtLS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4\n" - "aXN0L2hhbGJ0Y291dHNyYy5jDQo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsv\n" - "cnRsd2lmaS9idGNvZXhpc3QvaGFsYnRjb3V0c3JjLmMNCj4gQEAgLTEzMTgsNyArMTMxOCw3IEBA\n" - "IGJvb2wgZXhoYWxidGNfYmluZF9idF9jb2V4X3dpdGhhZGFwdGVyKHZvaWQgKmFkYXB0ZXIpDQo+\n" - "IMKgew0KPiDCoAlzdHJ1Y3QgcnRsX3ByaXYgKnJ0bHByaXYgPSBhZGFwdGVyOw0KPiDCoAlzdHJ1\n" - "Y3QgYnRjX2NvZXhpc3QgKmJ0Y29leGlzdCA9IHJ0bF9idGNfY29leGlzdChydGxwcml2KTsNCj4g\n" - "LQl1OCBhbnRfbnVtID0gMiwgY2hpcF90eXBlLCBzaW5nbGVfYW50X3BhdGggPSAwOw0KPiArCXU4\n" - "IGFudF9udW0sIGNoaXBfdHlwZSwgc2luZ2xlX2FudF9wYXRoOw0KPiDCoA0KPiDCoAlpZiAoIWJ0\n" - Y29leGlzdCkNCj4gwqAJCXJldHVybiBmYWxzZTsNCg0KDQo + "On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote:\n" + "> From: Colin Ian King <colin.king@canonical.com>\n" + "> \n" + "> The variables ant_num and single_ant_path are being initialized with a\n" + "> value that is never read and are being updated later with a new value.\n" + "> The initializations are redundant and can be removed.\n" + "> \n" + "> Addresses-Coverity: (\"Unused value\")\n" + "> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n" + "\n" + "Acked-by: Ping-Ke Shih <pkshih@realtek.com>\n" + "\n" + "Thank you\n" + "\n" + "> ---\n" + "> \302\240drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-\n" + "> \302\2401 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n" + "> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n" + "> index a4940a3842de..4949f99844b5 100644\n" + "> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n" + "> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n" + "> @@ -1318,7 +1318,7 @@ bool exhalbtc_bind_bt_coex_withadapter(void *adapter)\n" + "> \302\240{\n" + "> \302\240\tstruct rtl_priv *rtlpriv = adapter;\n" + "> \302\240\tstruct btc_coexist *btcoexist = rtl_btc_coexist(rtlpriv);\n" + "> -\tu8 ant_num = 2, chip_type, single_ant_path = 0;\n" + "> +\tu8 ant_num, chip_type, single_ant_path;\n" + "> \302\240\n" + "> \302\240\tif (!btcoexist)\n" + "> \302\240\t\treturn false;" -e244af17ecc126c7ce1a64e94b25f73b126efbda72b5bd7dd45c612f52314569 +a90415ec54f5c4bd96cfa43aea8c6d59571d898174e08dfa3333cb015dd4d8ef
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.