From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF6C4C433E0 for ; Mon, 3 Aug 2020 08:30:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CC9E206E2 for ; Mon, 3 Aug 2020 08:30:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3isE9cDh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JEo04xjD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC9E206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tk2jILBTIsyey/2PwMEJ1Cfm+GYQ8wDlwlIW71ssgDc=; b=3isE9cDhcqEdZIi+d6dVhs/f9 uraw2QNm2kTkvIeWm67m485f3iHnZNKk5GJvZOqasY7mgTTYgVS9ouxBYD+AETQHdKzWQqQc4+JL2 hvO8xJg3uh/v3MAQH0+pOK4Xf2Ju45P4/wuwbqpP91H1wdKIrT5e/jRzGLzqPpI2H32fAVqiBbiPH fzv9cD0x7mB17pF78ogheXItBbbZB2mbC2J8K7V0HdmOuEKs5fNaoS+TjIQGIavhPSzoABKOlRqpo 4U0ofCIf+YhCaaMEdkwR1buZf2kWLnH3BWsJWKfcRP7ZlMEPYejuDlAHxpvjWLCe2sPXUodp1/c/6 0RhEpbFyA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Vqx-0000Cw-SO; Mon, 03 Aug 2020 08:29:51 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Vqu-0000BT-Cj; Mon, 03 Aug 2020 08:29:49 +0000 X-UUID: 94700880e51a447ba0b08b1a9e749672-20200803 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EuuyH2OVGmIhL/U3X6SY1BLzxNovAUS15W1lABzBFs0=; b=JEo04xjD0JDyd4pfKxqCnA10Gh276qX9+c+0J29zY6ug5ZRwjeOGJPdq8rnw45o3qGSG7o9cnA6mi2T+T+K1IXGtgQW79E63Q26z4voGvtd/RASfsdg/jBhMrqKZUVpxqY6Cje02zeZPo92TgekHdQe8dy9DVPZYYpyKeI7pHsE=; X-UUID: 94700880e51a447ba0b08b1a9e749672-20200803 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 477312050; Mon, 03 Aug 2020 00:29:36 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 01:29:39 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 16:29:37 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Aug 2020 16:29:37 +0800 Message-ID: <1596443379.31084.3.camel@mtksdaap41> Subject: Re: [PATCH 1/8] mfd: mt6358: refine interrupt code From: Hsin-hsiung Wang To: Lee Jones Date: Mon, 3 Aug 2020 16:29:39 +0800 In-Reply-To: <20200727154840.GY1850026@dell> References: <1595509133-5358-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1595509133-5358-2-git-send-email-hsin-hsiung.wang@mediatek.com> <20200727154840.GY1850026@dell> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_042948_558395_1066D4FA X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Josef Friedl , srv_heupstream , Frank Wunderlich , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Mark Brown , linux-mediatek@lists.infradead.org, hsin-hsiung.wang@mediatek.com, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2020-07-27 at 16:48 +0100, Lee Jones wrote: > On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote: > > > This patch refines the interrupt related code to support new chips. > > Refines in what way? > > What makes this better? > Thanks for the comment. I will add more information into comment message based on my below explanation. > > Signed-off-by: Hsin-Hsiung Wang > > --- > > drivers/mfd/mt6358-irq.c | 65 ++++++++++++++++++++++++----------------- > > include/linux/mfd/mt6358/core.h | 8 ++--- > > 2 files changed, 41 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/mfd/mt6358-irq.c b/drivers/mfd/mt6358-irq.c > > index db734f2..4b094e5 100644 > > --- a/drivers/mfd/mt6358-irq.c > > +++ b/drivers/mfd/mt6358-irq.c > > @@ -13,7 +13,9 @@ > > #include > > #include > > > > -static struct irq_top_t mt6358_ints[] = { > > +#define MTK_PMIC_REG_WIDTH 16 > > + > > +static const struct irq_top_t mt6358_ints[] = { > > MT6358_TOP_GEN(BUCK), > > MT6358_TOP_GEN(LDO), > > MT6358_TOP_GEN(PSC), > > @@ -24,6 +26,13 @@ static struct irq_top_t mt6358_ints[] = { > > MT6358_TOP_GEN(MISC), > > }; > > > > +static struct pmic_irq_data mt6358_irqd = { > > + .num_top = ARRAY_SIZE(mt6358_ints), > > + .num_pmic_irqs = MT6358_IRQ_NR, > > + .top_int_status_reg = MT6358_TOP_INT_STATUS0, > > + .pmic_ints = mt6358_ints, > > +}; > > Dynamically assigned driver data is usually preferred. > > Why have you gone static? > Do you consider the memory allocation? Below modification is to assign necessary data dynamically and the code will become longer with more chips if we assign every member of the structure. @@ -180,17 +190,18 @@ int mt6358_irq_init(struct mt6397_chip *chip) int i, j, ret; struct pmic_irq_data *irqd; - irqd = devm_kzalloc(chip->dev, sizeof(*irqd), GFP_KERNEL); - if (!irqd) - return -ENOMEM; + switch (chip->chip_id) { + case MT6358_CHIP_ID: + chip->irq_data = &mt6358_irqd; + break; - chip->irq_data = irqd; + default: + dev_err(chip->dev, "unsupported chip: 0x%x \n", chip->chip_id); + return -ENODEV; + } mutex_init(&chip->irqlock); - irqd->top_int_status_reg = MT6358_TOP_INT_STATUS0; - irqd->num_pmic_irqs = MT6358_IRQ_NR; - irqd->num_top = ARRAY_SIZE(mt6358_ints); - + irqd = chip->irq_data; irqd->enable_hwirq = devm_kcalloc(chip->dev, irqd->num_pmic_irqs, sizeof(*irqd->enable_hwirq), _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B86C433DF for ; Mon, 3 Aug 2020 08:31:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D1CF206D7 for ; Mon, 3 Aug 2020 08:31:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fva/CQKo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JEo04xjD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D1CF206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BJAiM2QIDava5N30Ta10vlYY8wQcIzqcArs1yP4/+Zw=; b=fva/CQKoy+uHkAf4dlLmNlAwF mZKTTqNmXPaEy/PAUmn8Kgv7sfyblniCusChXscKcrry+deEIiU1c0GSr7Bn4KynVWzwoWS23GQEE Gr/UddVVJ5vkDWSKJxu1gA2Bzr+QkZhQsDjxWaPEGVrqQ/4dQn3588EM7TpBjsHcG7FE61vh7oGP5 ndafvZfEbHu9EQle4enTqJ4qR5TTcLhSo4Crt8CBZVSv0VbiRt3WEaD0q5cNNH3McJvDu3FmA747W WhhovuavJbTHkmcVajOh/kgHx+Qobtf4TB6KNkYUxNewn/04zBjBjDnhLjJhq5UX5p6lFz1ZV43vV xtI1oJD8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Vqw-0000Cg-Un; Mon, 03 Aug 2020 08:29:51 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Vqu-0000BT-Cj; Mon, 03 Aug 2020 08:29:49 +0000 X-UUID: 94700880e51a447ba0b08b1a9e749672-20200803 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EuuyH2OVGmIhL/U3X6SY1BLzxNovAUS15W1lABzBFs0=; b=JEo04xjD0JDyd4pfKxqCnA10Gh276qX9+c+0J29zY6ug5ZRwjeOGJPdq8rnw45o3qGSG7o9cnA6mi2T+T+K1IXGtgQW79E63Q26z4voGvtd/RASfsdg/jBhMrqKZUVpxqY6Cje02zeZPo92TgekHdQe8dy9DVPZYYpyKeI7pHsE=; X-UUID: 94700880e51a447ba0b08b1a9e749672-20200803 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 477312050; Mon, 03 Aug 2020 00:29:36 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 01:29:39 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 16:29:37 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Aug 2020 16:29:37 +0800 Message-ID: <1596443379.31084.3.camel@mtksdaap41> Subject: Re: [PATCH 1/8] mfd: mt6358: refine interrupt code From: Hsin-hsiung Wang To: Lee Jones Date: Mon, 3 Aug 2020 16:29:39 +0800 In-Reply-To: <20200727154840.GY1850026@dell> References: <1595509133-5358-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1595509133-5358-2-git-send-email-hsin-hsiung.wang@mediatek.com> <20200727154840.GY1850026@dell> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_042948_558395_1066D4FA X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Josef Friedl , srv_heupstream , Frank Wunderlich , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Mark Brown , linux-mediatek@lists.infradead.org, hsin-hsiung.wang@mediatek.com, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2020-07-27 at 16:48 +0100, Lee Jones wrote: > On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote: > > > This patch refines the interrupt related code to support new chips. > > Refines in what way? > > What makes this better? > Thanks for the comment. I will add more information into comment message based on my below explanation. > > Signed-off-by: Hsin-Hsiung Wang > > --- > > drivers/mfd/mt6358-irq.c | 65 ++++++++++++++++++++++++----------------- > > include/linux/mfd/mt6358/core.h | 8 ++--- > > 2 files changed, 41 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/mfd/mt6358-irq.c b/drivers/mfd/mt6358-irq.c > > index db734f2..4b094e5 100644 > > --- a/drivers/mfd/mt6358-irq.c > > +++ b/drivers/mfd/mt6358-irq.c > > @@ -13,7 +13,9 @@ > > #include > > #include > > > > -static struct irq_top_t mt6358_ints[] = { > > +#define MTK_PMIC_REG_WIDTH 16 > > + > > +static const struct irq_top_t mt6358_ints[] = { > > MT6358_TOP_GEN(BUCK), > > MT6358_TOP_GEN(LDO), > > MT6358_TOP_GEN(PSC), > > @@ -24,6 +26,13 @@ static struct irq_top_t mt6358_ints[] = { > > MT6358_TOP_GEN(MISC), > > }; > > > > +static struct pmic_irq_data mt6358_irqd = { > > + .num_top = ARRAY_SIZE(mt6358_ints), > > + .num_pmic_irqs = MT6358_IRQ_NR, > > + .top_int_status_reg = MT6358_TOP_INT_STATUS0, > > + .pmic_ints = mt6358_ints, > > +}; > > Dynamically assigned driver data is usually preferred. > > Why have you gone static? > Do you consider the memory allocation? Below modification is to assign necessary data dynamically and the code will become longer with more chips if we assign every member of the structure. @@ -180,17 +190,18 @@ int mt6358_irq_init(struct mt6397_chip *chip) int i, j, ret; struct pmic_irq_data *irqd; - irqd = devm_kzalloc(chip->dev, sizeof(*irqd), GFP_KERNEL); - if (!irqd) - return -ENOMEM; + switch (chip->chip_id) { + case MT6358_CHIP_ID: + chip->irq_data = &mt6358_irqd; + break; - chip->irq_data = irqd; + default: + dev_err(chip->dev, "unsupported chip: 0x%x \n", chip->chip_id); + return -ENODEV; + } mutex_init(&chip->irqlock); - irqd->top_int_status_reg = MT6358_TOP_INT_STATUS0; - irqd->num_pmic_irqs = MT6358_IRQ_NR; - irqd->num_top = ARRAY_SIZE(mt6358_ints); - + irqd = chip->irq_data; irqd->enable_hwirq = devm_kcalloc(chip->dev, irqd->num_pmic_irqs, sizeof(*irqd->enable_hwirq), _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D10C433E0 for ; Mon, 3 Aug 2020 08:29:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFA2320719 for ; Mon, 3 Aug 2020 08:29:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JEo04xjD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725945AbgHCI3o (ORCPT ); Mon, 3 Aug 2020 04:29:44 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:44166 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725884AbgHCI3n (ORCPT ); Mon, 3 Aug 2020 04:29:43 -0400 X-UUID: 05924b868abd422788d1adf1fe4eaeab-20200803 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EuuyH2OVGmIhL/U3X6SY1BLzxNovAUS15W1lABzBFs0=; b=JEo04xjD0JDyd4pfKxqCnA10Gh276qX9+c+0J29zY6ug5ZRwjeOGJPdq8rnw45o3qGSG7o9cnA6mi2T+T+K1IXGtgQW79E63Q26z4voGvtd/RASfsdg/jBhMrqKZUVpxqY6Cje02zeZPo92TgekHdQe8dy9DVPZYYpyKeI7pHsE=; X-UUID: 05924b868abd422788d1adf1fe4eaeab-20200803 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1692457246; Mon, 03 Aug 2020 16:29:40 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 16:29:37 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Aug 2020 16:29:37 +0800 Message-ID: <1596443379.31084.3.camel@mtksdaap41> Subject: Re: [PATCH 1/8] mfd: mt6358: refine interrupt code From: Hsin-hsiung Wang To: Lee Jones CC: Rob Herring , Matthias Brugger , Mark Brown , Liam Girdwood , Frank Wunderlich , "Josef Friedl" , , , , , srv_heupstream , Date: Mon, 3 Aug 2020 16:29:39 +0800 In-Reply-To: <20200727154840.GY1850026@dell> References: <1595509133-5358-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1595509133-5358-2-git-send-email-hsin-hsiung.wang@mediatek.com> <20200727154840.GY1850026@dell> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGksDQoNCk9uIE1vbiwgMjAyMC0wNy0yNyBhdCAxNjo0OCArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Og0KPiBPbiBUaHUsIDIzIEp1bCAyMDIwLCBIc2luLUhzaXVuZyBXYW5nIHdyb3RlOg0KPiANCj4g PiBUaGlzIHBhdGNoIHJlZmluZXMgdGhlIGludGVycnVwdCByZWxhdGVkIGNvZGUgdG8gc3VwcG9y dCBuZXcgY2hpcHMuDQo+IA0KPiBSZWZpbmVzIGluIHdoYXQgd2F5Pw0KPiANCj4gV2hhdCBtYWtl cyB0aGlzIGJldHRlcj8NCj4gDQoNClRoYW5rcyBmb3IgdGhlIGNvbW1lbnQuIEkgd2lsbCBhZGQg bW9yZSBpbmZvcm1hdGlvbiBpbnRvIGNvbW1lbnQgbWVzc2FnZQ0KYmFzZWQgb24gbXkgYmVsb3cg ZXhwbGFuYXRpb24uDQoNCj4gPiBTaWduZWQtb2ZmLWJ5OiBIc2luLUhzaXVuZyBXYW5nIDxoc2lu LWhzaXVuZy53YW5nQG1lZGlhdGVrLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9tZmQvbXQ2 MzU4LWlycS5jICAgICAgICB8IDY1ICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0tDQo+ID4gIGluY2x1ZGUvbGludXgvbWZkL210NjM1OC9jb3JlLmggfCAgOCArKy0tLQ0K PiA+ICAyIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDMyIGRlbGV0aW9ucygtKQ0K PiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9tdDYzNTgtaXJxLmMgYi9kcml2ZXJz L21mZC9tdDYzNTgtaXJxLmMNCj4gPiBpbmRleCBkYjczNGYyLi40YjA5NGU1IDEwMDY0NA0KPiA+ IC0tLSBhL2RyaXZlcnMvbWZkL210NjM1OC1pcnEuYw0KPiA+ICsrKyBiL2RyaXZlcnMvbWZkL210 NjM1OC1pcnEuYw0KPiA+IEBAIC0xMyw3ICsxMyw5IEBADQo+ID4gICNpbmNsdWRlIDxsaW51eC9w bGF0Zm9ybV9kZXZpY2UuaD4NCj4gPiAgI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5oPg0KPiA+ICAN Cj4gPiAtc3RhdGljIHN0cnVjdCBpcnFfdG9wX3QgbXQ2MzU4X2ludHNbXSA9IHsNCj4gPiArI2Rl ZmluZSBNVEtfUE1JQ19SRUdfV0lEVEggMTYNCj4gPiArDQo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgaXJxX3RvcF90IG10NjM1OF9pbnRzW10gPSB7DQo+ID4gIAlNVDYzNThfVE9QX0dFTihCVUNL KSwNCj4gPiAgCU1UNjM1OF9UT1BfR0VOKExETyksDQo+ID4gIAlNVDYzNThfVE9QX0dFTihQU0Mp LA0KPiA+IEBAIC0yNCw2ICsyNiwxMyBAQCBzdGF0aWMgc3RydWN0IGlycV90b3BfdCBtdDYzNThf aW50c1tdID0gew0KPiA+ICAJTVQ2MzU4X1RPUF9HRU4oTUlTQyksDQo+ID4gIH07DQo+ID4gIA0K PiA+ICtzdGF0aWMgc3RydWN0IHBtaWNfaXJxX2RhdGEgbXQ2MzU4X2lycWQgPSB7DQo+ID4gKwku bnVtX3RvcCA9IEFSUkFZX1NJWkUobXQ2MzU4X2ludHMpLA0KPiA+ICsJLm51bV9wbWljX2lycXMg PSBNVDYzNThfSVJRX05SLA0KPiA+ICsJLnRvcF9pbnRfc3RhdHVzX3JlZyA9IE1UNjM1OF9UT1Bf SU5UX1NUQVRVUzAsDQo+ID4gKwkucG1pY19pbnRzID0gbXQ2MzU4X2ludHMsDQo+ID4gK307DQo+ IA0KPiBEeW5hbWljYWxseSBhc3NpZ25lZCBkcml2ZXIgZGF0YSBpcyB1c3VhbGx5IHByZWZlcnJl ZC4NCj4gDQo+IFdoeSBoYXZlIHlvdSBnb25lIHN0YXRpYz8NCj4gDQoNCkRvIHlvdSBjb25zaWRl ciB0aGUgbWVtb3J5IGFsbG9jYXRpb24/DQpCZWxvdyBtb2RpZmljYXRpb24gaXMgdG8gYXNzaWdu IG5lY2Vzc2FyeSBkYXRhIGR5bmFtaWNhbGx5IGFuZCB0aGUgY29kZQ0Kd2lsbCBiZWNvbWUgbG9u Z2VyIHdpdGggbW9yZSBjaGlwcyBpZiB3ZSBhc3NpZ24gZXZlcnkgbWVtYmVyIG9mIHRoZQ0Kc3Ry dWN0dXJlLg0KDQpAQCAtMTgwLDE3ICsxOTAsMTggQEAgIGludCBtdDYzNThfaXJxX2luaXQoc3Ry dWN0IG10NjM5N19jaGlwICpjaGlwKQ0KICAgICAgICAgICAgICAgaW50IGksIGosIHJldDsNCiAg ICAgICAgICAgICAgIHN0cnVjdCBwbWljX2lycV9kYXRhICppcnFkOw0KDQotICAgICAgICAgICAg ICBpcnFkID0gZGV2bV9remFsbG9jKGNoaXAtPmRldiwgc2l6ZW9mKCppcnFkKSwNCkdGUF9LRVJO RUwpOw0KLSAgICAgICAgICAgICAgaWYgKCFpcnFkKQ0KLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHJldHVybiAtRU5PTUVNOw0KKyAgICAgICAgICAgICBzd2l0Y2ggKGNoaXAtPmNoaXBf aWQpIHsNCisgICAgICAgICAgICAgY2FzZSBNVDYzNThfQ0hJUF9JRDoNCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNoaXAtPmlycV9kYXRhID0gJm10NjM1OF9pcnFkOw0KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7DQoNCi0gICAgICAgICAgICAgIGNoaXAtPmlycV9k YXRhID0gaXJxZDsNCisgICAgICAgICAgICAgZGVmYXVsdDoNCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGRldl9lcnIoY2hpcC0+ZGV2LCAidW5zdXBwb3J0ZWQgY2hpcDogMHgleA0KXG4i LCBjaGlwLT5jaGlwX2lkKTsNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAt RU5PREVWOw0KKyAgICAgICAgICAgICB9DQoNCiAgICAgICAgICAgICAgICBtdXRleF9pbml0KCZj aGlwLT5pcnFsb2NrKTsNCi0gICAgICAgICAgICAgIGlycWQtPnRvcF9pbnRfc3RhdHVzX3JlZyA9 IE1UNjM1OF9UT1BfSU5UX1NUQVRVUzA7DQotICAgICAgICAgICAgICBpcnFkLT5udW1fcG1pY19p cnFzID0gTVQ2MzU4X0lSUV9OUjsNCi0gICAgICAgICAgICAgIGlycWQtPm51bV90b3AgPSBBUlJB WV9TSVpFKG10NjM1OF9pbnRzKTsNCi0NCisgICAgICAgICAgICAgaXJxZCA9IGNoaXAtPmlycV9k YXRhOw0KICAgICAgICAgICAgICAgaXJxZC0+ZW5hYmxlX2h3aXJxID0gZGV2bV9rY2FsbG9jKGNo aXAtPmRldiwNCg0KaXJxZC0+bnVtX3BtaWNfaXJxcywNCg0Kc2l6ZW9mKCppcnFkLT5lbmFibGVf aHdpcnEpLA0KDQo=