From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/mlx5: fix crash on deleting flow drop
	queue
Date: Fri, 05 May 2017 17:48:37 +0200
Message-ID: <1596826.VfqBUcD350@xps>
References: <20170501210542.5032-1-yskoh@mellanox.com>
 <20170502064515.GE31330@autoinstall.dev.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org,
 =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>,
 ferruh.yigit@intel.com, adrien.mazarguil@6wind.com
To: Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 55F674CE4
 for <dev@dpdk.org>; Fri,  5 May 2017 17:48:39 +0200 (CEST)
In-Reply-To: <20170502064515.GE31330@autoinstall.dev.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/05/2017 08:45, N=E9lio Laranjeiro:
> On Mon, May 01, 2017 at 02:05:42PM -0700, Yongseok Koh wrote:
> > If mlx5_dev_start() fails, it tries to rollback data structures related=
 to
> > rte_flow including drop queue. The destruction code doesn't assume the
> > structures are created but priv_flow_delete_drop_queue() never does san=
ity
> > check. This can cause a crash.
> >=20
> > Fixes: 028761059aeb ("net/mlx5: use an RSS drop queue")
> >=20
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>=20
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied, thanks