From: Oliver Neukum <oneukum@suse.com>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org
Subject: Re: [RFC]mooring API
Date: Mon, 10 Aug 2020 16:39:09 +0200 [thread overview]
Message-ID: <1597070349.2515.6.camel@suse.com> (raw)
In-Reply-To: <5F2C2C74.8000104@gmail.com>
Am Donnerstag, den 06.08.2020, 19:14 +0300 schrieb Eli Billauer:
> Hello,
>
> I feel I got more credit that I deserve. Hans de Goede discovered this
> issue and solved a specific problem that was related to the race back in
> 6ec4147. I was just lucky (or unlucky) enough to get a kernel panic on
> my machine due to another problem, for which I submitted a patch.
>
> To me the anchor API is great. If there is unclearances about its API, I
> suppose docs would help. The fact that the URB is unanchored prior to
> calling the completer is intuitive, so there's a clear benefit in that.
But is it necessary? DO you ever move URBs between anchors?
> This requires some ungraceful code where almost nobody's looking, but if
> that makes the common programmer's life easier, I think it's a good deal.
It would be, if the deal is necessary. In hindsight it still looks
to me like completion should unanchor an URB.
Regards
Oliver
next prev parent reply other threads:[~2020-08-10 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 14:07 [RFC]mooring API Oliver Neukum
2020-08-06 15:20 ` Alan Stern
2020-08-10 14:35 ` Oliver Neukum
2020-08-10 15:17 ` Alan Stern
2020-08-11 17:39 ` Oliver Neukum
2020-08-11 18:01 ` Alan Stern
2020-08-06 16:14 ` Eli Billauer
2020-08-10 14:39 ` Oliver Neukum [this message]
2020-08-10 16:01 ` Eli Billauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597070349.2515.6.camel@suse.com \
--to=oneukum@suse.com \
--cc=eli.billauer@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.