From: Oliver Neukum <oneukum@suse.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
Colin Ian King <colin.king@canonical.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-usb@vger.kernel.org,
syzbot <syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com>
Subject: Re: [PATCH] USB: cdc-wdm: Remove unsafe wdm_flush().
Date: Wed, 12 Aug 2020 10:02:51 +0200 [thread overview]
Message-ID: <1597219371.28022.6.camel@suse.com> (raw)
In-Reply-To: <1597188375-4787-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
Am Mittwoch, den 12.08.2020, 08:26 +0900 schrieb Tetsuo Handa:
> syzbot is reporting hung task at wdm_flush() [1], for there is a circular
> dependency that wdm_flush() from flip_close() for /dev/cdc-wdm0 forever
> waits for /dev/raw-gadget to be closed while close() for /dev/raw-gadget
> cannot be called unless close() for /dev/cdc-wdm0 completes.
>
> It turned out that wdm_flush() is broken in multiple aspects.
Sorry,
this seems to be a miscommunication. I was under the impression that
you were testing patches. I will push them upstream. You
cannot just remove flush() without impairing error handling.
Regards
Oliver
Nacked-by: Oliver Neukum <oneukum@suse.com>
next prev parent reply other threads:[~2020-08-12 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 23:26 [PATCH] USB: cdc-wdm: Remove unsafe wdm_flush() Tetsuo Handa
2020-08-12 8:02 ` Oliver Neukum [this message]
2020-08-12 10:09 ` Tetsuo Handa
2020-08-12 11:19 ` Oliver Neukum
2020-08-27 13:39 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597219371.28022.6.camel@suse.com \
--to=oneukum@suse.com \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.