From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 00/10] Add helper for plane reset Date: Mon, 06 Aug 2018 14:45:42 +0300 Message-ID: <15977863.ZBGtPEODRU@avalon> References: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> <20180806110727.GA3314@e114479-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180806110727.GA3314@e114479-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru-Cosmin Gheorghe Cc: alexandre.belloni@bootlin.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, thellstrom@vmware.com, krzk@kernel.org, maxime.ripard@bootlin.com, wens@csie.org, kgene@kernel.org, malidp@foss.arm.com, linux-graphics-maintainer@vmware.com, sunpeng.li@amd.com, boris.brezillon@bootlin.com, linux-samsung-soc@vger.kernel.org, nd@arm.com, Tony.Cheng@amd.com, linux-arm-kernel@lists.infradead.org, sw0312.kim@samsung.com, nicolas.ferre@microchip.com, shirish.s@amd.com, kyungmin.park@samsung.com, alexander.deucher@amd.com, christian.koenig@amd.com List-Id: linux-samsung-soc@vger.kernel.org SGkgQWxleCwKCk9uIE1vbmRheSwgNiBBdWd1c3QgMjAxOCAxNDowNzoyNyBFRVNUIEFsZXhhbmRy dS1Db3NtaW4gR2hlb3JnaGUgd3JvdGU6Cj4gSGksCj4gCj4gT24gU2F0LCBBdWcgMDQsIDIwMTgg YXQgMDU6MTU6MjBQTSArMDEwMCwgQWxleGFuZHJ1IEdoZW9yZ2hlIHdyb3RlOgo+ID4gTm8gc2ln bmlmaWNhbnQgY2hhbmdlIHNpbmNlIHYyLCBmaXhlZCBhIHNwZWxsaW5nIG1pc3Rha2UgYW5kCj4g PiBhZGRlZC9yZW1vdmVkIHNvbWUgbmV3bGluZXMgaW4gMDEgYW5kIDA3IHBhdGNoZXMuCj4gPiAK PiA+IEkgcGxhbiB0byBhcHBseSB0aGUgZmlyc3QgcGF0Y2ggb2YgdGhlIHNlcmllcyBhbmQgdGhl IHBhdGNoZXMgZm9yCj4gPiB0aGUgZHJpdmVycyBtYWludGFpbmVkIHRocm91Z2ggZHJtLW1pc2Mo dGhhdCBnbyBSZXZpZXdlZC9BY2spIGluCj4gPiBkcm0tbWlzYy1uZXh0IG9uIE1vbmRheS4KPiA+ IAo+ID4gRm9yIHRoZSBvdGhlciBkcml2ZXJzIHBsZWFzZSBsZXQgbWUga25vdyBpZiB5b3Ugd2Fu dCBtZSB0byBwdXNoIHRoZW0KPiA+IGluIGRybS1taXNjLW5leHQgYXMgd2VsbC4KPiAKPiBQdXNo ZWQgdGhlIGZvbGxvd2luZyBwYXRjaCB0byBkcm0tbWlzYy1uZXh0Ogo+IAo+IGRybS9hdG9taWM6 IEFkZCBfX2RybV9hdG9taWNfaGVscGVyX3BsYW5lX3Jlc2V0Cj4gZHJtOiBtYWxpLWRwOiBVc2Ug X19kcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9yZXNldCBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlCj4g bG9naWMKPiBkcm06IGF0bWVsLWhsY2RjOiBVc2UgX19kcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9y ZXNldCBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlCj4gbG9naWMKPiBkcm0vaW14OiBVc2UgX19kcm1f YXRvbWljX2hlbHBlcl9wbGFuZV9yZXNldCBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlIGxvZ2ljCj4g ZHJtL3N1bjRpOiBVc2UgX19kcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9yZXNldCBpbnN0ZWFkIG9m IGNvcHlpbmcgdGhlIGxvZ2ljCgpJJ3ZlIGFja2VkIHRoZSByY2FyLWR1IHBhcnQsIGNvdWxkIGl0 IGJlIG1lcmdlZCB3aXRoIHRoZSByZXN0IG9mIHRoZSBjb2RlID8KCj4gPiBDaGFuZ2VzIHNpbmNl IHYxOgo+ID4gIC0gTWFrZSBfX2RybV9hdG9taWNfaGVscGVyX3BsYW5lX3Jlc2V0IGNvbnNpc3Rl bnQgd2l0aCB0aGUgb3RoZXIKPiA+ICAgIGhlbHBlcnMgYW5kIHJlcXVpcmUgdGhhdCBib3RoIHBs YW5lIGFuZCBzdGF0ZSBub3QgYmUgTlVMTCwKPiA+ICAgIHN1Z2dlc3RlZCBieSBCb3JpcyBCcmV6 aWxsb24gYW5kIFBoaWxpcHAgWmFiZWwuIERyaXZlcnMgYWxyZWFkeQo+ID4gICAgY2hlY2sgZm9y IHRoYXQuCj4gPiAgCj4gPiAgLSBBZGQgYSBwcm9wZXIgY29tbWl0IG1lc3NhZ2UgZm9yIGRyaXZl ciBjaGFuZ2VzLgo+ID4gCj4gPiBEcml2ZXJzIHRoYXQgc3ViY2xhc3MgZHJtX3BsYW5lIG5lZWQg dG8gY29weSB0aGUgbG9naWMgZm9yIGxpbmtpbmcgdGhlCj4gPiBkcm1fcGxhbmUgd2l0aCBpdHMg c3RhdGUgYW5kIHRvIGluaXRpYWxpemUgY29yZSBwcm9wZXJ0aWVzIHRvIHRoZWlyCj4gPiBkZWZh dWx0IHZhbHVlcy4gRS5nIChhbHBoYSBhbmQgcm90YXRpb24pCj4gPiAKPiA+IEhhdmluZyBhIGhl bHBlciB0byByZXNldCB0aGUgcGxhbmVfc3RhdGUgbWFrZXMgc2Vuc2UgYmVjYXVzZSBvZiBtdWx0 aXBsZQo+ID4gcmVhc29uczoKPiA+IDEuIEVsaW1pbmF0ZSBjb2RlIGR1cGxpY2F0aW9uLgo+ID4g Mi4gQWRkIGEgc2luZ2xlIHBsYWNlIGZvciBpbml0aWFsaXppbmcgY29yZSBwcm9wZXJ0aWVzIHRv IHRoZWlyCj4gPiBkZWZhdWx0IHZhbHVlcywgbm8gbmVlZCBmb3IgZHJpdmVyIHRvIGRvIGl0IGlm IHdoYXQgdGhlIGhlbHBlciBzZXRzCj4gPiBtYWtlcyBzZW5zZSBmb3IgdGhlbS4KPiA+IDMuIE5v IG5lZWQgdG8gZGVidWcgdGhlIGRyaXZlciB3aGVuIHlvdSBlbmFibGUgYSBjb3JlIHByb3BlcnR5 IGFuZAo+ID4gb2JzZXJ2ZSBpdCBkb2Vzbid0IGhhdmUgYSBwcm9wZXIgZGVmYXVsdCB2YWx1ZS4K PiA+IAo+ID4gVGVzdGVkIHdpdGggbWFsaS1kcCB0aGUgb3RoZXIgZHJpdmVycyBhcmUganVzdCBi dWlsdC10ZXN0ZWQuCj4gPiAKPiA+IEFsZXhhbmRydSBHaGVvcmdoZSAoMTApOgo+ID4gICBkcm0v YXRvbWljOiBBZGQgIF9fZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfcmVzZXQKPiA+ICAgZHJtL2Ft ZC9kaXNwbGF5OiBVc2UgX19kcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9yZXNldCBpbnN0ZWFkIG9m Cj4gPiAgICAgY29weWluZyB0aGUgbG9naWMKPiA+ICAgZHJtOiBtYWxpLWRwOiBVc2UgX19kcm1f YXRvbWljX2hlbHBlcl9wbGFuZV9yZXNldCBpbnN0ZWFkIG9mIGNvcHlpbmcKPiA+ICAgICB0aGUg bG9naWMKPiA+ICAgZHJtOiBhdG1lbC1obGNkYzogVXNlIF9fZHJtX2F0b21pY19oZWxwZXJfcGxh bmVfcmVzZXQgaW5zdGVhZCBvZgo+ID4gICAgIGNvcHlpbmcgdGhlIGxvZ2ljCj4gPiAgIGRybS9l eHlub3M6IFVzZSBfX2RybV9hdG9taWNfaGVscGVyX3BsYW5lX3Jlc2V0IGluc3RlYWQgb2YgY29w eWluZyB0aGUKPiA+ICAgICBsb2dpYwo+ID4gICBkcm0vaW14OiBVc2UgX19kcm1fYXRvbWljX2hl bHBlcl9wbGFuZV9yZXNldCBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlCj4gPiAgICAgbG9naWMKPiA+ ICAgZHJtOiByY2FyLWR1OiBVc2UgX19kcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9yZXNldCBpbnN0 ZWFkIG9mIGNvcHlpbmcKPiA+ICAgICB0aGUgbG9naWMKPiA+ICAgZHJtL3N1bjRpOiBVc2UgX19k cm1fYXRvbWljX2hlbHBlcl9wbGFuZV9yZXNldCBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlCj4gPiAg ICAgbG9naWMKPiA+ICAgZHJtL3ZjNDogVXNlIF9fZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfcmVz ZXQgaW5zdGVhZCBvZiBjb3B5aW5nIHRoZQo+ID4gICAgIGxvZ2ljCj4gPiAgIGRybS92bXdnZng6 IFVzZSBfX2RybV9hdG9taWNfaGVscGVyX3BsYW5lX3Jlc2V0IGluc3RlYWQgb2YgY29weWluZyB0 aGUKPiA+ICAgICBsb2dpYwo+ID4gIAo+ID4gIC4uLi9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdw dV9kbS9hbWRncHVfZG0uYyB8ICA3ICsrLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlk cF9wbGFuZXMuYyAgICAgICAgICAgfCAgNyArKy0tCj4gPiAgLi4uL2dwdS9kcm0vYXRtZWwtaGxj ZGMvYXRtZWxfaGxjZGNfcGxhbmUuYyAgIHwgIDUgKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWNfaGVscGVyLmMgICAgICAgICAgIHwgMzMgKysrKysrKysrKysrKystLS0tLQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9wbGFuZS5jICAgICB8ICAzICstCj4g PiAgZHJpdmVycy9ncHUvZHJtL2lteC9pcHV2My1wbGFuZS5jICAgICAgICAgICAgIHwgIDggKyst LS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3BsYW5lLmMgICAgICAgfCAg NiArKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYyAgICAgICAg IHwgIDUgKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2xheWVyLmMgICAgICAg ICAgIHwgIDQgKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYyAgICAgICAg ICAgICAgIHwgIDQgKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMg ICAgICAgICAgIHwgIDQgKy0tCj4gPiAgaW5jbHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaCAg ICAgICAgICAgICAgIHwgIDIgKysKPiA+ICAxMiBmaWxlcyBjaGFuZ2VkLCA0MSBpbnNlcnRpb25z KCspLCA0NyBkZWxldGlvbnMoLSkKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 06 Aug 2018 14:45:42 +0300 Subject: [PATCH v3 00/10] Add helper for plane reset In-Reply-To: <20180806110727.GA3314@e114479-lin.cambridge.arm.com> References: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> <20180806110727.GA3314@e114479-lin.cambridge.arm.com> Message-ID: <15977863.ZBGtPEODRU@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Alex, On Monday, 6 August 2018 14:07:27 EEST Alexandru-Cosmin Gheorghe wrote: > Hi, > > On Sat, Aug 04, 2018 at 05:15:20PM +0100, Alexandru Gheorghe wrote: > > No significant change since v2, fixed a spelling mistake and > > added/removed some newlines in 01 and 07 patches. > > > > I plan to apply the first patch of the series and the patches for > > the drivers maintained through drm-misc(that go Reviewed/Ack) in > > drm-misc-next on Monday. > > > > For the other drivers please let me know if you want me to push them > > in drm-misc-next as well. > > Pushed the following patch to drm-misc-next: > > drm/atomic: Add __drm_atomic_helper_plane_reset > drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying the > logic > drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the > logic > drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic > drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the logic I've acked the rcar-du part, could it be merged with the rest of the code ? > > Changes since v1: > > - Make __drm_atomic_helper_plane_reset consistent with the other > > helpers and require that both plane and state not be NULL, > > suggested by Boris Brezillon and Philipp Zabel. Drivers already > > check for that. > > > > - Add a proper commit message for driver changes. > > > > Drivers that subclass drm_plane need to copy the logic for linking the > > drm_plane with its state and to initialize core properties to their > > default values. E.g (alpha and rotation) > > > > Having a helper to reset the plane_state makes sense because of multiple > > reasons: > > 1. Eliminate code duplication. > > 2. Add a single place for initializing core properties to their > > default values, no need for driver to do it if what the helper sets > > makes sense for them. > > 3. No need to debug the driver when you enable a core property and > > observe it doesn't have a proper default value. > > > > Tested with mali-dp the other drivers are just built-tested. > > > > Alexandru Gheorghe (10): > > drm/atomic: Add __drm_atomic_helper_plane_reset > > drm/amd/display: Use __drm_atomic_helper_plane_reset instead of > > copying the logic > > drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying > > the logic > > drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of > > copying the logic > > drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying > > the logic > > drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++-- > > drivers/gpu/drm/arm/malidp_planes.c | 7 ++-- > > .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +-- > > drivers/gpu/drm/drm_atomic_helper.c | 33 ++++++++++++++----- > > drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +- > > drivers/gpu/drm/imx/ipuv3-plane.c | 8 ++--- > > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 6 ++-- > > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 5 +-- > > drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +-- > > drivers/gpu/drm/vc4/vc4_plane.c | 4 +-- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +-- > > include/drm/drm_atomic_helper.h | 2 ++ > > 12 files changed, 41 insertions(+), 47 deletions(-) -- Regards, Laurent Pinchart