From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E167FC433DF for ; Wed, 19 Aug 2020 11:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE114206FA for ; Wed, 19 Aug 2020 11:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597836928; bh=KpPwydiYXV1vtumOke+FUyWqKFulfyc3+hU+7XexxpI=; h=Subject:To:Cc:From:Date:List-ID:From; b=u76Km9kxLgfGC5jA/zm0Vve2eWsJTdVvTY5fW5cM+CKPlnDZwZjE7tosOaUT3NQOI DD41aMqH4GjCOe6ysUMw1vx6I+nJepk93HUwpTTOmVUjtGBmOtHiSYyKQv0FBBdmqU cS4bfciIXb2j6wH58dii3gZThwqDAYIwc8Y1BwyE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728013AbgHSLf2 (ORCPT ); Wed, 19 Aug 2020 07:35:28 -0400 Received: from forward1-smtp.messagingengine.com ([66.111.4.223]:48213 "EHLO forward1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726820AbgHSLfU (ORCPT ); Wed, 19 Aug 2020 07:35:20 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.nyi.internal (Postfix) with ESMTP id AFAD21941DD5; Wed, 19 Aug 2020 07:35:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 19 Aug 2020 07:35:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ruZTaE LXhNiobp8VWmLJZY7hgS/aV6lGf87JdD0BHv8=; b=MoHzQXLTyauvQRczQ9oBOM 584QlfJgkdQoItVUwac1MKl4FQTzCchVCCXBwLp8W5LwummSMvbDnSYb+C5oeDmL WDpjf+/AiMC5cmmFuhRiJ0oA4p6krqDnT7X0f2KSnDp+00YgPDbt42H5t4h3xvzT upbt+5IDjqSYkiwZm+12PE8Trz0+/teSUzejSTCv9x+jCDcCjY+v/uJgae1AMdpr jbEgfKIPWfgB0vZHzxbjz5KzUf+j9XR6uxFlkczUQJ5fQ7WQ9/LLK8rYGQZwURgn 8p3IVHFWys/4USUPtYqb2zoIeBHIIhsoKFI17S38EO7JzBFIxxvOVAk2bwSyVHNw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddtkedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecuggftrfgrthhtvghrnhepieetveehuedvhfdtgfdvieeiheehfeelveevheejud etveeuveeludejjefgteehnecukfhppeekfedrkeeirdekledruddtjeenucevlhhushht vghrufhiiigvpeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh drtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D84C3060067; Wed, 19 Aug 2020 07:35:18 -0400 (EDT) Subject: FAILED: patch "[PATCH] btrfs: Move free_pages_out label in inline extent handling" failed to apply to 4.14-stable tree To: nborisov@suse.com, dsterba@suse.com Cc: From: Date: Wed, 19 Aug 2020 13:35:33 +0200 Message-ID: <159783693322742@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From cecc8d9038d164eda61fbcd72520975a554ea63e Mon Sep 17 00:00:00 2001 From: Nikolay Borisov Date: Wed, 17 Jul 2019 14:41:45 +0300 Subject: [PATCH] btrfs: Move free_pages_out label in inline extent handling branch in compress_file_range This label is only executed if compress_file_range fails to create an inline extent. So move its code in the semantically related inline extent handling branch. No functional changes. Signed-off-by: Nikolay Borisov Reviewed-by: David Sterba Signed-off-by: David Sterba diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index db814f555b26..385127ab0841 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -622,7 +622,14 @@ static noinline int compress_file_range(struct async_chunk *async_chunk) PAGE_SET_WRITEBACK | page_error_op | PAGE_END_WRITEBACK); - goto free_pages_out; + + for (i = 0; i < nr_pages; i++) { + WARN_ON(pages[i]->mapping); + put_page(pages[i]); + } + kfree(pages); + + return 0; } } @@ -700,15 +707,6 @@ static noinline int compress_file_range(struct async_chunk *async_chunk) compressed_extents++; return compressed_extents; - -free_pages_out: - for (i = 0; i < nr_pages; i++) { - WARN_ON(pages[i]->mapping); - put_page(pages[i]); - } - kfree(pages); - - return 0; } static void free_async_extent_pages(struct async_extent *async_extent)