From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Panu Matilainen <pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x
Date: Tue, 24 Feb 2015 03:46:41 +0100 [thread overview]
Message-ID: <1597878.lL4fhc8lIW@xps13> (raw)
In-Reply-To: <e2043c84f5643ec1c1bb09d9f695c214df6e9966.1424703222.git.pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Separately comparing major and minor versions becomes seriously clumsy
> when with major version changes, convert the entire version string into
> a numeric value (ie 4.6.0 becomes 460 and 5.0.0 becomes 500) and use
> that for comparisons, eliminate unnecessary negations while at it.
> This makes the comparisons simpler, more obvious and makes gcc 5.0
> naturally recognized at least as capable as newest 4.x.
>
> This three-digit scheme would run into trouble if gcc ever went to
> two-digit version segments, but that hasn't happened in the last 10+
> years so it seems like a safe assumption.
>
> Signed-off-by: Panu Matilainen <pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied, thanks
next prev parent reply other threads:[~2015-02-24 2:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 12:11 [PATCH] mk: Rework gcc version detection to permit versions newer than 4.x Panu Matilainen
[not found] ` <7a06a1e8019a40d4175c6bc2e1d7e62cf956b291.1424261465.git.pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-02-20 14:04 ` Thomas Monjalon
2015-02-20 15:25 ` Panu Matilainen
2015-02-23 14:53 ` [PATCH v2] " Panu Matilainen
[not found] ` <e2043c84f5643ec1c1bb09d9f695c214df6e9966.1424703222.git.pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-02-24 2:46 ` Thomas Monjalon [this message]
2015-02-24 9:25 ` David Marchand
[not found] ` <CALwxeUsPydmOr+Rt6q4CK4uVGGp-Zq6cr+N4FxZC=sicL-HG-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 9:50 ` Panu Matilainen
[not found] ` <54EC496C.7050200-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-02-24 10:09 ` David Marchand
[not found] ` <CALwxeUt0oDQ5nZB00mAAA=MV7nmPaLCXxos-fvPv1yMnrdP6YQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 10:21 ` David Marchand
[not found] ` <CALwxeUvM=Tsw3kYnE36c0i-+29XmnxY6MWSjwk0ESyn74xiiSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 10:36 ` Mcnamara, John
[not found] ` <B27915DBBA3421428155699D51E4CFE2EC72CF-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-24 10:44 ` David Marchand
[not found] ` <CALwxeUvV=mHpjToixfdK02zDdhndLjvTAyfHBWz2KvQLikGShg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 10:50 ` Bruce Richardson
2015-02-24 10:53 ` Panu Matilainen
2015-02-24 10:58 ` Mcnamara, John
2015-02-24 10:21 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597878.lL4fhc8lIW@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.