From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51CA8C433DF for ; Mon, 24 Aug 2020 20:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F24D120738 for ; Mon, 24 Aug 2020 20:20:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="APrUbGtQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="APrUbGtQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725963AbgHXUUs (ORCPT ); Mon, 24 Aug 2020 16:20:48 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:42938 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgHXUUs (ORCPT ); Mon, 24 Aug 2020 16:20:48 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id B06968EE17F; Mon, 24 Aug 2020 13:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1598300447; bh=h9IQ4yBT3+6FdH/X5N+2jUKDrCov+AzM1M/4z1LFGhk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=APrUbGtQ3g921ouuJIR0nSRfu3aLaUmGP5KdeVmMLyfPtMzzmaKVn04dIWdUxMKoR m6NuzCA1SJ+HNzYFfdGtUEJ5/QRweA7gB7jgdipB+XYoXAPRTh3b7rSfB9O23sFzjj 6vaIWVMPW+qzpokrXwHzbN1exqHrKjiwWtxNTKTo= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q_hNWT-_2JUY; Mon, 24 Aug 2020 13:20:47 -0700 (PDT) Received: from [153.66.254.174] (c-73-35-198-56.hsd1.wa.comcast.net [73.35.198.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 2404B8EE116; Mon, 24 Aug 2020 13:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1598300447; bh=h9IQ4yBT3+6FdH/X5N+2jUKDrCov+AzM1M/4z1LFGhk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=APrUbGtQ3g921ouuJIR0nSRfu3aLaUmGP5KdeVmMLyfPtMzzmaKVn04dIWdUxMKoR m6NuzCA1SJ+HNzYFfdGtUEJ5/QRweA7gB7jgdipB+XYoXAPRTh3b7rSfB9O23sFzjj 6vaIWVMPW+qzpokrXwHzbN1exqHrKjiwWtxNTKTo= Message-ID: <1598300446.4034.5.camel@HansenPartnership.com> Subject: Re: [PATCH v4 1/1] tpm: add sysfs exports for all banks of PCR registers From: James Bottomley To: Jarkko Sakkinen , Jason Gunthorpe Cc: Mimi Zohar , linux-integrity@vger.kernel.org Date: Mon, 24 Aug 2020 13:20:46 -0700 In-Reply-To: <20200824194457.GA7391@linux.intel.com> References: <14eaf21a808e333ca414c954d8f3a2f7b6dbf2ca.camel@linux.ibm.com> <20200819120238.GD1152540@nvidia.com> <1597850231.3875.13.camel@HansenPartnership.com> <20200819161845.GK1152540@nvidia.com> <78bc28a573f6660ee5b00d5965984fef2e1de167.camel@linux.ibm.com> <20200819171709.GN1152540@nvidia.com> <1597867756.3875.39.camel@HansenPartnership.com> <20200819232132.GT1152540@nvidia.com> <1597940084.3864.35.camel@HansenPartnership.com> <20200821193847.GA2811093@nvidia.com> <20200824194457.GA7391@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, 2020-08-24 at 22:44 +0300, Jarkko Sakkinen wrote: > On Fri, Aug 21, 2020 at 04:38:47PM -0300, Jason Gunthorpe wrote: > > On Thu, Aug 20, 2020 at 09:14:44AM -0700, James Bottomley wrote: > > > > > > eg we can't do it because we can't access /dev/tpm for > > > > permissions or > > > > something. > > > > > > I already said that: we can't it's root.root 0600 currently. All > > > the TSSs seem to change at least /dev/tpmrm to tpm.tpm 0660 but > > > we can't do that in the kernel because there's no fixed tpm > > > uid/gid. > > > > Permissions is a pretty good reason to add a sysfs file. > > > > Jason > > I'm not sure why suid/sgid utility to read pcrs would be worse. We don't do root running or suid/sgid binaries any more because they're exceptional security risks. That's why both TSSs for TPM 2.0 change the device ownership. For Trousers and TPM 1.2 we used to run the daemon as root until we started getting CVEs about it. James