From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CC0C433E1 for ; Tue, 25 Aug 2020 10:55:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C2782075B for ; Tue, 25 Aug 2020 10:55:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="NmgbONYQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C2782075B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kAWax-0006Gd-Uo; Tue, 25 Aug 2020 10:54:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kAWaw-0006GY-JQ for xen-devel@lists.xenproject.org; Tue, 25 Aug 2020 10:54:26 +0000 X-Inumbo-ID: 4a7804b5-347c-4817-8dee-8a3004b28b84 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a7804b5-347c-4817-8dee-8a3004b28b84; Tue, 25 Aug 2020 10:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1598352865; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=LDbPiJeF+8KXbukJtORCf6tqEi/eFnJw7/plDl/Z6Hg=; b=NmgbONYQduG4d/NhkqdEzeeQ6WhJ+lEHya7RxznD6lcQS4wo1pVxbKFJ AeAYDxL7KjMab32m0AnS3iIGmeWdO3cTu/RaIJli/6hrC+YYtfQ655MLR X4NQ6K5RkHrfJSBZ/B9lEOQQR3HGlB1LC7rFmcN6mW8+zsFRB4iBqnPXm g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: vEFZNiF0fGLwEHVX1aGesohMK0j7nnECefPjZynj+FHbLWT5RzwP82UlBidLs5ETEGtmwziuea euY4MJcX3hl9pDX9wyPv8R0ncgjXjvuC4XWgJ/MI1rgwfaaGHkXwUHB5qNQPtRG10ngjxqgzD5 IEV9qglS5DbBjDCIdhie1YlRWQE0PYs1iTwJ6U1QDQBggaswU7XE6/O+dNXD05KMog12VzKaA1 lUVnbZiHqJynry3bFaIvnQ72VvGrRJ2oVBbr/Lqqcp99iVZMZnS9gJb9JqeKJ6jOpkPosJINyd JWs= X-SBRS: 2.7 X-MesageID: 25536565 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,352,1592884800"; d="scan'208,217";a="25536565" From: Christian Lindig To: Juergen Gross , "xen-devel@lists.xenproject.org" , "xen-devel@dornerworks.com" CC: Samuel Thibault , Ian Jackson , Wei Liu , George Dunlap , Nick Rosbrook , "Andrew Cooper" , Jan Beulich , "Julien Grall" , Stefano Stabellini , Anthony Perard , =?iso-8859-1?Q?Marek_Marczykowski-G=F3recki?= , Josh Whitehead , Stewart Hildebrand , David Scott , "Shriram Rajagopalan" , Yang Hongyang , Edwin Torok Subject: Re: [PATCH v3 00/38] tools: move most libraries into tools/libs Thread-Topic: [PATCH v3 00/38] tools: move most libraries into tools/libs Thread-Index: AQHWeTC9ZIXZmGtXBk+5TUZnzDYz3KlIqAiJ Date: Tue, 25 Aug 2020 10:54:21 +0000 Message-ID: <1598352860986.67246@citrix.com> References: <20200823093519.18386-1-jgross@suse.com> In-Reply-To: <20200823093519.18386-1-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: multipart/alternative; boundary="_000_159835286098667246citrixcom_" MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --_000_159835286098667246citrixcom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I have no objections. For the OCaml part in particular I previously said th= at I believe that it would benefit from either be maintained outside the tr= ee (which requires a clean interface) or moving it to use Dune for its buil= d (triggered by the current make build). Any cleanup that is helping here i= s welcome. -- Acked-by: Christian Lindig ?? ________________________________ From: Juergen Gross Sent: 23 August 2020 10:34 To: xen-devel@lists.xenproject.org; xen-devel@dornerworks.com Cc: Juergen Gross; Samuel Thibault; Ian Jackson; Wei Liu; George Dunlap; Ni= ck Rosbrook; Andrew Cooper; Jan Beulich; Julien Grall; Stefano Stabellini; = Anthony Perard; Marek Marczykowski-G=F3recki; Josh Whitehead; Stewart Hilde= brand; Christian Lindig; David Scott; Shriram Rajagopalan; Yang Hongyang Subject: [PATCH v3 00/38] tools: move most libraries into tools/libs Move most remaining libraries under tools/libs, including libxenctrl and libxl. This is resulting in a lot of cleanup work regarding building libs and restructuring of the tools directory. After this huge cleanup all dependencies between libraries are defined in a single rather small file tools/libs/uselibs.mk, which is used to create the needed make variables and to control the stubdom build dependencies as well. Another bonus of the rework is the automation of setting the versions of unstable libraries. This removes the need to bump those versions manually for each Xen release. libfsimage is not moved by this series, as IMO there are some open questions: - should it really be unstable? - is the support of adding external fs-support used in practice, i.e. shouldn't the fs-specific sub-libraries be just included into libfsimage instead of being loaded dynamically? The complete series is available via: git://xenbits.xen.org/people/jgross/xen.git libbuild-v3 --_000_159835286098667246citrixcom_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


I have no objection= s. For the OCaml part in particular I previously said that I believe that i= t would benefit from either be maintained outside the tree (which requires = a clean interface) or moving it to use Dune for its build (triggered by the current make build). Any cleanup = that is helping here is welcome.

-- 
Acked-by: Christian Lindig <christian.lindig@citrix.com>​​= ;


From: Juergen Gross <j= gross@suse.com>
Sent: 23 August 2020 10:34
To: xen-devel@lists.xenproject.org; xen-devel@dornerworks.com
Cc: Juergen Gross; Samuel Thibault; Ian Jackson; Wei Liu; George Dun= lap; Nick Rosbrook; Andrew Cooper; Jan Beulich; Julien Grall; Stefano Stabe= llini; Anthony Perard; Marek Marczykowski-G=F3recki; Josh Whitehead; Stewar= t Hildebrand; Christian Lindig; David Scott; Shriram Rajagopalan; Yang Hongyang
Subject: [PATCH v3 00/38] tools: move most libraries into tools/libs=
 
Move most remaining libraries under tools/libs, in= cluding libxenctrl
and libxl. This is resulting in a lot of cleanup work regarding
building libs and restructuring of the tools directory.

After this huge cleanup all dependencies between libraries are defined
in a single rather small file tools/libs/uselibs.mk, which is used to
create the needed make variables and to control the stubdom build
dependencies as well.

Another bonus of the rework is the automation of setting the versions
of unstable libraries. This removes the need to bump those versions
manually for each Xen release.

libfsimage is not moved by this series, as IMO there are some open
questions:
- should it really be unstable?
- is the support of adding external fs-support used in practice, i.e.
  shouldn't the fs-specific sub-libraries be just included into
  libfsimage instead of being loaded dynamically?

The complete series is available via:

git://xenbits.xen.org/people/jgross/xen.git libbuild-v3




--_000_159835286098667246citrixcom_--