All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: wenzong.fan@windriver.com
Cc: wfan@windriver.com, openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS
Date: Mon, 11 Mar 2013 15:38:11 +0000	[thread overview]
Message-ID: <1599644.gZKTPRS2fY@helios> (raw)
In-Reply-To: <1362994719-12276-1-git-send-email-wenzong.fan@windriver.com>

On Monday 11 March 2013 17:38:39 wenzong.fan@windriver.com wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
> 
> Add LAYERVERSION and LAYERDEPENDS to layer.conf
> 
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>  meta-networking/conf/layer.conf |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta-networking/conf/layer.conf
> b/meta-networking/conf/layer.conf index 1ea2bc2..f75080a 100644
> --- a/meta-networking/conf/layer.conf
> +++ b/meta-networking/conf/layer.conf
> @@ -9,3 +9,8 @@ BBFILE_COLLECTIONS += "networking"
>  BBFILE_PATTERN_networking := "^${LAYERDIR}/"
>  BBFILE_PRIORITY_networking = "5"
> 
> +# This should only be incremented on significant changes that will
> +# cause compatibility issues with other layers
> +LAYERVERSION_networking = "1"
> +
> +LAYERDEPENDS_networking = "core"

This is good, but it might be useful to also set a versioned dependency on the 
core - that way if you attempt to use the denzil branch of OE-Core with master 
of one of these layers, instead of an error about incorrect indentation in 
python functions you get one specifically about the version being incorrect.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2013-03-11 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11  9:38 [PATCH] meta-networking: Add LAYERVERSION and LAYERDEPENDS wenzong.fan
2013-03-11 15:38 ` Paul Eggleton [this message]
2013-03-18 15:18   ` Joe MacDonald
2013-03-18 19:22 ` Joe MacDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599644.gZKTPRS2fY@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=wenzong.fan@windriver.com \
    --cc=wfan@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.