From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F12CC433E2 for ; Sun, 13 Sep 2020 02:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3754A206C9 for ; Sun, 13 Sep 2020 02:56:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="e9Zf+NBq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725909AbgIMC4t (ORCPT ); Sat, 12 Sep 2020 22:56:49 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:15355 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725908AbgIMC4s (ORCPT ); Sat, 12 Sep 2020 22:56:48 -0400 X-UUID: 30294c04fe634428b988292186f76724-20200913 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NwIK9pmWDw8n2NhaZLDMiaMs84qVaaRjufGgH4tn2mU=; b=e9Zf+NBq3/cLU+mpdQTwGmm3jtD3AHFd6xsLkTymLHeWrA6zM3HJVSWRaVq4+pWN+PCGmC2PuWchK+CtaimDYTuu8DrufLX0Pdpc/EilS1w615JwoZVUD1Rg2Ggzvh/s5HMlRmfgvj6WVjryKDjEjKQPgV7O2AD8WBRPlCXoduU=; X-UUID: 30294c04fe634428b988292186f76724-20200913 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 821780314; Sun, 13 Sep 2020 10:56:38 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 13 Sep 2020 10:56:36 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 13 Sep 2020 10:56:37 +0800 Message-ID: <1599965676.7466.35.camel@mhfsdcap03> Subject: Re: [PATCH v5 1/4] dt-bindings: pci: mediatek: Modified the Device tree bindings From: Chuanjia Liu To: Rob Herring CC: Bjorn Helgaas , Lorenzo Pieralisi , , , , , , "Frank Wunderlich" , Ryder Lee Date: Sun, 13 Sep 2020 10:54:36 +0800 In-Reply-To: <20200911225024.GB2960430@bogus> References: <20200910061115.909-1-chuanjia.liu@mediatek.com> <20200910061115.909-2-chuanjia.liu@mediatek.com> <20200911225024.GB2960430@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DCBCCB16731868D242FD5AA8DF4E970B1DADE979873D0CDC402F740BDDA4B1C82000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org T24gRnJpLCAyMDIwLTA5LTExIGF0IDE2OjUwIC0wNjAwLCBSb2IgSGVycmluZyB3cm90ZToNCj4g T24gVGh1LCBTZXAgMTAsIDIwMjAgYXQgMDI6MTE6MTJQTSArMDgwMCwgQ2h1YW5qaWEgTGl1IHdy b3RlOg0KPiA+IFNwbGl0IHRoZSBQQ0llIG5vZGUgYW5kIGFkZCBwY2llY2ZnIG5vZGUgdG8gZml4 IE1TSSBpc3N1ZS4NCj4gPiANCj4gPiBBY2tlZC1ieTogUnlkZXIgTGVlIDxyeWRlci5sZWVAbWVk aWF0ZWsuY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IENodWFuamlhIExpdSA8Y2h1YW5qaWEubGl1 QG1lZGlhdGVrLmNvbT4NCj4gPiAtLS0NCj4gPiAgLi4uL2JpbmRpbmdzL3BjaS9tZWRpYXRlay1w Y2llLWNmZy55YW1sICAgICAgIHwgIDM4ICsrKysrDQo+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRp bmdzL3BjaS9tZWRpYXRlay1wY2llLnR4dCB8IDE0NCArKysrKysrKysrKy0tLS0tLS0NCj4gPiAg MiBmaWxlcyBjaGFuZ2VkLCAxMjkgaW5zZXJ0aW9ucygrKSwgNTMgZGVsZXRpb25zKC0pDQo+ID4g IGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNp L21lZGlhdGVrLXBjaWUtY2ZnLnlhbWwNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9tZWRpYXRlay1wY2llLWNmZy55YW1sIGIvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9tZWRpYXRlay1wY2llLWNmZy55YW1s DQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjRkMjgz NWFiNDg1OA0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvcGNpL21lZGlhdGVrLXBjaWUtY2ZnLnlhbWwNCj4gPiBAQCAtMCwwICsx LDM4IEBADQo+ID4gKyMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seSBPUiBC U0QtMi1DbGF1c2UNCj4gPiArJVlBTUwgMS4yDQo+ID4gKy0tLQ0KPiA+ICskaWQ6IGh0dHA6Ly9k ZXZpY2V0cmVlLm9yZy9zY2hlbWFzL3BjaS9tZWRpYXRlay1wY2llLWNmZy55YW1sIw0KPiA+ICsk c2NoZW1hOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvbWV0YS1zY2hlbWFzL2NvcmUueWFtbCMNCj4g PiArDQo+ID4gK3RpdGxlOiBNZWRpYXRlayBQQ0lFQ0ZHIGNvbnRyb2xsZXINCj4gPiArDQo+ID4g K21haW50YWluZXJzOg0KPiA+ICsgIC0gQ2h1YW5qaWEgTGl1IDxjaHVhbmppYS5saXVAbWVkaWF0 ZWsuY29tPg0KPiA+ICsgIC0gSmlhbmp1biBXYW5nIDxqaWFuanVuLndhbmdAbWVkaWF0ZWsuY29t Pg0KPiA+ICsNCj4gPiArZGVzY3JpcHRpb246IHwNCj4gPiArICBUaGUgTWVkaWFUZWsgUENJRUNG RyBjb250cm9sbGVyIGNvbnRyb2xzIHNvbWUgZmVhdHVyZSBhYm91dA0KPiA+ICsgIExUU1NNLCBB U1BNIGFuZCBzbyBvbi4NCj4gPiArDQo+ID4gK3Byb3BlcnRpZXM6DQo+ID4gKyAgY29tcGF0aWJs ZToNCj4gPiArICAgICAgaXRlbXM6DQo+ID4gKyAgICAgICAgLSBlbnVtOg0KPiA+ICsgICAgICAg ICAgICAtIG1lZGlhdGVrLG10NzYyMi1wY2llY2ZnDQo+ID4gKyAgICAgICAgICAgIC0gbWVkaWF0 ZWssbXQ3NjI5LXBjaWVjZmcNCj4gPiArICAgICAgICAtIGNvbnN0OiBzeXNjb24NCj4gPiArDQo+ ID4gKyAgcmVnOg0KPiA+ICsgICAgbWF4SXRlbXM6IDENCj4gPiArDQo+ID4gK3JlcXVpcmVkOg0K PiA+ICsgIC0gY29tcGF0aWJsZQ0KPiA+ICsgIC0gcmVnDQo+ID4gKw0KPiA+ICtleGFtcGxlczoN Cj4gPiArICAtIHwNCj4gPiArICAgIHBjaWVjZmc6IHBjaWVjZmdAMWExNDAwMDAgew0KPiA+ICsg ICAgICAgIGNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ3NjIyLXBjaWVjZmciLCAic3lzY29uIjsN Cj4gPiArICAgICAgICByZWcgPSA8MCAweDFhMTQwMDAwIDAgMHgxMDAwPjsNCj4gPiArICAgIH07 DQo+ID4gKy4uLg0KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvcGNpL21lZGlhdGVrLXBjaWUudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3BjaS9tZWRpYXRlay1wY2llLnR4dA0KPiA+IGluZGV4IDc0NjhkNjY2NzYzYS4uMzFl MjYxOTMzNjg1IDEwMDY0NA0KPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9wY2kvbWVkaWF0ZWstcGNpZS50eHQNCj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvcGNpL21lZGlhdGVrLXBjaWUudHh0DQo+ID4gQEAgLTgsNyArOCw3IEBA IFJlcXVpcmVkIHByb3BlcnRpZXM6DQo+ID4gIAkibWVkaWF0ZWssbXQ3NjIzLXBjaWUiDQo+ID4g IAkibWVkaWF0ZWssbXQ3NjI5LXBjaWUiDQo+ID4gIC0gZGV2aWNlX3R5cGU6IE11c3QgYmUgInBj aSINCj4gPiAtLSByZWc6IEJhc2UgYWRkcmVzc2VzIGFuZCBsZW5ndGhzIG9mIHRoZSBQQ0llIHN1 YnN5cyBhbmQgcm9vdCBwb3J0cy4NCj4gPiArLSByZWc6IEJhc2UgYWRkcmVzc2VzIGFuZCBsZW5n dGhzIG9mIHRoZSByb290IHBvcnRzLg0KPiA+ICAtIHJlZy1uYW1lczogTmFtZXMgb2YgdGhlIGFi b3ZlIGFyZWFzIHRvIHVzZSBkdXJpbmcgcmVzb3VyY2UgbG9va3VwLg0KPiA+ICAtICNhZGRyZXNz LWNlbGxzOiBBZGRyZXNzIHJlcHJlc2VudGF0aW9uIGZvciByb290IHBvcnRzIChtdXN0IGJlIDMp DQo+ID4gIC0gI3NpemUtY2VsbHM6IFNpemUgcmVwcmVzZW50YXRpb24gZm9yIHJvb3QgcG9ydHMg KG11c3QgYmUgMikNCj4gPiBAQCAtMTksMTAgKzE5LDEwIEBAIFJlcXVpcmVkIHByb3BlcnRpZXM6 DQo+ID4gICAgIC0gc3lzX2NrTiA6dHJhbnNhY3Rpb24gbGF5ZXIgYW5kIGRhdGEgbGluayBsYXll ciBjbG9jaw0KPiA+ICAgIFJlcXVpcmVkIGVudHJpZXMgZm9yIE1UMjcwMS9NVDc2MjM6DQo+ID4g ICAgIC0gZnJlZV9jayA6Zm9yIHJlZmVyZW5jZSBjbG9jayBvZiBQQ0llIHN1YnN5cw0KPiA+IC0g IFJlcXVpcmVkIGVudHJpZXMgZm9yIE1UMjcxMi9NVDc2MjI6DQo+ID4gKyAgUmVxdWlyZWQgZW50 cmllcyBmb3IgTVQyNzEyL01UNzYyMi9NVDc2Mjk6DQo+ID4gICAgIC0gYWhiX2NrTiA6QUhCIHNs YXZlIGludGVyZmFjZSBvcGVyYXRpbmcgY2xvY2sgZm9yIENTUiBhY2Nlc3MgYW5kIFJDDQo+ID4g IAkgICAgICBpbml0aWF0ZWQgTU1JTyBhY2Nlc3MNCj4gPiAtICBSZXF1aXJlZCBlbnRyaWVzIGZv ciBNVDc2MjI6DQo+ID4gKyAgUmVxdWlyZWQgZW50cmllcyBmb3IgTVQ3NjIyL01UNzYyOToNCj4g PiAgICAgLSBheGlfY2tOIDphcHBsaWNhdGlvbiBsYXllciBNTUlPIGNoYW5uZWwgb3BlcmF0aW5n IGNsb2NrDQo+ID4gICAgIC0gYXV4X2NrTiA6cGUyX21hY19icmlkZ2UgYW5kIHBlMl9tYWNfY29y ZSBvcGVyYXRpbmcgY2xvY2sgd2hlbg0KPiA+ICAJICAgICAgcGNpZV9tYWNfY2svcGNpZV9waXBl X2NrIGlzIHR1cm5lZCBvZmYNCj4gPiBAQCAtNDcsMTAgKzQ3LDEzIEBAIFJlcXVpcmVkIHByb3Bl cnRpZXMgZm9yIE1UNzYyMy9NVDI3MDE6DQo+ID4gIC0gcmVzZXQtbmFtZXM6IE11c3QgYmUgInBj aWUtcnN0MCIsICJwY2llLXJzdDEiLCAicGNpZS1yc3ROIi4uIGJhc2VkIG9uIHRoZQ0KPiA+ICAg IG51bWJlciBvZiByb290IHBvcnRzLg0KPiA+ICANCj4gPiAtUmVxdWlyZWQgcHJvcGVydGllcyBm b3IgTVQyNzEyL01UNzYyMjoNCj4gPiArUmVxdWlyZWQgcHJvcGVydGllcyBmb3IgTVQyNzEyL01U NzYyMi9NVDc2Mjk6DQo+ID4gIC1pbnRlcnJ1cHRzOiBBIGxpc3Qgb2YgaW50ZXJydXB0IG91dHB1 dHMgb2YgdGhlIGNvbnRyb2xsZXIsIG11c3QgaGF2ZSBvbmUNCj4gPiAgCSAgICAgZW50cnkgZm9y IGVhY2ggUENJZSBwb3J0DQo+ID4gIA0KPiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzIGZvciBNVDc2 MjIvTVQ3NjI5Og0KPiA+ICstIG1lZGlhdGVrLHBjaWUtc3Vic3lzOiBTaG91bGQgYmUgYSBwaGFu ZGxlIG9mIHRoZSBwY2llY2ZnIG5vZGUuDQo+ID4gKw0KPiANCj4gWW91IGRvbid0IG5lZWQgdGhp cy4gWW91IGNhbiBzZWFyY2ggZm9yIHRoZSBub2RlIGJ5IGNvbXBhdGlibGUuDQo+IA0KPiBQbHVz IGl0IGRvZXNuJ3QgbWF0Y2ggdGhlIGV4YW1wbGUuDQoNClRoYW5rcyBmb3IgeW91IGNvbW1lbnQs IEkgd2lsbCBjaGFuZ2UgaXQgaW4gdGhlIG5leHQgdmVyc2lvbi4NCg0KcmVnYXJkcywNCkNodWFu amlhDQo+IA0KPiA+ICBJbiBhZGRpdGlvbiwgdGhlIGRldmljZSB0cmVlIG5vZGUgbXVzdCBoYXZl IHN1Yi1ub2RlcyBkZXNjcmliaW5nIGVhY2gNCj4gPiAgUENJZSBwb3J0IGludGVyZmFjZSwgaGF2 aW5nIHRoZSBmb2xsb3dpbmcgbWFuZGF0b3J5IHByb3BlcnRpZXM6DQo+ID4gIA0KPiA+IEBAIC0x NDMsNTYgKzE0Niw3MyBAQCBFeGFtcGxlcyBmb3IgTVQ3NjIzOg0KPiA+ICANCj4gPiAgRXhhbXBs ZXMgZm9yIE1UMjcxMjoNCj4gPiAgDQo+ID4gLQlwY2llOiBwY2llQDExNzAwMDAwIHsNCj4gPiAr CXBjaWUxOiBwY2llQDExMmZmMDAwIHsNCj4gPiAgCQljb21wYXRpYmxlID0gIm1lZGlhdGVrLG10 MjcxMi1wY2llIjsNCj4gPiAgCQlkZXZpY2VfdHlwZSA9ICJwY2kiOw0KPiA+IC0JCXJlZyA9IDww IDB4MTE3MDAwMDAgMCAweDEwMDA+LA0KPiA+IC0JCSAgICAgIDwwIDB4MTEyZmYwMDAgMCAweDEw MDA+Ow0KPiA+IC0JCXJlZy1uYW1lcyA9ICJwb3J0MCIsICJwb3J0MSI7DQo+ID4gKwkJcmVnID0g PDAgMHgxMTJmZjAwMCAwIDB4MTAwMD47DQo+ID4gKwkJcmVnLW5hbWVzID0gInBvcnQxIjsNCj4g PiAgCQkjYWRkcmVzcy1jZWxscyA9IDwzPjsNCj4gPiAgCQkjc2l6ZS1jZWxscyA9IDwyPjsNCj4g PiAtCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTE1IElSUV9UWVBFX0xFVkVMX0hJR0g+LA0KPiA+ IC0JCQkgICAgIDxHSUNfU1BJIDExNyBJUlFfVFlQRV9MRVZFTF9ISUdIPjsNCj4gPiAtCQljbG9j a3MgPSA8JnRvcGNrZ2VuIENMS19UT1BfUEUyX01BQ19QMF9TRUw+LA0KPiA+IC0JCQkgPCZ0b3Bj a2dlbiBDTEtfVE9QX1BFMl9NQUNfUDFfU0VMPiwNCj4gPiAtCQkJIDwmcGVyaWNmZyBDTEtfUEVS SV9QQ0lFMD4sDQo+ID4gKwkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDExNyBJUlFfVFlQRV9MRVZF TF9ISUdIPjsNCj4gPiArCQlpbnRlcnJ1cHQtbmFtZXMgPSAicGNpZV9pcnEiOw0KPiA+ICsJCWNs b2NrcyA9IDwmdG9wY2tnZW4gQ0xLX1RPUF9QRTJfTUFDX1AxX1NFTD4sDQo+ID4gIAkJCSA8JnBl cmljZmcgQ0xLX1BFUklfUENJRTE+Ow0KPiA+IC0JCWNsb2NrLW5hbWVzID0gInN5c19jazAiLCAi c3lzX2NrMSIsICJhaGJfY2swIiwgImFoYl9jazEiOw0KPiA+IC0JCXBoeXMgPSA8JnBjaWUwX3Bo eSBQSFlfVFlQRV9QQ0lFPiwgPCZwY2llMV9waHkgUEhZX1RZUEVfUENJRT47DQo+ID4gLQkJcGh5 LW5hbWVzID0gInBjaWUtcGh5MCIsICJwY2llLXBoeTEiOw0KPiA+ICsJCWNsb2NrLW5hbWVzID0g InN5c19jazEiLCAiYWhiX2NrMSI7DQo+ID4gKwkJcGh5cyA9IDwmdTNwb3J0MSBQSFlfVFlQRV9Q Q0lFPjsNCj4gPiArCQlwaHktbmFtZXMgPSAicGNpZS1waHkxIjsNCj4gPiAgCQlidXMtcmFuZ2Ug PSA8MHgwMCAweGZmPjsNCj4gPiAtCQlyYW5nZXMgPSA8MHg4MjAwMDAwMCAwIDB4MjAwMDAwMDAg IDB4MCAweDIwMDAwMDAwICAwIDB4MTAwMDAwMDA+Ow0KPiA+ICsJCXJhbmdlcyA9IDwweDgyMDAw MDAwIDAgMHgxMTQwMDAwMCAgMHgwIDB4MTE0MDAwMDAgIDAgMHgzMDAwMDA+Ow0KPiA+ICsJCXN0 YXR1cyA9ICJkaXNhYmxlZCI7DQo+ID4gIA0KPiA+IC0JCXBjaWUwOiBwY2llQDAsMCB7DQo+ID4g LQkJCXJlZyA9IDwweDAwMDAgMCAwIDAgMD47DQo+ID4gKwkJc2xvdDE6IHBjaWVAMSwwIHsNCj4g PiArCQkJcmVnID0gPDB4MDgwMCAwIDAgMCAwPjsNCj4gPiAgCQkJI2FkZHJlc3MtY2VsbHMgPSA8 Mz47DQo+ID4gIAkJCSNzaXplLWNlbGxzID0gPDI+Ow0KPiA+ICAJCQkjaW50ZXJydXB0LWNlbGxz ID0gPDE+Ow0KPiA+ICAJCQlyYW5nZXM7DQo+ID4gIAkJCWludGVycnVwdC1tYXAtbWFzayA9IDww IDAgMCA3PjsNCj4gPiAtCQkJaW50ZXJydXB0LW1hcCA9IDwwIDAgMCAxICZwY2llX2ludGMwIDA+ LA0KPiA+IC0JCQkJCTwwIDAgMCAyICZwY2llX2ludGMwIDE+LA0KPiA+IC0JCQkJCTwwIDAgMCAz ICZwY2llX2ludGMwIDI+LA0KPiA+IC0JCQkJCTwwIDAgMCA0ICZwY2llX2ludGMwIDM+Ow0KPiA+ IC0JCQlwY2llX2ludGMwOiBpbnRlcnJ1cHQtY29udHJvbGxlciB7DQo+ID4gKwkJCWludGVycnVw dC1tYXAgPSA8MCAwIDAgMSAmcGNpZV9pbnRjMSAwPiwNCj4gPiArCQkJCQk8MCAwIDAgMiAmcGNp ZV9pbnRjMSAxPiwNCj4gPiArCQkJCQk8MCAwIDAgMyAmcGNpZV9pbnRjMSAyPiwNCj4gPiArCQkJ CQk8MCAwIDAgNCAmcGNpZV9pbnRjMSAzPjsNCj4gPiArCQkJcGNpZV9pbnRjMTogaW50ZXJydXB0 LWNvbnRyb2xsZXIgew0KPiA+ICAJCQkJaW50ZXJydXB0LWNvbnRyb2xsZXI7DQo+ID4gIAkJCQkj YWRkcmVzcy1jZWxscyA9IDwwPjsNCj4gPiAgCQkJCSNpbnRlcnJ1cHQtY2VsbHMgPSA8MT47DQo+ ID4gIAkJCX07DQo+ID4gIAkJfTsNCj4gPiArCX07DQo+ID4gIA0KPiA+IC0JCXBjaWUxOiBwY2ll QDEsMCB7DQo+ID4gLQkJCXJlZyA9IDwweDA4MDAgMCAwIDAgMD47DQo+ID4gKwlwY2llMDogcGNp ZUAxMTcwMDAwMCB7DQo+ID4gKwkJY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDI3MTItcGNpZSI7 DQo+ID4gKwkJZGV2aWNlX3R5cGUgPSAicGNpIjsNCj4gPiArCQlyZWcgPSA8MCAweDExNzAwMDAw IDAgMHgxMDAwPjsNCj4gPiArCQlyZWctbmFtZXMgPSAicG9ydDAiOw0KPiA+ICsJCSNhZGRyZXNz LWNlbGxzID0gPDM+Ow0KPiA+ICsJCSNzaXplLWNlbGxzID0gPDI+Ow0KPiA+ICsJCWludGVycnVw dHMgPSA8R0lDX1NQSSAxMTUgSVJRX1RZUEVfTEVWRUxfSElHSD47DQo+ID4gKwkJaW50ZXJydXB0 LW5hbWVzID0gInBjaWVfaXJxIjsNCj4gPiArCQljbG9ja3MgPSA8JnRvcGNrZ2VuIENMS19UT1Bf UEUyX01BQ19QMF9TRUw+LA0KPiA+ICsJCQkgPCZwZXJpY2ZnIENMS19QRVJJX1BDSUUwPjsNCj4g PiArCQljbG9jay1uYW1lcyA9ICJzeXNfY2swIiwgImFoYl9jazAiOw0KPiA+ICsJCXBoeXMgPSA8 JnUzcG9ydDAgUEhZX1RZUEVfUENJRT47DQo+ID4gKwkJcGh5LW5hbWVzID0gInBjaWUtcGh5MCI7 DQo+ID4gKwkJYnVzLXJhbmdlID0gPDB4MDAgMHhmZj47DQo+ID4gKwkJcmFuZ2VzID0gPDB4ODIw MDAwMDAgMCAweDIwMDAwMDAwIDB4MCAweDIwMDAwMDAwIDAgMHgxMDAwMDAwMD47DQo+ID4gKwkJ c3RhdHVzID0gImRpc2FibGVkIjsNCj4gPiArDQo+ID4gKwkJc2xvdDA6IHBjaWVAMCwwIHsNCj4g PiArCQkJcmVnID0gPDB4MDAwMCAwIDAgMCAwPjsNCj4gPiAgCQkJI2FkZHJlc3MtY2VsbHMgPSA8 Mz47DQo+ID4gIAkJCSNzaXplLWNlbGxzID0gPDI+Ow0KPiA+ICAJCQkjaW50ZXJydXB0LWNlbGxz ID0gPDE+Ow0KPiA+ICAJCQlyYW5nZXM7DQo+ID4gIAkJCWludGVycnVwdC1tYXAtbWFzayA9IDww IDAgMCA3PjsNCj4gPiAtCQkJaW50ZXJydXB0LW1hcCA9IDwwIDAgMCAxICZwY2llX2ludGMxIDA+ LA0KPiA+IC0JCQkJCTwwIDAgMCAyICZwY2llX2ludGMxIDE+LA0KPiA+IC0JCQkJCTwwIDAgMCAz ICZwY2llX2ludGMxIDI+LA0KPiA+IC0JCQkJCTwwIDAgMCA0ICZwY2llX2ludGMxIDM+Ow0KPiA+ IC0JCQlwY2llX2ludGMxOiBpbnRlcnJ1cHQtY29udHJvbGxlciB7DQo+ID4gKwkJCWludGVycnVw dC1tYXAgPSA8MCAwIDAgMSAmcGNpZV9pbnRjMCAwPiwNCj4gPiArCQkJCQk8MCAwIDAgMiAmcGNp ZV9pbnRjMCAxPiwNCj4gPiArCQkJCQk8MCAwIDAgMyAmcGNpZV9pbnRjMCAyPiwNCj4gPiArCQkJ CQk8MCAwIDAgNCAmcGNpZV9pbnRjMCAzPjsNCj4gPiArCQkJcGNpZV9pbnRjMDogaW50ZXJydXB0 LWNvbnRyb2xsZXIgew0KPiA+ICAJCQkJaW50ZXJydXB0LWNvbnRyb2xsZXI7DQo+ID4gIAkJCQkj YWRkcmVzcy1jZWxscyA9IDwwPjsNCj4gPiAgCQkJCSNpbnRlcnJ1cHQtY2VsbHMgPSA8MT47DQo+ ID4gQEAgLTIwMiwzOSArMjIyLDMxIEBAIEV4YW1wbGVzIGZvciBNVDI3MTI6DQo+ID4gIA0KPiA+ ICBFeGFtcGxlcyBmb3IgTVQ3NjIyOg0KPiA+ICANCj4gPiAtCXBjaWU6IHBjaWVAMWExNDAwMDAg ew0KPiA+ICsJcGNpZTA6IHBjaWVAMWExNDMwMDAgew0KPiA+ICAJCWNvbXBhdGlibGUgPSAibWVk aWF0ZWssbXQ3NjIyLXBjaWUiOw0KPiA+ICAJCWRldmljZV90eXBlID0gInBjaSI7DQo+ID4gLQkJ cmVnID0gPDAgMHgxYTE0MDAwMCAwIDB4MTAwMD4sDQo+ID4gLQkJICAgICAgPDAgMHgxYTE0MzAw MCAwIDB4MTAwMD4sDQo+ID4gLQkJICAgICAgPDAgMHgxYTE0NTAwMCAwIDB4MTAwMD47DQo+ID4g LQkJcmVnLW5hbWVzID0gInN1YnN5cyIsICJwb3J0MCIsICJwb3J0MSI7DQo+ID4gKwkJcmVnID0g PDAgMHgxYTE0MzAwMCAwIDB4MTAwMD47DQo+ID4gKwkJcmVnLW5hbWVzID0gInBvcnQwIjsNCj4g PiArCQltZWRpYXRlayxwY2llLWNmZyA9IDwmcGNpZWNmZz47DQo+ID4gIAkJI2FkZHJlc3MtY2Vs bHMgPSA8Mz47DQo+ID4gIAkJI3NpemUtY2VsbHMgPSA8Mj47DQo+ID4gLQkJaW50ZXJydXB0cyA9 IDxHSUNfU1BJIDIyOCBJUlFfVFlQRV9MRVZFTF9MT1c+LA0KPiA+IC0JCQkgICAgIDxHSUNfU1BJ IDIyOSBJUlFfVFlQRV9MRVZFTF9MT1c+Ow0KPiA+ICsJCWludGVycnVwdHMgPSA8R0lDX1NQSSAy MjggSVJRX1RZUEVfTEVWRUxfTE9XPjsNCj4gPiArCQlpbnRlcnJ1cHQtbmFtZXMgPSAicGNpZV9p cnEiOw0KPiA+ICAJCWNsb2NrcyA9IDwmcGNpZXN5cyBDTEtfUENJRV9QMF9NQUNfRU4+LA0KPiA+ IC0JCQkgPCZwY2llc3lzIENMS19QQ0lFX1AxX01BQ19FTj4sDQo+ID4gIAkJCSA8JnBjaWVzeXMg Q0xLX1BDSUVfUDBfQUhCX0VOPiwNCj4gPiAtCQkJIDwmcGNpZXN5cyBDTEtfUENJRV9QMV9BSEJf RU4+LA0KPiA+ICAJCQkgPCZwY2llc3lzIENMS19QQ0lFX1AwX0FVWF9FTj4sDQo+ID4gLQkJCSA8 JnBjaWVzeXMgQ0xLX1BDSUVfUDFfQVVYX0VOPiwNCj4gPiAgCQkJIDwmcGNpZXN5cyBDTEtfUENJ RV9QMF9BWElfRU4+LA0KPiA+IC0JCQkgPCZwY2llc3lzIENMS19QQ0lFX1AxX0FYSV9FTj4sDQo+ ID4gIAkJCSA8JnBjaWVzeXMgQ0xLX1BDSUVfUDBfT0JGRl9FTj4sDQo+ID4gLQkJCSA8JnBjaWVz eXMgQ0xLX1BDSUVfUDFfT0JGRl9FTj4sDQo+ID4gLQkJCSA8JnBjaWVzeXMgQ0xLX1BDSUVfUDBf UElQRV9FTj4sDQo+ID4gLQkJCSA8JnBjaWVzeXMgQ0xLX1BDSUVfUDFfUElQRV9FTj47DQo+ID4g LQkJY2xvY2stbmFtZXMgPSAic3lzX2NrMCIsICJzeXNfY2sxIiwgImFoYl9jazAiLCAiYWhiX2Nr MSIsDQo+ID4gLQkJCSAgICAgICJhdXhfY2swIiwgImF1eF9jazEiLCAiYXhpX2NrMCIsICJheGlf Y2sxIiwNCj4gPiAtCQkJICAgICAgIm9iZmZfY2swIiwgIm9iZmZfY2sxIiwgInBpcGVfY2swIiwg InBpcGVfY2sxIjsNCj4gPiAtCQlwaHlzID0gPCZwY2llMF9waHkgUEhZX1RZUEVfUENJRT4sIDwm cGNpZTFfcGh5IFBIWV9UWVBFX1BDSUU+Ow0KPiA+IC0JCXBoeS1uYW1lcyA9ICJwY2llLXBoeTAi LCAicGNpZS1waHkxIjsNCj4gPiArCQkJIDwmcGNpZXN5cyBDTEtfUENJRV9QMF9QSVBFX0VOPjsN Cj4gPiArCQljbG9jay1uYW1lcyA9ICJzeXNfY2swIiwgImFoYl9jazAiLCAiYXV4X2NrMCIsDQo+ ID4gKwkJCSAgICAgICJheGlfY2swIiwgIm9iZmZfY2swIiwgInBpcGVfY2swIjsNCj4gPiArDQo+ ID4gIAkJcG93ZXItZG9tYWlucyA9IDwmc2Nwc3lzIE1UNzYyMl9QT1dFUl9ET01BSU5fSElGMD47 DQo+ID4gIAkJYnVzLXJhbmdlID0gPDB4MDAgMHhmZj47DQo+ID4gLQkJcmFuZ2VzID0gPDB4ODIw MDAwMDAgMCAweDIwMDAwMDAwICAweDAgMHgyMDAwMDAwMCAgMCAweDEwMDAwMDAwPjsNCj4gPiAr CQlyYW5nZXMgPSA8MHg4MjAwMDAwMCAwIDB4MjAwMDAwMDAgIDB4MCAweDIwMDAwMDAwICAwIDB4 ODAwMDAwMD47DQo+ID4gKwkJc3RhdHVzID0gImRpc2FibGVkIjsNCj4gPiAgDQo+ID4gLQkJcGNp ZTA6IHBjaWVAMCwwIHsNCj4gPiArCQlzbG90MDogcGNpZUAwLDAgew0KPiA+ICAJCQlyZWcgPSA8 MHgwMDAwIDAgMCAwIDA+Ow0KPiA+ICAJCQkjYWRkcmVzcy1jZWxscyA9IDwzPjsNCj4gPiAgCQkJ I3NpemUtY2VsbHMgPSA8Mj47DQo+ID4gQEAgLTI1MSw4ICsyNjMsMzQgQEAgRXhhbXBsZXMgZm9y IE1UNzYyMjoNCj4gPiAgCQkJCSNpbnRlcnJ1cHQtY2VsbHMgPSA8MT47DQo+ID4gIAkJCX07DQo+ ID4gIAkJfTsNCj4gPiArCX07DQo+ID4gKw0KPiA+ICsJcGNpZTE6IHBjaWVAMWExNDUwMDAgew0K PiA+ICsJCWNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ3NjIyLXBjaWUiOw0KPiA+ICsJCWRldmlj ZV90eXBlID0gInBjaSI7DQo+ID4gKwkJcmVnID0gPDAgMHgxYTE0NTAwMCAwIDB4MTAwMD47DQo+ ID4gKwkJcmVnLW5hbWVzID0gInBvcnQxIjsNCj4gPiArCQltZWRpYXRlayxwY2llLWNmZyA9IDwm cGNpZWNmZz47DQo+ID4gKwkJI2FkZHJlc3MtY2VsbHMgPSA8Mz47DQo+ID4gKwkJI3NpemUtY2Vs bHMgPSA8Mj47DQo+ID4gKwkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDIyOSBJUlFfVFlQRV9MRVZF TF9MT1c+Ow0KPiA+ICsJCWludGVycnVwdC1uYW1lcyA9ICJwY2llX2lycSI7DQo+ID4gKwkJY2xv Y2tzID0gPCZwY2llc3lzIENMS19QQ0lFX1AxX01BQ19FTj4sDQo+ID4gKwkJCSAvKiBkZXNpZ25l ciBoYXMgY29ubmVjdCBSQzEgd2l0aCBwMF9haGIgY2xvY2sgKi8NCj4gPiArCQkJIDwmcGNpZXN5 cyBDTEtfUENJRV9QMF9BSEJfRU4+LA0KPiA+ICsJCQkgPCZwY2llc3lzIENMS19QQ0lFX1AxX0FV WF9FTj4sDQo+ID4gKwkJCSA8JnBjaWVzeXMgQ0xLX1BDSUVfUDFfQVhJX0VOPiwNCj4gPiArCQkJ IDwmcGNpZXN5cyBDTEtfUENJRV9QMV9PQkZGX0VOPiwNCj4gPiArCQkJIDwmcGNpZXN5cyBDTEtf UENJRV9QMV9QSVBFX0VOPjsNCj4gPiArCQljbG9jay1uYW1lcyA9ICJzeXNfY2sxIiwgImFoYl9j azEiLCAiYXV4X2NrMSIsDQo+ID4gKwkJCSAgICAgICJheGlfY2sxIiwgIm9iZmZfY2sxIiwgInBp cGVfY2sxIjsNCj4gPiArDQo+ID4gKwkJcG93ZXItZG9tYWlucyA9IDwmc2Nwc3lzIE1UNzYyMl9Q T1dFUl9ET01BSU5fSElGMD47DQo+ID4gKwkJYnVzLXJhbmdlID0gPDB4MDAgMHhmZj47DQo+ID4g KwkJcmFuZ2VzID0gPDB4ODIwMDAwMDAgMCAweDI4MDAwMDAwICAweDAgMHgyODAwMDAwMCAgMCAw eDgwMDAwMDA+Ow0KPiA+ICsJCXN0YXR1cyA9ICJkaXNhYmxlZCI7DQo+ID4gIA0KPiA+IC0JCXBj aWUxOiBwY2llQDEsMCB7DQo+ID4gKwkJc2xvdDE6IHBjaWVAMSwwIHsNCj4gPiAgCQkJcmVnID0g PDB4MDgwMCAwIDAgMCAwPjsNCj4gPiAgCQkJI2FkZHJlc3MtY2VsbHMgPSA8Mz47DQo+ID4gIAkJ CSNzaXplLWNlbGxzID0gPDI+Ow0KPiA+IC0tIA0KPiA+IDIuMTguMA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55CC0C433E2 for ; Sun, 13 Sep 2020 03:06:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D68C320709 for ; Sun, 13 Sep 2020 03:06:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EAUVYVz9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="e9Zf+NBq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D68C320709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Yz4Re4F6FS6DyU+cplNhDL6woOnrxks5zRVpZEIX7FU=; b=EAUVYVz9Ei83RfGvbMC3CD80g fiEmbPH0tW3aLsKUFKBqOVRH1efAQfz1QtR52UeCSnvLYIntu/43KRqMYhz3OTNP/26f4u9RGhQiW npEclk+v+oJ03PbJDZEchSsNTEnHsc9SGZ+EQusyhTtbvI9U95tpuobuJmXlPbnsnyJKhsgZ6SeSd KSact1xsnOv4v47J8TZB26LC6wssc20dcqeQwKGqhzcBn1kG2thoX9E//cCMeSiB0a1zqsyYh+IRD nbjVSC+S9qWavprGbztcMw7hJkYo6XcyC6o0JlUS0xnNI1KD0QYs0k3t9GUovUhZWQudi65NZWGEN i6Pafs3bQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHILm-0006cH-SJ; Sun, 13 Sep 2020 03:06:46 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHILj-0006be-8S; Sun, 13 Sep 2020 03:06:45 +0000 X-UUID: e23fe1e1238246fbb1b7e7a4130c14e0-20200912 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NwIK9pmWDw8n2NhaZLDMiaMs84qVaaRjufGgH4tn2mU=; b=e9Zf+NBq3/cLU+mpdQTwGmm3jtD3AHFd6xsLkTymLHeWrA6zM3HJVSWRaVq4+pWN+PCGmC2PuWchK+CtaimDYTuu8DrufLX0Pdpc/EilS1w615JwoZVUD1Rg2Ggzvh/s5HMlRmfgvj6WVjryKDjEjKQPgV7O2AD8WBRPlCXoduU=; X-UUID: e23fe1e1238246fbb1b7e7a4130c14e0-20200912 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 12018367; Sat, 12 Sep 2020 19:06:41 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 12 Sep 2020 19:56:38 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 13 Sep 2020 10:56:36 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 13 Sep 2020 10:56:37 +0800 Message-ID: <1599965676.7466.35.camel@mhfsdcap03> Subject: Re: [PATCH v5 1/4] dt-bindings: pci: mediatek: Modified the Device tree bindings From: Chuanjia Liu To: Rob Herring Date: Sun, 13 Sep 2020 10:54:36 +0800 In-Reply-To: <20200911225024.GB2960430@bogus> References: <20200910061115.909-1-chuanjia.liu@mediatek.com> <20200910061115.909-2-chuanjia.liu@mediatek.com> <20200911225024.GB2960430@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DCBCCB16731868D242FD5AA8DF4E970B1DADE979873D0CDC402F740BDDA4B1C82000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200912_230643_562323_BBD8893B X-CRM114-Status: GOOD ( 26.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Frank Wunderlich , linux-pci@vger.kernel.org, Ryder Lee , linux-mediatek@lists.infradead.org, yong.wu@mediatek.com, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2020-09-11 at 16:50 -0600, Rob Herring wrote: > On Thu, Sep 10, 2020 at 02:11:12PM +0800, Chuanjia Liu wrote: > > Split the PCIe node and add pciecfg node to fix MSI issue. > > > > Acked-by: Ryder Lee > > Signed-off-by: Chuanjia Liu > > --- > > .../bindings/pci/mediatek-pcie-cfg.yaml | 38 +++++ > > .../devicetree/bindings/pci/mediatek-pcie.txt | 144 +++++++++++------- > > 2 files changed, 129 insertions(+), 53 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > new file mode 100644 > > index 000000000000..4d2835ab4858 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pci/mediatek-pcie-cfg.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Mediatek PCIECFG controller > > + > > +maintainers: > > + - Chuanjia Liu > > + - Jianjun Wang > > + > > +description: | > > + The MediaTek PCIECFG controller controls some feature about > > + LTSSM, ASPM and so on. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - mediatek,mt7622-pciecfg > > + - mediatek,mt7629-pciecfg > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + pciecfg: pciecfg@1a140000 { > > + compatible = "mediatek,mt7622-pciecfg", "syscon"; > > + reg = <0 0x1a140000 0 0x1000>; > > + }; > > +... > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > > index 7468d666763a..31e261933685 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > > @@ -8,7 +8,7 @@ Required properties: > > "mediatek,mt7623-pcie" > > "mediatek,mt7629-pcie" > > - device_type: Must be "pci" > > -- reg: Base addresses and lengths of the PCIe subsys and root ports. > > +- reg: Base addresses and lengths of the root ports. > > - reg-names: Names of the above areas to use during resource lookup. > > - #address-cells: Address representation for root ports (must be 3) > > - #size-cells: Size representation for root ports (must be 2) > > @@ -19,10 +19,10 @@ Required properties: > > - sys_ckN :transaction layer and data link layer clock > > Required entries for MT2701/MT7623: > > - free_ck :for reference clock of PCIe subsys > > - Required entries for MT2712/MT7622: > > + Required entries for MT2712/MT7622/MT7629: > > - ahb_ckN :AHB slave interface operating clock for CSR access and RC > > initiated MMIO access > > - Required entries for MT7622: > > + Required entries for MT7622/MT7629: > > - axi_ckN :application layer MMIO channel operating clock > > - aux_ckN :pe2_mac_bridge and pe2_mac_core operating clock when > > pcie_mac_ck/pcie_pipe_ck is turned off > > @@ -47,10 +47,13 @@ Required properties for MT7623/MT2701: > > - reset-names: Must be "pcie-rst0", "pcie-rst1", "pcie-rstN".. based on the > > number of root ports. > > > > -Required properties for MT2712/MT7622: > > +Required properties for MT2712/MT7622/MT7629: > > -interrupts: A list of interrupt outputs of the controller, must have one > > entry for each PCIe port > > > > +Required properties for MT7622/MT7629: > > +- mediatek,pcie-subsys: Should be a phandle of the pciecfg node. > > + > > You don't need this. You can search for the node by compatible. > > Plus it doesn't match the example. Thanks for you comment, I will change it in the next version. regards, Chuanjia > > > In addition, the device tree node must have sub-nodes describing each > > PCIe port interface, having the following mandatory properties: > > > > @@ -143,56 +146,73 @@ Examples for MT7623: > > > > Examples for MT2712: > > > > - pcie: pcie@11700000 { > > + pcie1: pcie@112ff000 { > > compatible = "mediatek,mt2712-pcie"; > > device_type = "pci"; > > - reg = <0 0x11700000 0 0x1000>, > > - <0 0x112ff000 0 0x1000>; > > - reg-names = "port0", "port1"; > > + reg = <0 0x112ff000 0 0x1000>; > > + reg-names = "port1"; > > #address-cells = <3>; > > #size-cells = <2>; > > - interrupts = , > > - ; > > - clocks = <&topckgen CLK_TOP_PE2_MAC_P0_SEL>, > > - <&topckgen CLK_TOP_PE2_MAC_P1_SEL>, > > - <&pericfg CLK_PERI_PCIE0>, > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > + clocks = <&topckgen CLK_TOP_PE2_MAC_P1_SEL>, > > <&pericfg CLK_PERI_PCIE1>; > > - clock-names = "sys_ck0", "sys_ck1", "ahb_ck0", "ahb_ck1"; > > - phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>; > > - phy-names = "pcie-phy0", "pcie-phy1"; > > + clock-names = "sys_ck1", "ahb_ck1"; > > + phys = <&u3port1 PHY_TYPE_PCIE>; > > + phy-names = "pcie-phy1"; > > bus-range = <0x00 0xff>; > > - ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > + ranges = <0x82000000 0 0x11400000 0x0 0x11400000 0 0x300000>; > > + status = "disabled"; > > > > - pcie0: pcie@0,0 { > > - reg = <0x0000 0 0 0 0>; > > + slot1: pcie@1,0 { > > + reg = <0x0800 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > #interrupt-cells = <1>; > > ranges; > > interrupt-map-mask = <0 0 0 7>; > > - interrupt-map = <0 0 0 1 &pcie_intc0 0>, > > - <0 0 0 2 &pcie_intc0 1>, > > - <0 0 0 3 &pcie_intc0 2>, > > - <0 0 0 4 &pcie_intc0 3>; > > - pcie_intc0: interrupt-controller { > > + interrupt-map = <0 0 0 1 &pcie_intc1 0>, > > + <0 0 0 2 &pcie_intc1 1>, > > + <0 0 0 3 &pcie_intc1 2>, > > + <0 0 0 4 &pcie_intc1 3>; > > + pcie_intc1: interrupt-controller { > > interrupt-controller; > > #address-cells = <0>; > > #interrupt-cells = <1>; > > }; > > }; > > + }; > > > > - pcie1: pcie@1,0 { > > - reg = <0x0800 0 0 0 0>; > > + pcie0: pcie@11700000 { > > + compatible = "mediatek,mt2712-pcie"; > > + device_type = "pci"; > > + reg = <0 0x11700000 0 0x1000>; > > + reg-names = "port0"; > > + #address-cells = <3>; > > + #size-cells = <2>; > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > + clocks = <&topckgen CLK_TOP_PE2_MAC_P0_SEL>, > > + <&pericfg CLK_PERI_PCIE0>; > > + clock-names = "sys_ck0", "ahb_ck0"; > > + phys = <&u3port0 PHY_TYPE_PCIE>; > > + phy-names = "pcie-phy0"; > > + bus-range = <0x00 0xff>; > > + ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > + status = "disabled"; > > + > > + slot0: pcie@0,0 { > > + reg = <0x0000 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > #interrupt-cells = <1>; > > ranges; > > interrupt-map-mask = <0 0 0 7>; > > - interrupt-map = <0 0 0 1 &pcie_intc1 0>, > > - <0 0 0 2 &pcie_intc1 1>, > > - <0 0 0 3 &pcie_intc1 2>, > > - <0 0 0 4 &pcie_intc1 3>; > > - pcie_intc1: interrupt-controller { > > + interrupt-map = <0 0 0 1 &pcie_intc0 0>, > > + <0 0 0 2 &pcie_intc0 1>, > > + <0 0 0 3 &pcie_intc0 2>, > > + <0 0 0 4 &pcie_intc0 3>; > > + pcie_intc0: interrupt-controller { > > interrupt-controller; > > #address-cells = <0>; > > #interrupt-cells = <1>; > > @@ -202,39 +222,31 @@ Examples for MT2712: > > > > Examples for MT7622: > > > > - pcie: pcie@1a140000 { > > + pcie0: pcie@1a143000 { > > compatible = "mediatek,mt7622-pcie"; > > device_type = "pci"; > > - reg = <0 0x1a140000 0 0x1000>, > > - <0 0x1a143000 0 0x1000>, > > - <0 0x1a145000 0 0x1000>; > > - reg-names = "subsys", "port0", "port1"; > > + reg = <0 0x1a143000 0 0x1000>; > > + reg-names = "port0"; > > + mediatek,pcie-cfg = <&pciecfg>; > > #address-cells = <3>; > > #size-cells = <2>; > > - interrupts = , > > - ; > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > clocks = <&pciesys CLK_PCIE_P0_MAC_EN>, > > - <&pciesys CLK_PCIE_P1_MAC_EN>, > > <&pciesys CLK_PCIE_P0_AHB_EN>, > > - <&pciesys CLK_PCIE_P1_AHB_EN>, > > <&pciesys CLK_PCIE_P0_AUX_EN>, > > - <&pciesys CLK_PCIE_P1_AUX_EN>, > > <&pciesys CLK_PCIE_P0_AXI_EN>, > > - <&pciesys CLK_PCIE_P1_AXI_EN>, > > <&pciesys CLK_PCIE_P0_OBFF_EN>, > > - <&pciesys CLK_PCIE_P1_OBFF_EN>, > > - <&pciesys CLK_PCIE_P0_PIPE_EN>, > > - <&pciesys CLK_PCIE_P1_PIPE_EN>; > > - clock-names = "sys_ck0", "sys_ck1", "ahb_ck0", "ahb_ck1", > > - "aux_ck0", "aux_ck1", "axi_ck0", "axi_ck1", > > - "obff_ck0", "obff_ck1", "pipe_ck0", "pipe_ck1"; > > - phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>; > > - phy-names = "pcie-phy0", "pcie-phy1"; > > + <&pciesys CLK_PCIE_P0_PIPE_EN>; > > + clock-names = "sys_ck0", "ahb_ck0", "aux_ck0", > > + "axi_ck0", "obff_ck0", "pipe_ck0"; > > + > > power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>; > > bus-range = <0x00 0xff>; > > - ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > + ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x8000000>; > > + status = "disabled"; > > > > - pcie0: pcie@0,0 { > > + slot0: pcie@0,0 { > > reg = <0x0000 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > @@ -251,8 +263,34 @@ Examples for MT7622: > > #interrupt-cells = <1>; > > }; > > }; > > + }; > > + > > + pcie1: pcie@1a145000 { > > + compatible = "mediatek,mt7622-pcie"; > > + device_type = "pci"; > > + reg = <0 0x1a145000 0 0x1000>; > > + reg-names = "port1"; > > + mediatek,pcie-cfg = <&pciecfg>; > > + #address-cells = <3>; > > + #size-cells = <2>; > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > + clocks = <&pciesys CLK_PCIE_P1_MAC_EN>, > > + /* designer has connect RC1 with p0_ahb clock */ > > + <&pciesys CLK_PCIE_P0_AHB_EN>, > > + <&pciesys CLK_PCIE_P1_AUX_EN>, > > + <&pciesys CLK_PCIE_P1_AXI_EN>, > > + <&pciesys CLK_PCIE_P1_OBFF_EN>, > > + <&pciesys CLK_PCIE_P1_PIPE_EN>; > > + clock-names = "sys_ck1", "ahb_ck1", "aux_ck1", > > + "axi_ck1", "obff_ck1", "pipe_ck1"; > > + > > + power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>; > > + bus-range = <0x00 0xff>; > > + ranges = <0x82000000 0 0x28000000 0x0 0x28000000 0 0x8000000>; > > + status = "disabled"; > > > > - pcie1: pcie@1,0 { > > + slot1: pcie@1,0 { > > reg = <0x0800 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > -- > > 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28E8C433E2 for ; Sun, 13 Sep 2020 03:08:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 354D520709 for ; Sun, 13 Sep 2020 03:08:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aasD25vz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="e9Zf+NBq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 354D520709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JKC6JbuYHEHDkbOh8KjrMdaPSHYmcLhGcOLaEcAg5vE=; b=aasD25vzsdpwEo7T5tITl4L1F 4DqcBG2qohVyFR9vAZ74UDuxIkisFXPUoAAXRRFO48Eh17NjUWbhh+NTNiT120oBh870YmEplLJca IlR4OgPxKjp6dNZFRQNV2eJCK1h6MpcbDKwIe0pPgPNqSaA5CENP4/uFkJeRJWBm3T/5ziipin8g3 uq1JFwx6V+lCnhZ/DiySVjP4N3HEkzqXnN/dYTSY8t3NuA6rDcvpBM7e1DNgtXTjJzO0hUfUI35UB 8qDIj64h64ieQunID1ylEn2X5kRcuK278iJbiQkHVVaFGxsrFqLUWpgYpOg/P6yrfJUyiTRh1IyVY RXwP54MoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHILn-0006cP-MF; Sun, 13 Sep 2020 03:06:47 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHILj-0006be-8S; Sun, 13 Sep 2020 03:06:45 +0000 X-UUID: e23fe1e1238246fbb1b7e7a4130c14e0-20200912 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NwIK9pmWDw8n2NhaZLDMiaMs84qVaaRjufGgH4tn2mU=; b=e9Zf+NBq3/cLU+mpdQTwGmm3jtD3AHFd6xsLkTymLHeWrA6zM3HJVSWRaVq4+pWN+PCGmC2PuWchK+CtaimDYTuu8DrufLX0Pdpc/EilS1w615JwoZVUD1Rg2Ggzvh/s5HMlRmfgvj6WVjryKDjEjKQPgV7O2AD8WBRPlCXoduU=; X-UUID: e23fe1e1238246fbb1b7e7a4130c14e0-20200912 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 12018367; Sat, 12 Sep 2020 19:06:41 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 12 Sep 2020 19:56:38 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 13 Sep 2020 10:56:36 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 13 Sep 2020 10:56:37 +0800 Message-ID: <1599965676.7466.35.camel@mhfsdcap03> Subject: Re: [PATCH v5 1/4] dt-bindings: pci: mediatek: Modified the Device tree bindings From: Chuanjia Liu To: Rob Herring Date: Sun, 13 Sep 2020 10:54:36 +0800 In-Reply-To: <20200911225024.GB2960430@bogus> References: <20200910061115.909-1-chuanjia.liu@mediatek.com> <20200910061115.909-2-chuanjia.liu@mediatek.com> <20200911225024.GB2960430@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DCBCCB16731868D242FD5AA8DF4E970B1DADE979873D0CDC402F740BDDA4B1C82000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200912_230643_562323_BBD8893B X-CRM114-Status: GOOD ( 26.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Frank Wunderlich , linux-pci@vger.kernel.org, Ryder Lee , linux-mediatek@lists.infradead.org, yong.wu@mediatek.com, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-09-11 at 16:50 -0600, Rob Herring wrote: > On Thu, Sep 10, 2020 at 02:11:12PM +0800, Chuanjia Liu wrote: > > Split the PCIe node and add pciecfg node to fix MSI issue. > > > > Acked-by: Ryder Lee > > Signed-off-by: Chuanjia Liu > > --- > > .../bindings/pci/mediatek-pcie-cfg.yaml | 38 +++++ > > .../devicetree/bindings/pci/mediatek-pcie.txt | 144 +++++++++++------- > > 2 files changed, 129 insertions(+), 53 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > new file mode 100644 > > index 000000000000..4d2835ab4858 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pci/mediatek-pcie-cfg.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Mediatek PCIECFG controller > > + > > +maintainers: > > + - Chuanjia Liu > > + - Jianjun Wang > > + > > +description: | > > + The MediaTek PCIECFG controller controls some feature about > > + LTSSM, ASPM and so on. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - mediatek,mt7622-pciecfg > > + - mediatek,mt7629-pciecfg > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + pciecfg: pciecfg@1a140000 { > > + compatible = "mediatek,mt7622-pciecfg", "syscon"; > > + reg = <0 0x1a140000 0 0x1000>; > > + }; > > +... > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > > index 7468d666763a..31e261933685 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > > @@ -8,7 +8,7 @@ Required properties: > > "mediatek,mt7623-pcie" > > "mediatek,mt7629-pcie" > > - device_type: Must be "pci" > > -- reg: Base addresses and lengths of the PCIe subsys and root ports. > > +- reg: Base addresses and lengths of the root ports. > > - reg-names: Names of the above areas to use during resource lookup. > > - #address-cells: Address representation for root ports (must be 3) > > - #size-cells: Size representation for root ports (must be 2) > > @@ -19,10 +19,10 @@ Required properties: > > - sys_ckN :transaction layer and data link layer clock > > Required entries for MT2701/MT7623: > > - free_ck :for reference clock of PCIe subsys > > - Required entries for MT2712/MT7622: > > + Required entries for MT2712/MT7622/MT7629: > > - ahb_ckN :AHB slave interface operating clock for CSR access and RC > > initiated MMIO access > > - Required entries for MT7622: > > + Required entries for MT7622/MT7629: > > - axi_ckN :application layer MMIO channel operating clock > > - aux_ckN :pe2_mac_bridge and pe2_mac_core operating clock when > > pcie_mac_ck/pcie_pipe_ck is turned off > > @@ -47,10 +47,13 @@ Required properties for MT7623/MT2701: > > - reset-names: Must be "pcie-rst0", "pcie-rst1", "pcie-rstN".. based on the > > number of root ports. > > > > -Required properties for MT2712/MT7622: > > +Required properties for MT2712/MT7622/MT7629: > > -interrupts: A list of interrupt outputs of the controller, must have one > > entry for each PCIe port > > > > +Required properties for MT7622/MT7629: > > +- mediatek,pcie-subsys: Should be a phandle of the pciecfg node. > > + > > You don't need this. You can search for the node by compatible. > > Plus it doesn't match the example. Thanks for you comment, I will change it in the next version. regards, Chuanjia > > > In addition, the device tree node must have sub-nodes describing each > > PCIe port interface, having the following mandatory properties: > > > > @@ -143,56 +146,73 @@ Examples for MT7623: > > > > Examples for MT2712: > > > > - pcie: pcie@11700000 { > > + pcie1: pcie@112ff000 { > > compatible = "mediatek,mt2712-pcie"; > > device_type = "pci"; > > - reg = <0 0x11700000 0 0x1000>, > > - <0 0x112ff000 0 0x1000>; > > - reg-names = "port0", "port1"; > > + reg = <0 0x112ff000 0 0x1000>; > > + reg-names = "port1"; > > #address-cells = <3>; > > #size-cells = <2>; > > - interrupts = , > > - ; > > - clocks = <&topckgen CLK_TOP_PE2_MAC_P0_SEL>, > > - <&topckgen CLK_TOP_PE2_MAC_P1_SEL>, > > - <&pericfg CLK_PERI_PCIE0>, > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > + clocks = <&topckgen CLK_TOP_PE2_MAC_P1_SEL>, > > <&pericfg CLK_PERI_PCIE1>; > > - clock-names = "sys_ck0", "sys_ck1", "ahb_ck0", "ahb_ck1"; > > - phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>; > > - phy-names = "pcie-phy0", "pcie-phy1"; > > + clock-names = "sys_ck1", "ahb_ck1"; > > + phys = <&u3port1 PHY_TYPE_PCIE>; > > + phy-names = "pcie-phy1"; > > bus-range = <0x00 0xff>; > > - ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > + ranges = <0x82000000 0 0x11400000 0x0 0x11400000 0 0x300000>; > > + status = "disabled"; > > > > - pcie0: pcie@0,0 { > > - reg = <0x0000 0 0 0 0>; > > + slot1: pcie@1,0 { > > + reg = <0x0800 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > #interrupt-cells = <1>; > > ranges; > > interrupt-map-mask = <0 0 0 7>; > > - interrupt-map = <0 0 0 1 &pcie_intc0 0>, > > - <0 0 0 2 &pcie_intc0 1>, > > - <0 0 0 3 &pcie_intc0 2>, > > - <0 0 0 4 &pcie_intc0 3>; > > - pcie_intc0: interrupt-controller { > > + interrupt-map = <0 0 0 1 &pcie_intc1 0>, > > + <0 0 0 2 &pcie_intc1 1>, > > + <0 0 0 3 &pcie_intc1 2>, > > + <0 0 0 4 &pcie_intc1 3>; > > + pcie_intc1: interrupt-controller { > > interrupt-controller; > > #address-cells = <0>; > > #interrupt-cells = <1>; > > }; > > }; > > + }; > > > > - pcie1: pcie@1,0 { > > - reg = <0x0800 0 0 0 0>; > > + pcie0: pcie@11700000 { > > + compatible = "mediatek,mt2712-pcie"; > > + device_type = "pci"; > > + reg = <0 0x11700000 0 0x1000>; > > + reg-names = "port0"; > > + #address-cells = <3>; > > + #size-cells = <2>; > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > + clocks = <&topckgen CLK_TOP_PE2_MAC_P0_SEL>, > > + <&pericfg CLK_PERI_PCIE0>; > > + clock-names = "sys_ck0", "ahb_ck0"; > > + phys = <&u3port0 PHY_TYPE_PCIE>; > > + phy-names = "pcie-phy0"; > > + bus-range = <0x00 0xff>; > > + ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > + status = "disabled"; > > + > > + slot0: pcie@0,0 { > > + reg = <0x0000 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > #interrupt-cells = <1>; > > ranges; > > interrupt-map-mask = <0 0 0 7>; > > - interrupt-map = <0 0 0 1 &pcie_intc1 0>, > > - <0 0 0 2 &pcie_intc1 1>, > > - <0 0 0 3 &pcie_intc1 2>, > > - <0 0 0 4 &pcie_intc1 3>; > > - pcie_intc1: interrupt-controller { > > + interrupt-map = <0 0 0 1 &pcie_intc0 0>, > > + <0 0 0 2 &pcie_intc0 1>, > > + <0 0 0 3 &pcie_intc0 2>, > > + <0 0 0 4 &pcie_intc0 3>; > > + pcie_intc0: interrupt-controller { > > interrupt-controller; > > #address-cells = <0>; > > #interrupt-cells = <1>; > > @@ -202,39 +222,31 @@ Examples for MT2712: > > > > Examples for MT7622: > > > > - pcie: pcie@1a140000 { > > + pcie0: pcie@1a143000 { > > compatible = "mediatek,mt7622-pcie"; > > device_type = "pci"; > > - reg = <0 0x1a140000 0 0x1000>, > > - <0 0x1a143000 0 0x1000>, > > - <0 0x1a145000 0 0x1000>; > > - reg-names = "subsys", "port0", "port1"; > > + reg = <0 0x1a143000 0 0x1000>; > > + reg-names = "port0"; > > + mediatek,pcie-cfg = <&pciecfg>; > > #address-cells = <3>; > > #size-cells = <2>; > > - interrupts = , > > - ; > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > clocks = <&pciesys CLK_PCIE_P0_MAC_EN>, > > - <&pciesys CLK_PCIE_P1_MAC_EN>, > > <&pciesys CLK_PCIE_P0_AHB_EN>, > > - <&pciesys CLK_PCIE_P1_AHB_EN>, > > <&pciesys CLK_PCIE_P0_AUX_EN>, > > - <&pciesys CLK_PCIE_P1_AUX_EN>, > > <&pciesys CLK_PCIE_P0_AXI_EN>, > > - <&pciesys CLK_PCIE_P1_AXI_EN>, > > <&pciesys CLK_PCIE_P0_OBFF_EN>, > > - <&pciesys CLK_PCIE_P1_OBFF_EN>, > > - <&pciesys CLK_PCIE_P0_PIPE_EN>, > > - <&pciesys CLK_PCIE_P1_PIPE_EN>; > > - clock-names = "sys_ck0", "sys_ck1", "ahb_ck0", "ahb_ck1", > > - "aux_ck0", "aux_ck1", "axi_ck0", "axi_ck1", > > - "obff_ck0", "obff_ck1", "pipe_ck0", "pipe_ck1"; > > - phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>; > > - phy-names = "pcie-phy0", "pcie-phy1"; > > + <&pciesys CLK_PCIE_P0_PIPE_EN>; > > + clock-names = "sys_ck0", "ahb_ck0", "aux_ck0", > > + "axi_ck0", "obff_ck0", "pipe_ck0"; > > + > > power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>; > > bus-range = <0x00 0xff>; > > - ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > + ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x8000000>; > > + status = "disabled"; > > > > - pcie0: pcie@0,0 { > > + slot0: pcie@0,0 { > > reg = <0x0000 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > @@ -251,8 +263,34 @@ Examples for MT7622: > > #interrupt-cells = <1>; > > }; > > }; > > + }; > > + > > + pcie1: pcie@1a145000 { > > + compatible = "mediatek,mt7622-pcie"; > > + device_type = "pci"; > > + reg = <0 0x1a145000 0 0x1000>; > > + reg-names = "port1"; > > + mediatek,pcie-cfg = <&pciecfg>; > > + #address-cells = <3>; > > + #size-cells = <2>; > > + interrupts = ; > > + interrupt-names = "pcie_irq"; > > + clocks = <&pciesys CLK_PCIE_P1_MAC_EN>, > > + /* designer has connect RC1 with p0_ahb clock */ > > + <&pciesys CLK_PCIE_P0_AHB_EN>, > > + <&pciesys CLK_PCIE_P1_AUX_EN>, > > + <&pciesys CLK_PCIE_P1_AXI_EN>, > > + <&pciesys CLK_PCIE_P1_OBFF_EN>, > > + <&pciesys CLK_PCIE_P1_PIPE_EN>; > > + clock-names = "sys_ck1", "ahb_ck1", "aux_ck1", > > + "axi_ck1", "obff_ck1", "pipe_ck1"; > > + > > + power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>; > > + bus-range = <0x00 0xff>; > > + ranges = <0x82000000 0 0x28000000 0x0 0x28000000 0 0x8000000>; > > + status = "disabled"; > > > > - pcie1: pcie@1,0 { > > + slot1: pcie@1,0 { > > reg = <0x0800 0 0 0 0>; > > #address-cells = <3>; > > #size-cells = <2>; > > -- > > 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel