All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Haakon Bugge <haakon.bugge@oracle.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"OFED mailing list" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] mei: Remove some dead code
Date: Sun, 28 Nov 2021 16:38:47 +0000	[thread overview]
Message-ID: <15b253e2abd049e6a9ebb4efafc10292@intel.com> (raw)
In-Reply-To: <YaOSQrGqogbFGAqJ@kroah.com>


> On Sun, Nov 28, 2021 at 11:12:33AM +0000, Winkler, Tomas wrote:
> >
> > >
> > >
> > > > On 12 Nov 2021, at 11:06, Christophe JAILLET
> > > <christophe.jaillet@wanadoo.fr> wrote:
> > > >
> > > > 'generated' is known to be true here, so "true || whatever" will
> > > > still be true.
> > > >
> > > > So, remove some dead code.
> > > >
> > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > > ---
> > > > This is also likely that a bug is lurking here.
> > > >
> > > > Maybe, the following was expected:
> > > > -	generated = generated ||
> > > > +	generated =
> > > > 		(hisr & HISR_INT_STS_MSK) ||
> > > > 		(ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> > > >
> > > > ?
> > >
> > > I concur about your analysis, but I do not know the intent here.
> > Your fix  is okay, I can ack that patch.
> 
> Is that an ack of this patch?  If so, please provide that...
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Thanks
Tomas


      reply	other threads:[~2021-11-28 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 10:06 [PATCH] mei: Remove some dead code Christophe JAILLET
2021-11-12 11:30 ` Haakon Bugge
2021-11-28 11:12   ` Winkler, Tomas
2021-11-28 14:29     ` gregkh
2021-11-28 16:38       ` Winkler, Tomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15b253e2abd049e6a9ebb4efafc10292@intel.com \
    --to=tomas.winkler@intel.com \
    --cc=arnd@arndb.de \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=haakon.bugge@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.