From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: ticotimo@gmail.com, bitbake-devel@lists.openembedded.org
Cc: Tim Orling <tim.orling@konsulko.com>
Subject: Re: [bitbake-devel] [PATCH] parse: only search each BBPATH directory once in include_all
Date: Tue, 20 Oct 2026 13:32:12 +0100 [thread overview]
Message-ID: <15d454e123cc90b3d307ed8199740748b00dc83e.camel@linuxfoundation.org> (raw)
In-Reply-To: <20261019020422.14365-1-tim.orling@konsulko.com>
On Sun, 2026-10-18 at 19:04 -0700, Tim Orling via lists.openembedded.org wrote:
> If a directory appears in BBPATH more than once, include_all includes
> the file from it again, applying it twice and warning "Duplicate
> inclusion". The layer index hits this because the core layer is in its
> initial BBPATH and appended again by layer.conf. Skip directories
> already searched, and add a test for it.
>
> This fixes one source of the warnings in [YOCTO #16451]; the duplicate
> inclusion of defaultsetup.conf reported there has a separate cause.
Tim and I talked briefly on the review call.
The patch is probably ok however the real issue is the path duplication
in BBPATH and the "real" fix is probably to detect and error on that
happening in the first place.
Cheers,
Richard
prev parent reply other threads:[~2026-10-20 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 2:04 [PATCH] parse: only search each BBPATH directory once in include_all Tim Orling
2026-10-19 16:12 ` [bitbake-devel] " Ross Burton
2026-10-20 12:30 ` Richard Purdie
2026-10-20 12:33 ` Ross Burton
2026-10-20 12:46 ` Richard Purdie
2026-10-20 12:32 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15d454e123cc90b3d307ed8199740748b00dc83e.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=ticotimo@gmail.com \
--cc=tim.orling@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.