From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: clarify IS_GEN vs IS_ usage Date: Mon, 09 May 2011 20:09:22 +0100 Message-ID: <15db10$kia2f3@fmsmga002.fm.intel.com> References: <1304633805-7505-1-git-send-email-jbarnes@virtuousgeek.org> <0d30dc$m4ic2q@orsmga001.jf.intel.com> <20110509114213.34816211@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 43ECD9E7EB for ; Mon, 9 May 2011 12:09:25 -0700 (PDT) In-Reply-To: <20110509114213.34816211@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 9 May 2011 11:42:13 -0700, Jesse Barnes wrote: > On Thu, 05 May 2011 23:57:56 +0100 > Chris Wilson wrote: > > Whilst you are in the vicinity, does it make sense to rename info->gen to > > info->render (or info->render_gen)? > > Sure. Ok, that really does reveal in how many locations we have conflated the display generation and the render generation. I think the next step would be a display generation enum. The third generation counter would be the BIOS/chipset series. And then we have those promiscuous registers used everywhere! Reading through it, I think the render_gen patch just highlights the obvious confusion and so we shouldn't apply it until we have some remedial patches. -Chris -- Chris Wilson, Intel Open Source Technology Centre