From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFEBBC61DA4 for ; Thu, 16 Feb 2023 17:19:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7055085B77; Thu, 16 Feb 2023 18:19:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="SUxAcnzT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 25BFD85B27; Thu, 16 Feb 2023 18:19:19 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 57B7C85B6E for ; Thu, 16 Feb 2023 18:19:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 070093F4B8 for ; Thu, 16 Feb 2023 17:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1676567955; bh=NgaK+sbxWLeuxIlvvMH90aOHxvGlplvekm4+YyeNdwE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SUxAcnzTHipEmNX2GXxF7jYEpbYg1m/jH4i8ADMJf/D7w3UL2VCJwZU3WcDcbUUTE MQZCVWC9kAzY7ggADopu8OT3aSabxjrW0OTYKr6Zj1ozq0xHqVl6BZpPvTM/piDLVH bDdjpMfev3pq4XgaXmqtmiNt7cF/zXTAVYgXYdBB7d4c1823SC8uPr1I0ou4DUNYku orKAZPZVjHdgUuMwpEpmyNMPb8bkKWUG9UpjCuIuGW9PljQtY+zEspIP898qPX4Dkm Fw8V3DATCnZ+xPZ19rUK1HlIC5ymUSq+/83r8/AFdir06Neqg+4agE2YWLA72M2FkG Aox1T53NWF6yQ== Received: by mail-wr1-f71.google.com with SMTP id f14-20020a0560001a8e00b002c3b562d76cso354850wry.12 for ; Thu, 16 Feb 2023 09:19:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NgaK+sbxWLeuxIlvvMH90aOHxvGlplvekm4+YyeNdwE=; b=a8ETkAxaquQpzI6JzvdBnOk70NWoSm9KPysxlfyXfpFDqg6dMG6BST6W89GvkAA2nx yJskCNyNTGUj7W6dJDHePAhN8fwEgvjHTZrP19fHZsf/fUD3+mBZn4oPjWBjbp++aJ3t 04V3LXNSv8SxHCaHO6bxMQd4d8epGJxGu8gyB2XhjBvoR6SMBPfXXtGwPB0A2vPMdzV9 z+Ei+3vO+EGrZIrYcyvLDC5+6jU8y4qtTi+jaU6Bo76B6Am0hw/tHjEh9dX1tGnZbdno my1XhB5nnzZxY0G+C0N7+Ei1SS360hr6KzZXia7pIkrYYTpxPOYZV8Y2jS+3udBWEVZZ y0OA== X-Gm-Message-State: AO0yUKUC9fI7z7EOeIh4VZogRORXnaMFg5QY+OqtkCH/QS66uH+jOuFh n+j7yv4WpIY9tQrndlN3gw/sgqL8LjpyMX98yCp1fi6QD6eZxT8hC98P0Mn8p516Vr7ZoUZkQ5E YziC5iYu/34TqPLU22BXfu9NLBxjaQ44= X-Received: by 2002:a05:600c:4aa0:b0:3e2:66b:e90e with SMTP id b32-20020a05600c4aa000b003e2066be90emr4029533wmp.10.1676567953552; Thu, 16 Feb 2023 09:19:13 -0800 (PST) X-Google-Smtp-Source: AK7set+7duxhhqpdebFiXPBAA9tZy+r2VtJv6XvB7M+NUwEY9jFNieAQOW5dvM2P7c3Tz647eA6MFw== X-Received: by 2002:a05:600c:4aa0:b0:3e2:66b:e90e with SMTP id b32-20020a05600c4aa000b003e2066be90emr4029524wmp.10.1676567953227; Thu, 16 Feb 2023 09:19:13 -0800 (PST) Received: from [192.168.123.94] (ip-088-152-145-137.um26.pools.vodafone-ip.de. [88.152.145.137]) by smtp.gmail.com with ESMTPSA id p22-20020a05600c205600b003de2fc8214esm2234323wmg.20.2023.02.16.09.19.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 09:19:12 -0800 (PST) Message-ID: <15eb0c06-33f7-31f3-e9d7-696f642de3d6@canonical.com> Date: Thu, 16 Feb 2023 18:19:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 1/1] spl: allow loading via partition type GUID To: Tom Rini Cc: Yanhong Wang , Simon Glass , Andrew Davis , Alper Nebi Yasak , Stefan Roese , Andre Przywara , =?UTF-8?B?SsOpcsO0bWUgQ2FycmV0ZXJv?= , Harald Seiler , u-boot@lists.denx.de References: <20230216152956.130038-1-heinrich.schuchardt@canonical.com> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/16/23 18:01, Tom Rini wrote: > On Thu, Feb 16, 2023 at 04:29:56PM +0100, Heinrich Schuchardt wrote: > >> Some boards provide main U-Boot as a dedicated partition to SPL. >> Currently we can define either a fixed partition number or an MBR >> partition type to define which partition is to be used. >> >> Partition numbers tend to conflict with established partitioning schemes >> of Linux distros. MBR partitioning is more and more replaced by GPT >> partitioning. >> >> Allow defining a partition type GUID identifying the partition to load >> main U-Boot from. >> >> Signed-off-by: Heinrich Schuchardt > [snip] >> +config SYS_MMCSD_RAW_MODE_U_BOOT_GPT_PARTITION_TYPE >> + string "GPT Partition Type on the MMC to load U-Boot from" >> + depends on SYS_MMCSD_RAW_MODE_U_BOOT_USE_GPT_PARTITION_TYPE >> + default d2f002f8-e4e7-4269-b8ac-3bb6fabeaff6 > > Is there a reason to use any other GUID value here? If not, just define, > or use it directly with a comment. If there is a reason for other > values to be used: Board vendors already differ in the partition GUIDs they use, e.g. SiFive: SPL: 5B193300-FC78-40CD-8002-E86C45580B47 Main U-Boot: 2E54B353-1271-4842-806F-E436D6AF6985 StarFive SPL: 2E54B353-1271-4842-806F-E436D6AF6985 (sic) Microchip Icicle Board: SPL: 21686148-6449-6E6F-744E-656564454649 Using unique IDs per board allow to create SD card images where U-Boot for multiple boards is installed in parallel: The boot ROM will select the board specific SPL via a unique ID and then SPL will use another unique ID to load the matching main U-Boot. I only added a default value here to provide a formatting sample. Best regards Heinrich > > Reviewed-by: Tom Rini >