From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=mspinler@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42VkQ73sgRzDsPd for ; Thu, 11 Oct 2018 06:17:51 +1100 (AEDT) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9AJEPfj133256 for ; Wed, 10 Oct 2018 15:17:48 -0400 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0a-001b2d01.pphosted.com with ESMTP id 2n1pj1t8da-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 10 Oct 2018 15:17:48 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Oct 2018 13:17:47 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 10 Oct 2018 13:17:45 -0600 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9AJHiKh42795030 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Oct 2018 12:17:44 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 86E376E04E; Wed, 10 Oct 2018 13:17:44 -0600 (MDT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 646126E05B; Wed, 10 Oct 2018 13:17:44 -0600 (MDT) Received: from ltc.linux.ibm.com (unknown [9.16.170.189]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 10 Oct 2018 13:17:44 -0600 (MDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 Oct 2018 14:19:14 -0500 From: Matt Spinler To: Patrick Venture Cc: OpenBMC Maillist Subject: Re: Recipe Renames, etc In-Reply-To: References: <9dc677b3c95c2bc7e7c5a11a97df49a7@linux.vnet.ibm.com> X-Sender: mspinler@linux.vnet.ibm.com User-Agent: Roundcube Webmail/1.0.1 X-TM-AS-GCONF: 00 x-cbid: 18101019-0036-0000-0000-00000A483433 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009855; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000268; SDB=6.01100747; UDB=6.00569538; IPR=6.00880796; MB=3.00023700; MTD=3.00000008; XFM=3.00000015; UTC=2018-10-10 19:17:46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18101019-0037-0000-0000-0000493D5175 Message-Id: <15eff4674f364d8a4f47a07bf0b60066@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-10_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810100179 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 19:17:52 -0000 On 2018-10-10 14:02, Patrick Venture wrote: > On Wed, Oct 10, 2018 at 12:01 PM Patrick Venture > wrote: >> >> On Wed, Oct 10, 2018 at 12:00 PM Matt Spinler >> wrote: >> > >> > On 2018-10-10 13:50, Patrick Venture wrote: >> > > On Wed, Oct 10, 2018 at 11:46 AM Patrick Venture >> > > wrote: >> > >> >> > >> On Wed, Oct 10, 2018 at 11:45 AM Patrick Venture >> > >> wrote: >> > >> > >> > >> > On Wed, Oct 10, 2018 at 11:38 AM Matt Spinler >> > >> > wrote: >> > >> > > >> > >> > > On 2018-10-02 10:28, Patrick Venture wrote: >> > >> > > > I've sent a bunch of recipe renames, but I'm still updating each with >> > >> > > > an individual tested footer. I will try marking them all as WIP now >> > >> > > > >> > >> > > > Patrick >> > >> > > >> > >> > > >> > >> > > Hi Patrick, >> > >> > > >> > >> > > I think you broke master with these. For example, the phosphor-rest >> > >> > > recipe - it has a default url-config.json, and then a layer specific file gets >> > >> > > applied from the meta-ibm layer, like: >> > >> > > >> > >> > > meta-ibm/recipes-phosphor/interfaces/phosphor-rest/url_config.json >> > >> > > >> > >> > > However, from the log.do_unpack from the phosphor-rest build, it doesn't >> > >> > > look there, it now only looks in phosphor-rest%. So any override directory without >> > >> > > a % isn't being found. >> > >> > >> > >> > Interesting that the CI didn't catch the break since witherspoon is >> > >> > one of the systems built via it. But I'll take a look. >> > >> > Yea, our current automated test bucket can't catch this. (shows there >> > is still room for improvement) >> > >> > >> > >> >> > >> Although I have had configuration files disappear when the wildcard is >> > >> missing from the directory, the recipe normally complains about being >> > >> unable to find the file. For a file override, if there's already that >> > >> file - presumably then it wouldn't complain. >> > >> > The latter is what's happening here. >> > >> > > >> > > I've fired off a witherspoon build locally from openbmc HEAD, and will >> > > report back. Very few of the recipes were updated in this fashion so >> > > I'm not terribly worried about a general breakage. >> > >> > Thanks for looking. I'm not sure if there's an easy way to find these >> > cases. >> >> This specific case is difficult to catch but, it's something that's >> avoided for most of the renames, so at least there's that. Future >> changes though -- one will just have to be more cognizant of matching >> output. >> >> > >> > > >> > >> >> > >> > >> > >> > > >> > >> > > I haven't looked to see what all is broken yet and in how many layers, >> > >> > > at least our phosphor-rest and phosphor-gevent, which is why the web UI stopped >> > >> > > working on witherspoon. Not sure if any other systems are also having problems. >> > >> > > >> > >> > > >> > > > Given it looks like I've already staged the fixes to this, we just > need to move those forward and when it settles, it should all be > copacetic. Those patches do indeed fix it. Glad everything is already done. Thanks!