All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: kernel-dev@igalia.com, Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Subject: Re: [RFC 1/2] drm/amdgpu: Store SDMA instance and index in the ring
Date: Tue, 08 Sep 2026 10:42:19 +0200	[thread overview]
Message-ID: <15g9zLryTPO4j32E_pIEBQ@gmail.com> (raw)
In-Reply-To: <20260622143649.54632-2-tvrtko.ursulin@igalia.com>

On 2026. június 22., hétfő 16:36:48 közép-európai nyári idő Tvrtko Ursulin 
wrote:
> Instead of searching for the matching SDMA instance inside many of the
> SDMA ring vfuncs, lets just cache the instance and index in the new SDMA
> specific section of struct amdgpu_ring. This converts a function call plus
> array walks to a direct lookup.

AFAIK, the rings already have the IP block instance ID in the "me" field. So 
this could be simplified by using that. For example like this:
https://pastebin.com/raw/jp4Uk2sE

> 
> While at it, we also consolidate the initialization side with a new
> amdgpu_sdma_ring_init() helper.

Can you move that part to a separate commit?

Best regards,
Timur




  reply	other threads:[~2026-09-08  8:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 14:36 [RFC 0/2] Store SDMA ring instance and index in the ring Tvrtko Ursulin
2026-06-22 14:36 ` [RFC 1/2] drm/amdgpu: Store SDMA " Tvrtko Ursulin
2026-09-08  8:42   ` Timur Kristóf [this message]
2026-09-08  8:54     ` Tvrtko Ursulin
2026-09-08  9:32       ` Timur Kristóf
2026-06-22 14:36 ` [RFC 2/2] drm/amdgpu: Drop null SDMA instance checks from SDMA vfuncs Tvrtko Ursulin
2026-09-08  8:42   ` Timur Kristóf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15g9zLryTPO4j32E_pIEBQ@gmail.com \
    --to=timur.kristof@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.