From: Oliver Neukum <oneukum@suse.de>
To: Allen Pais <allen.lkml@gmail.com>, davem@davemloft.net
Cc: m.grzeschik@pengutronix.de, kuba@kernel.org, paulus@samba.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
petkan@nucleusys.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-ppp@vger.kernel.org,
Allen Pais <apais@linux.microsoft.com>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [RESEND net-next v2 12/12] net: usbnet: convert tasklets to use new tasklet_setup() API
Date: Mon, 14 Sep 2020 08:02:47 +0000 [thread overview]
Message-ID: <1600070567.2534.3.camel@suse.de> (raw)
In-Reply-To: <20200914073131.803374-13-allen.lkml@gmail.com>
Am Montag, den 14.09.2020, 13:01 +0530 schrieb Allen Pais:
> From: Allen Pais <apais@linux.microsoft.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly
> and remove the .data field.
Hi,
how would bisecting be supposed to run smoothly, if this
patch were applied? We'd pass a NULL pointer.
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.de>
To: Allen Pais <allen.lkml@gmail.com>, davem@davemloft.net
Cc: m.grzeschik@pengutronix.de, kuba@kernel.org, paulus@samba.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
petkan@nucleusys.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-ppp@vger.kernel.org,
Allen Pais <apais@linux.microsoft.com>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [RESEND net-next v2 12/12] net: usbnet: convert tasklets to use new tasklet_setup() API
Date: Mon, 14 Sep 2020 10:02:47 +0200 [thread overview]
Message-ID: <1600070567.2534.3.camel@suse.de> (raw)
In-Reply-To: <20200914073131.803374-13-allen.lkml@gmail.com>
Am Montag, den 14.09.2020, 13:01 +0530 schrieb Allen Pais:
> From: Allen Pais <apais@linux.microsoft.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly
> and remove the .data field.
Hi,
how would bisecting be supposed to run smoothly, if this
patch were applied? We'd pass a NULL pointer.
Regards
Oliver
next prev parent reply other threads:[~2020-09-14 8:02 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:31 [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 01/12] net: mvpp2: Prepare to use the new tasklet API Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-15 1:02 ` Jakub Kicinski
2020-09-15 1:02 ` Jakub Kicinski
2020-09-14 7:31 ` [RESEND net-next v2 02/12] net: arcnet: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 03/12] net: caif: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 04/12] net: ifb: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 05/12] net: ppp: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 06/12] net: cdc_ncm: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 07/12] net: hso: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 08/12] net: lan78xx: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 09/12] net: pegasus: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 10/12] net: r8152: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 11/12] net: rtl8150: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 7:31 ` [RESEND net-next v2 12/12] net: usbnet: " Allen Pais
2020-09-14 7:43 ` Allen Pais
2020-09-14 8:02 ` Oliver Neukum [this message]
2020-09-14 8:02 ` Oliver Neukum
2020-09-14 20:24 ` [RESEND net-next v2 00/12]drivers: net: " David Miller
2020-09-14 20:24 ` David Miller
2020-09-15 4:08 ` Allen Pais
2020-09-15 4:20 ` Allen Pais
2020-09-14 21:16 ` Saeed Mahameed
2020-09-14 21:16 ` Saeed Mahameed
2020-09-15 4:12 ` Allen Pais
2020-09-15 4:24 ` Allen Pais
2020-09-15 4:41 ` Saeed Mahameed
2020-09-15 4:41 ` Saeed Mahameed
2020-09-15 4:44 ` Allen Pais
2020-09-15 4:56 ` Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600070567.2534.3.camel@suse.de \
--to=oneukum@suse.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=allen.lkml@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=petkan@nucleusys.com \
--cc=romain.perier@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.