From: Oliver Neukum <oneukum@suse.com>
To: Pavel Machek <pavel@denx.de>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
johan@kernel.org, gustavoars@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: yurex: Rearrange code not to need GFP_ATOMIC
Date: Mon, 21 Sep 2020 14:24:52 +0200 [thread overview]
Message-ID: <1600691092.2424.85.camel@suse.com> (raw)
In-Reply-To: <20200920084452.GA2257@amd>
Am Sonntag, den 20.09.2020, 10:44 +0200 schrieb Pavel Machek:
> Move prepare to wait around, so that normal GFP_KERNEL allocation can
> be used.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
Ehm. Please recheck.
> diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c
> index b2e09883c7e2..071f1debebba 100644
> --- a/drivers/usb/misc/yurex.c
> +++ b/drivers/usb/misc/yurex.c
> @@ -489,10 +489,10 @@ static ssize_t yurex_write(struct file *file, const char __user *user_buffer,
> }
>
> /* send the data as the control msg */
> - prepare_to_wait(&dev->waitq, &wait, TASK_INTERRUPTIBLE);
> dev_dbg(&dev->interface->dev, "%s - submit %c\n", __func__,
> dev->cntl_buffer[0]);
> - retval = usb_submit_urb(dev->cntl_urb, GFP_ATOMIC);
> + retval = usb_submit_urb(dev->cntl_urb, GFP_KERNEL);
URB completes here. wake_up() returns the task to RUNNING.
> + prepare_to_wait(&dev->waitq, &wait, TASK_INTERRUPTIBLE);
Task goes to TASK_INTERRUPTIBLE
> if (retval >= 0)
> timeout = schedule_timeout(YUREX_WRITE_TIMEOUT);
Task turns into Sleeping Beauty until timeout
> finish_wait(&dev->waitq, &wait);
And here task goes into error reporting as it checks timeout.
Regards
Oliver
next prev parent reply other threads:[~2020-09-21 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 8:44 [PATCH] usb: yurex: Rearrange code not to need GFP_ATOMIC Pavel Machek
2020-09-21 12:24 ` Oliver Neukum [this message]
2020-09-21 12:52 ` Pavel Machek
2020-09-21 13:00 ` Oliver Neukum
2020-09-21 14:45 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600691092.2424.85.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel@denx.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.