From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 10/10] drm/rcar-du/crc: Implement get_crc_sources callback Date: Thu, 19 Jul 2018 14:12:48 +0300 Message-ID: <1600855.omIG2KBUNv@avalon> References: <20180713135942.25061-1-mahesh1.kumar@intel.com> <20180713135942.25061-11-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 58CA06E189 for ; Thu, 19 Jul 2018 11:12:16 +0000 (UTC) In-Reply-To: <20180713135942.25061-11-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWFoZXNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDEzIEp1bHkg MjAxOCAxNjo1OTo0MiBFRVNUIE1haGVzaCBLdW1hciB3cm90ZToKPiBUaGlzIHBhdGNoIGltcGxl bWVudHMgZ2V0X2NyY19zb3VyY2VzIGNhbGxiYWNrLCB3aGljaCByZXR1cm5zIGxpc3Qgb2YKPiBh bGwgdGhlIGNyYyBzb3VyY2VzIHN1cHBvcnRlZCBieSBkcml2ZXIgaW4gY3VycmVudCBwbGF0Zm9y bS4KPiAKPiBDaGFuZ2VzIFNpbmNlIFYxOgo+ICAtIG1vdmUgc291cmNlcyBsaXN0IHBlci1jcnRj Cj4gIC0gaW5pdCBzb3VyY2VzLWxpc3Qgb25seSBmb3IgZ2VuMwo+IAo+IFNpZ25lZC1vZmYtYnk6 IE1haGVzaCBLdW1hciA8bWFoZXNoMS5rdW1hckBpbnRlbC5jb20+Cj4gQ2M6IExhdXJlbnQgUGlu Y2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMgfCA5NiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKystCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5oIHwg IDMgKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA5OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5j Cj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYyBpbmRleCA2YTI5MDU1 YTRhYjAuLmJiZTQxN2U5M2ZlMwo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2Fy LWR1L3JjYXJfZHVfY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9k dV9jcnRjLmMKPiBAQCAtNjkxLDYgKzY5MSw3OSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9j cnRjX2hlbHBlcl9mdW5jcwo+IGNydGNfaGVscGVyX2Z1bmNzID0geyAuYXRvbWljX2Rpc2FibGUg PSByY2FyX2R1X2NydGNfYXRvbWljX2Rpc2FibGUsCj4gIH07Cj4gCj4gK3N0YXRpYyB2b2lkIHJj YXJfZHVfY3J0Y19jcmNfc291cmNlc19saXN0X2luaXQoc3RydWN0IHJjYXJfZHVfY3J0YyAqcmNy dGMpCj4gK3sKPiArCXN0cnVjdCByY2FyX2R1X2RldmljZSAqcmNkdSA9IHJjcnRjLT5ncm91cC0+ ZGV2Owo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHJjcnRjLT5jcnRjLmRldjsKPiArCXN0 cnVjdCBkcm1fY3J0YyAqY3J0YyA9ICZyY3J0Yy0+Y3J0YzsKPiArCXN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lOwo+ICsJdW5zaWduZWQgaW50IGNvdW50Owo+ICsJY29uc3QgY2hhciAqKnNvdXJjZXM7 Cj4gKwl1MzIgcGxhbmVfbWFzazsKPiArCWludCBpID0gMDsKCmkgbmV2ZXIgdGFrZXMgbmVnYXRp dmUgdmFsdWVzLCBpdCBjYW4gYmUgYW4gdW5zaWduZWQgaW50LgoKPiArCS8qIENSQyBhdmFpbGFi bGUgb25seSBvbiBHZW4zIEhXICovCgpQbGVhc2UgY2FwaXRhbGl6ZSBzZW50ZW5jZXMgYW5kIGVu ZCB0aGVtIHdpdGggYSBwZXJpb2QgaW4gY29tbWVudHMgdG8gbWF0Y2ggCnRoZSBkcml2ZXIncyBz dHlsZS4gVGhpcyBhcHBsaWVzIHRvIG90aGVyIGxvY2F0aW9ucyBpbiB0aGlzIHBhdGNoLgoKPiAr CWlmIChyY2R1LT5pbmZvLT5nZW4gPCAzKQo+ICsJCWdvdG8gZmFpbDsKCllvdSBjYW4ganVzdCBy ZXR1cm4gaGVyZSwgc291cmNlc19jb3VudCBhbmQgc291cmNlcyBhcmUgaW5pdGlhbGl6ZWQgdG8g MCB3aGVuIAp0aGUgcmNhcl9kdV9jcnRjIHN0cnVjdHVyZSBpcyBhbGxvY2F0ZWQuCgo+ICsJZHJt X2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBkZXYpIHsKPiArCQlpZiAoZHJtX2NydGNfbWFzayhjcnRj KSAmIHBsYW5lLT5wb3NzaWJsZV9jcnRjcykgewo+ICsJCQljb3VudCsrOwo+ICsJCQlwbGFuZV9t YXNrIHw9IGRybV9wbGFuZV9tYXNrKHBsYW5lKTsKPiArCQl9Cj4gKwl9CgpZb3UgY2FuIGluc3Rl YWQgaXRlcmF0ZSBvdmVyIHRoZSBwbGFuZXMgb2YgdGhlIGFzc29jaWF0ZWQgVlNQIChoYXJkd2Fy ZSAKY29tcG9zZXIpLgoKCS8qIFJlc2VydmUgMSBmb3IgImF1dG8iIHNvdXJjZS4gKi8KCWNvdW50 ID0gcmNydGMtPnZzcC0+bnVtX3BsYW5lcyArIDE7CgphbmQgZ2V0IHJpZCBvZiBwbGFuZV9tYXNr LgoKPiArCS8qIHJlc2VydmUgMSBmb3IgImF1dG8iIHNvdXJjZSAqLwo+ICsJY291bnQgKz0gMTsK PiArCXNvdXJjZXMgPSBrbWFsbG9jX2FycmF5KGNvdW50LCBzaXplb2YoY2hhciAqKSwgR0ZQX0tF Uk5FTCk7CgpzL3NpemVvZihjaGFyICopL3NpemVvZigqc291cmNlcykvCgo+ICsJaWYgKCFzb3Vy Y2VzKQo+ICsJCWdvdG8gZmFpbDsKPiArCj4gKwlzb3VyY2VzW2ldID0ga3N0cmR1cCgiYXV0byIs IEdGUF9LRVJORUwpOwo+ICsJaWYgKCFzb3VyY2VzW2ldKQo+ICsJCWdvdG8gZmFpbF9ub19tZW07 Cj4gKwo+ICsJaSsrOwo+ICsJZHJtX2Zvcl9lYWNoX3BsYW5lX21hc2socGxhbmUsIGRldiwgcGxh bmVfbWFzaykgewo+ICsJCWNoYXIgbmFtZVsxNl07Cj4gKwo+ICsJCXNwcmludGYobmFtZSwgInBs YW5lJWQiLCBwbGFuZS0+YmFzZS5pZCk7CgpUaGUgSUQgaXMgYW4gdW5zaWduZWQgaW50ZWdlciwg eW91IHNob3VsZCB1c2UgJXUuCgo+ICsJCXNvdXJjZXNbaV0gPSBrc3RyZHVwKG5hbWUsIEdGUF9L RVJORUwpOwo+ICsJCWlmICghc291cmNlc1tpXSkKPiArCQkJZ290byBmYWlsX25vX21lbTsKCkFz IHRoZXJlIHdpbGwgYmUgYSBzaW5nbGUgZXJyb3IgbGFiZWwsIHlvdSBjYW4ganVzdCBuYW1lIGl0 ICJlcnJvciIuCgo+ICsJCWkrKzsKPiArCX0KCllvdSBjYW4gaXRlcmF0ZSBvdmVyIHRoZSBWU1Ag cGxhbmVzIGhlcmUgdG9vLgoKCWZvciAoaSA9IDA7IGkgPCByY3J0Yy0+dnNwLT5udW1fcGxhbmVz OyArK2kpIHsKCQlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9ICZyY3J0Yy0+dnNwLT5wbGFuZXNb aV0ucGxhbmU7CgkJY2hhciBuYW1lWzE2XTsKCgkJc3ByaW50ZihuYW1lLCAicGxhbmUldSIsIHBs YW5lLT5iYXNlLmlkKTsKCQlzb3VyY2VzW2krMV0gPSBrc3RyZHVwKG5hbWUsIEdGUF9LRVJORUwp OwoJCWlmICghc291cmNlc1tpKzFdKQoJCQlnb3RvIGVycm9yOwoJfQoKPiArCXJjcnRjLT5zb3Vy Y2VzID0gc291cmNlczsKPiArCXJjcnRjLT5zb3VyY2VzX2NvdW50ID0gY291bnQ7Cj4gKwlyZXR1 cm47Cj4gKwo+ICtmYWlsX25vX21lbToKPiArCXdoaWxlIChpID4gMCkgewo+ICsJCWktLTsKPiAr CQlrZnJlZShzb3VyY2VzW2ldKTsKPiArCX0KCllvdSdsbCBoYXZlIHRvIGFkYXB0IGl0IGJhc2Vk IG9uIHRoZSBjb2RlIGFib3ZlLgoKPiArCWtmcmVlKHNvdXJjZXMpOwo+ICtmYWlsOgo+ICsJcmNy dGMtPnNvdXJjZXMgPSBOVUxMOwo+ICsJcmNydGMtPnNvdXJjZXNfY291bnQgPSAwOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgdm9pZCByY2FyX2R1X2NydGNfY3JjX3NvdXJjZXNfbGlzdF91bmluaXQoc3Ry dWN0IHJjYXJfZHVfY3J0Ywo+ICpyY3J0YykKPiArewo+ICsJdW5zaWduZWQgaW50IGk7Cj4gKwo+ ICsJaWYgKCFyY3J0Yy0+c291cmNlcykKPiArCQlyZXR1cm47Cj4gKwo+ICsJZm9yIChpID0gMDsg aSA8IHJjcnRjLT5zb3VyY2VzX2NvdW50OyBpKyspCj4gKwkJa2ZyZWUocmNydGMtPnNvdXJjZXNb aV0pOwo+ICsJa2ZyZWUocmNydGMtPnNvdXJjZXMpOwo+ICsKPiArCXJjcnRjLT5zb3VyY2VzID0g TlVMTDsKPiArCXJjcnRjLT5zb3VyY2VzX2NvdW50ID0gMDsKPiArfQo+ICsKPiAgc3RhdGljIHN0 cnVjdCBkcm1fY3J0Y19zdGF0ZSAqCj4gIHJjYXJfZHVfY3J0Y19hdG9taWNfZHVwbGljYXRlX3N0 YXRlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgewo+IEBAIC03MTcsNiArNzkwLDE1IEBAIHN0 YXRpYyB2b2lkIHJjYXJfZHVfY3J0Y19hdG9taWNfZGVzdHJveV9zdGF0ZShzdHJ1Y3QKPiBkcm1f Y3J0YyAqY3J0Yywga2ZyZWUodG9fcmNhcl9jcnRjX3N0YXRlKHN0YXRlKSk7Cj4gIH0KPiAKPiAr c3RhdGljIHZvaWQgcmNhcl9kdV9jcnRjX2NsZWFudXAoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ ICt7Cj4gKwlzdHJ1Y3QgcmNhcl9kdV9jcnRjICpyY3J0YyA9IHRvX3JjYXJfY3J0YyhjcnRjKTsK PiArCj4gKwlyY2FyX2R1X2NydGNfY3JjX3NvdXJjZXNfbGlzdF91bmluaXQocmNydGMpOwo+ICsK PiArCXJldHVybiBkcm1fY3J0Y19jbGVhbnVwKGNydGMpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9p ZCByY2FyX2R1X2NydGNfcmVzZXQoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICB7Cj4gIAlzdHJ1 Y3QgcmNhcl9kdV9jcnRjX3N0YXRlICpzdGF0ZTsKPiBAQCAtODExLDYgKzg5MywxNSBAQCBzdGF0 aWMgaW50IHJjYXJfZHVfY3J0Y192ZXJpZnlfY3JjX3NvdXJjZShzdHJ1Y3QKPiBkcm1fY3J0YyAq Y3J0YywgcmV0dXJuIDA7Cj4gIH0KPiAKPiArY29uc3QgY2hhciAqY29uc3QgKnJjYXJfZHVfY3J0 Y19nZXRfY3JjX3NvdXJjZXMoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICsJCQkJCQlzaXplX3Qg KmNvdW50KQo+ICt7Cj4gKwlzdHJ1Y3QgcmNhcl9kdV9jcnRjICpyY3J0YyA9IHRvX3JjYXJfY3J0 YyhjcnRjKTsKPiArCj4gKwkqY291bnQgPSByY3J0Yy0+c291cmNlc19jb3VudDsKPiArCXJldHVy biAoY29uc3QgY2hhciAqIGNvbnN0KilyY3J0Yy0+c291cmNlczsKClNob3VsZG4ndCB5b3UgZGVj bGFyZSByY3J0Yy0+c291cmNlcyBhcyBhIGNvbnN0IGNoYXIgKiBjb25zdCAqIGZpZWxkIGluc3Rl YWQgCm9mIGNhc3RpbmcgaXQgaGVyZSA/Cgo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHJjYXJfZHVf Y3J0Y19zZXRfY3JjX3NvdXJjZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCQkgICAgICAg Y29uc3QgY2hhciAqc291cmNlX25hbWUpCj4gIHsKPiBAQCAtODgxLDcgKzk3Miw3IEBAIHN0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgY3J0Y19mdW5jc19nZW4yID0gewo+IAo+ICBz dGF0aWMgY29uc3Qgc3RydWN0IGRybV9jcnRjX2Z1bmNzIGNydGNfZnVuY3NfZ2VuMyA9IHsKPiAg CS5yZXNldCA9IHJjYXJfZHVfY3J0Y19yZXNldCwKPiAtCS5kZXN0cm95ID0gZHJtX2NydGNfY2xl YW51cCwKPiArCS5kZXN0cm95ID0gcmNhcl9kdV9jcnRjX2NsZWFudXAsCj4gIAkuc2V0X2NvbmZp ZyA9IGRybV9hdG9taWNfaGVscGVyX3NldF9jb25maWcsCj4gIAkucGFnZV9mbGlwID0gZHJtX2F0 b21pY19oZWxwZXJfcGFnZV9mbGlwLAo+ICAJLmF0b21pY19kdXBsaWNhdGVfc3RhdGUgPSByY2Fy X2R1X2NydGNfYXRvbWljX2R1cGxpY2F0ZV9zdGF0ZSwKPiBAQCAtODkwLDYgKzk4MSw3IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgY3J0Y19mdW5jc19nZW4zID0gewo+ICAJ LmRpc2FibGVfdmJsYW5rID0gcmNhcl9kdV9jcnRjX2Rpc2FibGVfdmJsYW5rLAo+ICAJLnNldF9j cmNfc291cmNlID0gcmNhcl9kdV9jcnRjX3NldF9jcmNfc291cmNlLAo+ICAJLnZlcmlmeV9jcmNf c291cmNlID0gcmNhcl9kdV9jcnRjX3ZlcmlmeV9jcmNfc291cmNlLAo+ICsJLmdldF9jcmNfc291 cmNlcyA9IHJjYXJfZHVfY3J0Y19nZXRfY3JjX3NvdXJjZXMsCj4gIH07Cj4gCj4gIC8qCj4gLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gLS0gQEAgLTEwMjgsNSArMTEyMCw3IEBAIGludCByY2FyX2R1X2Ny dGNfY3JlYXRlKHN0cnVjdCByY2FyX2R1X2dyb3VwICpyZ3JwLAo+IHVuc2lnbmVkIGludCBzd2lu ZGV4LCByZXR1cm4gcmV0Owo+ICAJfQo+IAo+ICsJcmNhcl9kdV9jcnRjX2NyY19zb3VyY2VzX2xp c3RfaW5pdChyY3J0Yyk7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmgKPiBiL2RyaXZlcnMvZ3B1L2RybS9y Y2FyLWR1L3JjYXJfZHVfY3J0Yy5oIGluZGV4IDc2ODBjYjI2MzZjOC4uMGNkMGMxNjU1YmViCj4g MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmgKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuaAo+IEBAIC02Nyw2ICs2 Nyw5IEBAIHN0cnVjdCByY2FyX2R1X2NydGMgewo+ICAJc3RydWN0IHJjYXJfZHVfZ3JvdXAgKmdy b3VwOwo+ICAJc3RydWN0IHJjYXJfZHVfdnNwICp2c3A7Cj4gIAl1bnNpZ25lZCBpbnQgdnNwX3Bp cGU7Cj4gKwo+ICsJY29uc3QgY2hhciAqKnNvdXJjZXM7Cj4gKwl1bnNpZ25lZCBpbnQgc291cmNl c19jb3VudDsKPiAgfTsKPiAKPiAgI2RlZmluZSB0b19yY2FyX2NydGMoYykJY29udGFpbmVyX29m KGMsIHN0cnVjdCByY2FyX2R1X2NydGMsIGNydGMpCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGlu Y2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==