From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9924EC4363D for ; Fri, 25 Sep 2020 10:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4382E21D91 for ; Fri, 25 Sep 2020 10:06:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="uYdoEsn+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727324AbgIYKGG (ORCPT ); Fri, 25 Sep 2020 06:06:06 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:51863 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727044AbgIYKGG (ORCPT ); Fri, 25 Sep 2020 06:06:06 -0400 X-UUID: 357d642f6173461d9e22a29083a61259-20200925 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Bph4b89m0n2SvzrQ5y28tD7qLIYsd+I1XIgm6YWOMxg=; b=uYdoEsn+gAceZhj9nTI+EJ9/uYegZSglG4cVZiwuPbc+vzLAhzefsG+snIJX4/mz7GY7tZune8HIxGV2S+aSg3XcZx86Ze2sDv4O3dGeY+MZE1g0bP450dNZWEVYRJyUMACVEsgNabpbq307nmEeOTyn5jPRIer+vxJV9M5jhUU=; X-UUID: 357d642f6173461d9e22a29083a61259-20200925 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 689825253; Fri, 25 Sep 2020 18:06:03 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 18:06:01 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 25 Sep 2020 18:06:00 +0800 Message-ID: <1601028361.1346.38.camel@mtksdaap41> Subject: Re: [PATCH 00/12] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller From: Weiyi Lu To: Enric Balletbo i Serra CC: , Collabora Kernel ML , , , , , Rob Herring , , , Date: Fri, 25 Sep 2020 18:06:01 +0800 In-Reply-To: <20200910172826.3074357-1-enric.balletbo@collabora.com> References: <20200910172826.3074357-1-enric.balletbo@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org T24gVGh1LCAyMDIwLTA5LTEwIGF0IDE5OjI4ICswMjAwLCBFbnJpYyBCYWxsZXRibyBpIFNlcnJh IHdyb3RlOg0KPiBEZWFyIGFsbCwNCj4gDQo+IFRoaXMgaXMgYSBuZXcgZHJpdmVyIHdpdGggdGhl IGFpbSB0byBkZXByZWNhdGUgdGhlIG10ay1zY3BzeXMgZHJpdmVyLg0KPiBUaGUgcHJvYmxlbSB3 aXRoIHRoYXQgZHJpdmVyIGlzIHRoYXQsIGluIG9yZGVyIHRvIHN1cHBvcnQgbW9yZSBNZWRpYXRl aw0KPiBTb0NzIHlvdSBuZWVkIHRvIGFkZCBzb21lIGxvZ2ljIHRvIGhhbmRsZSBwcm9wZXJseSB0 aGUgcG93ZXItdXANCj4gc2VxdWVuY2Ugb2YgbmV3ZXIgTWVkaWF0ZWsgU29DcywgZG9lc24ndCBo YW5kbGUgcGFyZW50LWNoaWxkIHBvd2VyDQo+IGRvbWFpbnMgYW5kIG5lZWQgdG8gaGFyZGNvZGUg YWxsIHRoZSBjbG9ja3MgaW4gdGhlIGRyaXZlciBpdHNlbGYuIFRoZQ0KPiByZXN1bHQgaXMgdGhh dCB0aGUgZHJpdmVyIGlzIGdldHRpbmcgYmlnZ2VyIGFuZCBiaWdnZXIgZXZlcnkgdGltZSBhDQo+ IG5ldyBTb0MgbmVlZHMgdG8gYmUgc3VwcG9ydGVkLg0KPiANCg0KSGkgRW5yaWMgYW5kIE1hdHRo aWFzLA0KDQpGaXJzdCBvZiBhbGwsIHRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLiBCdXQgSSdtIHdv cnJpZWQgdGhlIHByb2JsZW0geW91DQptZW50aW9uZWQgd29uJ3QgYmUgc29sdmVkIGV2ZW4gaWYg d2Ugd29yayBvbiB0aGlzIG5ldyBkcml2ZXIgaW4gdGhlDQpmdXR1cmUuIE15IHdvcmsgb24gdGhl IE1UODE4MyBzY3BzeXMobm93IHYxNykgaXMgdG8gaW1wbGVtZW50IHRoZSBuZXcNCmhhcmR3YXJl IGxvZ2ljLiBIZXJlLCBJIGFsc28gc2VlIHJlbGF0ZWQgcGF0Y2hlcywgd2hpY2ggbWVhbnMgdGhh dCB0aGVzZQ0KbmV3IGxvZ2ljcyBhcmUgbmVjZXNzYXJ5LiBXaHkgY2FuJ3Qgd2Ugd29yayBvbiB0 aGUgb3JpZ2luYWwgZHJpdmVyPw0KTWVhbndoaWxlLCBJIHRob3VnaHQgbWF5YmUgd2Ugc2hvdWxk IHNlcGFyYXRlIHRoZSBkcml2ZXIgaW50byBnZW5lcmFsDQpjb250cm9sIGFuZCBwbGF0Zm9ybSBk YXRhIGZvciBlYWNoIFNvQywgb3RoZXJ3aXNlIGl0J2xsIGtlZXAgZ2V0dGluZw0KYmlnZ2VyIGFu ZCBiaWdnZXIgaWYgaXQgbmVlZCB0byBiZSBzdXBwb3J0IG5ldyBTb0MuDQoNCkFuZCBjb25zaWRl ciBEVkZTUkMNCihkeW5hbWljIHZvbHRhZ2UgYW5kIGZyZXF1ZW5jeSBzY2FsaW5nIHJlc291cmNl IGNvbGxlY3RvciksIHNob3VsZCB3ZQ0Ka2VlcCB0aGUgb3JpZ2luYWwgZHJpdmVyIG5hbWUgInNj cHN5cyIgaW5zdGVhZCBvZiAicG0tZG9tYWlucyIgYmVjYXVzZQ0KaXQgbWF5IHByb3ZpZGUgbW9y ZSBmdW5jdGlvbnMgdGhhbiBwb3dlciBkb21haW5zPw0KDQo+IEFsbCB0aGlzIGluZm9ybWF0aW9u IGNhbiBiZSBnZXR0ZWQgZnJvbSBhIHByb3Blcmx5IGRlZmluZWQgYmluZGluZywgc28NCj4gY2Fu IGJlIGNsZWFuZXIgYW5kIHNtYWxsZXIsIGhlbmNlLCB3ZSBpbXBsZW1lbnRlZCBhIG5ldyBkcml2 ZXIuIEZvcg0KPiBub3csIG9ubHkgTVQ4MTczIGFuZCBNVDgxODMgaXMgc3VwcG9ydGVkIGJ1dCBz aG91bGQgYmUgZmFpcmx5IGVhc3kgdG8NCj4gYWRkIHN1cHBvcnQgZm9yIG5ldyBTb0NzLg0KPiAN Cj4gQmVzdCByZWdhcmRzLA0KPiAgIEVucmljDQo+IA0KPiBFbnJpYyBCYWxsZXRibyBpIFNlcnJh ICg0KToNCj4gICBkdC1iaW5kaW5nczogcG93ZXI6IEFkZCBiaW5kaW5ncyBmb3IgdGhlIE1lZGlh dGVrIFNDUFNZUyBwb3dlciBkb21haW5zDQo+ICAgICBjb250cm9sbGVyDQo+ICAgc29jOiBtZWRp YXRlazogQWRkIE1lZGlhVGVrIFNDUFNZUyBwb3dlciBkb21haW5zDQo+ICAgYXJtNjQ6IGR0czog bWVkaWF0ZWs6IEFkZCBtdDgxNzMgcG93ZXIgZG9tYWluIGNvbnRyb2xsZXINCj4gICBkdC1iaW5k aW5nczogcG93ZXI6IEFkZCBNVDgxODMgcG93ZXIgZG9tYWlucw0KPiANCj4gTWF0dGhpYXMgQnJ1 Z2dlciAoOCk6DQo+ICAgc29jOiBtZWRpYXRlazogcG0tZG9tYWluczogQWRkIGJ1cyBwcm90ZWN0 aW9uIHByb3RvY29sDQo+ICAgc29jOiBtZWRpYXRlazogcG1fZG9tYWluczogTWFrZSBidXMgcHJv dGVjdGlvbiBnZW5lcmljDQo+ICAgc29jOiBtZWRpYXRlazogcG0tZG9tYWluczogQWRkIFNNSSBi bG9jayBhcyBidXMgcHJvdGVjdGlvbiBibG9jaw0KPiAgIHNvYzogbWVkaWF0ZWs6IHBtLWRvbWFp bnM6IEFkZCBleHRyYSBzcmFtIGNvbnRyb2wNCj4gICBzb2M6IG1lZGlhdGVrOiBwbS1kb21haW5z OiBBZGQgc3Vic3lzdGVtIGNsb2Nrcw0KPiAgIHNvYzogbWVkaWF0ZWs6IHBtLWRvbWFpbnM6IEFs bG93IGJ1cyBwcm90ZWN0aW9uIHRvIGlnbm9yZSBjbGVhciBhY2sNCj4gICBzb2M6IG1lZGlhdGVr OiBwbS1kb21haW5zOiBBZGQgc3VwcG9ydCBmb3IgbXQ4MTgzDQo+ICAgYXJtNjQ6IGR0czogbWVk aWF0ZWs6IEFkZCBtdDgxODMgcG93ZXIgZG9tYWlucyBjb250cm9sbGVyDQo+IA0KPiAgLi4uL3Bv d2VyL21lZGlhdGVrLHBvd2VyLWNvbnRyb2xsZXIueWFtbCAgICAgIHwgMTczICsrKysNCj4gIGFy Y2gvYXJtNjQvYm9vdC9kdHMvbWVkaWF0ZWsvbXQ4MTczLmR0c2kgICAgICB8ICA3OCArLQ0KPiAg YXJjaC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDgxODMuZHRzaSAgICAgIHwgMTYwICsrKw0K PiAgZHJpdmVycy9zb2MvbWVkaWF0ZWsvS2NvbmZpZyAgICAgICAgICAgICAgICAgIHwgIDEzICsN Cj4gIGRyaXZlcnMvc29jL21lZGlhdGVrL01ha2VmaWxlICAgICAgICAgICAgICAgICB8ICAgMSAr DQo+ICBkcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstaW5mcmFjZmcuYyAgICAgICAgICAgfCAgIDUg LQ0KPiAgZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLXBtLWRvbWFpbnMuYyAgICAgICAgIHwgOTUy ICsrKysrKysrKysrKysrKysrKw0KPiAgaW5jbHVkZS9kdC1iaW5kaW5ncy9wb3dlci9tdDgxODMt cG93ZXIuaCAgICAgIHwgIDI2ICsNCj4gIGluY2x1ZGUvbGludXgvc29jL21lZGlhdGVrL2luZnJh Y2ZnLmggICAgICAgICB8ICAzOSArDQo+ICA5IGZpbGVzIGNoYW5nZWQsIDE0MzMgaW5zZXJ0aW9u cygrKSwgMTQgZGVsZXRpb25zKC0pDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Bvd2VyL21lZGlhdGVrLHBvd2VyLWNvbnRyb2xsZXIueWFt bA0KPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvc29jL21lZGlhdGVrL210ay1wbS1kb21h aW5zLmMNCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2R0LWJpbmRpbmdzL3Bvd2VyL210 ODE4My1wb3dlci5oDQo+IA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F857C4727C for ; Fri, 25 Sep 2020 10:07:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5C4120BED for ; Fri, 25 Sep 2020 10:07:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ApqYRqA6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="uYdoEsn+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5C4120BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OlFNjO7mZqb7nZ3rUb/a7wJjh1wGqvomRe/uo9d/g5k=; b=ApqYRqA6TT5vMjbbo2hPkrXuQ yKm7Q3r/Bzxj5SF4SkIDanzcB+5psIXPvWgZPFd2m1N84ZGWAUUx+O4uG3wR1Z+L1DWbjVocCb+9m QZhiquje7iMggv7HWnKifBrrFVt4EZGkR+Hn8asI/EKPHTALeBgwL/Vgn6rnoP+bCjED58vEu1vNa pr7k1yI3cdBXFW3ciRjPdzZtS98/24Tm17rJEC/GkrOCVLQaiaFHpTGBxUHpQzGFw4cMEpmqAcjGF vXMaQ3FfJznkkMH1gBD5AXr71c/4HapYY/QBTLy7yLsor+Kjg8GjC77quM8hhmabepQHLCtbQ8rbr NjzvmnPDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLkdJ-0003fj-73; Fri, 25 Sep 2020 10:07:17 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLkdE-0003ey-VS; Fri, 25 Sep 2020 10:07:14 +0000 X-UUID: 30f100d3e8d541c4a9babb596709599e-20200925 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Bph4b89m0n2SvzrQ5y28tD7qLIYsd+I1XIgm6YWOMxg=; b=uYdoEsn+gAceZhj9nTI+EJ9/uYegZSglG4cVZiwuPbc+vzLAhzefsG+snIJX4/mz7GY7tZune8HIxGV2S+aSg3XcZx86Ze2sDv4O3dGeY+MZE1g0bP450dNZWEVYRJyUMACVEsgNabpbq307nmEeOTyn5jPRIer+vxJV9M5jhUU=; X-UUID: 30f100d3e8d541c4a9babb596709599e-20200925 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 799204048; Fri, 25 Sep 2020 02:07:02 -0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 03:06:13 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 18:06:01 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 25 Sep 2020 18:06:00 +0800 Message-ID: <1601028361.1346.38.camel@mtksdaap41> Subject: Re: [PATCH 00/12] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller From: Weiyi Lu To: Enric Balletbo i Serra Date: Fri, 25 Sep 2020 18:06:01 +0800 In-Reply-To: <20200910172826.3074357-1-enric.balletbo@collabora.com> References: <20200910172826.3074357-1-enric.balletbo@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_060713_145203_EACFF9A2 X-CRM114-Status: GOOD ( 23.74 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, drinkcat@chromium.org, linux-kernel@vger.kernel.org, fparent@baylibre.com, Rob Herring , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-09-10 at 19:28 +0200, Enric Balletbo i Serra wrote: > Dear all, > > This is a new driver with the aim to deprecate the mtk-scpsys driver. > The problem with that driver is that, in order to support more Mediatek > SoCs you need to add some logic to handle properly the power-up > sequence of newer Mediatek SoCs, doesn't handle parent-child power > domains and need to hardcode all the clocks in the driver itself. The > result is that the driver is getting bigger and bigger every time a > new SoC needs to be supported. > Hi Enric and Matthias, First of all, thank you for the patch. But I'm worried the problem you mentioned won't be solved even if we work on this new driver in the future. My work on the MT8183 scpsys(now v17) is to implement the new hardware logic. Here, I also see related patches, which means that these new logics are necessary. Why can't we work on the original driver? Meanwhile, I thought maybe we should separate the driver into general control and platform data for each SoC, otherwise it'll keep getting bigger and bigger if it need to be support new SoC. And consider DVFSRC (dynamic voltage and frequency scaling resource collector), should we keep the original driver name "scpsys" instead of "pm-domains" because it may provide more functions than power domains? > All this information can be getted from a properly defined binding, so > can be cleaner and smaller, hence, we implemented a new driver. For > now, only MT8173 and MT8183 is supported but should be fairly easy to > add support for new SoCs. > > Best regards, > Enric > > Enric Balletbo i Serra (4): > dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains > controller > soc: mediatek: Add MediaTek SCPSYS power domains > arm64: dts: mediatek: Add mt8173 power domain controller > dt-bindings: power: Add MT8183 power domains > > Matthias Brugger (8): > soc: mediatek: pm-domains: Add bus protection protocol > soc: mediatek: pm_domains: Make bus protection generic > soc: mediatek: pm-domains: Add SMI block as bus protection block > soc: mediatek: pm-domains: Add extra sram control > soc: mediatek: pm-domains: Add subsystem clocks > soc: mediatek: pm-domains: Allow bus protection to ignore clear ack > soc: mediatek: pm-domains: Add support for mt8183 > arm64: dts: mediatek: Add mt8183 power domains controller > > .../power/mediatek,power-controller.yaml | 173 ++++ > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 78 +- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 160 +++ > drivers/soc/mediatek/Kconfig | 13 + > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mtk-infracfg.c | 5 - > drivers/soc/mediatek/mtk-pm-domains.c | 952 ++++++++++++++++++ > include/dt-bindings/power/mt8183-power.h | 26 + > include/linux/soc/mediatek/infracfg.h | 39 + > 9 files changed, 1433 insertions(+), 14 deletions(-) > create mode 100644 Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > create mode 100644 drivers/soc/mediatek/mtk-pm-domains.c > create mode 100644 include/dt-bindings/power/mt8183-power.h > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DEBDC4363D for ; Fri, 25 Sep 2020 10:08:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFCB620BED for ; Fri, 25 Sep 2020 10:08:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eAZoNeCl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="uYdoEsn+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFCB620BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rUYqC7els7Fo38cGjvbXeMIbr2BrOjsiVSJcM91gfMY=; b=eAZoNeClGGgT2Dpr5q9QwU56E XpA5Ze7uO2xdLF6Lyepow4Hkg3qnVSQHBrP8astlF6oqRf2yYXPdSFao+LHx5g0J5hrv7+nD7Z2CH /jsErhbxmnZgj+6U3BrxNi8nR9Q494EIvIKqsRoupIategKuZS1365h/ywawz3D+ge8wd0XwcP1Ks bFdbuJr94OcAvqYxHPsXgquv18AyY9LbysoiHzpV4r/tf+wiW2tI9BF30BJKw3JLGX2iZJFtB8hVX Vg/J5IGHrd6j6IUd/Sjb40y3sWH0uIWXoBo0PwZ1yFiewOIYSomeBqyjhifxYo7yBpNB6xjQSdk9f T3fUeLdww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLkdK-0003fu-8t; Fri, 25 Sep 2020 10:07:18 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLkdE-0003ey-VS; Fri, 25 Sep 2020 10:07:14 +0000 X-UUID: 30f100d3e8d541c4a9babb596709599e-20200925 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Bph4b89m0n2SvzrQ5y28tD7qLIYsd+I1XIgm6YWOMxg=; b=uYdoEsn+gAceZhj9nTI+EJ9/uYegZSglG4cVZiwuPbc+vzLAhzefsG+snIJX4/mz7GY7tZune8HIxGV2S+aSg3XcZx86Ze2sDv4O3dGeY+MZE1g0bP450dNZWEVYRJyUMACVEsgNabpbq307nmEeOTyn5jPRIer+vxJV9M5jhUU=; X-UUID: 30f100d3e8d541c4a9babb596709599e-20200925 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 799204048; Fri, 25 Sep 2020 02:07:02 -0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 03:06:13 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 18:06:01 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 25 Sep 2020 18:06:00 +0800 Message-ID: <1601028361.1346.38.camel@mtksdaap41> Subject: Re: [PATCH 00/12] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller From: Weiyi Lu To: Enric Balletbo i Serra Date: Fri, 25 Sep 2020 18:06:01 +0800 In-Reply-To: <20200910172826.3074357-1-enric.balletbo@collabora.com> References: <20200910172826.3074357-1-enric.balletbo@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_060713_145203_EACFF9A2 X-CRM114-Status: GOOD ( 23.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, drinkcat@chromium.org, linux-kernel@vger.kernel.org, fparent@baylibre.com, Rob Herring , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-09-10 at 19:28 +0200, Enric Balletbo i Serra wrote: > Dear all, > > This is a new driver with the aim to deprecate the mtk-scpsys driver. > The problem with that driver is that, in order to support more Mediatek > SoCs you need to add some logic to handle properly the power-up > sequence of newer Mediatek SoCs, doesn't handle parent-child power > domains and need to hardcode all the clocks in the driver itself. The > result is that the driver is getting bigger and bigger every time a > new SoC needs to be supported. > Hi Enric and Matthias, First of all, thank you for the patch. But I'm worried the problem you mentioned won't be solved even if we work on this new driver in the future. My work on the MT8183 scpsys(now v17) is to implement the new hardware logic. Here, I also see related patches, which means that these new logics are necessary. Why can't we work on the original driver? Meanwhile, I thought maybe we should separate the driver into general control and platform data for each SoC, otherwise it'll keep getting bigger and bigger if it need to be support new SoC. And consider DVFSRC (dynamic voltage and frequency scaling resource collector), should we keep the original driver name "scpsys" instead of "pm-domains" because it may provide more functions than power domains? > All this information can be getted from a properly defined binding, so > can be cleaner and smaller, hence, we implemented a new driver. For > now, only MT8173 and MT8183 is supported but should be fairly easy to > add support for new SoCs. > > Best regards, > Enric > > Enric Balletbo i Serra (4): > dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains > controller > soc: mediatek: Add MediaTek SCPSYS power domains > arm64: dts: mediatek: Add mt8173 power domain controller > dt-bindings: power: Add MT8183 power domains > > Matthias Brugger (8): > soc: mediatek: pm-domains: Add bus protection protocol > soc: mediatek: pm_domains: Make bus protection generic > soc: mediatek: pm-domains: Add SMI block as bus protection block > soc: mediatek: pm-domains: Add extra sram control > soc: mediatek: pm-domains: Add subsystem clocks > soc: mediatek: pm-domains: Allow bus protection to ignore clear ack > soc: mediatek: pm-domains: Add support for mt8183 > arm64: dts: mediatek: Add mt8183 power domains controller > > .../power/mediatek,power-controller.yaml | 173 ++++ > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 78 +- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 160 +++ > drivers/soc/mediatek/Kconfig | 13 + > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mtk-infracfg.c | 5 - > drivers/soc/mediatek/mtk-pm-domains.c | 952 ++++++++++++++++++ > include/dt-bindings/power/mt8183-power.h | 26 + > include/linux/soc/mediatek/infracfg.h | 39 + > 9 files changed, 1433 insertions(+), 14 deletions(-) > create mode 100644 Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > create mode 100644 drivers/soc/mediatek/mtk-pm-domains.c > create mode 100644 include/dt-bindings/power/mt8183-power.h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel