All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Robin Jarry <rjarry@redhat.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH] devtools: download scripts from linux if not found
Date: Tue, 26 Nov 2024 15:03:57 +0100	[thread overview]
Message-ID: <16017055.uLZWGnKmhe@thomas> (raw)
In-Reply-To: <20241004093128.5932a84e@hermes.local>

04/10/2024 18:31, Stephen Hemminger:
> On Fri, 15 Mar 2024 15:14:42 +0100
> Robin Jarry <rjarry@redhat.com> wrote:
> 
> > Both checkpatches.sh and get-maintainer.sh require scripts that come
> > from the linux sources. And they require DPDK_*_PATH variables to be set
> > to point at these scripts locally. For new contributors this can be
> > tedious since they will have to clone the whole linux sources just to
> > have simple perl scripts.
> > 
> > Update checkpatches.sh and get-maintainer.sh to have them download the
> > upstream scripts if they are not found locally. Store the downloaded
> > scripts in the .git/ folder so that they are found for future runs.
> > 
> > If either DPDK_CHECKPATCH_PATH or DPDK_GETMAINTAINER_PATH are set, they
> > will be used in priority.
> > 
> > Signed-off-by: Robin Jarry <rjarry@redhat.com>
> 
> This makes live easier for new contributors.
> Not sure if is the best way to autodownload, or where to put the scripts
> but something is better than the current way.
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

I would prefer we host our own fork of checkpatch.pl.
There are too many irrelevant checks that we should drop.



  reply	other threads:[~2024-11-26 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15 14:14 [PATCH] devtools: download scripts from linux if not found Robin Jarry
2024-10-04 16:31 ` Stephen Hemminger
2024-11-26 14:03   ` Thomas Monjalon [this message]
2024-11-26 15:16     ` Robin Jarry
2024-11-26 15:36       ` Thomas Monjalon
2024-11-26 15:56         ` Robin Jarry
2026-01-31 19:59 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16017055.uLZWGnKmhe@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=rjarry@redhat.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.