From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A597C433DF for ; Mon, 12 Oct 2020 03:25:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC2CF2076C for ; Mon, 12 Oct 2020 03:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z8BGOjYm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iHV97fO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC2CF2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x1wy9rJp4NdRWYAHctKQzcnJGEIGJSPb/7I5x2HtaMk=; b=Z8BGOjYmcakUUTqkVGF/TsmtK TaDJ3B3lcnHLFW2qd8rb1mmabFdX+btgbMgFcZ+6KHrigjToUd1JpZVdKulQIElr2G2LGP1Ooivx0 3CnmYDlDXelH1sD7GvGgFcG1jCT7TWTMskoRB1K0ET9rfTE/2hXgW2UsuMDF1PsfijqWpBsczNMQG Q/lL6HT7Rc/6ZhIIclBmuYfhF0sEhJx7hkPxvzyHa2ZIDJGXXU+8FBzRy67hXVcea76SqtOVg+5Jo dgLCkCXFCDPCOZRZHWxZcI+pR1K9F2303Wf6x2TCdfJgZXTMWh/GnA7+GYUfgK160dufprWb+ingh aKXHjQ/tA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRoSY-0007I8-C1; Mon, 12 Oct 2020 03:25:14 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRoSU-0007HF-2h; Mon, 12 Oct 2020 03:25:11 +0000 X-UUID: 48893f9d205e41aa870d082a350d7745-20201011 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Bm72sr6Ouy/aEnxVTOQTJVItEbE2HZ45eGSUlY3+1i4=; b=iHV97fO7VS8aMf3ROYlU++JLJjIQsfA5n5ZaaYPFHZanI88tjH4NgEBLV0cNbGaLVhF2pQi281WgwsnOvCRYZTgcg8j3Q+Ll/rrvVEis9js4hUo3EHAmCIINN4uiq3blb/Nzty8xaYzSYD5SFcgXOo+ANpSeO1r3UB7/3K8wL+Y=; X-UUID: 48893f9d205e41aa870d082a350d7745-20201011 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1970765546; Sun, 11 Oct 2020 19:25:02 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 11 Oct 2020 20:25:00 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Oct 2020 11:24:57 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 12 Oct 2020 11:24:57 +0800 Message-ID: <1602473098.26774.5.camel@mtkswgap22> Subject: Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver From: Neal Liu To: Matthias Brugger Date: Mon, 12 Oct 2020 11:24:58 +0800 In-Reply-To: <0ece983b-2e55-cf06-aca8-02a014fce090@gmail.com> References: <1598497593-15781-1-git-send-email-neal.liu@mediatek.com> <1598497593-15781-3-git-send-email-neal.liu@mediatek.com> <1602124514.28301.17.camel@mtkswgap22> <1602149965.8784.6.camel@mtkswgap22> <0ece983b-2e55-cf06-aca8-02a014fce090@gmail.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: A57CB5B722B96A24B6BC4E4DA5FC2FE3FA559752A9CF0861603F1BE94AA214DC2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201011_232510_255973_7B048641 X-CRM114-Status: GOOD ( 25.80 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , wsd_upstream@mediatek.com, devicetree@vger.kernel.org, lkml , Rob Herring , linux-mediatek@lists.infradead.org, Neal Liu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2020-10-09 at 14:34 +0200, Matthias Brugger wrote: > > On 08/10/2020 11:39, Neal Liu wrote: > > On Thu, 2020-10-08 at 10:45 +0200, Matthias Brugger wrote: > >> > >> On 08/10/2020 04:35, Neal Liu wrote: > >>> On Wed, 2020-10-07 at 12:44 +0200, Matthias Brugger wrote: > >>>> > >>>> On 27/08/2020 05:06, Neal Liu wrote: > [...] > > >>>>> +static int mtk_devapc_probe(struct platform_device *pdev) > >>>>> +{ > >>>>> + struct device_node *node = pdev->dev.of_node; > >>>>> + struct mtk_devapc_context *ctx; > >>>>> + u32 devapc_irq; > >>>>> + int ret; > >>>>> + > >>>>> + if (IS_ERR(node)) > >>>>> + return -ENODEV; > >>>>> + > >>>>> + ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); > >>>>> + if (!ctx) > >>>>> + return -ENOMEM; > >>>>> + > >>>>> + ctx->data = of_device_get_match_data(&pdev->dev); > >>>>> + ctx->dev = &pdev->dev; > >>>>> + > >>>>> + ctx->infra_base = of_iomap(node, 0); > >>>> > >>>> Does this mean the device is part of the infracfg block? > >>>> I wasn't able to find any information about it. > >>> > >>> I'm not sure why you would ask infracfg block. devapc is parts of our > >>> SoC infra, it's different with infracfg. > >>> > >> > >> I'm asking because I want to understand the HW better. I'm not able to find any > >> information in the datasheets. I want to avoid a situation as we had with the > >> MMSYS where a clock driver was submitted first and later on we realized that > >> MMSYS is much more then that and we had to work hard to get the driver right. > >> > >> Now it's happening with SCPSYS, where a driver with the scpsys compatible was > >> send years ago. But SCPSYS is much more then the driver submitted. In this case > >> we opted to write a new driver, but moving from one driver to another one is > >> painfull and full of problems. For that I want to make sure we fully understand > >> Device APC (by the way, what does APC stands for?). Is it a totally independent > >> HW block or is it part of a subsystem, like for example SCP? > >> > >> Regards, > >> Matthias > > > > It's a totally independent HW block instead of a subsystem. > > I think it's more simple than MMSYS or SCPSYS. But if you would like to > > understand more about this HW, we could find another way/channel to > > introduce it. > > > > If it's a independent HW block, then we are good. No further information needed > by me. I'd just advise to rename the infra_base to something like base, as it > made me confuse. > > Thanks! > Matthias You can imagine that infra_base means infra devapc base address for MT6779. In 5G platforms, MediaTek infrastructure would separate into multiple parts, so does devapc HW. And devapc would be like: infra_base, peri_base, peri2_base, ... Thanks. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A5EC433DF for ; Mon, 12 Oct 2020 03:27:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C568F2076C for ; Mon, 12 Oct 2020 03:27:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OJupg5FQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iHV97fO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C568F2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dEOSF2wDwdxQlGvsneYhSH5M3cMYGpWs8roEcxjoKuk=; b=OJupg5FQXDghr9R3CKjgqRmu0 TzxU61mGAj0kCOpyyOsHH9Zl8cH49ai9J4CGMEAN8LOUApoKU1j036glw0H8kMID9FXpEL8ZH/8Gq 1nrlUEShDhI1P6oyb7MVSzhvqV5ypMNkN9sC+eNkyUogeI1VwBFHENUduC8ZqIHFG/qKRA/1q+Xt2 fHFs3YnvpCaJ0gZ/jbFq9Zr1wGA1mTyRIiiNRTkmXB/I7PV3g+KecRUIsQbDYp76pB1lSS2JSA/1C y80iuVyqAY2XFGtRFA8hRLgz+oWfxOtDUy7ybX1+8wrQmgFeCgfakGUKEZwEb5rPL5xWz4ZZnks0J hUHxuO6UA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRoSX-0007Hx-0b; Mon, 12 Oct 2020 03:25:13 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRoSU-0007HF-2h; Mon, 12 Oct 2020 03:25:11 +0000 X-UUID: 48893f9d205e41aa870d082a350d7745-20201011 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Bm72sr6Ouy/aEnxVTOQTJVItEbE2HZ45eGSUlY3+1i4=; b=iHV97fO7VS8aMf3ROYlU++JLJjIQsfA5n5ZaaYPFHZanI88tjH4NgEBLV0cNbGaLVhF2pQi281WgwsnOvCRYZTgcg8j3Q+Ll/rrvVEis9js4hUo3EHAmCIINN4uiq3blb/Nzty8xaYzSYD5SFcgXOo+ANpSeO1r3UB7/3K8wL+Y=; X-UUID: 48893f9d205e41aa870d082a350d7745-20201011 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1970765546; Sun, 11 Oct 2020 19:25:02 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 11 Oct 2020 20:25:00 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Oct 2020 11:24:57 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 12 Oct 2020 11:24:57 +0800 Message-ID: <1602473098.26774.5.camel@mtkswgap22> Subject: Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver From: Neal Liu To: Matthias Brugger Date: Mon, 12 Oct 2020 11:24:58 +0800 In-Reply-To: <0ece983b-2e55-cf06-aca8-02a014fce090@gmail.com> References: <1598497593-15781-1-git-send-email-neal.liu@mediatek.com> <1598497593-15781-3-git-send-email-neal.liu@mediatek.com> <1602124514.28301.17.camel@mtkswgap22> <1602149965.8784.6.camel@mtkswgap22> <0ece983b-2e55-cf06-aca8-02a014fce090@gmail.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: A57CB5B722B96A24B6BC4E4DA5FC2FE3FA559752A9CF0861603F1BE94AA214DC2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201011_232510_255973_7B048641 X-CRM114-Status: GOOD ( 25.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , wsd_upstream@mediatek.com, devicetree@vger.kernel.org, lkml , Rob Herring , linux-mediatek@lists.infradead.org, Neal Liu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-10-09 at 14:34 +0200, Matthias Brugger wrote: > > On 08/10/2020 11:39, Neal Liu wrote: > > On Thu, 2020-10-08 at 10:45 +0200, Matthias Brugger wrote: > >> > >> On 08/10/2020 04:35, Neal Liu wrote: > >>> On Wed, 2020-10-07 at 12:44 +0200, Matthias Brugger wrote: > >>>> > >>>> On 27/08/2020 05:06, Neal Liu wrote: > [...] > > >>>>> +static int mtk_devapc_probe(struct platform_device *pdev) > >>>>> +{ > >>>>> + struct device_node *node = pdev->dev.of_node; > >>>>> + struct mtk_devapc_context *ctx; > >>>>> + u32 devapc_irq; > >>>>> + int ret; > >>>>> + > >>>>> + if (IS_ERR(node)) > >>>>> + return -ENODEV; > >>>>> + > >>>>> + ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); > >>>>> + if (!ctx) > >>>>> + return -ENOMEM; > >>>>> + > >>>>> + ctx->data = of_device_get_match_data(&pdev->dev); > >>>>> + ctx->dev = &pdev->dev; > >>>>> + > >>>>> + ctx->infra_base = of_iomap(node, 0); > >>>> > >>>> Does this mean the device is part of the infracfg block? > >>>> I wasn't able to find any information about it. > >>> > >>> I'm not sure why you would ask infracfg block. devapc is parts of our > >>> SoC infra, it's different with infracfg. > >>> > >> > >> I'm asking because I want to understand the HW better. I'm not able to find any > >> information in the datasheets. I want to avoid a situation as we had with the > >> MMSYS where a clock driver was submitted first and later on we realized that > >> MMSYS is much more then that and we had to work hard to get the driver right. > >> > >> Now it's happening with SCPSYS, where a driver with the scpsys compatible was > >> send years ago. But SCPSYS is much more then the driver submitted. In this case > >> we opted to write a new driver, but moving from one driver to another one is > >> painfull and full of problems. For that I want to make sure we fully understand > >> Device APC (by the way, what does APC stands for?). Is it a totally independent > >> HW block or is it part of a subsystem, like for example SCP? > >> > >> Regards, > >> Matthias > > > > It's a totally independent HW block instead of a subsystem. > > I think it's more simple than MMSYS or SCPSYS. But if you would like to > > understand more about this HW, we could find another way/channel to > > introduce it. > > > > If it's a independent HW block, then we are good. No further information needed > by me. I'd just advise to rename the infra_base to something like base, as it > made me confuse. > > Thanks! > Matthias You can imagine that infra_base means infra devapc base address for MT6779. In 5G platforms, MediaTek infrastructure would separate into multiple parts, so does devapc HW. And devapc would be like: infra_base, peri_base, peri2_base, ... Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67007C433E7 for ; Mon, 12 Oct 2020 03:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E76B020776 for ; Mon, 12 Oct 2020 03:25:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iHV97fO7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727136AbgJLDZG (ORCPT ); Sun, 11 Oct 2020 23:25:06 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:53220 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726371AbgJLDZG (ORCPT ); Sun, 11 Oct 2020 23:25:06 -0400 X-UUID: bdfb87fcbd6a45d0944ca2cfad11dd11-20201012 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Bm72sr6Ouy/aEnxVTOQTJVItEbE2HZ45eGSUlY3+1i4=; b=iHV97fO7VS8aMf3ROYlU++JLJjIQsfA5n5ZaaYPFHZanI88tjH4NgEBLV0cNbGaLVhF2pQi281WgwsnOvCRYZTgcg8j3Q+Ll/rrvVEis9js4hUo3EHAmCIINN4uiq3blb/Nzty8xaYzSYD5SFcgXOo+ANpSeO1r3UB7/3K8wL+Y=; X-UUID: bdfb87fcbd6a45d0944ca2cfad11dd11-20201012 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1833974140; Mon, 12 Oct 2020 11:25:00 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Oct 2020 11:24:57 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 12 Oct 2020 11:24:57 +0800 Message-ID: <1602473098.26774.5.camel@mtkswgap22> Subject: Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver From: Neal Liu To: Matthias Brugger CC: Neal Liu , Rob Herring , Chun-Kuang Hu , , , , lkml , Date: Mon, 12 Oct 2020 11:24:58 +0800 In-Reply-To: <0ece983b-2e55-cf06-aca8-02a014fce090@gmail.com> References: <1598497593-15781-1-git-send-email-neal.liu@mediatek.com> <1598497593-15781-3-git-send-email-neal.liu@mediatek.com> <1602124514.28301.17.camel@mtkswgap22> <1602149965.8784.6.camel@mtkswgap22> <0ece983b-2e55-cf06-aca8-02a014fce090@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: A57CB5B722B96A24B6BC4E4DA5FC2FE3FA559752A9CF0861603F1BE94AA214DC2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org T24gRnJpLCAyMDIwLTEwLTA5IGF0IDE0OjM0ICswMjAwLCBNYXR0aGlhcyBCcnVnZ2VyIHdyb3Rl Og0KPiANCj4gT24gMDgvMTAvMjAyMCAxMTozOSwgTmVhbCBMaXUgd3JvdGU6DQo+ID4gT24gVGh1 LCAyMDIwLTEwLTA4IGF0IDEwOjQ1ICswMjAwLCBNYXR0aGlhcyBCcnVnZ2VyIHdyb3RlOg0KPiA+ Pg0KPiA+PiBPbiAwOC8xMC8yMDIwIDA0OjM1LCBOZWFsIExpdSB3cm90ZToNCj4gPj4+IE9uIFdl ZCwgMjAyMC0xMC0wNyBhdCAxMjo0NCArMDIwMCwgTWF0dGhpYXMgQnJ1Z2dlciB3cm90ZToNCj4g Pj4+Pg0KPiA+Pj4+IE9uIDI3LzA4LzIwMjAgMDU6MDYsIE5lYWwgTGl1IHdyb3RlOg0KPiBbLi4u XQ0KPiANCj4gPj4+Pj4gK3N0YXRpYyBpbnQgbXRrX2RldmFwY19wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQ0KPiA+Pj4+PiArew0KPiA+Pj4+PiArCXN0cnVjdCBkZXZpY2Vfbm9k ZSAqbm9kZSA9IHBkZXYtPmRldi5vZl9ub2RlOw0KPiA+Pj4+PiArCXN0cnVjdCBtdGtfZGV2YXBj X2NvbnRleHQgKmN0eDsNCj4gPj4+Pj4gKwl1MzIgZGV2YXBjX2lycTsNCj4gPj4+Pj4gKwlpbnQg cmV0Ow0KPiA+Pj4+PiArDQo+ID4+Pj4+ICsJaWYgKElTX0VSUihub2RlKSkNCj4gPj4+Pj4gKwkJ cmV0dXJuIC1FTk9ERVY7DQo+ID4+Pj4+ICsNCj4gPj4+Pj4gKwljdHggPSBkZXZtX2t6YWxsb2Mo JnBkZXYtPmRldiwgc2l6ZW9mKCpjdHgpLCBHRlBfS0VSTkVMKTsNCj4gPj4+Pj4gKwlpZiAoIWN0 eCkNCj4gPj4+Pj4gKwkJcmV0dXJuIC1FTk9NRU07DQo+ID4+Pj4+ICsNCj4gPj4+Pj4gKwljdHgt PmRhdGEgPSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7DQo+ID4+Pj4+ICsJ Y3R4LT5kZXYgPSAmcGRldi0+ZGV2Ow0KPiA+Pj4+PiArDQo+ID4+Pj4+ICsJY3R4LT5pbmZyYV9i YXNlID0gb2ZfaW9tYXAobm9kZSwgMCk7DQo+ID4+Pj4NCj4gPj4+PiBEb2VzIHRoaXMgbWVhbiB0 aGUgZGV2aWNlIGlzIHBhcnQgb2YgdGhlIGluZnJhY2ZnIGJsb2NrPw0KPiA+Pj4+IEkgd2Fzbid0 IGFibGUgdG8gZmluZCBhbnkgaW5mb3JtYXRpb24gYWJvdXQgaXQuDQo+ID4+Pg0KPiA+Pj4gSSdt IG5vdCBzdXJlIHdoeSB5b3Ugd291bGQgYXNrIGluZnJhY2ZnIGJsb2NrLiBkZXZhcGMgaXMgcGFy dHMgb2Ygb3VyDQo+ID4+PiBTb0MgaW5mcmEsIGl0J3MgZGlmZmVyZW50IHdpdGggaW5mcmFjZmcu DQo+ID4+Pg0KPiA+Pg0KPiA+PiBJJ20gYXNraW5nIGJlY2F1c2UgSSB3YW50IHRvIHVuZGVyc3Rh bmQgdGhlIEhXIGJldHRlci4gSSdtIG5vdCBhYmxlIHRvIGZpbmQgYW55DQo+ID4+IGluZm9ybWF0 aW9uIGluIHRoZSBkYXRhc2hlZXRzLiBJIHdhbnQgdG8gYXZvaWQgYSBzaXR1YXRpb24gYXMgd2Ug aGFkIHdpdGggdGhlDQo+ID4+IE1NU1lTIHdoZXJlIGEgY2xvY2sgZHJpdmVyIHdhcyBzdWJtaXR0 ZWQgZmlyc3QgYW5kIGxhdGVyIG9uIHdlIHJlYWxpemVkIHRoYXQNCj4gPj4gTU1TWVMgaXMgbXVj aCBtb3JlIHRoZW4gdGhhdCBhbmQgd2UgaGFkIHRvIHdvcmsgaGFyZCB0byBnZXQgdGhlIGRyaXZl ciByaWdodC4NCj4gPj4NCj4gPj4gTm93IGl0J3MgaGFwcGVuaW5nIHdpdGggU0NQU1lTLCB3aGVy ZSBhIGRyaXZlciB3aXRoIHRoZSBzY3BzeXMgY29tcGF0aWJsZSB3YXMNCj4gPj4gc2VuZCB5ZWFy cyBhZ28uIEJ1dCBTQ1BTWVMgaXMgbXVjaCBtb3JlIHRoZW4gdGhlIGRyaXZlciBzdWJtaXR0ZWQu IEluIHRoaXMgY2FzZQ0KPiA+PiB3ZSBvcHRlZCB0byB3cml0ZSBhIG5ldyBkcml2ZXIsIGJ1dCBt b3ZpbmcgZnJvbSBvbmUgZHJpdmVyIHRvIGFub3RoZXIgb25lIGlzDQo+ID4+IHBhaW5mdWxsIGFu ZCBmdWxsIG9mIHByb2JsZW1zLiBGb3IgdGhhdCBJIHdhbnQgdG8gbWFrZSBzdXJlIHdlIGZ1bGx5 IHVuZGVyc3RhbmQNCj4gPj4gRGV2aWNlIEFQQyAoYnkgdGhlIHdheSwgd2hhdCBkb2VzIEFQQyBz dGFuZHMgZm9yPykuIElzIGl0IGEgdG90YWxseSBpbmRlcGVuZGVudA0KPiA+PiBIVyBibG9jayBv ciBpcyBpdCBwYXJ0IG9mIGEgc3Vic3lzdGVtLCBsaWtlIGZvciBleGFtcGxlIFNDUD8NCj4gPj4N Cj4gPj4gUmVnYXJkcywNCj4gPj4gTWF0dGhpYXMNCj4gPiANCj4gPiBJdCdzIGEgdG90YWxseSBp bmRlcGVuZGVudCBIVyBibG9jayBpbnN0ZWFkIG9mIGEgc3Vic3lzdGVtLg0KPiA+IEkgdGhpbmsg aXQncyBtb3JlIHNpbXBsZSB0aGFuIE1NU1lTIG9yIFNDUFNZUy4gQnV0IGlmIHlvdSB3b3VsZCBs aWtlIHRvDQo+ID4gdW5kZXJzdGFuZCBtb3JlIGFib3V0IHRoaXMgSFcsIHdlIGNvdWxkIGZpbmQg YW5vdGhlciB3YXkvY2hhbm5lbCB0bw0KPiA+IGludHJvZHVjZSBpdC4NCj4gPiANCj4gDQo+IElm IGl0J3MgYSBpbmRlcGVuZGVudCBIVyBibG9jaywgdGhlbiB3ZSBhcmUgZ29vZC4gTm8gZnVydGhl ciBpbmZvcm1hdGlvbiBuZWVkZWQgDQo+IGJ5IG1lLiBJJ2QganVzdCBhZHZpc2UgdG8gcmVuYW1l IHRoZSBpbmZyYV9iYXNlIHRvIHNvbWV0aGluZyBsaWtlIGJhc2UsIGFzIGl0IA0KPiBtYWRlIG1l IGNvbmZ1c2UuDQo+IA0KPiBUaGFua3MhDQo+IE1hdHRoaWFzDQoNCllvdSBjYW4gaW1hZ2luZSB0 aGF0IGluZnJhX2Jhc2UgbWVhbnMgaW5mcmEgZGV2YXBjIGJhc2UgYWRkcmVzcyBmb3INCk1UNjc3 OS4gSW4gNUcgcGxhdGZvcm1zLCBNZWRpYVRlayBpbmZyYXN0cnVjdHVyZSB3b3VsZCBzZXBhcmF0 ZSBpbnRvDQptdWx0aXBsZSBwYXJ0cywgc28gZG9lcyBkZXZhcGMgSFcuIEFuZCBkZXZhcGMgd291 bGQgYmUgbGlrZToNCmluZnJhX2Jhc2UsIHBlcmlfYmFzZSwgcGVyaTJfYmFzZSwgLi4uDQoNClRo YW5rcy4NCg0K