From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: harish.patil@qlogic.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] l3fwd: Fix l3fwd crash due to unaligned load/store intrinsics
Date: Mon, 07 Dec 2015 03:16:19 +0100 [thread overview]
Message-ID: <1603158.UYlFNfLQMJ@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836AC87E4@irsmsx105.ger.corp.intel.com>
> > l3fwd app expects PMDs to return packets whose L2 header is
> > 16-byte aligned due to usage of _mm_load_si128()/_mm_store_si128()
> > intrinsics in the app. However, most of the protocol stacks expects
> > packets such that its IP/L3 header be aligned on a 16-byte boundary.
> >
> > Based on the recommendations received on dpdk-dev, we are changing
> > the l3fwd app to use _mm_loadu_si128()/_mm_loadu_si128() so that the
> > address need not be 16-byte aligned and thereby preventing crash.
> > We have tested that there is no performance impact due to this
> > change.
> >
> > Signed-off-by: Harish Patil <harish.patil@qlogic.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-12-07 2:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 19:39 [PATCH] l3fwd: Fix l3fwd crash due to unaligned load/store intrinsics harish.patil
2015-11-13 10:35 ` Ananyev, Konstantin
2015-11-16 18:16 ` Harish Patil
2015-12-07 2:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603158.UYlFNfLQMJ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.