From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cantor2.suse.de ([195.135.220.15] helo=mx2.suse.de) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TtjHj-0003Ah-9Z for kexec@lists.infradead.org; Fri, 11 Jan 2013 18:24:56 +0000 From: Thomas Renninger Subject: Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case Date: Fri, 11 Jan 2013 19:24:41 +0100 Message-ID: <1603289.LXteBtkifD@hammer82.arch.suse.de> In-Reply-To: References: <20121127004144.3604.61708.sendpatchset@tindoh.g01.fujitsu.local> <201301111333.49238.trenn@suse.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Yinghai Lu Cc: horms@verge.net.au, Takao Indoh , MUNEDA Takahiro , tokunaga.keiich@jp.fujitsu.com, linux-pci@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hbabu@us.ibm.com, andi@firstfloor.org, ddutile@redhat.com, ishii.hironobu@jp.fujitsu.com, hpa@zytor.com, bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, vgoyal@redhat.com, khalid@gonehiking.org On Friday, January 11, 2013 08:16:52 AM Yinghai Lu wrote: > On Fri, Jan 11, 2013 at 4:33 AM, Thomas Renninger wrote: ... > > - e820.nr_map = 0; > > + /* > > + * Remove all usable memory (this is for kdump), usable > > + * memory will be passed via memmap=X@Y parameter > > + */ > > + e820_remove_range_type(E820_RAM); > > We may need to keep exactmap intact. Why? Kexec/kdump should have been the only user? If older/current kexec calls still add ACPI maps via memmap=X#Y, they should already exist in the original e820 map and fall off or get glued to one region if (wrongly) overlapping via sanitize_map. > but could add another one like exact_ram_map > or extend to have memmap=exactmap=ram or etc. I would avoid that if anyhow possible because then you run into kexec vs kernel version problems. Maybe I should explicitly post (out of this thread) the patch to the kexec list. If nobody can come up with a strong reason, it should be ok? Thomas _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:45569 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754452Ab3AKSYy (ORCPT ); Fri, 11 Jan 2013 13:24:54 -0500 From: Thomas Renninger To: Yinghai Lu Cc: MUNEDA Takahiro , Takao Indoh , linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, andi@firstfloor.org, tokunaga.keiich@jp.fujitsu.com, kexec@lists.infradead.org, hbabu@us.ibm.com, mingo@redhat.com, ddutile@redhat.com, vgoyal@redhat.com, ishii.hironobu@jp.fujitsu.com, hpa@zytor.com, bhelgaas@google.com, tglx@linutronix.de, khalid@gonehiking.org, horms@verge.net.au Subject: Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case Date: Fri, 11 Jan 2013 19:24:41 +0100 Message-ID: <1603289.LXteBtkifD@hammer82.arch.suse.de> In-Reply-To: References: <20121127004144.3604.61708.sendpatchset@tindoh.g01.fujitsu.local> <201301111333.49238.trenn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-pci-owner@vger.kernel.org List-ID: On Friday, January 11, 2013 08:16:52 AM Yinghai Lu wrote: > On Fri, Jan 11, 2013 at 4:33 AM, Thomas Renninger wrote: ... > > - e820.nr_map = 0; > > + /* > > + * Remove all usable memory (this is for kdump), usable > > + * memory will be passed via memmap=X@Y parameter > > + */ > > + e820_remove_range_type(E820_RAM); > > We may need to keep exactmap intact. Why? Kexec/kdump should have been the only user? If older/current kexec calls still add ACPI maps via memmap=X#Y, they should already exist in the original e820 map and fall off or get glued to one region if (wrongly) overlapping via sanitize_map. > but could add another one like exact_ram_map > or extend to have memmap=exactmap=ram or etc. I would avoid that if anyhow possible because then you run into kexec vs kernel version problems. Maybe I should explicitly post (out of this thread) the patch to the kexec list. If nobody can come up with a strong reason, it should be ok? Thomas