All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Alex Deucher <alexdeucher@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, Aric Cyr <aric.cyr@amd.com>
Subject: Re: [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state
Date: Mon, 26 Oct 2020 12:56:07 -0400	[thread overview]
Message-ID: <1603731150.75fg1z8ezy.none@localhost> (raw)
In-Reply-To: <20201026143040.887736-1-alexander.deucher@amd.com>

Excerpts from Alex Deucher's message of October 26, 2020 10:30 am:
> It looks this was accidently lost in a follow up patch.
> dc context is large and we don't need contiguous pages.
> 
> Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode change")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Aric Cyr <aric.cyr@amd.com>
> Cc: Alex Xu <alex_y_xu@yahoo.ca>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 7ff029143722..64da60450fb0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1564,8 +1564,8 @@ static void init_state(struct dc *dc, struct dc_state *context)
>  
>  struct dc_state *dc_create_state(struct dc *dc)
>  {
> -	struct dc_state *context = kzalloc(sizeof(struct dc_state),
> -					   GFP_KERNEL);
> +	struct dc_state *context = kvzalloc(sizeof(struct dc_state),
> +					    GFP_KERNEL);
>  
>  	if (!context)
>  		return NULL;
> -- 
> 2.25.4
> 
> 

Did a quick test, it seems to resolve the issue for me. If you could 
apply one or both of:

Reported-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
Tested-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>

I'd appreciate it, but it's not a big deal. Thanks!
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2020-10-26 17:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 14:30 [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state Alex Deucher
2020-10-26 15:29 ` Kazlauskas, Nicholas
2020-10-26 16:56 ` Alex Xu (Hello71) [this message]
2020-10-26 17:35   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1603731150.75fg1z8ezy.none@localhost \
    --to=alex_y_xu@yahoo.ca \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aric.cyr@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.