Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

[Tomasz Figa <tomasz.figa@gmail.com>]

On Thursday 19 of December 2013 10:05:52 Sachin Kamat wrote:
> Hi Tomasz,
> 
> On 18 December 2013 20:46, Tomasz Figa <t.figa@samsung.com> wrote:
> > Hi Sachin,
> >
> > On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:
> >> Added regulator entries to Exynos5420 SMDK board.
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> ---
> >> Changes since v1:
> >> Changed node name
> >> ---
> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 +++++++++++++++++++++++++++++
> >>  1 file changed, 216 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> index fb5a1e25c632..62e1ebe4e989 100644
> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> @@ -120,4 +120,220 @@
> >>                       reg = <0x50>;
> >>               };
> >>       };
> >> +
> >> +     hsi2c_4: i2c@12CA0000 {
> >> +             status = "okay";
> >> +
> >> +             s2mps11_pmic@66 {
> >
> > Just pmic@66 is enough.
> 
> Please see my comment below.
> 
> >
> >> +                     compatible = "samsung,s2mps11-pmic";
> >> +                     reg = <0x66>;
> >> +                     s2mps11,buck2-ramp-delay = <12>;
> >> +                     s2mps11,buck34-ramp-delay = <12>;
> >> +                     s2mps11,buck16-ramp-delay = <12>;
> >> +                     s2mps11,buck6-ramp-enable = <1>;
> >> +                     s2mps11,buck2-ramp-enable = <1>;
> >> +                     s2mps11,buck3-ramp-enable = <1>;
> >> +                     s2mps11,buck4-ramp-enable = <1>;
> >> +
> >> +                     s2mps11_osc: clocks {
> >> +                             #clock-cells = <1>;
> >> +                             clock-output-names = "s2mps11_ap",
> >> +                                             "s2mps11_cp", "s2mps11_bt";
> >> +                     };
> >> +
> >> +                     regulators {
> >> +                             ldo1_reg: LDO1 {
> >> +                                     regulator-name = "vdd_ldo1";
> >
> > Is this the name as written on the PCB or board schematics?
> > + the same for all regulators below.
> 
> Yes, the schematic refers to these just as above (with no specific names).
> Unless you have strong objections or a re-spin of this patch becomes
> necessary, I
> wouldn't want to change the name you pointed above. :)

OK.

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz