From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D965FC388F7 for ; Tue, 10 Nov 2020 08:18:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36F772080A for ; Tue, 10 Nov 2020 08:18:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MsNnjcuz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="TTX30iUD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36F772080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3653B16C7; Tue, 10 Nov 2020 09:18:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3653B16C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604996332; bh=TKBOSDs5SG5iZh6CckK8QZc6kQZOfaoRrMqk9Jg2YQY=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MsNnjcuz1S8Y8jDzfwmHKFLUhg1922MU2srJ4gjvEA+KAg3AF5UXMCYpndIge4xzm 7CYiuE7Cu1FZv8ccwfH//XpQgnwKw+Isos8t5Ne2f6C9eHQ+oRMyNlBp8XyFoVbrCg KcCm+coOxVjXqIO7SN4jxYU3eqtzpVG/7jH/671Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BC90CF80161; Tue, 10 Nov 2020 09:18:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31EDBF801D5; Tue, 10 Nov 2020 09:17:59 +0100 (CET) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by alsa1.perex.cz (Postfix) with ESMTP id B1B70F80059 for ; Tue, 10 Nov 2020 09:17:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B1B70F80059 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="TTX30iUD" X-UUID: 5d54318515aa4cab9a44b62fe30a18ca-20201110 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=TKBOSDs5SG5iZh6CckK8QZc6kQZOfaoRrMqk9Jg2YQY=; b=TTX30iUD7UaD4Y7EwJahVXuwmLfxY/7qoVflQIevBV/QLbGUUdh8HF1EEfZPv04FmlPvSLpLv4lQm+pVaY8el/swO/ziFntCv7ka24hnNYo0APIV5Xu251k6GG8/xfnptZ8Oi0Rd3fRzQN3uahikA3WI6fH5+e31NmiMTZRe7dk=; X-UUID: 5d54318515aa4cab9a44b62fe30a18ca-20201110 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1701661434; Tue, 10 Nov 2020 16:17:48 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 Nov 2020 16:17:46 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 10 Nov 2020 16:17:47 +0800 Message-ID: <1604996266.2817.1.camel@mtkswgap22> Subject: Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET From: Macpaul Lin To: Takashi Iwai Date: Tue, 10 Nov 2020 16:17:46 +0800 In-Reply-To: References: <1604995443-30453-1-git-send-email-macpaul.lin@mediatek.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, Mediatek WSD Upstream , Christopher Swenson , linux-kernel@vger.kernel.org, Macpaul Lin , Eddie Hung , Takashi Iwai , Chunfeng Yun , Alexander Tsoy , linux-mediatek@lists.infradead.org, Nick Kossifidis , Matthias Brugger , Nicola Lunghi , linux-arm-kernel@lists.infradead.org, Ainge Hsu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" T24gVHVlLCAyMDIwLTExLTEwIGF0IDA5OjEyICswMTAwLCBUYWthc2hpIEl3YWkgd3JvdGU6DQo+ IE9uIFR1ZSwgMTAgTm92IDIwMjAgMDk6MDQ6MDMgKzAxMDAsDQo+IE1hY3BhdWwgTGluIHdyb3Rl Og0KPiA+IA0KPiA+IFRoZSBIVUFXRUkgVVNCLUMgaGVhZHNldCAoVklEOjB4MTJkMSwgUElEOjB4 M2EwNykgcmVwb3J0ZWQgaXQgc3VwcG9ydHMNCj4gPiA5Nmtoei4gSG93ZXZlciB0aGVyZSB3aWxs IGJlIHNvbWUgcmFuZG9tIGlzc3VlIHVuZGVyIDk2a2h6Lg0KPiA+IE5vdCBzdXJlIGlmIHRoZXJl IGlzIGFueSBhbHRlcm5hdGUgc2V0dGluZyBjb3VsZCBiZSBhcHBsaWVkLg0KPiA+IEhlbmNlIDQ4 a2h6IGlzIHN1Z2dlc3RlZCB0byBiZSBhcHBsaWVkIGF0IHRoaXMgbW9tZW50Lg0KPiA+IA0KPiA+ IFNpZ25lZC1vZmYtYnk6IE1hY3BhdWwgTGluIDxtYWNwYXVsLmxpbkBtZWRpYXRlay5jb20+DQo+ ID4gU2lnbmVkLW9mZi1ieTogRWRkaWUgSHVuZyA8ZWRkaWUuaHVuZ0BtZWRpYXRlay5jb20+DQo+ ID4gLS0tDQo+ID4gIHNvdW5kL3VzYi9mb3JtYXQuYyB8ICAgIDUgKysrKysNCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9zb3VuZC91 c2IvZm9ybWF0LmMgYi9zb3VuZC91c2IvZm9ybWF0LmMNCj4gPiBpbmRleCAxYjI4ZDAxLi42ZjZl NzliIDEwMDY0NA0KPiA+IC0tLSBhL3NvdW5kL3VzYi9mb3JtYXQuYw0KPiA+ICsrKyBiL3NvdW5k L3VzYi9mb3JtYXQuYw0KPiA+IEBAIC0yMTcsNiArMjE3LDExIEBAIHN0YXRpYyBpbnQgcGFyc2Vf YXVkaW9fZm9ybWF0X3JhdGVzX3YxKHN0cnVjdCBzbmRfdXNiX2F1ZGlvICpjaGlwLCBzdHJ1Y3Qg YXVkaW9mDQo+ID4gIAkJCSAgICAoY2hpcC0+dXNiX2lkID09IFVTQl9JRCgweDA0MWUsIDB4NDA2 NCkgfHwNCj4gPiAgCQkJICAgICBjaGlwLT51c2JfaWQgPT0gVVNCX0lEKDB4MDQxZSwgMHg0MDY4 KSkpDQo+ID4gIAkJCQlyYXRlID0gODAwMDsNCj4gPiArCQkJLyogSHVhd2VpIGhlYWRzZXQgY2Fu J3Qgc3VwcG9ydCA5NmtIeiBmdWxseSAqLw0KPiA+ICsJCQlpZiAocmF0ZSA9PSA5NjAwMCAmJg0K PiA+ICsJCQkgICAgY2hpcC0+dXNiX2lkID09IFVTQl9JRCgweDEyZDEsIDB4M2EwNykgJiYNCj4g PiArCQkJICAgIGxlMTZfdG9fY3B1KHVkZXYtPmRlc2NyaXB0b3IuYmNkRGV2aWNlKSA9PSAweDQ5 KQ0KPiANCj4gVGhpcyBjYXVzZXMgdGhlIGNvbXBpbGUgZXJyb3IgZHVlIHRvIHRoZSB1bmtub3du IHVkZXYuDQo+IElzIHRoaXMgYmNkRGV2aWNlIGNoZWNrIG1hbmRhdG9yeT8NCg0KVGhpcyBtZWFu cyBmaXJtd2FyZSB2ZXJzaW9uIG9mIHRoZSBoZWFkc2V0IGFzIGZhciBhcyBJIGtub3cuLg0KU29y cnkgSSdsbCBjaGVjayB0aGUgY29tcGlsZSBlcnJvciBhbmQgcmVzZW5kIGxhdGVyLg0KDQo+IA0K PiB0aGFua3MsDQo+IA0KPiBUYWthc2hpDQoNClRoYW5rcw0KTWFjcGF1bCBMaW4NCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F554C388F7 for ; Tue, 10 Nov 2020 08:18:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DEEA2080A for ; Tue, 10 Nov 2020 08:18:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="waVCwc+j"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="qV4ZFRGJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DEEA2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bKH95GSCiV+k2E2V6zXOltqFfXy7wwSz/94tR9hPHig=; b=waVCwc+joGZR36uHMXz67GUHi Wo41ms22jlTWt9K0dW4oci1WlF2IV8aCw1qeBwIcge0rqgR3CTURHAYkctkZdrUtVT3tDb4pf7CcF nfR1G2DIw/H+UoXoUKxHZ85QbbjlyVN+//tH3Amu60RaZMwo7nQgnrCuu7X/CvUJZKswe7kIyj0Je v1zRxvGeQ5GOoerf55SgOKj8UzR1I9pY+zO9jHOx94F131dWp5gggcKahjOWkxAiLUPd4dL0uIiAq gcFCYCNB5AoQj1yImfPvvxxBJnkyPOFnw1rR3ZAwS5Sl8yB7FDYoWoOmabnnkWrZsra2ZFP3P0W6i cBEd/CiTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcOqo-0003uc-5b; Tue, 10 Nov 2020 08:18:02 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcOql-0003tQ-99; Tue, 10 Nov 2020 08:18:00 +0000 X-UUID: c678496dd7c142699dde032310821275-20201110 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=TKBOSDs5SG5iZh6CckK8QZc6kQZOfaoRrMqk9Jg2YQY=; b=qV4ZFRGJ4M3K3wl2UkqLeqkyOBnIzys1mMY6TwESiHcNcaJackGWhab8/s4HSCbn2Uce2PVIMqrJczBRse4zAIA607xYtZrwSNrpxhHzWZY7yTJ/ZFT7VkGzjdjbBJCAV/SjAMqlJB7XASfaAsKVKZRDzjKdM3I5wH4ZllyNCkY=; X-UUID: c678496dd7c142699dde032310821275-20201110 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1574035773; Tue, 10 Nov 2020 00:17:56 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 Nov 2020 00:17:54 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 Nov 2020 16:17:46 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 10 Nov 2020 16:17:47 +0800 Message-ID: <1604996266.2817.1.camel@mtkswgap22> Subject: Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET From: Macpaul Lin To: Takashi Iwai Date: Tue, 10 Nov 2020 16:17:46 +0800 In-Reply-To: References: <1604995443-30453-1-git-send-email-macpaul.lin@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_031759_499173_DB9F13F1 X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, Mediatek WSD Upstream , Christopher Swenson , linux-kernel@vger.kernel.org, Macpaul Lin , Eddie Hung , Takashi Iwai , Jaroslav Kysela , Chunfeng Yun , Alexander Tsoy , linux-mediatek@lists.infradead.org, Nick Kossifidis , Matthias Brugger , Nicola Lunghi , linux-arm-kernel@lists.infradead.org, Ainge Hsu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-11-10 at 09:12 +0100, Takashi Iwai wrote: > On Tue, 10 Nov 2020 09:04:03 +0100, > Macpaul Lin wrote: > > > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting could be applied. > > Hence 48khz is suggested to be applied at this moment. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: Eddie Hung > > --- > > sound/usb/format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 1b28d01..6f6e79b 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > rate = 8000; > > + /* Huawei headset can't support 96kHz fully */ > > + if (rate == 96000 && > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > + le16_to_cpu(udev->descriptor.bcdDevice) == 0x49) > > This causes the compile error due to the unknown udev. > Is this bcdDevice check mandatory? This means firmware version of the headset as far as I know.. Sorry I'll check the compile error and resend later. > > thanks, > > Takashi Thanks Macpaul Lin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DDB4C56201 for ; Tue, 10 Nov 2020 08:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B01520870 for ; Tue, 10 Nov 2020 08:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="TTX30iUD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729795AbgKJIRx (ORCPT ); Tue, 10 Nov 2020 03:17:53 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:51773 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727098AbgKJIRw (ORCPT ); Tue, 10 Nov 2020 03:17:52 -0500 X-UUID: 5d54318515aa4cab9a44b62fe30a18ca-20201110 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=TKBOSDs5SG5iZh6CckK8QZc6kQZOfaoRrMqk9Jg2YQY=; b=TTX30iUD7UaD4Y7EwJahVXuwmLfxY/7qoVflQIevBV/QLbGUUdh8HF1EEfZPv04FmlPvSLpLv4lQm+pVaY8el/swO/ziFntCv7ka24hnNYo0APIV5Xu251k6GG8/xfnptZ8Oi0Rd3fRzQN3uahikA3WI6fH5+e31NmiMTZRe7dk=; X-UUID: 5d54318515aa4cab9a44b62fe30a18ca-20201110 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1701661434; Tue, 10 Nov 2020 16:17:48 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 Nov 2020 16:17:46 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 10 Nov 2020 16:17:47 +0800 Message-ID: <1604996266.2817.1.camel@mtkswgap22> Subject: Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET From: Macpaul Lin To: Takashi Iwai CC: Jaroslav Kysela , Takashi Iwai , Matthias Brugger , Alexander Tsoy , Nicola Lunghi , "Christopher Swenson" , Nick Kossifidis , , Ainge Hsu , Eddie Hung , Chunfeng Yun , Mediatek WSD Upstream , Macpaul Lin , , , , Date: Tue, 10 Nov 2020 16:17:46 +0800 In-Reply-To: References: <1604995443-30453-1-git-send-email-macpaul.lin@mediatek.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gVHVlLCAyMDIwLTExLTEwIGF0IDA5OjEyICswMTAwLCBUYWthc2hpIEl3YWkgd3JvdGU6DQo+ IE9uIFR1ZSwgMTAgTm92IDIwMjAgMDk6MDQ6MDMgKzAxMDAsDQo+IE1hY3BhdWwgTGluIHdyb3Rl Og0KPiA+IA0KPiA+IFRoZSBIVUFXRUkgVVNCLUMgaGVhZHNldCAoVklEOjB4MTJkMSwgUElEOjB4 M2EwNykgcmVwb3J0ZWQgaXQgc3VwcG9ydHMNCj4gPiA5Nmtoei4gSG93ZXZlciB0aGVyZSB3aWxs IGJlIHNvbWUgcmFuZG9tIGlzc3VlIHVuZGVyIDk2a2h6Lg0KPiA+IE5vdCBzdXJlIGlmIHRoZXJl IGlzIGFueSBhbHRlcm5hdGUgc2V0dGluZyBjb3VsZCBiZSBhcHBsaWVkLg0KPiA+IEhlbmNlIDQ4 a2h6IGlzIHN1Z2dlc3RlZCB0byBiZSBhcHBsaWVkIGF0IHRoaXMgbW9tZW50Lg0KPiA+IA0KPiA+ IFNpZ25lZC1vZmYtYnk6IE1hY3BhdWwgTGluIDxtYWNwYXVsLmxpbkBtZWRpYXRlay5jb20+DQo+ ID4gU2lnbmVkLW9mZi1ieTogRWRkaWUgSHVuZyA8ZWRkaWUuaHVuZ0BtZWRpYXRlay5jb20+DQo+ ID4gLS0tDQo+ID4gIHNvdW5kL3VzYi9mb3JtYXQuYyB8ICAgIDUgKysrKysNCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9zb3VuZC91 c2IvZm9ybWF0LmMgYi9zb3VuZC91c2IvZm9ybWF0LmMNCj4gPiBpbmRleCAxYjI4ZDAxLi42ZjZl NzliIDEwMDY0NA0KPiA+IC0tLSBhL3NvdW5kL3VzYi9mb3JtYXQuYw0KPiA+ICsrKyBiL3NvdW5k L3VzYi9mb3JtYXQuYw0KPiA+IEBAIC0yMTcsNiArMjE3LDExIEBAIHN0YXRpYyBpbnQgcGFyc2Vf YXVkaW9fZm9ybWF0X3JhdGVzX3YxKHN0cnVjdCBzbmRfdXNiX2F1ZGlvICpjaGlwLCBzdHJ1Y3Qg YXVkaW9mDQo+ID4gIAkJCSAgICAoY2hpcC0+dXNiX2lkID09IFVTQl9JRCgweDA0MWUsIDB4NDA2 NCkgfHwNCj4gPiAgCQkJICAgICBjaGlwLT51c2JfaWQgPT0gVVNCX0lEKDB4MDQxZSwgMHg0MDY4 KSkpDQo+ID4gIAkJCQlyYXRlID0gODAwMDsNCj4gPiArCQkJLyogSHVhd2VpIGhlYWRzZXQgY2Fu J3Qgc3VwcG9ydCA5NmtIeiBmdWxseSAqLw0KPiA+ICsJCQlpZiAocmF0ZSA9PSA5NjAwMCAmJg0K PiA+ICsJCQkgICAgY2hpcC0+dXNiX2lkID09IFVTQl9JRCgweDEyZDEsIDB4M2EwNykgJiYNCj4g PiArCQkJICAgIGxlMTZfdG9fY3B1KHVkZXYtPmRlc2NyaXB0b3IuYmNkRGV2aWNlKSA9PSAweDQ5 KQ0KPiANCj4gVGhpcyBjYXVzZXMgdGhlIGNvbXBpbGUgZXJyb3IgZHVlIHRvIHRoZSB1bmtub3du IHVkZXYuDQo+IElzIHRoaXMgYmNkRGV2aWNlIGNoZWNrIG1hbmRhdG9yeT8NCg0KVGhpcyBtZWFu cyBmaXJtd2FyZSB2ZXJzaW9uIG9mIHRoZSBoZWFkc2V0IGFzIGZhciBhcyBJIGtub3cuLg0KU29y cnkgSSdsbCBjaGVjayB0aGUgY29tcGlsZSBlcnJvciBhbmQgcmVzZW5kIGxhdGVyLg0KDQo+IA0K PiB0aGFua3MsDQo+IA0KPiBUYWthc2hpDQoNClRoYW5rcw0KTWFjcGF1bCBMaW4NCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9842C388F7 for ; Tue, 10 Nov 2020 08:19:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AA0B2080A for ; Tue, 10 Nov 2020 08:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qboy0gWH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="qV4ZFRGJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AA0B2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LrmE6qij/XmOHXcXZb/XIiIAaiVyFttVdEn3Zs70U2I=; b=Qboy0gWH73kEOFmojsMV2xpio goo7RE26AvLeaP6lqntbV1WkV+omdTZ+FXz/htuBq1uTNoIfNmvcY0tASmuW9YHMv2KKrmj4L9u6t Xs/NgV+AM0TFwaMix4Doc1e5iOsSQ69ZdTuo1NeY9j1oMq12/JmQ71XXleqjCrUk1yKkIVF3Bvlv0 kK0qEv/Ey2C6jPg6+CyvYGgwwFPW9ThG06uA2iDsPzzPTy5HxeHzXvqfUcGz11e9ViwtJaKDK3Et0 qwbON+yUHxrLSW3oi5FJNPJSkhJTv0UBr+XHUj22kMQ0xRkZ8HQyKf0gNwBebNVY90s5LQxq+f7pz RNg2hhHAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcOqo-0003un-P9; Tue, 10 Nov 2020 08:18:02 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcOql-0003tQ-99; Tue, 10 Nov 2020 08:18:00 +0000 X-UUID: c678496dd7c142699dde032310821275-20201110 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=TKBOSDs5SG5iZh6CckK8QZc6kQZOfaoRrMqk9Jg2YQY=; b=qV4ZFRGJ4M3K3wl2UkqLeqkyOBnIzys1mMY6TwESiHcNcaJackGWhab8/s4HSCbn2Uce2PVIMqrJczBRse4zAIA607xYtZrwSNrpxhHzWZY7yTJ/ZFT7VkGzjdjbBJCAV/SjAMqlJB7XASfaAsKVKZRDzjKdM3I5wH4ZllyNCkY=; X-UUID: c678496dd7c142699dde032310821275-20201110 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1574035773; Tue, 10 Nov 2020 00:17:56 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 Nov 2020 00:17:54 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 Nov 2020 16:17:46 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 10 Nov 2020 16:17:47 +0800 Message-ID: <1604996266.2817.1.camel@mtkswgap22> Subject: Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET From: Macpaul Lin To: Takashi Iwai Date: Tue, 10 Nov 2020 16:17:46 +0800 In-Reply-To: References: <1604995443-30453-1-git-send-email-macpaul.lin@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_031759_499173_DB9F13F1 X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, Mediatek WSD Upstream , Christopher Swenson , linux-kernel@vger.kernel.org, Macpaul Lin , Eddie Hung , Takashi Iwai , Jaroslav Kysela , Chunfeng Yun , Alexander Tsoy , linux-mediatek@lists.infradead.org, Nick Kossifidis , Matthias Brugger , Nicola Lunghi , linux-arm-kernel@lists.infradead.org, Ainge Hsu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-11-10 at 09:12 +0100, Takashi Iwai wrote: > On Tue, 10 Nov 2020 09:04:03 +0100, > Macpaul Lin wrote: > > > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting could be applied. > > Hence 48khz is suggested to be applied at this moment. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: Eddie Hung > > --- > > sound/usb/format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 1b28d01..6f6e79b 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > rate = 8000; > > + /* Huawei headset can't support 96kHz fully */ > > + if (rate == 96000 && > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > + le16_to_cpu(udev->descriptor.bcdDevice) == 0x49) > > This causes the compile error due to the unknown udev. > Is this bcdDevice check mandatory? This means firmware version of the headset as far as I know.. Sorry I'll check the compile error and resend later. > > thanks, > > Takashi Thanks Macpaul Lin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel