From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chen Yu <yu.c.chen@intel.com>, Chen Yu <yu.chen.surf@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH v5 0/4] tools/bootconfig: Align the bootconfig applied initrd
Date: Thu, 19 Nov 2020 14:53:13 +0900 [thread overview]
Message-ID: <160576519277.320071.14260402851742732108.stgit@devnote2> (raw)
Hi,
This is the 5th version of the bootconfig tool update to align
the total size of initrd + bootconfig to 4.
Previous version is here;
https://lkml.kernel.org/r/160571371674.277955.11736890010190945946.stgit@devnote2
This version fixes bugs in [2/4] and [3/4] and cleans up code in [3/4].
To adjust the file size, the bootconfig tool adds padding null
characters in between the boot configuration data and the footer.
The changing points are
- The bootconfig applied initrd image size is aligned to 4.
- To insert the padding null ('\0') bytes, the size in the footer
can be bigger than the actual bootconfig file size.
- But the max size of the boot configuration file is same, because
the max size doesn't include the last null characters.
In this series I keep 4 bytes aligned instead of longer size,
because only I could found was that the grub might align the initrd
filesize to 4, and U-Boot/EDK2 would not change it. So I couldn't
say what is the best size.
Anyway, I updated the documentation too, which clearly says that
the above changing points, and if the bootloader pass the wrong
size, kernel will not find bootconfig from the initrd.
Thank you,
---
Masami Hiramatsu (4):
tools/bootconfig: Fix errno reference after printf()
tools/bootconfig: Fix to check the write failure correctly
tools/bootconfig: Align the bootconfig applied initrd image size to 4
docs: bootconfig: Update file format on initrd image
tools/bootconfig/main.c | 121 +++++++++++++++++++++++------------
tools/bootconfig/test-bootconfig.sh | 6 +-
2 files changed, 85 insertions(+), 42 deletions(-)
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next reply other threads:[~2020-11-19 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 5:53 Masami Hiramatsu [this message]
2020-11-19 5:53 ` [PATCH v5 1/4] tools/bootconfig: Fix errno reference after printf() Masami Hiramatsu
2020-11-19 5:53 ` [PATCH v5 2/4] tools/bootconfig: Fix to check the write failure correctly Masami Hiramatsu
2020-11-19 5:53 ` [PATCH v5 3/4] tools/bootconfig: Align the bootconfig applied initrd image size to 4 Masami Hiramatsu
2020-11-19 5:53 ` [PATCH v5 4/4] docs: bootconfig: Update file format on initrd image Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160576519277.320071.14260402851742732108.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=yu.c.chen@intel.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.