From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72DA9C2D0E4 for ; Thu, 19 Nov 2020 12:59:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD46E21D7A for ; Thu, 19 Nov 2020 12:59:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HnI7nK39"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JjfRZyMy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD46E21D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ttRMs0Rpb6C2zqclpq/BK2Mzy9SLHbnuPJG+PO25fDc=; b=HnI7nK39p1NgGbhvKzwuLshR3 qxUHHKSkj+FRZp5ekQnu9njBdzs4xDn8d7fReB9P38XMy3hjn5HfguAC32jJu06VxYXnbEvzJV9+u T6FwGuj3noWaEB3ZgNY0pCqsqg2GXtxe8YbM+WJAziF1YdeGkqdhJj6vWaaZoptEoS+cD34RpUAq5 OTQKNIFGSOMMPs7lrI5FlbIHBdSbB1A3wRy7MD53UnoZkA0UMutZARltbcg4QqWaz05coIoXWI9eg 9YF0QaigndSEOChZ0exNB418waexgpdcSzzeijVYEZ4ppyp8k2znlRbflnyYnkGP3LHDLd3ZszIWg 4MMM2mm/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfjWo-0002Pn-19; Thu, 19 Nov 2020 12:59:10 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfjWl-0002O6-25; Thu, 19 Nov 2020 12:59:08 +0000 X-UUID: 0bb33657af724380822bf3bdf701afe7-20201119 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jtIPXLdRzRuqtAWsnlgJ678Skl74sQc1PCkrSIeeLWc=; b=JjfRZyMyiqqLW2gQfa/o6j/BNQBKm6/cESXzVPrGtkQasFXhiYNRV6+qPu/oGN1ULJg27pyeZ451Hi6GXzT2RpNqFmImz4OK8Njpi/tyTJ4dqgs+ENND4AUnuOFQf1dmus/Iz+cwL7NMoOykZUKEDMCE9ofZMLRk2KC6iBoEOs0=; X-UUID: 0bb33657af724380822bf3bdf701afe7-20201119 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1670620635; Thu, 19 Nov 2020 04:58:55 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 04:58:54 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 20:58:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 Nov 2020 20:58:44 +0800 Message-ID: <1605790724.4733.107.camel@mhfsdcap03> Subject: Re: [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings From: Dongchun Zhu To: Sakari Ailus Date: Thu, 19 Nov 2020 20:58:44 +0800 In-Reply-To: <20201030162756.GR26150@paasikivi.fi.intel.com> References: <20201013130503.2412-1-dongchun.zhu@mediatek.com> <20201013130503.2412-2-dongchun.zhu@mediatek.com> <20201013161938.GE13341@paasikivi.fi.intel.com> <1602641418.4733.80.camel@mhfsdcap03> <20201014083139.GG13341@paasikivi.fi.intel.com> <20201019082759.GL13341@paasikivi.fi.intel.com> <20201030162756.GR26150@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 35267B2D9D4741786357859B1F81D467D956B070A5A5332966B0F689BDE873402000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_075907_338624_C184AD9C X-CRM114-Status: GOOD ( 46.14 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-devicetree , Nicolas Boichat , srv_heupstream , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Andy Shevchenko , Tomasz Figa , Louis Kuo , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , dongchun.zhu@mediatek.com, Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sakari, On Fri, 2020-10-30 at 18:27 +0200, Sakari Ailus wrote: > Hi Tomasz, Dongchun, > > On Mon, Oct 19, 2020 at 09:20:15PM +0200, Tomasz Figa wrote: > > On Mon, Oct 19, 2020 at 10:28 AM Sakari Ailus > > wrote: > > > > > > On Wed, Oct 14, 2020 at 01:48:00PM +0200, Tomasz Figa wrote: > > > > On Wed, Oct 14, 2020 at 10:31 AM Sakari Ailus > > > > wrote: > > > > > > > > > > On Wed, Oct 14, 2020 at 10:10:18AM +0800, Dongchun Zhu wrote: > > > > > > Hello Sakari, > > > > > > > > > > > > Thanks for your timely review. > > > > > > > > > > > > On Tue, 2020-10-13 at 19:19 +0300, Sakari Ailus wrote: > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > On Tue, Oct 13, 2020 at 09:05:02PM +0800, Dongchun Zhu wrote: > > > > > > > > Add YAML device tree binding for OV02A10 CMOS image sensor, and the > > > > > > > > relevant MAINTAINERS entries. > > > > > > > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > > > > --- > > > > > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 162 +++++++++++++++++++++ > > > > > > > > MAINTAINERS | 7 + > > > > > > > > 2 files changed, 169 insertions(+) > > > > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > > > > > > > > > > [snip]... > > > > > > > > > > > > > > + ovti,mipi-clock-voltage: > > > > > > > > + description: > > > > > > > > + An array of 2-tuples items, and each item consists of link frequency and > > > > > > > > + MIPI clock voltage unit like . Clock voltage unit is > > > > > > > > + dependent upon link speed, indicating MIPI transmission speed select that > > > > > > > > + controls D-PHY timing setting by adjusting MIPI clock voltage to improve > > > > > > > > + the clock driver capability. > > > > > > > > + $ref: "/schemas/types.yaml#/definitions/uint32-array" > > > > > > > > + minItems: 2 > > > > > > > > + default: [390000, 4] > > > > > > > > > > > > > > Why do you have the link frequency here as well? > > > > > > > > > > > > > > In principle this does belong to the endpoint as link frequencies are > > > > > > > specific to that, but I don't mind; there's just a single port anyway. > > > > > > > > > > > > > > > > > > > This is an optional property which we model as an array of > > > > > clock voltage> pairs. An example to have all link speeds up to 390MHz > > > > > > use the value 4 for current driver. If one wants to select different > > > > > > voltage for different link, they could do so as well. > > > > > > > > > > If you think you'd need that, then you need to put this to the endpoint. > > > > > > > > The mipi-clock-voltage property is not a property of the endpoint. The > > > > link frequency there does not set the link frequency - it only > > > > specifies which link frequency the given voltage should be used for. > > > > > > If it is not bound to the endpoint --- that specifies the properties of the > > > link --- then you could just put it to the driver, couldn't you? > > > > > > But earlier on, we established that this is specific to a given board, or a > > > given link. Endpoints are used to describe connections that a device may > > > have to other devices. Therefore their properties are different. > > > > > > The graph bindings allow for several endpoints on a single physical port, > > > some may be disabled in that case. This is admittedly mostly done with > > > CSI-2 receivers. > > > > > > Either way, putting this property to the device may affect how DT source is > > > arranged for boards that have this device. Any similar configuration on > > > other devices with multiple transmitters or receivers would be in endpoints > > > anyway --- because they have to, so I don't see why bindings for this > > > device should be different. > > > > > > If you put it to endpoint, the driver also doesn't need to match the link > > > frequencies in kHz and Hz between the two properties, but just use the same > > > index for both. > > > > I agree in general, but I think in this case this is a device-specific > > property and the sensor only has 1 CSI-2 interface, so maybe it > > doesn't really matter? > > > > Specifying frequency, voltage pairs is a common practice in other > > bindings, such as the OPP bindings, by the way. > > > > That said, if you insist, I'm fine with this being moved to the > > endpoint node too. > > Please, unless there are sound technical reasons to do otherwise. > Sorry for the late reply. In fact I'm still wonder whether 'MIPI clock voltage unit' here is a very common or meaningful property that needs to be moved to the endpoint data structure in v4l2 framework. Just because it relates to link frequency? In another words, if we set clock voltage as a separate property, as patchset 13 or earlier version presents, is there no need to move the position? _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB62C2D0E4 for ; Thu, 19 Nov 2020 13:00:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1539A2468B for ; Thu, 19 Nov 2020 13:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="msuWDyKW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JjfRZyMy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1539A2468B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EG83GEs3OlJg+OG3WpTJ8UoMzBl30AT3lKzS4g3TXZc=; b=msuWDyKWS0hR6eRHWlJkuI752 b+nnzboWCu8ic5Rs9FxmjkM+9xBaoEbJXFvuvUH0Ci2KFO0O+yi1OG5oTGwUv1V6VBzBl6tr0bE+O +MLjZ01EoMM6e6yWK37E1uLlKyx6ZaPJV7Biw+61PSG11/w59YkVoJ0EaAsOkv0FJui4dcakWwpi5 9I4iSiArlOXNTj+K5FBrw0rbR0QYQjaooJk05AIfBWuiVGYbndYmt3wKlplPXKP2bQ1+V8JBQvCBk EL3r2F6LbxKOJRVlv+k3L5YKx7loaf3LcMsA1axpj1z9xRcGxptjComR5NYQ7xhnSXinaCKMsQGnJ jY3DiDFzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfjWq-0002QI-8Q; Thu, 19 Nov 2020 12:59:12 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfjWl-0002O6-25; Thu, 19 Nov 2020 12:59:08 +0000 X-UUID: 0bb33657af724380822bf3bdf701afe7-20201119 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jtIPXLdRzRuqtAWsnlgJ678Skl74sQc1PCkrSIeeLWc=; b=JjfRZyMyiqqLW2gQfa/o6j/BNQBKm6/cESXzVPrGtkQasFXhiYNRV6+qPu/oGN1ULJg27pyeZ451Hi6GXzT2RpNqFmImz4OK8Njpi/tyTJ4dqgs+ENND4AUnuOFQf1dmus/Iz+cwL7NMoOykZUKEDMCE9ofZMLRk2KC6iBoEOs0=; X-UUID: 0bb33657af724380822bf3bdf701afe7-20201119 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1670620635; Thu, 19 Nov 2020 04:58:55 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 04:58:54 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 20:58:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 Nov 2020 20:58:44 +0800 Message-ID: <1605790724.4733.107.camel@mhfsdcap03> Subject: Re: [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings From: Dongchun Zhu To: Sakari Ailus Date: Thu, 19 Nov 2020 20:58:44 +0800 In-Reply-To: <20201030162756.GR26150@paasikivi.fi.intel.com> References: <20201013130503.2412-1-dongchun.zhu@mediatek.com> <20201013130503.2412-2-dongchun.zhu@mediatek.com> <20201013161938.GE13341@paasikivi.fi.intel.com> <1602641418.4733.80.camel@mhfsdcap03> <20201014083139.GG13341@paasikivi.fi.intel.com> <20201019082759.GL13341@paasikivi.fi.intel.com> <20201030162756.GR26150@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 35267B2D9D4741786357859B1F81D467D956B070A5A5332966B0F689BDE873402000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_075907_338624_C184AD9C X-CRM114-Status: GOOD ( 46.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-devicetree , Nicolas Boichat , srv_heupstream , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Andy Shevchenko , Tomasz Figa , Louis Kuo , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , dongchun.zhu@mediatek.com, Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, On Fri, 2020-10-30 at 18:27 +0200, Sakari Ailus wrote: > Hi Tomasz, Dongchun, > > On Mon, Oct 19, 2020 at 09:20:15PM +0200, Tomasz Figa wrote: > > On Mon, Oct 19, 2020 at 10:28 AM Sakari Ailus > > wrote: > > > > > > On Wed, Oct 14, 2020 at 01:48:00PM +0200, Tomasz Figa wrote: > > > > On Wed, Oct 14, 2020 at 10:31 AM Sakari Ailus > > > > wrote: > > > > > > > > > > On Wed, Oct 14, 2020 at 10:10:18AM +0800, Dongchun Zhu wrote: > > > > > > Hello Sakari, > > > > > > > > > > > > Thanks for your timely review. > > > > > > > > > > > > On Tue, 2020-10-13 at 19:19 +0300, Sakari Ailus wrote: > > > > > > > Hi Dongchun, > > > > > > > > > > > > > > On Tue, Oct 13, 2020 at 09:05:02PM +0800, Dongchun Zhu wrote: > > > > > > > > Add YAML device tree binding for OV02A10 CMOS image sensor, and the > > > > > > > > relevant MAINTAINERS entries. > > > > > > > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > > > > --- > > > > > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 162 +++++++++++++++++++++ > > > > > > > > MAINTAINERS | 7 + > > > > > > > > 2 files changed, 169 insertions(+) > > > > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > > > > > > > > > > [snip]... > > > > > > > > > > > > > > + ovti,mipi-clock-voltage: > > > > > > > > + description: > > > > > > > > + An array of 2-tuples items, and each item consists of link frequency and > > > > > > > > + MIPI clock voltage unit like . Clock voltage unit is > > > > > > > > + dependent upon link speed, indicating MIPI transmission speed select that > > > > > > > > + controls D-PHY timing setting by adjusting MIPI clock voltage to improve > > > > > > > > + the clock driver capability. > > > > > > > > + $ref: "/schemas/types.yaml#/definitions/uint32-array" > > > > > > > > + minItems: 2 > > > > > > > > + default: [390000, 4] > > > > > > > > > > > > > > Why do you have the link frequency here as well? > > > > > > > > > > > > > > In principle this does belong to the endpoint as link frequencies are > > > > > > > specific to that, but I don't mind; there's just a single port anyway. > > > > > > > > > > > > > > > > > > > This is an optional property which we model as an array of > > > > > clock voltage> pairs. An example to have all link speeds up to 390MHz > > > > > > use the value 4 for current driver. If one wants to select different > > > > > > voltage for different link, they could do so as well. > > > > > > > > > > If you think you'd need that, then you need to put this to the endpoint. > > > > > > > > The mipi-clock-voltage property is not a property of the endpoint. The > > > > link frequency there does not set the link frequency - it only > > > > specifies which link frequency the given voltage should be used for. > > > > > > If it is not bound to the endpoint --- that specifies the properties of the > > > link --- then you could just put it to the driver, couldn't you? > > > > > > But earlier on, we established that this is specific to a given board, or a > > > given link. Endpoints are used to describe connections that a device may > > > have to other devices. Therefore their properties are different. > > > > > > The graph bindings allow for several endpoints on a single physical port, > > > some may be disabled in that case. This is admittedly mostly done with > > > CSI-2 receivers. > > > > > > Either way, putting this property to the device may affect how DT source is > > > arranged for boards that have this device. Any similar configuration on > > > other devices with multiple transmitters or receivers would be in endpoints > > > anyway --- because they have to, so I don't see why bindings for this > > > device should be different. > > > > > > If you put it to endpoint, the driver also doesn't need to match the link > > > frequencies in kHz and Hz between the two properties, but just use the same > > > index for both. > > > > I agree in general, but I think in this case this is a device-specific > > property and the sensor only has 1 CSI-2 interface, so maybe it > > doesn't really matter? > > > > Specifying frequency, voltage pairs is a common practice in other > > bindings, such as the OPP bindings, by the way. > > > > That said, if you insist, I'm fine with this being moved to the > > endpoint node too. > > Please, unless there are sound technical reasons to do otherwise. > Sorry for the late reply. In fact I'm still wonder whether 'MIPI clock voltage unit' here is a very common or meaningful property that needs to be moved to the endpoint data structure in v4l2 framework. Just because it relates to link frequency? In another words, if we set clock voltage as a separate property, as patchset 13 or earlier version presents, is there no need to move the position? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C035C63697 for ; Thu, 19 Nov 2020 12:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F238121D7A for ; Thu, 19 Nov 2020 12:59:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JjfRZyMy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727238AbgKSM7D (ORCPT ); Thu, 19 Nov 2020 07:59:03 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:8198 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727252AbgKSM7C (ORCPT ); Thu, 19 Nov 2020 07:59:02 -0500 X-UUID: d1d95da996414eb29b8f2eb41edb7113-20201119 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jtIPXLdRzRuqtAWsnlgJ678Skl74sQc1PCkrSIeeLWc=; b=JjfRZyMyiqqLW2gQfa/o6j/BNQBKm6/cESXzVPrGtkQasFXhiYNRV6+qPu/oGN1ULJg27pyeZ451Hi6GXzT2RpNqFmImz4OK8Njpi/tyTJ4dqgs+ENND4AUnuOFQf1dmus/Iz+cwL7NMoOykZUKEDMCE9ofZMLRk2KC6iBoEOs0=; X-UUID: d1d95da996414eb29b8f2eb41edb7113-20201119 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 993231741; Thu, 19 Nov 2020 20:58:52 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 20:58:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 Nov 2020 20:58:44 +0800 Message-ID: <1605790724.4733.107.camel@mhfsdcap03> Subject: Re: [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings From: Dongchun Zhu To: Sakari Ailus CC: Tomasz Figa , Mauro Carvalho Chehab , Andy Shevchenko , Rob Herring , Mark Rutland , Nicolas Boichat , Matthias Brugger , Cao Bing Bu , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , "Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?=" , Date: Thu, 19 Nov 2020 20:58:44 +0800 In-Reply-To: <20201030162756.GR26150@paasikivi.fi.intel.com> References: <20201013130503.2412-1-dongchun.zhu@mediatek.com> <20201013130503.2412-2-dongchun.zhu@mediatek.com> <20201013161938.GE13341@paasikivi.fi.intel.com> <1602641418.4733.80.camel@mhfsdcap03> <20201014083139.GG13341@paasikivi.fi.intel.com> <20201019082759.GL13341@paasikivi.fi.intel.com> <20201030162756.GR26150@paasikivi.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 35267B2D9D4741786357859B1F81D467D956B070A5A5332966B0F689BDE873402000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgU2FrYXJpLA0KDQpPbiBGcmksIDIwMjAtMTAtMzAgYXQgMTg6MjcgKzAyMDAsIFNha2FyaSBB aWx1cyB3cm90ZToNCj4gSGkgVG9tYXN6LCBEb25nY2h1biwNCj4gDQo+IE9uIE1vbiwgT2N0IDE5 LCAyMDIwIGF0IDA5OjIwOjE1UE0gKzAyMDAsIFRvbWFzeiBGaWdhIHdyb3RlOg0KPiA+IE9uIE1v biwgT2N0IDE5LCAyMDIwIGF0IDEwOjI4IEFNIFNha2FyaSBBaWx1cw0KPiA+IDxzYWthcmkuYWls dXNAbGludXguaW50ZWwuY29tPiB3cm90ZToNCj4gPiA+DQo+ID4gPiBPbiBXZWQsIE9jdCAxNCwg MjAyMCBhdCAwMTo0ODowMFBNICswMjAwLCBUb21hc3ogRmlnYSB3cm90ZToNCj4gPiA+ID4gT24g V2VkLCBPY3QgMTQsIDIwMjAgYXQgMTA6MzEgQU0gU2FrYXJpIEFpbHVzDQo+ID4gPiA+IDxzYWth cmkuYWlsdXNAbGludXguaW50ZWwuY29tPiB3cm90ZToNCj4gPiA+ID4gPg0KPiA+ID4gPiA+IE9u IFdlZCwgT2N0IDE0LCAyMDIwIGF0IDEwOjEwOjE4QU0gKzA4MDAsIERvbmdjaHVuIFpodSB3cm90 ZToNCj4gPiA+ID4gPiA+IEhlbGxvIFNha2FyaSwNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBU aGFua3MgZm9yIHlvdXIgdGltZWx5IHJldmlldy4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBP biBUdWUsIDIwMjAtMTAtMTMgYXQgMTk6MTkgKzAzMDAsIFNha2FyaSBBaWx1cyB3cm90ZToNCj4g PiA+ID4gPiA+ID4gSGkgRG9uZ2NodW4sDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IE9u IFR1ZSwgT2N0IDEzLCAyMDIwIGF0IDA5OjA1OjAyUE0gKzA4MDAsIERvbmdjaHVuIFpodSB3cm90 ZToNCj4gPiA+ID4gPiA+ID4gPiBBZGQgWUFNTCBkZXZpY2UgdHJlZSBiaW5kaW5nIGZvciBPVjAy QTEwIENNT1MgaW1hZ2Ugc2Vuc29yLCBhbmQgdGhlDQo+ID4gPiA+ID4gPiA+ID4gcmVsZXZhbnQg TUFJTlRBSU5FUlMgZW50cmllcy4NCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IFNp Z25lZC1vZmYtYnk6IERvbmdjaHVuIFpodSA8ZG9uZ2NodW4uemh1QG1lZGlhdGVrLmNvbT4NCj4g PiA+ID4gPiA+ID4gPiAtLS0NCj4gPiA+ID4gPiA+ID4gPiAgLi4uL2JpbmRpbmdzL21lZGlhL2ky Yy9vdnRpLG92MDJhMTAueWFtbCAgICAgICAgICAgfCAxNjIgKysrKysrKysrKysrKysrKysrKysr DQo+ID4gPiA+ID4gPiA+ID4gIE1BSU5UQUlORVJTICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICA3ICsNCj4gPiA+ID4gPiA+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAx NjkgaW5zZXJ0aW9ucygrKQ0KPiA+ID4gPiA+ID4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lZGlhL2kyYy9vdnRpLG92MDJhMTAueWFt bA0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gW3NuaXBdLi4uDQo+ ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ICsgIG92dGksbWlwaS1jbG9jay12b2x0YWdlOg0K PiA+ID4gPiA+ID4gPiA+ICsgICAgZGVzY3JpcHRpb246DQo+ID4gPiA+ID4gPiA+ID4gKyAgICAg IEFuIGFycmF5IG9mIDItdHVwbGVzIGl0ZW1zLCBhbmQgZWFjaCBpdGVtIGNvbnNpc3RzIG9mIGxp bmsgZnJlcXVlbmN5IGFuZA0KPiA+ID4gPiA+ID4gPiA+ICsgICAgICBNSVBJIGNsb2NrIHZvbHRh Z2UgdW5pdCBsaWtlIDxmcmVxLWtIeiB2b2x0LXVuaXQ+LiBDbG9jayB2b2x0YWdlIHVuaXQgaXMN Cj4gPiA+ID4gPiA+ID4gPiArICAgICAgZGVwZW5kZW50IHVwb24gbGluayBzcGVlZCwgaW5kaWNh dGluZyBNSVBJIHRyYW5zbWlzc2lvbiBzcGVlZCBzZWxlY3QgdGhhdA0KPiA+ID4gPiA+ID4gPiA+ ICsgICAgICBjb250cm9scyBELVBIWSB0aW1pbmcgc2V0dGluZyBieSBhZGp1c3RpbmcgTUlQSSBj bG9jayB2b2x0YWdlIHRvIGltcHJvdmUNCj4gPiA+ID4gPiA+ID4gPiArICAgICAgdGhlIGNsb2Nr IGRyaXZlciBjYXBhYmlsaXR5Lg0KPiA+ID4gPiA+ID4gPiA+ICsgICAgJHJlZjogIi9zY2hlbWFz L3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3VpbnQzMi1hcnJheSINCj4gPiA+ID4gPiA+ID4gPiAr ICAgIG1pbkl0ZW1zOiAyDQo+ID4gPiA+ID4gPiA+ID4gKyAgICBkZWZhdWx0OiBbMzkwMDAwLCA0 XQ0KPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiBXaHkgZG8geW91IGhhdmUgdGhlIGxpbmsg ZnJlcXVlbmN5IGhlcmUgYXMgd2VsbD8NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gSW4g cHJpbmNpcGxlIHRoaXMgZG9lcyBiZWxvbmcgdG8gdGhlIGVuZHBvaW50IGFzIGxpbmsgZnJlcXVl bmNpZXMgYXJlDQo+ID4gPiA+ID4gPiA+IHNwZWNpZmljIHRvIHRoYXQsIGJ1dCBJIGRvbid0IG1p bmQ7IHRoZXJlJ3MganVzdCBhIHNpbmdsZSBwb3J0IGFueXdheS4NCj4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBUaGlzIGlzIGFuIG9wdGlvbmFsIHByb3BlcnR5IHdoaWNo IHdlIG1vZGVsIGFzIGFuIGFycmF5IG9mIDxsaW5rIHNwZWVkLA0KPiA+ID4gPiA+ID4gY2xvY2sg dm9sdGFnZT4gcGFpcnMuIEFuIGV4YW1wbGUgdG8gaGF2ZSBhbGwgbGluayBzcGVlZHMgdXAgdG8g MzkwTUh6DQo+ID4gPiA+ID4gPiB1c2UgdGhlIHZhbHVlIDQgZm9yIGN1cnJlbnQgZHJpdmVyLiBJ ZiBvbmUgd2FudHMgdG8gc2VsZWN0IGRpZmZlcmVudA0KPiA+ID4gPiA+ID4gdm9sdGFnZSBmb3Ig ZGlmZmVyZW50IGxpbmssIHRoZXkgY291bGQgZG8gc28gYXMgd2VsbC4NCj4gPiA+ID4gPg0KPiA+ ID4gPiA+IElmIHlvdSB0aGluayB5b3UnZCBuZWVkIHRoYXQsIHRoZW4geW91IG5lZWQgdG8gcHV0 IHRoaXMgdG8gdGhlIGVuZHBvaW50Lg0KPiA+ID4gPg0KPiA+ID4gPiBUaGUgbWlwaS1jbG9jay12 b2x0YWdlIHByb3BlcnR5IGlzIG5vdCBhIHByb3BlcnR5IG9mIHRoZSBlbmRwb2ludC4gVGhlDQo+ ID4gPiA+IGxpbmsgZnJlcXVlbmN5IHRoZXJlIGRvZXMgbm90IHNldCB0aGUgbGluayBmcmVxdWVu Y3kgLSBpdCBvbmx5DQo+ID4gPiA+IHNwZWNpZmllcyB3aGljaCBsaW5rIGZyZXF1ZW5jeSB0aGUg Z2l2ZW4gdm9sdGFnZSBzaG91bGQgYmUgdXNlZCBmb3IuDQo+ID4gPg0KPiA+ID4gSWYgaXQgaXMg bm90IGJvdW5kIHRvIHRoZSBlbmRwb2ludCAtLS0gdGhhdCBzcGVjaWZpZXMgdGhlIHByb3BlcnRp ZXMgb2YgdGhlDQo+ID4gPiBsaW5rIC0tLSB0aGVuIHlvdSBjb3VsZCBqdXN0IHB1dCBpdCB0byB0 aGUgZHJpdmVyLCBjb3VsZG4ndCB5b3U/DQo+ID4gPg0KPiA+ID4gQnV0IGVhcmxpZXIgb24sIHdl IGVzdGFibGlzaGVkIHRoYXQgdGhpcyBpcyBzcGVjaWZpYyB0byBhIGdpdmVuIGJvYXJkLCBvciBh DQo+ID4gPiBnaXZlbiBsaW5rLiBFbmRwb2ludHMgYXJlIHVzZWQgdG8gZGVzY3JpYmUgY29ubmVj dGlvbnMgdGhhdCBhIGRldmljZSBtYXkNCj4gPiA+IGhhdmUgdG8gb3RoZXIgZGV2aWNlcy4gVGhl cmVmb3JlIHRoZWlyIHByb3BlcnRpZXMgYXJlIGRpZmZlcmVudC4NCj4gPiA+DQo+ID4gPiBUaGUg Z3JhcGggYmluZGluZ3MgYWxsb3cgZm9yIHNldmVyYWwgZW5kcG9pbnRzIG9uIGEgc2luZ2xlIHBo eXNpY2FsIHBvcnQsDQo+ID4gPiBzb21lIG1heSBiZSBkaXNhYmxlZCBpbiB0aGF0IGNhc2UuIFRo aXMgaXMgYWRtaXR0ZWRseSBtb3N0bHkgZG9uZSB3aXRoDQo+ID4gPiBDU0ktMiByZWNlaXZlcnMu DQo+ID4gPg0KPiA+ID4gRWl0aGVyIHdheSwgcHV0dGluZyB0aGlzIHByb3BlcnR5IHRvIHRoZSBk ZXZpY2UgbWF5IGFmZmVjdCBob3cgRFQgc291cmNlIGlzDQo+ID4gPiBhcnJhbmdlZCBmb3IgYm9h cmRzIHRoYXQgaGF2ZSB0aGlzIGRldmljZS4gQW55IHNpbWlsYXIgY29uZmlndXJhdGlvbiBvbg0K PiA+ID4gb3RoZXIgZGV2aWNlcyB3aXRoIG11bHRpcGxlIHRyYW5zbWl0dGVycyBvciByZWNlaXZl cnMgd291bGQgYmUgaW4gZW5kcG9pbnRzDQo+ID4gPiBhbnl3YXkgLS0tIGJlY2F1c2UgdGhleSBo YXZlIHRvLCBzbyBJIGRvbid0IHNlZSB3aHkgYmluZGluZ3MgZm9yIHRoaXMNCj4gPiA+IGRldmlj ZSBzaG91bGQgYmUgZGlmZmVyZW50Lg0KPiA+ID4NCj4gPiA+IElmIHlvdSBwdXQgaXQgdG8gZW5k cG9pbnQsIHRoZSBkcml2ZXIgYWxzbyBkb2Vzbid0IG5lZWQgdG8gbWF0Y2ggdGhlIGxpbmsNCj4g PiA+IGZyZXF1ZW5jaWVzIGluIGtIeiBhbmQgSHogYmV0d2VlbiB0aGUgdHdvIHByb3BlcnRpZXMs IGJ1dCBqdXN0IHVzZSB0aGUgc2FtZQ0KPiA+ID4gaW5kZXggZm9yIGJvdGguDQo+ID4gDQo+ID4g SSBhZ3JlZSBpbiBnZW5lcmFsLCBidXQgSSB0aGluayBpbiB0aGlzIGNhc2UgdGhpcyBpcyBhIGRl dmljZS1zcGVjaWZpYw0KPiA+IHByb3BlcnR5IGFuZCB0aGUgc2Vuc29yIG9ubHkgaGFzIDEgQ1NJ LTIgaW50ZXJmYWNlLCBzbyBtYXliZSBpdA0KPiA+IGRvZXNuJ3QgcmVhbGx5IG1hdHRlcj8NCj4g PiANCj4gPiBTcGVjaWZ5aW5nIGZyZXF1ZW5jeSwgdm9sdGFnZSBwYWlycyBpcyBhIGNvbW1vbiBw cmFjdGljZSBpbiBvdGhlcg0KPiA+IGJpbmRpbmdzLCBzdWNoIGFzIHRoZSBPUFAgYmluZGluZ3Ms IGJ5IHRoZSB3YXkuDQo+ID4gDQo+ID4gVGhhdCBzYWlkLCBpZiB5b3UgaW5zaXN0LCBJJ20gZmlu ZSB3aXRoIHRoaXMgYmVpbmcgbW92ZWQgdG8gdGhlDQo+ID4gZW5kcG9pbnQgbm9kZSB0b28uDQo+ IA0KPiBQbGVhc2UsIHVubGVzcyB0aGVyZSBhcmUgc291bmQgdGVjaG5pY2FsIHJlYXNvbnMgdG8g ZG8gb3RoZXJ3aXNlLg0KPiANCg0KU29ycnkgZm9yIHRoZSBsYXRlIHJlcGx5Lg0KDQpJbiBmYWN0 IEknbSBzdGlsbCB3b25kZXIgd2hldGhlciAnTUlQSSBjbG9jayB2b2x0YWdlIHVuaXQnIGhlcmUg aXMgYQ0KdmVyeSBjb21tb24gb3IgbWVhbmluZ2Z1bCBwcm9wZXJ0eSB0aGF0IG5lZWRzIHRvIGJl IG1vdmVkIHRvIHRoZQ0KZW5kcG9pbnQgZGF0YSBzdHJ1Y3R1cmUgaW4gdjRsMiBmcmFtZXdvcmsu IEp1c3QgYmVjYXVzZSBpdCByZWxhdGVzIHRvDQpsaW5rIGZyZXF1ZW5jeT8NCg0KSW4gYW5vdGhl ciB3b3JkcywgaWYgd2Ugc2V0IGNsb2NrIHZvbHRhZ2UgYXMgYSBzZXBhcmF0ZSBwcm9wZXJ0eSwg YXMNCnBhdGNoc2V0IDEzIG9yIGVhcmxpZXIgdmVyc2lvbiBwcmVzZW50cywgaXMgdGhlcmUgbm8g bmVlZCB0byBtb3ZlIHRoZQ0KcG9zaXRpb24/DQoNCg==