From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8ACC2D0E4 for ; Thu, 19 Nov 2020 13:43:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DFBD206D5 for ; Thu, 19 Nov 2020 13:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gsf4Wu4b"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IaY5ZYdl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DFBD206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wog/WU88gvESBHew7KMJYpvyDfx1dxrFkjPLKdUwcmg=; b=Gsf4Wu4bGy1A2eB40EfRCe/Hq hyREQf+lBwW+UbNF/lsFDZOJJMd/E1WNB1I3NY4hXQwC7zrLezRFwpYZcIfkZSLol18AfdMB6KPtL 6ePDQd5srDwQDhoPNukik3j8TAjNY6V3UcKxAKp5ed5ePYDnWllb5cVv4GArKmuenylDenIUg/NqK 7cs7WvsaHoh7NPc+t0AR5FuyqLPiSG2MCFQyOgAyHQRb6by+4ycHdMMgtVl+X69dBEgwRuqmxynTJ hlknTNCaRSNBc+tpOkkHyLvVYe5503pMQMckrilt0sPRHuzT/M1rAp2kbx+npJhvxowwHy8G//dgA Qubp9hmrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfkDY-0002A3-Dz; Thu, 19 Nov 2020 13:43:20 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfkDP-00026W-IU; Thu, 19 Nov 2020 13:43:12 +0000 X-UUID: 90f25ee3c8a14fa89136f597c95b4883-20201119 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=f+40F60WpF0RZTPE/zrEdYD2XiyfhWpsYsOzRWiBkB8=; b=IaY5ZYdlfEnGZ1UYxohbkFYvMeYXEsWBRo1RGp6SUtKGLiXoL1QhU5/kiZevF9mdakSzeBCF5Th7nC6W6lAG1znaoEkWhFgy7kzICYW9798X5Jw0Ws0XIQXD5Rk33UDMSG0/gczUt7+WrCUr7FLTF//1ejweY8NWg5aaMP3p9kM=; X-UUID: 90f25ee3c8a14fa89136f597c95b4883-20201119 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 553868426; Thu, 19 Nov 2020 05:43:04 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 05:40:32 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 21:40:18 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 Nov 2020 21:40:18 +0800 Message-ID: <1605793218.20463.5.camel@mtkswgap22> Subject: Re: [PATCH v8 1/3] cpufreq: mediatek-hw: Add support for CPUFREQ HW From: Hector Yuan To: Lukasz Luba Date: Thu, 19 Nov 2020 21:40:18 +0800 In-Reply-To: <9382b917-f20d-c7b5-42e4-46d11465073f@arm.com> References: <1603700349-5922-1-git-send-email-hector.yuan@mediatek.com> <1603700349-5922-2-git-send-email-hector.yuan@mediatek.com> <9382b917-f20d-c7b5-42e4-46d11465073f@arm.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_084311_770837_22E772F3 X-CRM114-Status: GOOD ( 21.25 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ulf Hansson , Florian Fainelli , wsd_upstream@mediatek.com, Dave Gerlach , linux-pm@vger.kernel.org, Stephen Boyd , Viresh Kumar , Santosh Shilimkar , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Maxime Ripard , Rob Herring , linux-mediatek@lists.infradead.org, Amit Kucheria , Sudeep Holla , Lorenzo Pieralisi , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-11-19 at 12:41 +0000, Lukasz Luba wrote: > Hi Hector, > > On 10/26/20 8:19 AM, Hector Yuan wrote: > > From: "Hector.Yuan" > > > > Add cpufreq HW support. > > > > Signed-off-by: Hector.Yuan > > [snip] > > > + > > +static int mtk_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) > > +{ > > + struct cpufreq_mtk *c; > > + struct device *cpu_dev; > > + struct em_data_callback em_cb = EM_DATA_CB(mtk_cpufreq_get_cpu_power); > > + struct pm_qos_request *qos_request; > > + int sig, pwr_hw = CPUFREQ_HW_STATUS | SVS_HW_STATUS; > > + > > + qos_request = kzalloc(sizeof(*qos_request), GFP_KERNEL); > > + if (!qos_request) > > + return -ENOMEM; > > + > > + cpu_dev = get_cpu_device(policy->cpu); > > + if (!cpu_dev) { > > + pr_err("failed to get cpu%d device\n", policy->cpu); > > + return -ENODEV; > > + } > > + > > + c = mtk_freq_domain_map[policy->cpu]; > > + if (!c) { > > + pr_err("No scaling support for CPU%d\n", policy->cpu); > > + return -ENODEV; > > + } > > + > > + cpumask_copy(policy->cpus, &c->related_cpus); > > + > > + policy->freq_table = c->table; > > + policy->driver_data = c; > > To control frequency transition rate in schedutil, you might > be interested in setting: > > policy->cpuinfo.transition_latency = ; > > Example, when this latency value comes from FW [1] > OK, I will add it in v9. > > + > > + /* Let CPUs leave idle-off state for SVS CPU initializing */ > > + cpu_latency_qos_add_request(qos_request, 0); > > + > > + /* HW should be in enabled state to proceed now */ > > + writel_relaxed(0x1, c->reg_bases[REG_FREQ_ENABLE]); > > + > > + if (readl_poll_timeout(c->reg_bases[REG_FREQ_HW_STATE], sig, > > + (sig & pwr_hw) == pwr_hw, POLL_USEC, > > + TIMEOUT_USEC)) { > > + if (!(sig & CPUFREQ_HW_STATUS)) { > > + pr_info("cpufreq hardware of CPU%d is not enabled\n", > > + policy->cpu); > > + return -ENODEV; > > + } > > + > > + pr_info("SVS of CPU%d is not enabled\n", policy->cpu); > > + } > > + > > + em_dev_register_perf_domain(cpu_dev, c->nr_opp, &em_cb, policy->cpus); > > Please keep in mind that this is going to be changed soon with a new > argument: 'milliwatts'. It's queued in pm/linux-next [2]. > OK, thanks for the remind. > Regards, > Lukasz > > [1] > https://elixir.bootlin.com/linux/latest/source/drivers/cpufreq/scmi-cpufreq.c#L194 > [2] > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=c250d50fe2ce627ca9805d9c8ac11cbbf922a4a6 > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F592C63697 for ; Thu, 19 Nov 2020 13:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AB2422255 for ; Thu, 19 Nov 2020 13:40:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IaY5ZYdl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbgKSNkc (ORCPT ); Thu, 19 Nov 2020 08:40:32 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:43512 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726407AbgKSNkc (ORCPT ); Thu, 19 Nov 2020 08:40:32 -0500 X-UUID: b34cd89420d04ec99fd42f4f533ccb8e-20201119 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=f+40F60WpF0RZTPE/zrEdYD2XiyfhWpsYsOzRWiBkB8=; b=IaY5ZYdlfEnGZ1UYxohbkFYvMeYXEsWBRo1RGp6SUtKGLiXoL1QhU5/kiZevF9mdakSzeBCF5Th7nC6W6lAG1znaoEkWhFgy7kzICYW9798X5Jw0Ws0XIQXD5Rk33UDMSG0/gczUt7+WrCUr7FLTF//1ejweY8NWg5aaMP3p9kM=; X-UUID: b34cd89420d04ec99fd42f4f533ccb8e-20201119 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1081661305; Thu, 19 Nov 2020 21:40:22 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 21:40:18 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 Nov 2020 21:40:18 +0800 Message-ID: <1605793218.20463.5.camel@mtkswgap22> Subject: Re: [PATCH v8 1/3] cpufreq: mediatek-hw: Add support for CPUFREQ HW From: Hector Yuan To: Lukasz Luba CC: , , , "Rob Herring" , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Maxime Ripard , Santosh Shilimkar , Amit Kucheria , Stephen Boyd , Ulf Hansson , Dave Gerlach , Florian Fainelli , Robin Murphy , Lorenzo Pieralisi , , , Date: Thu, 19 Nov 2020 21:40:18 +0800 In-Reply-To: <9382b917-f20d-c7b5-42e4-46d11465073f@arm.com> References: <1603700349-5922-1-git-send-email-hector.yuan@mediatek.com> <1603700349-5922-2-git-send-email-hector.yuan@mediatek.com> <9382b917-f20d-c7b5-42e4-46d11465073f@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org T24gVGh1LCAyMDIwLTExLTE5IGF0IDEyOjQxICswMDAwLCBMdWthc3ogTHViYSB3cm90ZToNCj4g SGkgSGVjdG9yLA0KPiANCj4gT24gMTAvMjYvMjAgODoxOSBBTSwgSGVjdG9yIFl1YW4gd3JvdGU6 DQo+ID4gRnJvbTogIkhlY3Rvci5ZdWFuIiA8aGVjdG9yLnl1YW5AbWVkaWF0ZWsuY29tPg0KPiA+ IA0KPiA+IEFkZCBjcHVmcmVxIEhXIHN1cHBvcnQuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTog SGVjdG9yLll1YW4gPGhlY3Rvci55dWFuQG1lZGlhdGVrLmNvbT4NCj4gDQo+IFtzbmlwXQ0KPiAN Cj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgbXRrX2NwdWZyZXFfaHdfY3B1X2luaXQoc3RydWN0IGNw dWZyZXFfcG9saWN5ICpwb2xpY3kpDQo+ID4gK3sNCj4gPiArCXN0cnVjdCBjcHVmcmVxX210ayAq YzsNCj4gPiArCXN0cnVjdCBkZXZpY2UgKmNwdV9kZXY7DQo+ID4gKwlzdHJ1Y3QgZW1fZGF0YV9j YWxsYmFjayBlbV9jYiA9IEVNX0RBVEFfQ0IobXRrX2NwdWZyZXFfZ2V0X2NwdV9wb3dlcik7DQo+ ID4gKwlzdHJ1Y3QgcG1fcW9zX3JlcXVlc3QgKnFvc19yZXF1ZXN0Ow0KPiA+ICsJaW50IHNpZywg cHdyX2h3ID0gQ1BVRlJFUV9IV19TVEFUVVMgfCBTVlNfSFdfU1RBVFVTOw0KPiA+ICsNCj4gPiAr CXFvc19yZXF1ZXN0ID0ga3phbGxvYyhzaXplb2YoKnFvc19yZXF1ZXN0KSwgR0ZQX0tFUk5FTCk7 DQo+ID4gKwlpZiAoIXFvc19yZXF1ZXN0KQ0KPiA+ICsJCXJldHVybiAtRU5PTUVNOw0KPiA+ICsN Cj4gPiArCWNwdV9kZXYgPSBnZXRfY3B1X2RldmljZShwb2xpY3ktPmNwdSk7DQo+ID4gKwlpZiAo IWNwdV9kZXYpIHsNCj4gPiArCQlwcl9lcnIoImZhaWxlZCB0byBnZXQgY3B1JWQgZGV2aWNlXG4i LCBwb2xpY3ktPmNwdSk7DQo+ID4gKwkJcmV0dXJuIC1FTk9ERVY7DQo+ID4gKwl9DQo+ID4gKw0K PiA+ICsJYyA9IG10a19mcmVxX2RvbWFpbl9tYXBbcG9saWN5LT5jcHVdOw0KPiA+ICsJaWYgKCFj KSB7DQo+ID4gKwkJcHJfZXJyKCJObyBzY2FsaW5nIHN1cHBvcnQgZm9yIENQVSVkXG4iLCBwb2xp Y3ktPmNwdSk7DQo+ID4gKwkJcmV0dXJuIC1FTk9ERVY7DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICsJ Y3B1bWFza19jb3B5KHBvbGljeS0+Y3B1cywgJmMtPnJlbGF0ZWRfY3B1cyk7DQo+ID4gKw0KPiA+ ICsJcG9saWN5LT5mcmVxX3RhYmxlID0gYy0+dGFibGU7DQo+ID4gKwlwb2xpY3ktPmRyaXZlcl9k YXRhID0gYzsNCj4gDQo+IFRvIGNvbnRyb2wgZnJlcXVlbmN5IHRyYW5zaXRpb24gcmF0ZSBpbiBz Y2hlZHV0aWwsIHlvdSBtaWdodA0KPiBiZSBpbnRlcmVzdGVkIGluIHNldHRpbmc6DQo+IA0KPiBw b2xpY3ktPmNwdWluZm8udHJhbnNpdGlvbl9sYXRlbmN5ID0gPG10a192YWx1ZV9oZXJlPjsNCj4g DQo+IEV4YW1wbGUsIHdoZW4gdGhpcyBsYXRlbmN5IHZhbHVlIGNvbWVzIGZyb20gRlcgWzFdDQo+ IA0KT0ssIEkgd2lsbCBhZGQgaXQgaW4gdjkuDQo+ID4gKw0KPiA+ICsJLyogTGV0IENQVXMgbGVh dmUgaWRsZS1vZmYgc3RhdGUgZm9yIFNWUyBDUFUgaW5pdGlhbGl6aW5nICovDQo+ID4gKwljcHVf bGF0ZW5jeV9xb3NfYWRkX3JlcXVlc3QocW9zX3JlcXVlc3QsIDApOw0KPiA+ICsNCj4gPiArCS8q IEhXIHNob3VsZCBiZSBpbiBlbmFibGVkIHN0YXRlIHRvIHByb2NlZWQgbm93ICovDQo+ID4gKwl3 cml0ZWxfcmVsYXhlZCgweDEsIGMtPnJlZ19iYXNlc1tSRUdfRlJFUV9FTkFCTEVdKTsNCj4gPiAr DQo+ID4gKwlpZiAocmVhZGxfcG9sbF90aW1lb3V0KGMtPnJlZ19iYXNlc1tSRUdfRlJFUV9IV19T VEFURV0sIHNpZywNCj4gPiArCQkJICAgICAgIChzaWcgJiBwd3JfaHcpID09IHB3cl9odywgUE9M TF9VU0VDLA0KPiA+ICsJCQkgICAgICAgVElNRU9VVF9VU0VDKSkgew0KPiA+ICsJCWlmICghKHNp ZyAmIENQVUZSRVFfSFdfU1RBVFVTKSkgew0KPiA+ICsJCQlwcl9pbmZvKCJjcHVmcmVxIGhhcmR3 YXJlIG9mIENQVSVkIGlzIG5vdCBlbmFibGVkXG4iLA0KPiA+ICsJCQkJcG9saWN5LT5jcHUpOw0K PiA+ICsJCQlyZXR1cm4gLUVOT0RFVjsNCj4gPiArCQl9DQo+ID4gKw0KPiA+ICsJCXByX2luZm8o IlNWUyBvZiBDUFUlZCBpcyBub3QgZW5hYmxlZFxuIiwgcG9saWN5LT5jcHUpOw0KPiA+ICsJfQ0K PiA+ICsNCj4gPiArCWVtX2Rldl9yZWdpc3Rlcl9wZXJmX2RvbWFpbihjcHVfZGV2LCBjLT5ucl9v cHAsICZlbV9jYiwgcG9saWN5LT5jcHVzKTsNCj4gDQo+IFBsZWFzZSBrZWVwIGluIG1pbmQgdGhh dCB0aGlzIGlzIGdvaW5nIHRvIGJlIGNoYW5nZWQgc29vbiB3aXRoIGEgbmV3DQo+IGFyZ3VtZW50 OiAnbWlsbGl3YXR0cycuIEl0J3MgcXVldWVkIGluIHBtL2xpbnV4LW5leHQgWzJdLg0KPiANCk9L LCB0aGFua3MgZm9yIHRoZSByZW1pbmQuDQo+IFJlZ2FyZHMsDQo+IEx1a2Fzeg0KPiANCj4gWzFd IA0KPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291cmNlL2RyaXZl cnMvY3B1ZnJlcS9zY21pLWNwdWZyZXEuYyNMMTk0DQo+IFsyXSANCj4gaHR0cHM6Ly9naXQua2Vy bmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvcmFmYWVsL2xpbnV4LXBtLmdpdC9jb21t aXQvP2g9bGludXgtbmV4dCZpZD1jMjUwZDUwZmUyY2U2MjdjYTk4MDVkOWM4YWMxMWNiYmY5MjJh NGE2DQo+IA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D97BC63697 for ; Thu, 19 Nov 2020 13:43:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CC91206D5 for ; Thu, 19 Nov 2020 13:43:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wl5OlPJr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IaY5ZYdl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC91206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v3ILc9x5fVcgBxkQ9owopVbK+YDUaGZZTwNU2LQepRQ=; b=Wl5OlPJrE5JXR9zBzm2DCm7kX ccFZvqoVYqMN6911afj5TXdef0uZbMrDhm4K8Ko12OnDbI314QKYSxAPNqyHuIu10QDhaGnOgvcul MD81NfQ5zN2sFagNHY42MyUy9/LJxNbLfcMNbbRxgWaS3Cs1h36wUtIRId8mFsXo3o/k9XLgAnDNt xRNVY1pali0WuXHiaQ1cGuNATrEwyFoHk0hj3UFf31vLiliV/DIIzK0EwZN2nlZIC6oibnt+ie6az lRnwN5et4ZEbkZW+7X/dI05NpXVI3Cq/32Hl1bBn3EMtwMDJpFaBpIAsGYVuZlqjlUHK8ia07/Cvc O/EBA4Nlw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfkDT-00028o-4j; Thu, 19 Nov 2020 13:43:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfkDP-00026W-IU; Thu, 19 Nov 2020 13:43:12 +0000 X-UUID: 90f25ee3c8a14fa89136f597c95b4883-20201119 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=f+40F60WpF0RZTPE/zrEdYD2XiyfhWpsYsOzRWiBkB8=; b=IaY5ZYdlfEnGZ1UYxohbkFYvMeYXEsWBRo1RGp6SUtKGLiXoL1QhU5/kiZevF9mdakSzeBCF5Th7nC6W6lAG1znaoEkWhFgy7kzICYW9798X5Jw0Ws0XIQXD5Rk33UDMSG0/gczUt7+WrCUr7FLTF//1ejweY8NWg5aaMP3p9kM=; X-UUID: 90f25ee3c8a14fa89136f597c95b4883-20201119 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 553868426; Thu, 19 Nov 2020 05:43:04 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 05:40:32 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Nov 2020 21:40:18 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 Nov 2020 21:40:18 +0800 Message-ID: <1605793218.20463.5.camel@mtkswgap22> Subject: Re: [PATCH v8 1/3] cpufreq: mediatek-hw: Add support for CPUFREQ HW From: Hector Yuan To: Lukasz Luba Date: Thu, 19 Nov 2020 21:40:18 +0800 In-Reply-To: <9382b917-f20d-c7b5-42e4-46d11465073f@arm.com> References: <1603700349-5922-1-git-send-email-hector.yuan@mediatek.com> <1603700349-5922-2-git-send-email-hector.yuan@mediatek.com> <9382b917-f20d-c7b5-42e4-46d11465073f@arm.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_084311_770837_22E772F3 X-CRM114-Status: GOOD ( 21.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ulf Hansson , Florian Fainelli , wsd_upstream@mediatek.com, Dave Gerlach , linux-pm@vger.kernel.org, Stephen Boyd , Viresh Kumar , Santosh Shilimkar , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Maxime Ripard , Rob Herring , linux-mediatek@lists.infradead.org, Amit Kucheria , Sudeep Holla , Lorenzo Pieralisi , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-11-19 at 12:41 +0000, Lukasz Luba wrote: > Hi Hector, > > On 10/26/20 8:19 AM, Hector Yuan wrote: > > From: "Hector.Yuan" > > > > Add cpufreq HW support. > > > > Signed-off-by: Hector.Yuan > > [snip] > > > + > > +static int mtk_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) > > +{ > > + struct cpufreq_mtk *c; > > + struct device *cpu_dev; > > + struct em_data_callback em_cb = EM_DATA_CB(mtk_cpufreq_get_cpu_power); > > + struct pm_qos_request *qos_request; > > + int sig, pwr_hw = CPUFREQ_HW_STATUS | SVS_HW_STATUS; > > + > > + qos_request = kzalloc(sizeof(*qos_request), GFP_KERNEL); > > + if (!qos_request) > > + return -ENOMEM; > > + > > + cpu_dev = get_cpu_device(policy->cpu); > > + if (!cpu_dev) { > > + pr_err("failed to get cpu%d device\n", policy->cpu); > > + return -ENODEV; > > + } > > + > > + c = mtk_freq_domain_map[policy->cpu]; > > + if (!c) { > > + pr_err("No scaling support for CPU%d\n", policy->cpu); > > + return -ENODEV; > > + } > > + > > + cpumask_copy(policy->cpus, &c->related_cpus); > > + > > + policy->freq_table = c->table; > > + policy->driver_data = c; > > To control frequency transition rate in schedutil, you might > be interested in setting: > > policy->cpuinfo.transition_latency = ; > > Example, when this latency value comes from FW [1] > OK, I will add it in v9. > > + > > + /* Let CPUs leave idle-off state for SVS CPU initializing */ > > + cpu_latency_qos_add_request(qos_request, 0); > > + > > + /* HW should be in enabled state to proceed now */ > > + writel_relaxed(0x1, c->reg_bases[REG_FREQ_ENABLE]); > > + > > + if (readl_poll_timeout(c->reg_bases[REG_FREQ_HW_STATE], sig, > > + (sig & pwr_hw) == pwr_hw, POLL_USEC, > > + TIMEOUT_USEC)) { > > + if (!(sig & CPUFREQ_HW_STATUS)) { > > + pr_info("cpufreq hardware of CPU%d is not enabled\n", > > + policy->cpu); > > + return -ENODEV; > > + } > > + > > + pr_info("SVS of CPU%d is not enabled\n", policy->cpu); > > + } > > + > > + em_dev_register_perf_domain(cpu_dev, c->nr_opp, &em_cb, policy->cpus); > > Please keep in mind that this is going to be changed soon with a new > argument: 'milliwatts'. It's queued in pm/linux-next [2]. > OK, thanks for the remind. > Regards, > Lukasz > > [1] > https://elixir.bootlin.com/linux/latest/source/drivers/cpufreq/scmi-cpufreq.c#L194 > [2] > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=c250d50fe2ce627ca9805d9c8ac11cbbf922a4a6 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel