From: patchwork-bot+netdevbpf@kernel.org
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: kuba@kernel.org, davem@davemloft.net, nic_swsd@realtek.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: reduce number of workaround doorbell rings
Date: Sat, 21 Nov 2020 02:40:05 +0000 [thread overview]
Message-ID: <160592640524.13180.7708519953108227572.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <0a15a83c-aecf-ab51-8071-b29d9dcd529a@gmail.com>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Thu, 19 Nov 2020 21:57:27 +0100 you wrote:
> Some chip versions have a hw bug resulting in lost door bell rings.
> To work around this the doorbell is also rung whenever we still have
> tx descriptors in flight after having cleaned up tx descriptors.
> These PCI(e) writes come at a cost, therefore let's reduce the number
> of extra doorbell rings.
> If skb is NULL then this means:
> - last cleaned-up descriptor belongs to a skb with at least one fragment
> and last fragment isn't marked as sent yet
> - hw is in progress sending the skb, therefore no extra doorbell ring
> is needed for this skb
> - once last fragment is marked as transmitted hw will trigger
> a tx done interrupt and we come here again (with skb != NULL)
> and ring the doorbell if needed
> Therefore skip the workaround doorbell ring if skb is NULL.
>
> [...]
Here is the summary with links:
- [net-next] r8169: reduce number of workaround doorbell rings
https://git.kernel.org/netdev/net-next/c/94d8a98e6235
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2020-11-21 2:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 20:57 [PATCH net-next] r8169: reduce number of workaround doorbell rings Heiner Kallweit
2020-11-21 2:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160592640524.13180.7708519953108227572.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.