From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B9CC56202 for ; Wed, 25 Nov 2020 11:04:17 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 545F120665 for ; Wed, 25 Nov 2020 11:04:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Vy5FClWJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 545F120665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D9FB987541; Wed, 25 Nov 2020 11:04:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wovocPaBo3G4; Wed, 25 Nov 2020 11:04:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 7DA1487534; Wed, 25 Nov 2020 11:04:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 63AC9C0891; Wed, 25 Nov 2020 11:04:14 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id CCDC1C0052 for ; Wed, 25 Nov 2020 11:04:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id BBD5186E5A for ; Wed, 25 Nov 2020 11:04:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RuD96B+2nMI5 for ; Wed, 25 Nov 2020 11:04:08 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by whitealder.osuosl.org (Postfix) with ESMTP id 77FBD86A00 for ; Wed, 25 Nov 2020 11:03:45 +0000 (UTC) X-UUID: 0772767d57e343e6891beb8ab16b4e8e-20201125 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=xI/ceqZKKONm10j9fLWN04WfsGQ+Y6PfpXlP79ucbtc=; b=Vy5FClWJFnjQyR2mZzAmi3S6inaTOenZU3qhbvrxlXtKflmvFTy6blSm+77b7dpHtGZ3iPP21cHe4J/o2+EYEqhFX0NXMoKAj5iRO99L8uhKXaq/X7K1aZ1sCha+O5L0PmBAPQyTnynkabuPPr2SCqhXMSHQDL3iZHpLJkfkkY4=; X-UUID: 0772767d57e343e6891beb8ab16b4e8e-20201125 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 617537765; Wed, 25 Nov 2020 19:03:36 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Nov 2020 19:03:34 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 25 Nov 2020 19:03:33 +0800 Message-ID: <1606302214.26323.141.camel@mhfsdcap03> Subject: Re: [PATCH] iommu: Improve the performance for direct_mapping From: Yong Wu To: Will Deacon Date: Wed, 25 Nov 2020 19:03:34 +0800 In-Reply-To: <20201124110520.GA12980@willie-the-truck> References: <20201120090628.6566-1-yong.wu@mediatek.com> <20201123123258.GC10233@willie-the-truck> <1606209884.26323.132.camel@mhfsdcap03> <20201124110520.GA12980@willie-the-truck> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3E37F2948B73A16F8990BEF5FB644CD56B780219D1EF19A777FBD0308C48F13A2000:8 X-MTK: N Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , srv_heupstream@mediatek.com, Tomasz Figa , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , chao.hao@mediatek.com, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, 2020-11-24 at 11:05 +0000, Will Deacon wrote: > On Tue, Nov 24, 2020 at 05:24:44PM +0800, Yong Wu wrote: > > On Mon, 2020-11-23 at 12:32 +0000, Will Deacon wrote: > > > On Fri, Nov 20, 2020 at 05:06:28PM +0800, Yong Wu wrote: > > > > + unmapped_sz = 0; > > > > + } > > > > + start += pg_size; > > > > + } > > > > + if (unmapped_sz) { > > > > + ret = iommu_map(domain, start, start, unmapped_sz, > > > > + entry->prot); > > > > > > Can you avoid this hunk by changing your loop check to something like: > > > > > > if (!phys_addr) { > > > map_size += pg_size; > > > if (addr + pg_size < end) > > > continue; > > > } > > > > Thanks for your quick review. I have fixed and tested it. the patch is > > simple. I copy it here. Is this readable for you now? > > > > > > --- a/drivers/iommu/iommu.c > > +++ b/drivers/iommu/iommu.c > > @@ -737,6 +737,7 @@ static int > > iommu_create_device_direct_mappings(struct iommu_group *group, > > /* We need to consider overlapping regions for different devices */ > > list_for_each_entry(entry, &mappings, list) { > > dma_addr_t start, end, addr; > > + size_t map_size = 0; > > > > if (domain->ops->apply_resv_region) > > domain->ops->apply_resv_region(dev, domain, entry); > > @@ -752,12 +753,21 @@ static int > > iommu_create_device_direct_mappings(struct iommu_group *group, > > phys_addr_t phys_addr; > > > > phys_addr = iommu_iova_to_phys(domain, addr); > > - if (phys_addr) > > - continue; > > + if (!phys_addr) { > > + map_size += pg_size; > > + if (addr + pg_size < end) > > + continue; > > + else > > You don't need the 'else' here ^^^ > > > + addr += pg_size; /*Point to End */ > > addr = end ? > > That said, maybe we could simplify this further by changing the loop bounds > to be: > > for (addr = start; addr <= end; addr += pg_size) > > and checking: > > if (!phys_addr && addr != end) { > map_size += pg_size; > continue; > } > > does that work? It works but I think we can not check iommu_iova_to_phys(domain, end). We should add a "if", like: for (addr = start; addr <= end; addr += pg_size) { ... if (addr < end) { phys_addr = iommu_iova_to_phys(domain, addr); if (!phys_addr) { map_size += pg_size; continue; } } ... If you don't like this "if (addr < end)", then we have to add a "goto". like this: for (addr = start; addr <= end; addr += pg_size) { phys_addr_t phys_addr; if (addr == end) goto map_last; phys_addr = iommu_iova_to_phys(domain, addr); if (!phys_addr) { map_size += pg_size; continue; } map_last: if (!map_size) continue; ret = iommu_map(domain, addr - map_size, addr - map_size, map_size, entry->prot); if (ret) goto out; } Which one is better? > > Will > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C787C5519F for ; Wed, 25 Nov 2020 11:13:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DE23206B7 for ; Wed, 25 Nov 2020 11:13:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1PF+ofen"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Fk02J6x4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DE23206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5/lmIZRzx8rOgP3JyiTwe+O48hD2JdD4DgFaUhDJhMs=; b=1PF+ofencS6TSAksVmKBsVAzE Y9gDBgusnWvfjBpQ0feHCQ9plypu4BrWFHn9RUuCV4RAP7Y2IWkFbD9mwFaQfSclp0ok6O7U0vSSS 8StodkXoLt4flkt9X1mu3CJjkKQaUFsOieDWnPVZgCU9Dcok0AWQA2neKTbyVhnsBR8BnWQNWKNaO 2/Vo4OQShOKjBZ4DmyeDBCuXM0AFGvrt9QpBIkoMkZlU2RNUnoZXY4aW5JO8Ql2yDbtRH/+7QLEkd ojQtBKybvkvbCJSf/JUZlq/4uzErv4xY/cciOruPhA2dPxKVtj/bO6shZgBx0m0quq0DkyC5ZnuVS HsNXodvcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khskB-0007nQ-Ua; Wed, 25 Nov 2020 11:13:52 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khsk9-0007l5-D4; Wed, 25 Nov 2020 11:13:50 +0000 X-UUID: f3284587bf584583b6bfe09288cd2695-20201125 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=xI/ceqZKKONm10j9fLWN04WfsGQ+Y6PfpXlP79ucbtc=; b=Fk02J6x4gYEjQNlA9YmduD9VtFZEumjvhjw9/e55K8RlZ3n6s4XuiYYZmGU8WfxVKLa3z8OnHIJ42GpiZt7Q8QBp046nkh/qoaZF9Ca+0sHhqgJvOhdpTKr0NPzmPfSlCrfcWpFtQ88gnMj1q4uSaUH9i3dQqfrwTGk2K4xmzLk=; X-UUID: f3284587bf584583b6bfe09288cd2695-20201125 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 938886545; Wed, 25 Nov 2020 03:13:33 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Nov 2020 03:03:36 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Nov 2020 19:03:34 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 25 Nov 2020 19:03:33 +0800 Message-ID: <1606302214.26323.141.camel@mhfsdcap03> Subject: Re: [PATCH] iommu: Improve the performance for direct_mapping From: Yong Wu To: Will Deacon Date: Wed, 25 Nov 2020 19:03:34 +0800 In-Reply-To: <20201124110520.GA12980@willie-the-truck> References: <20201120090628.6566-1-yong.wu@mediatek.com> <20201123123258.GC10233@willie-the-truck> <1606209884.26323.132.camel@mhfsdcap03> <20201124110520.GA12980@willie-the-truck> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3E37F2948B73A16F8990BEF5FB644CD56B780219D1EF19A777FBD0308C48F13A2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201125_061349_667379_96755502 X-CRM114-Status: GOOD ( 28.67 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , srv_heupstream@mediatek.com, Tomasz Figa , Joerg Roedel , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , chao.hao@mediatek.com, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-11-24 at 11:05 +0000, Will Deacon wrote: > On Tue, Nov 24, 2020 at 05:24:44PM +0800, Yong Wu wrote: > > On Mon, 2020-11-23 at 12:32 +0000, Will Deacon wrote: > > > On Fri, Nov 20, 2020 at 05:06:28PM +0800, Yong Wu wrote: > > > > + unmapped_sz = 0; > > > > + } > > > > + start += pg_size; > > > > + } > > > > + if (unmapped_sz) { > > > > + ret = iommu_map(domain, start, start, unmapped_sz, > > > > + entry->prot); > > > > > > Can you avoid this hunk by changing your loop check to something like: > > > > > > if (!phys_addr) { > > > map_size += pg_size; > > > if (addr + pg_size < end) > > > continue; > > > } > > > > Thanks for your quick review. I have fixed and tested it. the patch is > > simple. I copy it here. Is this readable for you now? > > > > > > --- a/drivers/iommu/iommu.c > > +++ b/drivers/iommu/iommu.c > > @@ -737,6 +737,7 @@ static int > > iommu_create_device_direct_mappings(struct iommu_group *group, > > /* We need to consider overlapping regions for different devices */ > > list_for_each_entry(entry, &mappings, list) { > > dma_addr_t start, end, addr; > > + size_t map_size = 0; > > > > if (domain->ops->apply_resv_region) > > domain->ops->apply_resv_region(dev, domain, entry); > > @@ -752,12 +753,21 @@ static int > > iommu_create_device_direct_mappings(struct iommu_group *group, > > phys_addr_t phys_addr; > > > > phys_addr = iommu_iova_to_phys(domain, addr); > > - if (phys_addr) > > - continue; > > + if (!phys_addr) { > > + map_size += pg_size; > > + if (addr + pg_size < end) > > + continue; > > + else > > You don't need the 'else' here ^^^ > > > + addr += pg_size; /*Point to End */ > > addr = end ? > > That said, maybe we could simplify this further by changing the loop bounds > to be: > > for (addr = start; addr <= end; addr += pg_size) > > and checking: > > if (!phys_addr && addr != end) { > map_size += pg_size; > continue; > } > > does that work? It works but I think we can not check iommu_iova_to_phys(domain, end). We should add a "if", like: for (addr = start; addr <= end; addr += pg_size) { ... if (addr < end) { phys_addr = iommu_iova_to_phys(domain, addr); if (!phys_addr) { map_size += pg_size; continue; } } ... If you don't like this "if (addr < end)", then we have to add a "goto". like this: for (addr = start; addr <= end; addr += pg_size) { phys_addr_t phys_addr; if (addr == end) goto map_last; phys_addr = iommu_iova_to_phys(domain, addr); if (!phys_addr) { map_size += pg_size; continue; } map_last: if (!map_size) continue; ret = iommu_map(domain, addr - map_size, addr - map_size, map_size, entry->prot); if (ret) goto out; } Which one is better? > > Will > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A25DC5519F for ; Wed, 25 Nov 2020 11:15:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01592206B7 for ; Wed, 25 Nov 2020 11:15:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="traDXb/B"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Fk02J6x4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01592206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IPIJ8j2F07AsBebxujHe/1BIAF5eixJSi2oshak6u+4=; b=traDXb/B/A2FIQDq39484DuB9 haWyktPBVBBouWz+Az7pZ39o/TwNyTVdg2EACBXlmZISVqqBS4y6BYaC2X0OPOgXtHkoSGg2LxVYx t934FUnvoBtuWURM6opPH229jYCUO2kcBJil2ye4AhihvgIs/nOSJN/wRNsZQkIAeJ6ImkF9x466Y 2WOwFGrGCuD/kGdF5aBoIn5kmpRs9FLRRVNhuBD6417Lehd9IwCEsRlbu8ws7x2WOhir+xZShNNUS 4rphHWzbvolA53oatwU33Uo2gGVl9pCOWWcKi5LHoLC3P50g/oWK8ih6TQXu7jHfxXuLjycpR0FVt isVJJZGpg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khskC-0007nc-Ph; Wed, 25 Nov 2020 11:13:52 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khsk9-0007l5-D4; Wed, 25 Nov 2020 11:13:50 +0000 X-UUID: f3284587bf584583b6bfe09288cd2695-20201125 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=xI/ceqZKKONm10j9fLWN04WfsGQ+Y6PfpXlP79ucbtc=; b=Fk02J6x4gYEjQNlA9YmduD9VtFZEumjvhjw9/e55K8RlZ3n6s4XuiYYZmGU8WfxVKLa3z8OnHIJ42GpiZt7Q8QBp046nkh/qoaZF9Ca+0sHhqgJvOhdpTKr0NPzmPfSlCrfcWpFtQ88gnMj1q4uSaUH9i3dQqfrwTGk2K4xmzLk=; X-UUID: f3284587bf584583b6bfe09288cd2695-20201125 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 938886545; Wed, 25 Nov 2020 03:13:33 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Nov 2020 03:03:36 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Nov 2020 19:03:34 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 25 Nov 2020 19:03:33 +0800 Message-ID: <1606302214.26323.141.camel@mhfsdcap03> Subject: Re: [PATCH] iommu: Improve the performance for direct_mapping From: Yong Wu To: Will Deacon Date: Wed, 25 Nov 2020 19:03:34 +0800 In-Reply-To: <20201124110520.GA12980@willie-the-truck> References: <20201120090628.6566-1-yong.wu@mediatek.com> <20201123123258.GC10233@willie-the-truck> <1606209884.26323.132.camel@mhfsdcap03> <20201124110520.GA12980@willie-the-truck> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3E37F2948B73A16F8990BEF5FB644CD56B780219D1EF19A777FBD0308C48F13A2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201125_061349_667379_96755502 X-CRM114-Status: GOOD ( 28.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , srv_heupstream@mediatek.com, Tomasz Figa , Joerg Roedel , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , chao.hao@mediatek.com, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-11-24 at 11:05 +0000, Will Deacon wrote: > On Tue, Nov 24, 2020 at 05:24:44PM +0800, Yong Wu wrote: > > On Mon, 2020-11-23 at 12:32 +0000, Will Deacon wrote: > > > On Fri, Nov 20, 2020 at 05:06:28PM +0800, Yong Wu wrote: > > > > + unmapped_sz = 0; > > > > + } > > > > + start += pg_size; > > > > + } > > > > + if (unmapped_sz) { > > > > + ret = iommu_map(domain, start, start, unmapped_sz, > > > > + entry->prot); > > > > > > Can you avoid this hunk by changing your loop check to something like: > > > > > > if (!phys_addr) { > > > map_size += pg_size; > > > if (addr + pg_size < end) > > > continue; > > > } > > > > Thanks for your quick review. I have fixed and tested it. the patch is > > simple. I copy it here. Is this readable for you now? > > > > > > --- a/drivers/iommu/iommu.c > > +++ b/drivers/iommu/iommu.c > > @@ -737,6 +737,7 @@ static int > > iommu_create_device_direct_mappings(struct iommu_group *group, > > /* We need to consider overlapping regions for different devices */ > > list_for_each_entry(entry, &mappings, list) { > > dma_addr_t start, end, addr; > > + size_t map_size = 0; > > > > if (domain->ops->apply_resv_region) > > domain->ops->apply_resv_region(dev, domain, entry); > > @@ -752,12 +753,21 @@ static int > > iommu_create_device_direct_mappings(struct iommu_group *group, > > phys_addr_t phys_addr; > > > > phys_addr = iommu_iova_to_phys(domain, addr); > > - if (phys_addr) > > - continue; > > + if (!phys_addr) { > > + map_size += pg_size; > > + if (addr + pg_size < end) > > + continue; > > + else > > You don't need the 'else' here ^^^ > > > + addr += pg_size; /*Point to End */ > > addr = end ? > > That said, maybe we could simplify this further by changing the loop bounds > to be: > > for (addr = start; addr <= end; addr += pg_size) > > and checking: > > if (!phys_addr && addr != end) { > map_size += pg_size; > continue; > } > > does that work? It works but I think we can not check iommu_iova_to_phys(domain, end). We should add a "if", like: for (addr = start; addr <= end; addr += pg_size) { ... if (addr < end) { phys_addr = iommu_iova_to_phys(domain, addr); if (!phys_addr) { map_size += pg_size; continue; } } ... If you don't like this "if (addr < end)", then we have to add a "goto". like this: for (addr = start; addr <= end; addr += pg_size) { phys_addr_t phys_addr; if (addr == end) goto map_last; phys_addr = iommu_iova_to_phys(domain, addr); if (!phys_addr) { map_size += pg_size; continue; } map_last: if (!map_size) continue; ret = iommu_map(domain, addr - map_size, addr - map_size, map_size, entry->prot); if (ret) goto out; } Which one is better? > > Will > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A85BC5519F for ; Wed, 25 Nov 2020 11:03:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B74A3206E5 for ; Wed, 25 Nov 2020 11:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Vy5FClWJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727376AbgKYLDq (ORCPT ); Wed, 25 Nov 2020 06:03:46 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:27639 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726189AbgKYLDq (ORCPT ); Wed, 25 Nov 2020 06:03:46 -0500 X-UUID: 0772767d57e343e6891beb8ab16b4e8e-20201125 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=xI/ceqZKKONm10j9fLWN04WfsGQ+Y6PfpXlP79ucbtc=; b=Vy5FClWJFnjQyR2mZzAmi3S6inaTOenZU3qhbvrxlXtKflmvFTy6blSm+77b7dpHtGZ3iPP21cHe4J/o2+EYEqhFX0NXMoKAj5iRO99L8uhKXaq/X7K1aZ1sCha+O5L0PmBAPQyTnynkabuPPr2SCqhXMSHQDL3iZHpLJkfkkY4=; X-UUID: 0772767d57e343e6891beb8ab16b4e8e-20201125 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 617537765; Wed, 25 Nov 2020 19:03:36 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 Nov 2020 19:03:34 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 25 Nov 2020 19:03:33 +0800 Message-ID: <1606302214.26323.141.camel@mhfsdcap03> Subject: Re: [PATCH] iommu: Improve the performance for direct_mapping From: Yong Wu To: Will Deacon CC: , , Nicolas Boichat , , , Joerg Roedel , , Krzysztof Kozlowski , Tomasz Figa , , , Matthias Brugger , Robin Murphy , Date: Wed, 25 Nov 2020 19:03:34 +0800 In-Reply-To: <20201124110520.GA12980@willie-the-truck> References: <20201120090628.6566-1-yong.wu@mediatek.com> <20201123123258.GC10233@willie-the-truck> <1606209884.26323.132.camel@mhfsdcap03> <20201124110520.GA12980@willie-the-truck> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3E37F2948B73A16F8990BEF5FB644CD56B780219D1EF19A777FBD0308C48F13A2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVHVlLCAyMDIwLTExLTI0IGF0IDExOjA1ICswMDAwLCBXaWxsIERlYWNvbiB3cm90ZToNCj4g T24gVHVlLCBOb3YgMjQsIDIwMjAgYXQgMDU6MjQ6NDRQTSArMDgwMCwgWW9uZyBXdSB3cm90ZToN Cj4gPiBPbiBNb24sIDIwMjAtMTEtMjMgYXQgMTI6MzIgKzAwMDAsIFdpbGwgRGVhY29uIHdyb3Rl Og0KPiA+ID4gT24gRnJpLCBOb3YgMjAsIDIwMjAgYXQgMDU6MDY6MjhQTSArMDgwMCwgWW9uZyBX dSB3cm90ZToNCj4gPiA+ID4gKwkJCQl1bm1hcHBlZF9zeiA9IDA7DQo+ID4gPiA+ICsJCQl9DQo+ ID4gPiA+ICsJCQlzdGFydCArPSBwZ19zaXplOw0KPiA+ID4gPiArCQl9DQo+ID4gPiA+ICsJCWlm ICh1bm1hcHBlZF9zeikgew0KPiA+ID4gPiArCQkJcmV0ID0gaW9tbXVfbWFwKGRvbWFpbiwgc3Rh cnQsIHN0YXJ0LCB1bm1hcHBlZF9zeiwNCj4gPiA+ID4gKwkJCQkJZW50cnktPnByb3QpOw0KPiA+ ID4gDQo+ID4gPiBDYW4geW91IGF2b2lkIHRoaXMgaHVuayBieSBjaGFuZ2luZyB5b3VyIGxvb3Ag Y2hlY2sgdG8gc29tZXRoaW5nIGxpa2U6DQo+ID4gPiANCj4gPiA+IAlpZiAoIXBoeXNfYWRkcikg ew0KPiA+ID4gCQltYXBfc2l6ZSArPSBwZ19zaXplOw0KPiA+ID4gCQlpZiAoYWRkciArIHBnX3Np emUgPCBlbmQpDQo+ID4gPiAJCQljb250aW51ZTsNCj4gPiA+IAl9DQo+ID4gDQo+ID4gVGhhbmtz IGZvciB5b3VyIHF1aWNrIHJldmlldy4gSSBoYXZlIGZpeGVkIGFuZCB0ZXN0ZWQgaXQuIHRoZSBw YXRjaCBpcw0KPiA+IHNpbXBsZS4gSSBjb3B5IGl0IGhlcmUuIElzIHRoaXMgcmVhZGFibGUgZm9y IHlvdSBub3c/DQo+ID4gDQo+ID4gDQo+ID4gLS0tIGEvZHJpdmVycy9pb21tdS9pb21tdS5jDQo+ ID4gKysrIGIvZHJpdmVycy9pb21tdS9pb21tdS5jDQo+ID4gQEAgLTczNyw2ICs3MzcsNyBAQCBz dGF0aWMgaW50DQo+ID4gaW9tbXVfY3JlYXRlX2RldmljZV9kaXJlY3RfbWFwcGluZ3Moc3RydWN0 IGlvbW11X2dyb3VwICpncm91cCwNCj4gPiAgCS8qIFdlIG5lZWQgdG8gY29uc2lkZXIgb3Zlcmxh cHBpbmcgcmVnaW9ucyBmb3IgZGlmZmVyZW50IGRldmljZXMgKi8NCj4gPiAgCWxpc3RfZm9yX2Vh Y2hfZW50cnkoZW50cnksICZtYXBwaW5ncywgbGlzdCkgew0KPiA+ICAJCWRtYV9hZGRyX3Qgc3Rh cnQsIGVuZCwgYWRkcjsNCj4gPiArCQlzaXplX3QgbWFwX3NpemUgPSAwOw0KPiA+ICANCj4gPiAg CQlpZiAoZG9tYWluLT5vcHMtPmFwcGx5X3Jlc3ZfcmVnaW9uKQ0KPiA+ICAJCQlkb21haW4tPm9w cy0+YXBwbHlfcmVzdl9yZWdpb24oZGV2LCBkb21haW4sIGVudHJ5KTsNCj4gPiBAQCAtNzUyLDEy ICs3NTMsMjEgQEAgc3RhdGljIGludA0KPiA+IGlvbW11X2NyZWF0ZV9kZXZpY2VfZGlyZWN0X21h cHBpbmdzKHN0cnVjdCBpb21tdV9ncm91cCAqZ3JvdXAsDQo+ID4gIAkJCXBoeXNfYWRkcl90IHBo eXNfYWRkcjsNCj4gPiAgDQo+ID4gIAkJCXBoeXNfYWRkciA9IGlvbW11X2lvdmFfdG9fcGh5cyhk b21haW4sIGFkZHIpOw0KPiA+IC0JCQlpZiAocGh5c19hZGRyKQ0KPiA+IC0JCQkJY29udGludWU7 DQo+ID4gKwkJCWlmICghcGh5c19hZGRyKSB7DQo+ID4gKwkJCQltYXBfc2l6ZSArPSBwZ19zaXpl Ow0KPiA+ICsJCQkJaWYgKGFkZHIgKyBwZ19zaXplIDwgZW5kKQ0KPiA+ICsJCQkJCWNvbnRpbnVl Ow0KPiA+ICsJCQkJZWxzZQ0KPiANCj4gWW91IGRvbid0IG5lZWQgdGhlICdlbHNlJyBoZXJlICBe Xl4NCj4gDQo+ID4gKwkJCQkJYWRkciArPSBwZ19zaXplOyAvKlBvaW50IHRvIEVuZCAqLw0KPiAN Cj4gYWRkciA9IGVuZCA/DQo+IA0KPiBUaGF0IHNhaWQsIG1heWJlIHdlIGNvdWxkIHNpbXBsaWZ5 IHRoaXMgZnVydGhlciBieSBjaGFuZ2luZyB0aGUgbG9vcCBib3VuZHMNCj4gdG8gYmU6DQo+IA0K PiAJZm9yIChhZGRyID0gc3RhcnQ7IGFkZHIgPD0gZW5kOyBhZGRyICs9IHBnX3NpemUpDQo+IA0K PiBhbmQgY2hlY2tpbmc6DQo+IA0KPiAJaWYgKCFwaHlzX2FkZHIgJiYgYWRkciAhPSBlbmQpIHsN Cj4gCQltYXBfc2l6ZSArPSBwZ19zaXplOw0KPiAJCWNvbnRpbnVlOw0KPiAJfQ0KPiANCj4gZG9l cyB0aGF0IHdvcms/DQoNCkl0IHdvcmtzIGJ1dCBJIHRoaW5rIHdlIGNhbiBub3QgY2hlY2sgaW9t bXVfaW92YV90b19waHlzKGRvbWFpbiwgZW5kKS4NCldlIHNob3VsZCBhZGQgYSAiaWYiLCBsaWtl Og0KDQpmb3IgKGFkZHIgPSBzdGFydDsgYWRkciA8PSBlbmQ7IGFkZHIgKz0gcGdfc2l6ZSkgew0K Li4uDQoJaWYgKGFkZHIgPCBlbmQpIHsNCgkJcGh5c19hZGRyID0gaW9tbXVfaW92YV90b19waHlz KGRvbWFpbiwgYWRkcik7DQoJCWlmICghcGh5c19hZGRyKSB7DQoJCQltYXBfc2l6ZSArPSBwZ19z aXplOw0KCQkJY29udGludWU7DQoJCX0NCgl9DQouLi4NCg0KDQpJZiB5b3UgZG9uJ3QgbGlrZSB0 aGlzICJpZiAoYWRkciA8IGVuZCkiLCB0aGVuIHdlIGhhdmUgdG8gYWRkIGEgImdvdG8iLg0KbGlr ZSB0aGlzOg0KDQoNCmZvciAoYWRkciA9IHN0YXJ0OyBhZGRyIDw9IGVuZDsgYWRkciArPSBwZ19z aXplKSB7DQogCXBoeXNfYWRkcl90IHBoeXNfYWRkcjsNCiANCglpZiAoYWRkciA9PSBlbmQpDQoJ CWdvdG8gbWFwX2xhc3Q7DQoNCglwaHlzX2FkZHIgPSBpb21tdV9pb3ZhX3RvX3BoeXMoZG9tYWlu LCBhZGRyKTsNCglpZiAoIXBoeXNfYWRkcikgew0KCQltYXBfc2l6ZSArPSBwZ19zaXplOw0KCQlj b250aW51ZTsNCgl9DQoNCm1hcF9sYXN0Og0KCWlmICghbWFwX3NpemUpDQoJCWNvbnRpbnVlOw0K CXJldCA9IGlvbW11X21hcChkb21haW4sIGFkZHIgLSBtYXBfc2l6ZSwNCgkJCWFkZHIgLSBtYXBf c2l6ZSwgbWFwX3NpemUsIGVudHJ5LT5wcm90KTsNCglpZiAocmV0KQ0KCQlnb3RvIG91dDsNCn0N Cg0KV2hpY2ggb25lIGlzIGJldHRlcj8NCg0KPiANCj4gV2lsbA0KPiANCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gTGludXgtbWVkaWF0ZWsgbWFp bGluZyBsaXN0DQo+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlaw0KDQo=