From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:39714 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754291AbeDYNoi (ORCPT ); Wed, 25 Apr 2018 09:44:38 -0400 From: Laurent Pinchart To: Vaishali Thakkar Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] drm: rcar-du: Use drm_dev_put Date: Wed, 25 Apr 2018 16:44:53 +0300 Message-ID: <16063366.hqKB8js4d5@avalon> In-Reply-To: References: <20180425121036.28965-1-vthakkar1994@gmail.com> <5811471.PjpYk9OX8O@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Vaishali, On Wednesday, 25 April 2018 16:42:59 EEST Vaishali Thakkar wrote: > On Wed, Apr 25, 2018 at 7:02 PM, Laurent Pinchart wrote: > > On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote: > >> As specified in drm_drv.c, drm_dev_unref is a compatibility alias > >> for drm_dev_put and shouldn't be used in new code. So, use > >> drm_dev_put instead. > > > > This looks good to me. However, how about taking it one step further and > > mass- patching all drivers to use drm_dev_put() ? We could then remove > > drm_dev_unref() completely. > > Sure thing! Do you want me to fold this patch in that patchset or will you > be fine with applying this separately? I don't think we should split the change in one patch per driver, so if you send a single patch (to be applied through drm-misc) I think it would make sense to fold this change in. > >> Signed-off-by: Vaishali Thakkar > >> --- > >> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 05745e86d73e..418a80e6b2f4 > >> 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> @@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> return 0; > >> } -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: Use drm_dev_put Date: Wed, 25 Apr 2018 16:44:53 +0300 Message-ID: <16063366.hqKB8js4d5@avalon> References: <20180425121036.28965-1-vthakkar1994@gmail.com> <5811471.PjpYk9OX8O@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CC916E5D5 for ; Wed, 25 Apr 2018 13:44:38 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vaishali Thakkar Cc: airlied@linux.ie, linux-renesas-soc@vger.kernel.org, Linux Kernel Mailing List , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVmFpc2hhbGksCgpPbiBXZWRuZXNkYXksIDI1IEFwcmlsIDIwMTggMTY6NDI6NTkgRUVTVCBW YWlzaGFsaSBUaGFra2FyIHdyb3RlOgo+IE9uIFdlZCwgQXByIDI1LCAyMDE4IGF0IDc6MDIgUE0s IExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBXZWRuZXNkYXksIDI1IEFwcmlsIDIwMTgg MTU6MTA6MzYgRUVTVCBWYWlzaGFsaSBUaGFra2FyIHdyb3RlOgo+ID4+IEFzIHNwZWNpZmllZCBp biBkcm1fZHJ2LmMsIGRybV9kZXZfdW5yZWYgaXMgYSBjb21wYXRpYmlsaXR5IGFsaWFzCj4gPj4g Zm9yIGRybV9kZXZfcHV0IGFuZCBzaG91bGRuJ3QgYmUgdXNlZCBpbiBuZXcgY29kZS4gU28sIHVz ZQo+ID4+IGRybV9kZXZfcHV0IGluc3RlYWQuCj4gPiAKPiA+IFRoaXMgbG9va3MgZ29vZCB0byBt ZS4gSG93ZXZlciwgaG93IGFib3V0IHRha2luZyBpdCBvbmUgc3RlcCBmdXJ0aGVyIGFuZAo+ID4g bWFzcy0gcGF0Y2hpbmcgYWxsIGRyaXZlcnMgdG8gdXNlIGRybV9kZXZfcHV0KCkgPyBXZSBjb3Vs ZCB0aGVuIHJlbW92ZQo+ID4gZHJtX2Rldl91bnJlZigpIGNvbXBsZXRlbHkuCj4gCj4gU3VyZSB0 aGluZyEgRG8geW91IHdhbnQgbWUgdG8gZm9sZCB0aGlzIHBhdGNoIGluIHRoYXQgcGF0Y2hzZXQg b3Igd2lsbCB5b3UKPiBiZSBmaW5lIHdpdGggYXBwbHlpbmcgdGhpcyBzZXBhcmF0ZWx5PwoKSSBk b24ndCB0aGluayB3ZSBzaG91bGQgc3BsaXQgdGhlIGNoYW5nZSBpbiBvbmUgcGF0Y2ggcGVyIGRy aXZlciwgc28gaWYgeW91IApzZW5kIGEgc2luZ2xlIHBhdGNoICh0byBiZSBhcHBsaWVkIHRocm91 Z2ggZHJtLW1pc2MpIEkgdGhpbmsgaXQgd291bGQgbWFrZSAKc2Vuc2UgdG8gZm9sZCB0aGlzIGNo YW5nZSBpbi4KCj4gPj4gU2lnbmVkLW9mZi1ieTogVmFpc2hhbGkgVGhha2thciA8dnRoYWtrYXIx OTk0QGdtYWlsLmNvbT4KPiA+PiAtLS0KPiA+PiAKPiA+PiAgZHJpdmVycy9ncHUvZHJtL3JjYXIt ZHUvcmNhcl9kdV9kcnYuYyB8IDIgKy0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pCj4gPj4gCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfZHJ2LmMgaW5kZXggMDU3NDVlODZkNzNlLi40MThhODBlNmIyZjQKPiA+PiAxMDA2NDQK PiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+ID4+IEBAIC0zNzgsNyAr Mzc4LDcgQEAgc3RhdGljIGludCByY2FyX2R1X3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl Cj4gPj4gKnBkZXYpCj4gPj4gICAgICAgZHJtX2ttc19oZWxwZXJfcG9sbF9maW5pKGRkZXYpOwo+ ID4+ICAgICAgIGRybV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRkZXYpOwo+ID4+IAo+ID4+IC0gICAg IGRybV9kZXZfdW5yZWYoZGRldik7Cj4gPj4gKyAgICAgZHJtX2Rldl9wdXQoZGRldik7Cj4gPj4g ICAgICAgcmV0dXJuIDA7Cj4gPj4gIH0KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK