From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D56BC2D0E4 for ; Fri, 27 Nov 2020 05:58:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 726F9221EB for ; Fri, 27 Nov 2020 05:58:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CHxE4jnU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="abqYXwa5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 726F9221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tD50ZRCrN3E07+k/IIm/k5T+xQzz9g+tvy/Z+AeVvEk=; b=CHxE4jnU4uQTAyJenzcUtJz5s ahm/OqQ9B1H9evi43gp59dCDSY6MBxJ90goBusNxl1umrhwAD/HrR7RfuBSDXaoFqjyP2MvorxWqu hV5u0AnQUlD11N5ltCff18+GAqAm16lDV3iO7D9uMTCqWxI1c5vdh5rKmJuB4yErCR/+YJSboLslI BYexAsteJvtCCqEb/swkYF0IBCoDx2uQFTJsIQ5ApLLAEBs0DcU8wAu0xdZzBOaeUgOtupvVFSeJa bZTZ/S8OrBkRif0ng963p0/2IUaDI6Lu4s/IBhD9oAK+Cvq4fjnfgEmGFw6ChNvwjZ/E7JrNtkxHz xFVGwciNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiWmF-0008Pr-7W; Fri, 27 Nov 2020 05:58:39 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiWmA-0008OI-Q8; Fri, 27 Nov 2020 05:58:35 +0000 X-UUID: 803454a51f2d4787b7db3a2970c98d83-20201126 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VV/UVxBer8cz/LL3HT1bG3fkm0bU1MCnYZbcXRXqx5g=; b=abqYXwa5oSUmv/YH5Q2xOcqoc3nIqP4N73SJp60+hvJhiLJFzU3uGAhTIVVlc/c+T2RMd+nyZXPpzSPoZlp2ZRtNLb8iWg8HwEkDTmHieJY2F3U39oo6AjY+beCBFWd5jhvuSNRbWk+TZ4T3bfZwYj9FNI9JIneyaAEYdo2LdGI=; X-UUID: 803454a51f2d4787b7db3a2970c98d83-20201126 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1207745045; Thu, 26 Nov 2020 21:58:21 -0800 Received: from MTKMBS32N2.mediatek.inc (172.27.4.72) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 26 Nov 2020 21:58:18 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Nov 2020 13:58:15 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 27 Nov 2020 13:58:14 +0800 Message-ID: <1606456694.7284.13.camel@mhfsdcap03> Subject: Re: [PATCH v2] phy: mediatek: Make PHY_MTK_{XSPHY,TPHY} depend on HAS_IOMEM and OF_ADDRESS to fix build errors From: Chunfeng Yun To: Tiezhu Yang Date: Fri, 27 Nov 2020 13:58:14 +0800 In-Reply-To: <1606289865-692-1-git-send-email-yangtiezhu@loongson.cn> References: <1606289865-692-1-git-send-email-yangtiezhu@loongson.cn> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A1348FE1C622C32EE3BBD342ACC8DE129ED9659DFB7E737BC92FAEBB073FDC842000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_005835_235687_8BF92466 X-CRM114-Status: GOOD ( 21.83 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Randy Dunlap , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , linux-mediatek@lists.infradead.org, Xuefeng Li , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2020-11-25 at 15:37 +0800, Tiezhu Yang wrote: > devm_ioremap_resource() will be not built in lib/devres.c if > CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be > not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not > set, and then there exists two build errors about undefined > reference to "devm_ioremap_resource" and "of_address_to_resource" > in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY, > make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it. > > The above issue is reported by kernel test robot , > through the discussion in the v1 patch, as Chunfeng said we need > also do this for config PHY_MTK_TPHY: > > drivers/phy/mediatek/phy-mtk-tphy.c:1157: retval = of_address_to_resource(child_np, 0, &res); > drivers/phy/mediatek/phy-mtk-tphy.c:1123: tphy->sif_base = devm_ioremap_resource(dev, sif_res); > drivers/phy/mediatek/phy-mtk-tphy.c:1164: instance->port_base = devm_ioremap_resource(&phy->dev, &res); > > Reported-by: kernel test robot > Signed-off-by: Tiezhu Yang > Acked-by: Randy Dunlap > --- The changes in v2 should be described after '---' Except that, it looks good to me, Acked-by: Chunfeng Yun Thanks a lot > drivers/phy/mediatek/Kconfig | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > index 50c5e93..f44800b 100644 > --- a/drivers/phy/mediatek/Kconfig > +++ b/drivers/phy/mediatek/Kconfig > @@ -5,7 +5,8 @@ > config PHY_MTK_TPHY > tristate "MediaTek T-PHY Driver" > depends on ARCH_MEDIATEK || COMPILE_TEST > - depends on OF > + depends on OF && OF_ADDRESS > + depends on HAS_IOMEM > select GENERIC_PHY > help > Say 'Y' here to add support for MediaTek T-PHY driver, > @@ -29,7 +30,8 @@ config PHY_MTK_UFS > config PHY_MTK_XSPHY > tristate "MediaTek XS-PHY Driver" > depends on ARCH_MEDIATEK || COMPILE_TEST > - depends on OF > + depends on OF && OF_ADDRESS > + depends on HAS_IOMEM > select GENERIC_PHY > help > Enable this to support the SuperSpeedPlus XS-PHY transceiver for _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480F6C2D0E4 for ; Fri, 27 Nov 2020 06:00:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC241221EB for ; Fri, 27 Nov 2020 06:00:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f0YqPg5o"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="abqYXwa5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC241221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZF+fXJcis0iW/0aIG7ME8Hbi7hN0QLwM60kTrr3qRlY=; b=f0YqPg5oos6F99aN/hxVfyqwd Nus4sWai8hYk+K7KE8lcY7wl6Ns4Pc0kdlVqSM/Q7suF3fTyleqwmpw9BS/AbKmwPdyqC3sB1eGC7 3J+EGzmSEOvf4R42fY7iPy/GdOxQLpP/aAg1ri1fCRn9qNNoXJzUHxtIGcJ/CFauPrUsP3q3fyLOp F4SAoS3nZi0ET1hxwe19jB/LpqHNXw8O59JJ40EN+xA1EpRUfqp3jx5RBqyjFZjEZQUH28lHgDWOn gSwgZhyq+Y5DT4UfOY8qUMqn+Gttt4J02mxKWkKGVH3OM0SRkXrVoguhWiO+H6P3jVL0fsLBHYGlh E1gWFsOrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiWmH-0008QK-FU; Fri, 27 Nov 2020 05:58:43 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiWmA-0008OI-Q8; Fri, 27 Nov 2020 05:58:35 +0000 X-UUID: 803454a51f2d4787b7db3a2970c98d83-20201126 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VV/UVxBer8cz/LL3HT1bG3fkm0bU1MCnYZbcXRXqx5g=; b=abqYXwa5oSUmv/YH5Q2xOcqoc3nIqP4N73SJp60+hvJhiLJFzU3uGAhTIVVlc/c+T2RMd+nyZXPpzSPoZlp2ZRtNLb8iWg8HwEkDTmHieJY2F3U39oo6AjY+beCBFWd5jhvuSNRbWk+TZ4T3bfZwYj9FNI9JIneyaAEYdo2LdGI=; X-UUID: 803454a51f2d4787b7db3a2970c98d83-20201126 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1207745045; Thu, 26 Nov 2020 21:58:21 -0800 Received: from MTKMBS32N2.mediatek.inc (172.27.4.72) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 26 Nov 2020 21:58:18 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Nov 2020 13:58:15 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 27 Nov 2020 13:58:14 +0800 Message-ID: <1606456694.7284.13.camel@mhfsdcap03> Subject: Re: [PATCH v2] phy: mediatek: Make PHY_MTK_{XSPHY,TPHY} depend on HAS_IOMEM and OF_ADDRESS to fix build errors From: Chunfeng Yun To: Tiezhu Yang Date: Fri, 27 Nov 2020 13:58:14 +0800 In-Reply-To: <1606289865-692-1-git-send-email-yangtiezhu@loongson.cn> References: <1606289865-692-1-git-send-email-yangtiezhu@loongson.cn> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A1348FE1C622C32EE3BBD342ACC8DE129ED9659DFB7E737BC92FAEBB073FDC842000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_005835_235687_8BF92466 X-CRM114-Status: GOOD ( 21.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Randy Dunlap , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , linux-mediatek@lists.infradead.org, Xuefeng Li , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-11-25 at 15:37 +0800, Tiezhu Yang wrote: > devm_ioremap_resource() will be not built in lib/devres.c if > CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be > not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not > set, and then there exists two build errors about undefined > reference to "devm_ioremap_resource" and "of_address_to_resource" > in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY, > make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it. > > The above issue is reported by kernel test robot , > through the discussion in the v1 patch, as Chunfeng said we need > also do this for config PHY_MTK_TPHY: > > drivers/phy/mediatek/phy-mtk-tphy.c:1157: retval = of_address_to_resource(child_np, 0, &res); > drivers/phy/mediatek/phy-mtk-tphy.c:1123: tphy->sif_base = devm_ioremap_resource(dev, sif_res); > drivers/phy/mediatek/phy-mtk-tphy.c:1164: instance->port_base = devm_ioremap_resource(&phy->dev, &res); > > Reported-by: kernel test robot > Signed-off-by: Tiezhu Yang > Acked-by: Randy Dunlap > --- The changes in v2 should be described after '---' Except that, it looks good to me, Acked-by: Chunfeng Yun Thanks a lot > drivers/phy/mediatek/Kconfig | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > index 50c5e93..f44800b 100644 > --- a/drivers/phy/mediatek/Kconfig > +++ b/drivers/phy/mediatek/Kconfig > @@ -5,7 +5,8 @@ > config PHY_MTK_TPHY > tristate "MediaTek T-PHY Driver" > depends on ARCH_MEDIATEK || COMPILE_TEST > - depends on OF > + depends on OF && OF_ADDRESS > + depends on HAS_IOMEM > select GENERIC_PHY > help > Say 'Y' here to add support for MediaTek T-PHY driver, > @@ -29,7 +30,8 @@ config PHY_MTK_UFS > config PHY_MTK_XSPHY > tristate "MediaTek XS-PHY Driver" > depends on ARCH_MEDIATEK || COMPILE_TEST > - depends on OF > + depends on OF && OF_ADDRESS > + depends on HAS_IOMEM > select GENERIC_PHY > help > Enable this to support the SuperSpeedPlus XS-PHY transceiver for _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8CE3C2D0E4 for ; Fri, 27 Nov 2020 05:58:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80B87221F1 for ; Fri, 27 Nov 2020 05:58:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="abqYXwa5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732921AbgK0F6Z (ORCPT ); Fri, 27 Nov 2020 00:58:25 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:3825 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1731985AbgK0F6Z (ORCPT ); Fri, 27 Nov 2020 00:58:25 -0500 X-UUID: b4e933b0133147a1af2d03c003ee2205-20201127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VV/UVxBer8cz/LL3HT1bG3fkm0bU1MCnYZbcXRXqx5g=; b=abqYXwa5oSUmv/YH5Q2xOcqoc3nIqP4N73SJp60+hvJhiLJFzU3uGAhTIVVlc/c+T2RMd+nyZXPpzSPoZlp2ZRtNLb8iWg8HwEkDTmHieJY2F3U39oo6AjY+beCBFWd5jhvuSNRbWk+TZ4T3bfZwYj9FNI9JIneyaAEYdo2LdGI=; X-UUID: b4e933b0133147a1af2d03c003ee2205-20201127 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1039532657; Fri, 27 Nov 2020 13:58:16 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Nov 2020 13:58:15 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 27 Nov 2020 13:58:14 +0800 Message-ID: <1606456694.7284.13.camel@mhfsdcap03> Subject: Re: [PATCH v2] phy: mediatek: Make PHY_MTK_{XSPHY,TPHY} depend on HAS_IOMEM and OF_ADDRESS to fix build errors From: Chunfeng Yun To: Tiezhu Yang CC: Vinod Koul , Kishon Vijay Abraham I , , , , Heiko Stuebner , "Randy Dunlap" , Xuefeng Li Date: Fri, 27 Nov 2020 13:58:14 +0800 In-Reply-To: <1606289865-692-1-git-send-email-yangtiezhu@loongson.cn> References: <1606289865-692-1-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A1348FE1C622C32EE3BBD342ACC8DE129ED9659DFB7E737BC92FAEBB073FDC842000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gV2VkLCAyMDIwLTExLTI1IGF0IDE1OjM3ICswODAwLCBUaWV6aHUgWWFuZyB3cm90ZToNCj4g ZGV2bV9pb3JlbWFwX3Jlc291cmNlKCkgd2lsbCBiZSBub3QgYnVpbHQgaW4gbGliL2RldnJlcy5j IGlmDQo+IENPTkZJR19IQVNfSU9NRU0gaXMgbm90IHNldCwgb2ZfYWRkcmVzc190b19yZXNvdXJj ZSgpIHdpbGwgYmUNCj4gbm90IGJ1aWx0IGluIGRyaXZlcnMvb2YvYWRkcmVzcy5jIGlmIENPTkZJ R19PRl9BRERSRVNTIGlzIG5vdA0KPiBzZXQsIGFuZCB0aGVuIHRoZXJlIGV4aXN0cyB0d28gYnVp bGQgZXJyb3JzIGFib3V0IHVuZGVmaW5lZA0KPiByZWZlcmVuY2UgdG8gImRldm1faW9yZW1hcF9y ZXNvdXJjZSIgYW5kICJvZl9hZGRyZXNzX3RvX3Jlc291cmNlIg0KPiBpbiBwaHktbXRrLXhzcGh5 LmMgdW5kZXIgQ09NUElMRV9URVNUIGFuZCBDT05GSUdfUEhZX01US19YU1BIWSwNCj4gbWFrZSBQ SFlfTVRLX1hTUEhZIGRlcGVuZCBvbiBIQVNfSU9NRU0gYW5kIE9GX0FERFJFU1MgdG8gZml4IGl0 Lg0KPiANCj4gVGhlIGFib3ZlIGlzc3VlIGlzIHJlcG9ydGVkIGJ5IGtlcm5lbCB0ZXN0IHJvYm90 IDxsa3BAaW50ZWwuY29tPiwNCj4gdGhyb3VnaCB0aGUgZGlzY3Vzc2lvbiBpbiB0aGUgdjEgcGF0 Y2gsIGFzIENodW5mZW5nIHNhaWQgd2UgbmVlZA0KPiBhbHNvIGRvIHRoaXMgZm9yIGNvbmZpZyBQ SFlfTVRLX1RQSFk6DQo+IA0KPiBkcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLXRwaHkuYzox MTU3OgkJcmV0dmFsID0gb2ZfYWRkcmVzc190b19yZXNvdXJjZShjaGlsZF9ucCwgMCwgJnJlcyk7 DQo+IGRyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstdHBoeS5jOjExMjM6CQl0cGh5LT5zaWZf YmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHNpZl9yZXMpOw0KPiBkcml2ZXJzL3Bo eS9tZWRpYXRlay9waHktbXRrLXRwaHkuYzoxMTY0OgkJaW5zdGFuY2UtPnBvcnRfYmFzZSA9IGRl dm1faW9yZW1hcF9yZXNvdXJjZSgmcGh5LT5kZXYsICZyZXMpOw0KPiANCj4gUmVwb3J0ZWQtYnk6 IGtlcm5lbCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBUaWV6 aHUgWWFuZyA8eWFuZ3RpZXpodUBsb29uZ3Nvbi5jbj4NCj4gQWNrZWQtYnk6IFJhbmR5IER1bmxh cCA8cmR1bmxhcEBpbmZyYWRlYWQub3JnPg0KPiAtLS0NClRoZSBjaGFuZ2VzIGluIHYyIHNob3Vs ZCBiZSBkZXNjcmliZWQgYWZ0ZXIgJy0tLScNCg0KRXhjZXB0IHRoYXQsIGl0IGxvb2tzIGdvb2Qg dG8gbWUsDQpBY2tlZC1ieTogQ2h1bmZlbmcgWXVuIDxjaHVuZmVuZy55dW5AbWVkaWF0ZWsuY29t Pg0KDQpUaGFua3MgYSBsb3QNCg0KPiAgZHJpdmVycy9waHkvbWVkaWF0ZWsvS2NvbmZpZyB8IDYg KysrKy0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L21lZGlhdGVrL0tjb25maWcgYi9kcml2 ZXJzL3BoeS9tZWRpYXRlay9LY29uZmlnDQo+IGluZGV4IDUwYzVlOTMuLmY0NDgwMGIgMTAwNjQ0 DQo+IC0tLSBhL2RyaXZlcnMvcGh5L21lZGlhdGVrL0tjb25maWcNCj4gKysrIGIvZHJpdmVycy9w aHkvbWVkaWF0ZWsvS2NvbmZpZw0KPiBAQCAtNSw3ICs1LDggQEANCj4gIGNvbmZpZyBQSFlfTVRL X1RQSFkNCj4gIAl0cmlzdGF0ZSAiTWVkaWFUZWsgVC1QSFkgRHJpdmVyIg0KPiAgCWRlcGVuZHMg b24gQVJDSF9NRURJQVRFSyB8fCBDT01QSUxFX1RFU1QNCj4gLQlkZXBlbmRzIG9uIE9GDQo+ICsJ ZGVwZW5kcyBvbiBPRiAmJiBPRl9BRERSRVNTDQo+ICsJZGVwZW5kcyBvbiBIQVNfSU9NRU0NCj4g IAlzZWxlY3QgR0VORVJJQ19QSFkNCj4gIAloZWxwDQo+ICAJICBTYXkgJ1knIGhlcmUgdG8gYWRk IHN1cHBvcnQgZm9yIE1lZGlhVGVrIFQtUEhZIGRyaXZlciwNCj4gQEAgLTI5LDcgKzMwLDggQEAg Y29uZmlnIFBIWV9NVEtfVUZTDQo+ICBjb25maWcgUEhZX01US19YU1BIWQ0KPiAgCXRyaXN0YXRl ICJNZWRpYVRlayBYUy1QSFkgRHJpdmVyIg0KPiAgCWRlcGVuZHMgb24gQVJDSF9NRURJQVRFSyB8 fCBDT01QSUxFX1RFU1QNCj4gLQlkZXBlbmRzIG9uIE9GDQo+ICsJZGVwZW5kcyBvbiBPRiAmJiBP Rl9BRERSRVNTDQo+ICsJZGVwZW5kcyBvbiBIQVNfSU9NRU0NCj4gIAlzZWxlY3QgR0VORVJJQ19Q SFkNCj4gIAloZWxwDQo+ICAJICBFbmFibGUgdGhpcyB0byBzdXBwb3J0IHRoZSBTdXBlclNwZWVk UGx1cyBYUy1QSFkgdHJhbnNjZWl2ZXIgZm9yDQoNCg==