From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, loic.poulain@linaro.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v3 2/7] bus: mhi: core: Allow channel to be disabled from stopped state
Date: Wed, 2 Dec 2020 15:40:33 -0800 [thread overview]
Message-ID: <1606952438-15321-3-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1606952438-15321-1-git-send-email-bbhatt@codeaurora.org>
If a channel was explicitly stopped but not reset, allow it to
move to a disabled state so the channel context can be cleaned
up. As the channel remained in a stopped state, its context was
not reset and cleared, which needs to be done if a client driver
module is unloaded or a device crash occurs.
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
---
drivers/bus/mhi/core/init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index f0697f4..e7b9a90 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -1288,7 +1288,8 @@ static int mhi_driver_remove(struct device *dev)
mutex_lock(&mhi_chan->mutex);
- if (ch_state[dir] == MHI_CH_STATE_ENABLED &&
+ if ((ch_state[dir] == MHI_CH_STATE_ENABLED ||
+ ch_state[dir] == MHI_CH_STATE_STOP) &&
!mhi_chan->offload_ch)
mhi_deinit_chan_ctxt(mhi_cntrl, mhi_chan);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-12-02 23:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:40 [PATCH v3 0/7] Updates to MHI channel handling Bhaumik Bhatt
2020-12-02 23:40 ` [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response Bhaumik Bhatt
2020-12-03 0:15 ` Hemant Kumar
2020-12-04 1:43 ` Bhaumik Bhatt
2020-12-02 23:40 ` Bhaumik Bhatt [this message]
2020-12-03 0:17 ` [PATCH v3 2/7] bus: mhi: core: Allow channel to be disabled from stopped state Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 3/7] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2020-12-03 0:51 ` Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 4/7] bus: mhi: core: Add support to stop or start channel data transfers Bhaumik Bhatt
2020-12-03 0:33 ` Hemant Kumar
2020-12-04 1:44 ` Bhaumik Bhatt
2020-12-02 23:40 ` [PATCH v3 5/7] bus: mhi: core: Check execution environment for channel before issuing reset Bhaumik Bhatt
2020-12-03 0:54 ` Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 6/7] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2020-12-02 23:48 ` Hemant Kumar
2020-12-02 23:40 ` [PATCH v3 7/7] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2020-12-03 0:56 ` Hemant Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1606952438-15321-3-git-send-email-bbhatt@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.