diff for duplicates of <1607050654.5824.0.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index a466699..c9745fe 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,26 +1,40 @@ -T24gVGh1LCAyMDIwLTEyLTAzIGF0IDE3OjUxICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG -cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gQ3Vy -cmVudGx5IHRoZSB2YXJpYWJsZSAnaW50ZXJ2YWwnIGlzIG5vdCBpbml0aWFsaXplZCBhbmQgaXMg -b25seSBzZXQNCj4gdG8gMSB3aGVuIG9leF9zdGF0LT5idF80MThfaGlkX2V4aXN0aSBpcyB0cnVl -LsKgwqBGaXggdGhpcyBieSBpbmludGlhbGl6aW5nDQo+IHZhcmlhYmxlIGludGVydmFsIHRvIDAg -KHdoaWNoIEknbSBhc3N1bWluZyBpcyB0aGUgaW50ZW5kZWQgZGVmYXVsdCkuDQo+IA0KPiBBZGRy -ZXNzZXMtQ292ZXJpdHk6ICgiVW5pbml0YWxpemVkIHNjYWxhciB2YXJpYWJsZSIpDQo+IEZpeGVz -OiA1YjJlOWEzNWU0NTYgKCJydHc4ODogY29leDogYWRkIGZlYXR1cmUgdG8gZW5oYW5jZSBISUQg -Y29leGlzdGVuY2UNCj4gcGVyZm9ybWFuY2UiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4g -S2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KDQpUaGFua3MgZm9yIHlvdXIgZml4Lg0K -DQpBY2tlZC1ieTogUGluZy1LZSBTaGloIDxwa3NoaWhAcmVhbHRlay5jb20+DQoNCj4gLS0tDQo+ -IMKgZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9jb2V4LmMgfCAyICstDQo+IMKg -MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZm -IC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9jb2V4LmMNCj4gYi9k -cml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0dzg4L2NvZXguYw0KPiBpbmRleCBjNzA0YzY4 -ODVhMTguLjI0NTMwY2FmY2JhNyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3Mv -cmVhbHRlay9ydHc4OC9jb2V4LmMNCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRl -ay9ydHc4OC9jb2V4LmMNCj4gQEAgLTIwNTEsNyArMjA1MSw3IEBAIHN0YXRpYyB2b2lkIHJ0d19j -b2V4X2FjdGlvbl9idF9hMmRwX2hpZChzdHJ1Y3QgcnR3X2Rldg0KPiAqcnR3ZGV2KQ0KPiDCoAlz -dHJ1Y3QgcnR3X2NvZXhfZG0gKmNvZXhfZG0gPSAmY29leC0+ZG07DQo+IMKgCXN0cnVjdCBydHdf -ZWZ1c2UgKmVmdXNlID0gJnJ0d2Rldi0+ZWZ1c2U7DQo+IMKgCXN0cnVjdCBydHdfY2hpcF9pbmZv -ICpjaGlwID0gcnR3ZGV2LT5jaGlwOw0KPiAtCXU4IHRhYmxlX2Nhc2UsIHRkbWFfY2FzZSwgaW50 -ZXJ2YWw7DQo+ICsJdTggdGFibGVfY2FzZSwgdGRtYV9jYXNlLCBpbnRlcnZhbCA9IDA7DQo+IMKg -CXUzMiBzbG90X3R5cGUgPSAwOw0KPiDCoAlib29sIGlzX3RvZ2dsZV90YWJsZSA9IGZhbHNlOw0K -PiDCoA0KPiAtLcKgDQo+IDIuMjkuMg0KPiANCj4gDQo+IC0tLS0tLVBsZWFzZSBjb25zaWRlciB0 -aGUgZW52aXJvbm1lbnQgYmVmb3JlIHByaW50aW5nIHRoaXMgZS1tYWlsLg0KDQoNCg= +On Thu, 2020-12-03 at 17:51 +0000, Colin King wrote: +> From: Colin Ian King <colin.king@canonical.com> +> +> Currently the variable 'interval' is not initialized and is only set +> to 1 when oex_stat->bt_418_hid_existi is true. Fix this by inintializing +> variable interval to 0 (which I'm assuming is the intended default). +> +> Addresses-Coverity: ("Uninitalized scalar variable") +> Fixes: 5b2e9a35e456 ("rtw88: coex: add feature to enhance HID coexistence +> performance") +> Signed-off-by: Colin Ian King <colin.king@canonical.com> + +Thanks for your fix. + +Acked-by: Ping-Ke Shih <pkshih@realtek.com> + +> --- +> drivers/net/wireless/realtek/rtw88/coex.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c +> b/drivers/net/wireless/realtek/rtw88/coex.c +> index c704c6885a18..24530cafcba7 100644 +> --- a/drivers/net/wireless/realtek/rtw88/coex.c +> +++ b/drivers/net/wireless/realtek/rtw88/coex.c +> @@ -2051,7 +2051,7 @@ static void rtw_coex_action_bt_a2dp_hid(struct rtw_dev +> *rtwdev) +> struct rtw_coex_dm *coex_dm = &coex->dm; +> struct rtw_efuse *efuse = &rtwdev->efuse; +> struct rtw_chip_info *chip = rtwdev->chip; +> - u8 table_case, tdma_case, interval; +> + u8 table_case, tdma_case, interval = 0; +> u32 slot_type = 0; +> bool is_toggle_table = false; +> +> -- +> 2.29.2 +> +> +> ------Please consider the environment before printing this e-mail. diff --git a/a/content_digest b/N1/content_digest index 2d44540..4f5c385 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020201203175142.1071738-1-colin.king@canonical.com\0" "From\0Pkshih <pkshih@realtek.com>\0" "Subject\0Re: [PATCH][next] rtw88: coex: fix missing unitialization of variable 'interval'\0" - "Date\0Fri, 04 Dec 2020 02:57:36 +0000\0" + "Date\0Fri, 4 Dec 2020 02:57:36 +0000\0" "To\0tony0620emma@gmail.com <tony0620emma@gmail.com>" colin.king@canonical.com <colin.king@canonical.com> DeanKu <ku920601@realtek.com> @@ -14,31 +14,45 @@ " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDIwLTEyLTAzIGF0IDE3OjUxICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG\n" - "cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gQ3Vy\n" - "cmVudGx5IHRoZSB2YXJpYWJsZSAnaW50ZXJ2YWwnIGlzIG5vdCBpbml0aWFsaXplZCBhbmQgaXMg\n" - "b25seSBzZXQNCj4gdG8gMSB3aGVuIG9leF9zdGF0LT5idF80MThfaGlkX2V4aXN0aSBpcyB0cnVl\n" - "LsKgwqBGaXggdGhpcyBieSBpbmludGlhbGl6aW5nDQo+IHZhcmlhYmxlIGludGVydmFsIHRvIDAg\n" - "KHdoaWNoIEknbSBhc3N1bWluZyBpcyB0aGUgaW50ZW5kZWQgZGVmYXVsdCkuDQo+IA0KPiBBZGRy\n" - "ZXNzZXMtQ292ZXJpdHk6ICgiVW5pbml0YWxpemVkIHNjYWxhciB2YXJpYWJsZSIpDQo+IEZpeGVz\n" - "OiA1YjJlOWEzNWU0NTYgKCJydHc4ODogY29leDogYWRkIGZlYXR1cmUgdG8gZW5oYW5jZSBISUQg\n" - "Y29leGlzdGVuY2UNCj4gcGVyZm9ybWFuY2UiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4g\n" - "S2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KDQpUaGFua3MgZm9yIHlvdXIgZml4Lg0K\n" - "DQpBY2tlZC1ieTogUGluZy1LZSBTaGloIDxwa3NoaWhAcmVhbHRlay5jb20+DQoNCj4gLS0tDQo+\n" - "IMKgZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9jb2V4LmMgfCAyICstDQo+IMKg\n" - "MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZm\n" - "IC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9jb2V4LmMNCj4gYi9k\n" - "cml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0dzg4L2NvZXguYw0KPiBpbmRleCBjNzA0YzY4\n" - "ODVhMTguLjI0NTMwY2FmY2JhNyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3Mv\n" - "cmVhbHRlay9ydHc4OC9jb2V4LmMNCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRl\n" - "ay9ydHc4OC9jb2V4LmMNCj4gQEAgLTIwNTEsNyArMjA1MSw3IEBAIHN0YXRpYyB2b2lkIHJ0d19j\n" - "b2V4X2FjdGlvbl9idF9hMmRwX2hpZChzdHJ1Y3QgcnR3X2Rldg0KPiAqcnR3ZGV2KQ0KPiDCoAlz\n" - "dHJ1Y3QgcnR3X2NvZXhfZG0gKmNvZXhfZG0gPSAmY29leC0+ZG07DQo+IMKgCXN0cnVjdCBydHdf\n" - "ZWZ1c2UgKmVmdXNlID0gJnJ0d2Rldi0+ZWZ1c2U7DQo+IMKgCXN0cnVjdCBydHdfY2hpcF9pbmZv\n" - "ICpjaGlwID0gcnR3ZGV2LT5jaGlwOw0KPiAtCXU4IHRhYmxlX2Nhc2UsIHRkbWFfY2FzZSwgaW50\n" - "ZXJ2YWw7DQo+ICsJdTggdGFibGVfY2FzZSwgdGRtYV9jYXNlLCBpbnRlcnZhbCA9IDA7DQo+IMKg\n" - "CXUzMiBzbG90X3R5cGUgPSAwOw0KPiDCoAlib29sIGlzX3RvZ2dsZV90YWJsZSA9IGZhbHNlOw0K\n" - "PiDCoA0KPiAtLcKgDQo+IDIuMjkuMg0KPiANCj4gDQo+IC0tLS0tLVBsZWFzZSBjb25zaWRlciB0\n" - aGUgZW52aXJvbm1lbnQgYmVmb3JlIHByaW50aW5nIHRoaXMgZS1tYWlsLg0KDQoNCg= + "On Thu, 2020-12-03 at 17:51 +0000, Colin King wrote:\n" + "> From: Colin Ian King <colin.king@canonical.com>\n" + "> \n" + "> Currently the variable 'interval' is not initialized and is only set\n" + "> to 1 when oex_stat->bt_418_hid_existi is true.\302\240\302\240Fix this by inintializing\n" + "> variable interval to 0 (which I'm assuming is the intended default).\n" + "> \n" + "> Addresses-Coverity: (\"Uninitalized scalar variable\")\n" + "> Fixes: 5b2e9a35e456 (\"rtw88: coex: add feature to enhance HID coexistence\n" + "> performance\")\n" + "> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n" + "\n" + "Thanks for your fix.\n" + "\n" + "Acked-by: Ping-Ke Shih <pkshih@realtek.com>\n" + "\n" + "> ---\n" + "> \302\240drivers/net/wireless/realtek/rtw88/coex.c | 2 +-\n" + "> \302\2401 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c\n" + "> b/drivers/net/wireless/realtek/rtw88/coex.c\n" + "> index c704c6885a18..24530cafcba7 100644\n" + "> --- a/drivers/net/wireless/realtek/rtw88/coex.c\n" + "> +++ b/drivers/net/wireless/realtek/rtw88/coex.c\n" + "> @@ -2051,7 +2051,7 @@ static void rtw_coex_action_bt_a2dp_hid(struct rtw_dev\n" + "> *rtwdev)\n" + "> \302\240\tstruct rtw_coex_dm *coex_dm = &coex->dm;\n" + "> \302\240\tstruct rtw_efuse *efuse = &rtwdev->efuse;\n" + "> \302\240\tstruct rtw_chip_info *chip = rtwdev->chip;\n" + "> -\tu8 table_case, tdma_case, interval;\n" + "> +\tu8 table_case, tdma_case, interval = 0;\n" + "> \302\240\tu32 slot_type = 0;\n" + "> \302\240\tbool is_toggle_table = false;\n" + "> \302\240\n" + "> --\302\240\n" + "> 2.29.2\n" + "> \n" + "> \n" + > ------Please consider the environment before printing this e-mail. -12d0a49d40805c3e9b90b68e69010177dcba2f96072e51fbccf33598807f0acf +3aab15d5fdc54b7a0dad7a7287737993cda9bd0aee7f2c8467cab4d43025cf3e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.