diff for duplicates of <1607400896.23328.7.camel@mhfsdcap03> diff --git a/a/1.txt b/N1/1.txt index 9e08fa8..e4cd733 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,19 +1,32 @@ -T24gVGh1LCAyMDIwLTEyLTAzIGF0IDExOjQxICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K -PiBUaGlzIGNvZGUgaXMgdXNpbmcgdGhlIHdyb25nIHNpemVvZigpIHNvIGl0IGRvZXMgbm90IGFs -bG9jYXRlIGVub3VnaA0KPiBtZW1vcnkuICBJdCBhbGxvY2F0ZXMgMzIgYnl0ZXMgYnV0IDcyIGFy -ZSByZXF1aXJlZC4gIFRoYXQgd2lsbCBsZWFkIHRvDQo+IG1lbW9yeSBjb3JydXB0aW9uLg0KPiAN -Cj4gRml4ZXM6IGFlMDc4MDkyNTVkMyAoInVzYjogbXR1MzogYWRkIGRlYnVnZnMgaW50ZXJmYWNl -IGZpbGVzIikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv -cmFjbGUuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvdXNiL210dTMvbXR1M19kZWJ1Z2ZzLmMgfCAy -ICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4g -DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jIGIvZHJpdmVy -cy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiBpbmRleCBmZGVhZGU2MjU0YWUuLjc1MzdiZmQ2 -NTFhZiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiAr -KysgYi9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jDQo+IEBAIC0xMjcsNyArMTI3LDcg -QEAgc3RhdGljIHZvaWQgbXR1M19kZWJ1Z2ZzX3JlZ3NldChzdHJ1Y3QgbXR1MyAqbXR1LCB2b2lk -IF9faW9tZW0gKmJhc2UsDQo+ICAJc3RydWN0IGRlYnVnZnNfcmVnc2V0MzIgKnJlZ3NldDsNCj4g -IAlzdHJ1Y3QgbXR1M19yZWdzZXQgKm1yZWdzOw0KPiAgDQo+IC0JbXJlZ3MgPSBkZXZtX2t6YWxs -b2MobXR1LT5kZXYsIHNpemVvZigqcmVnc2V0KSwgR0ZQX0tFUk5FTCk7DQo+ICsJbXJlZ3MgPSBk -ZXZtX2t6YWxsb2MobXR1LT5kZXYsIHNpemVvZigqbXJlZ3MpLCBHRlBfS0VSTkVMKTsNCj4gIAlp -ZiAoIW1yZWdzKQ0KPiAgCQlyZXR1cm47DQo+ICBBY2tlZC1ieTogQ2h1bmZlbmcgWXVuIDxjaHVu -ZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KDQpUaGFua3MNCg0KDQo +On Thu, 2020-12-03 at 11:41 +0300, Dan Carpenter wrote: +> This code is using the wrong sizeof() so it does not allocate enough +> memory. It allocates 32 bytes but 72 are required. That will lead to +> memory corruption. +> +> Fixes: ae07809255d3 ("usb: mtu3: add debugfs interface files") +> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> --- +> drivers/usb/mtu3/mtu3_debugfs.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c +> index fdeade6254ae..7537bfd651af 100644 +> --- a/drivers/usb/mtu3/mtu3_debugfs.c +> +++ b/drivers/usb/mtu3/mtu3_debugfs.c +> @@ -127,7 +127,7 @@ static void mtu3_debugfs_regset(struct mtu3 *mtu, void __iomem *base, +> struct debugfs_regset32 *regset; +> struct mtu3_regset *mregs; +> +> - mregs = devm_kzalloc(mtu->dev, sizeof(*regset), GFP_KERNEL); +> + mregs = devm_kzalloc(mtu->dev, sizeof(*mregs), GFP_KERNEL); +> if (!mregs) +> return; +> Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com> + +Thanks + + +_______________________________________________ +Linux-mediatek mailing list +Linux-mediatek@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-mediatek diff --git a/a/content_digest b/N1/content_digest index f000e79..5db1aaf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0X8ikqc4Mo2/0G72j@mwanda\0" "From\0Chunfeng Yun <chunfeng.yun@mediatek.com>\0" "Subject\0Re: [PATCH 1/2] usb: mtu3: fix memory corruption in mtu3_debugfs_regset()\0" - "Date\0Tue, 08 Dec 2020 04:14:56 +0000\0" + "Date\0Tue, 8 Dec 2020 12:14:56 +0800\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>" kernel-janitors@vger.kernel.org @@ -9,24 +9,37 @@ " linux-mediatek@lists.infradead.org\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDIwLTEyLTAzIGF0IDExOjQxICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K\n" - "PiBUaGlzIGNvZGUgaXMgdXNpbmcgdGhlIHdyb25nIHNpemVvZigpIHNvIGl0IGRvZXMgbm90IGFs\n" - "bG9jYXRlIGVub3VnaA0KPiBtZW1vcnkuICBJdCBhbGxvY2F0ZXMgMzIgYnl0ZXMgYnV0IDcyIGFy\n" - "ZSByZXF1aXJlZC4gIFRoYXQgd2lsbCBsZWFkIHRvDQo+IG1lbW9yeSBjb3JydXB0aW9uLg0KPiAN\n" - "Cj4gRml4ZXM6IGFlMDc4MDkyNTVkMyAoInVzYjogbXR1MzogYWRkIGRlYnVnZnMgaW50ZXJmYWNl\n" - "IGZpbGVzIikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv\n" - "cmFjbGUuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvdXNiL210dTMvbXR1M19kZWJ1Z2ZzLmMgfCAy\n" - "ICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4g\n" - "DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jIGIvZHJpdmVy\n" - "cy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiBpbmRleCBmZGVhZGU2MjU0YWUuLjc1MzdiZmQ2\n" - "NTFhZiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiAr\n" - "KysgYi9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jDQo+IEBAIC0xMjcsNyArMTI3LDcg\n" - "QEAgc3RhdGljIHZvaWQgbXR1M19kZWJ1Z2ZzX3JlZ3NldChzdHJ1Y3QgbXR1MyAqbXR1LCB2b2lk\n" - "IF9faW9tZW0gKmJhc2UsDQo+ICAJc3RydWN0IGRlYnVnZnNfcmVnc2V0MzIgKnJlZ3NldDsNCj4g\n" - "IAlzdHJ1Y3QgbXR1M19yZWdzZXQgKm1yZWdzOw0KPiAgDQo+IC0JbXJlZ3MgPSBkZXZtX2t6YWxs\n" - "b2MobXR1LT5kZXYsIHNpemVvZigqcmVnc2V0KSwgR0ZQX0tFUk5FTCk7DQo+ICsJbXJlZ3MgPSBk\n" - "ZXZtX2t6YWxsb2MobXR1LT5kZXYsIHNpemVvZigqbXJlZ3MpLCBHRlBfS0VSTkVMKTsNCj4gIAlp\n" - "ZiAoIW1yZWdzKQ0KPiAgCQlyZXR1cm47DQo+ICBBY2tlZC1ieTogQ2h1bmZlbmcgWXVuIDxjaHVu\n" - ZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KDQpUaGFua3MNCg0KDQo + "On Thu, 2020-12-03 at 11:41 +0300, Dan Carpenter wrote:\n" + "> This code is using the wrong sizeof() so it does not allocate enough\n" + "> memory. It allocates 32 bytes but 72 are required. That will lead to\n" + "> memory corruption.\n" + "> \n" + "> Fixes: ae07809255d3 (\"usb: mtu3: add debugfs interface files\")\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> ---\n" + "> drivers/usb/mtu3/mtu3_debugfs.c | 2 +-\n" + "> 1 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c\n" + "> index fdeade6254ae..7537bfd651af 100644\n" + "> --- a/drivers/usb/mtu3/mtu3_debugfs.c\n" + "> +++ b/drivers/usb/mtu3/mtu3_debugfs.c\n" + "> @@ -127,7 +127,7 @@ static void mtu3_debugfs_regset(struct mtu3 *mtu, void __iomem *base,\n" + "> \tstruct debugfs_regset32 *regset;\n" + "> \tstruct mtu3_regset *mregs;\n" + "> \n" + "> -\tmregs = devm_kzalloc(mtu->dev, sizeof(*regset), GFP_KERNEL);\n" + "> +\tmregs = devm_kzalloc(mtu->dev, sizeof(*mregs), GFP_KERNEL);\n" + "> \tif (!mregs)\n" + "> \t\treturn;\n" + "> Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>\n" + "\n" + "Thanks\n" + "\n" + "\n" + "_______________________________________________\n" + "Linux-mediatek mailing list\n" + "Linux-mediatek@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-mediatek -58303df032bc125f159cca6b8c068d07466b2e6dccc3aac0d079f9008a8a8574 +66e8eb30c4eecbd9830459f04eb99cdf21c74495104f5f692689db0d5d1db028
diff --git a/a/1.txt b/N2/1.txt index 9e08fa8..03f81cc 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,19 +1,26 @@ -T24gVGh1LCAyMDIwLTEyLTAzIGF0IDExOjQxICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K -PiBUaGlzIGNvZGUgaXMgdXNpbmcgdGhlIHdyb25nIHNpemVvZigpIHNvIGl0IGRvZXMgbm90IGFs -bG9jYXRlIGVub3VnaA0KPiBtZW1vcnkuICBJdCBhbGxvY2F0ZXMgMzIgYnl0ZXMgYnV0IDcyIGFy -ZSByZXF1aXJlZC4gIFRoYXQgd2lsbCBsZWFkIHRvDQo+IG1lbW9yeSBjb3JydXB0aW9uLg0KPiAN -Cj4gRml4ZXM6IGFlMDc4MDkyNTVkMyAoInVzYjogbXR1MzogYWRkIGRlYnVnZnMgaW50ZXJmYWNl -IGZpbGVzIikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv -cmFjbGUuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvdXNiL210dTMvbXR1M19kZWJ1Z2ZzLmMgfCAy -ICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4g -DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jIGIvZHJpdmVy -cy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiBpbmRleCBmZGVhZGU2MjU0YWUuLjc1MzdiZmQ2 -NTFhZiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiAr -KysgYi9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jDQo+IEBAIC0xMjcsNyArMTI3LDcg -QEAgc3RhdGljIHZvaWQgbXR1M19kZWJ1Z2ZzX3JlZ3NldChzdHJ1Y3QgbXR1MyAqbXR1LCB2b2lk -IF9faW9tZW0gKmJhc2UsDQo+ICAJc3RydWN0IGRlYnVnZnNfcmVnc2V0MzIgKnJlZ3NldDsNCj4g -IAlzdHJ1Y3QgbXR1M19yZWdzZXQgKm1yZWdzOw0KPiAgDQo+IC0JbXJlZ3MgPSBkZXZtX2t6YWxs -b2MobXR1LT5kZXYsIHNpemVvZigqcmVnc2V0KSwgR0ZQX0tFUk5FTCk7DQo+ICsJbXJlZ3MgPSBk -ZXZtX2t6YWxsb2MobXR1LT5kZXYsIHNpemVvZigqbXJlZ3MpLCBHRlBfS0VSTkVMKTsNCj4gIAlp -ZiAoIW1yZWdzKQ0KPiAgCQlyZXR1cm47DQo+ICBBY2tlZC1ieTogQ2h1bmZlbmcgWXVuIDxjaHVu -ZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KDQpUaGFua3MNCg0KDQo +On Thu, 2020-12-03 at 11:41 +0300, Dan Carpenter wrote: +> This code is using the wrong sizeof() so it does not allocate enough +> memory. It allocates 32 bytes but 72 are required. That will lead to +> memory corruption. +> +> Fixes: ae07809255d3 ("usb: mtu3: add debugfs interface files") +> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> --- +> drivers/usb/mtu3/mtu3_debugfs.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c +> index fdeade6254ae..7537bfd651af 100644 +> --- a/drivers/usb/mtu3/mtu3_debugfs.c +> +++ b/drivers/usb/mtu3/mtu3_debugfs.c +> @@ -127,7 +127,7 @@ static void mtu3_debugfs_regset(struct mtu3 *mtu, void __iomem *base, +> struct debugfs_regset32 *regset; +> struct mtu3_regset *mregs; +> +> - mregs = devm_kzalloc(mtu->dev, sizeof(*regset), GFP_KERNEL); +> + mregs = devm_kzalloc(mtu->dev, sizeof(*mregs), GFP_KERNEL); +> if (!mregs) +> return; +> Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com> + +Thanks diff --git a/a/content_digest b/N2/content_digest index f000e79..f2ea26e 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,32 +1,39 @@ "ref\0X8ikqc4Mo2/0G72j@mwanda\0" "From\0Chunfeng Yun <chunfeng.yun@mediatek.com>\0" "Subject\0Re: [PATCH 1/2] usb: mtu3: fix memory corruption in mtu3_debugfs_regset()\0" - "Date\0Tue, 08 Dec 2020 04:14:56 +0000\0" + "Date\0Tue, 8 Dec 2020 12:14:56 +0800\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>" - kernel-janitors@vger.kernel.org - linux-usb@vger.kernel.org - " linux-mediatek@lists.infradead.org\0" + <linux-usb@vger.kernel.org> + <linux-mediatek@lists.infradead.org> + " <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDIwLTEyLTAzIGF0IDExOjQxICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K\n" - "PiBUaGlzIGNvZGUgaXMgdXNpbmcgdGhlIHdyb25nIHNpemVvZigpIHNvIGl0IGRvZXMgbm90IGFs\n" - "bG9jYXRlIGVub3VnaA0KPiBtZW1vcnkuICBJdCBhbGxvY2F0ZXMgMzIgYnl0ZXMgYnV0IDcyIGFy\n" - "ZSByZXF1aXJlZC4gIFRoYXQgd2lsbCBsZWFkIHRvDQo+IG1lbW9yeSBjb3JydXB0aW9uLg0KPiAN\n" - "Cj4gRml4ZXM6IGFlMDc4MDkyNTVkMyAoInVzYjogbXR1MzogYWRkIGRlYnVnZnMgaW50ZXJmYWNl\n" - "IGZpbGVzIikNCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv\n" - "cmFjbGUuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvdXNiL210dTMvbXR1M19kZWJ1Z2ZzLmMgfCAy\n" - "ICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4g\n" - "DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jIGIvZHJpdmVy\n" - "cy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiBpbmRleCBmZGVhZGU2MjU0YWUuLjc1MzdiZmQ2\n" - "NTFhZiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy91c2IvbXR1My9tdHUzX2RlYnVnZnMuYw0KPiAr\n" - "KysgYi9kcml2ZXJzL3VzYi9tdHUzL210dTNfZGVidWdmcy5jDQo+IEBAIC0xMjcsNyArMTI3LDcg\n" - "QEAgc3RhdGljIHZvaWQgbXR1M19kZWJ1Z2ZzX3JlZ3NldChzdHJ1Y3QgbXR1MyAqbXR1LCB2b2lk\n" - "IF9faW9tZW0gKmJhc2UsDQo+ICAJc3RydWN0IGRlYnVnZnNfcmVnc2V0MzIgKnJlZ3NldDsNCj4g\n" - "IAlzdHJ1Y3QgbXR1M19yZWdzZXQgKm1yZWdzOw0KPiAgDQo+IC0JbXJlZ3MgPSBkZXZtX2t6YWxs\n" - "b2MobXR1LT5kZXYsIHNpemVvZigqcmVnc2V0KSwgR0ZQX0tFUk5FTCk7DQo+ICsJbXJlZ3MgPSBk\n" - "ZXZtX2t6YWxsb2MobXR1LT5kZXYsIHNpemVvZigqbXJlZ3MpLCBHRlBfS0VSTkVMKTsNCj4gIAlp\n" - "ZiAoIW1yZWdzKQ0KPiAgCQlyZXR1cm47DQo+ICBBY2tlZC1ieTogQ2h1bmZlbmcgWXVuIDxjaHVu\n" - ZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KDQpUaGFua3MNCg0KDQo + "On Thu, 2020-12-03 at 11:41 +0300, Dan Carpenter wrote:\n" + "> This code is using the wrong sizeof() so it does not allocate enough\n" + "> memory. It allocates 32 bytes but 72 are required. That will lead to\n" + "> memory corruption.\n" + "> \n" + "> Fixes: ae07809255d3 (\"usb: mtu3: add debugfs interface files\")\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> ---\n" + "> drivers/usb/mtu3/mtu3_debugfs.c | 2 +-\n" + "> 1 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c\n" + "> index fdeade6254ae..7537bfd651af 100644\n" + "> --- a/drivers/usb/mtu3/mtu3_debugfs.c\n" + "> +++ b/drivers/usb/mtu3/mtu3_debugfs.c\n" + "> @@ -127,7 +127,7 @@ static void mtu3_debugfs_regset(struct mtu3 *mtu, void __iomem *base,\n" + "> \tstruct debugfs_regset32 *regset;\n" + "> \tstruct mtu3_regset *mregs;\n" + "> \n" + "> -\tmregs = devm_kzalloc(mtu->dev, sizeof(*regset), GFP_KERNEL);\n" + "> +\tmregs = devm_kzalloc(mtu->dev, sizeof(*mregs), GFP_KERNEL);\n" + "> \tif (!mregs)\n" + "> \t\treturn;\n" + "> Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>\n" + "\n" + Thanks -58303df032bc125f159cca6b8c068d07466b2e6dccc3aac0d079f9008a8a8574 +9e8876d9ea15127f63ed64f06a861f940371683c0772f27f14f904b2b547fe4b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.