From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers Date: Fri, 15 Sep 2017 20:02:46 +0300 Message-ID: <1607973.DTifMlLdNl@avalon> In-Reply-To: <199d29db89a7953f59e1eb4e91a3421336e3ed2a.1505493461.git-series.kieran.bingham+renesas@ideasonboard.com> References: <199d29db89a7953f59e1eb4e91a3421336e3ed2a.1505493461.git-series.kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Friday, 15 September 2017 19:42:06 EEST Kieran Bingham wrote: > The pipeline needs to ensure that the hardware is idle for suspend and > resume operations. I'm not sure to really understand this sentence. > Implement suspend and resume functions using the DRM atomic helper > functions. > > CC: dri-devel@lists.freedesktop.org > > Signed-off-by: Kieran Bingham The rest of the patch looks good to me. With the commit message clarified, Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 18 +++++++++++++++--- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 09fbceade6b1..01b91d0c169c > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -22,6 +22,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -267,9 +268,19 @@ static struct drm_driver rcar_du_driver = { > static int rcar_du_pm_suspend(struct device *dev) > { > struct rcar_du_device *rcdu = dev_get_drvdata(dev); > + struct drm_atomic_state *state; > > drm_kms_helper_poll_disable(rcdu->ddev); > - /* TODO Suspend the CRTC */ > + drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, true); > + > + state = drm_atomic_helper_suspend(rcdu->ddev); > + if (IS_ERR(state)) { > + drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, false); > + drm_kms_helper_poll_enable(rcdu->ddev); > + return PTR_ERR(state); > + } > + > + rcdu->suspend_state = state; > > return 0; > } > @@ -278,9 +289,10 @@ static int rcar_du_pm_resume(struct device *dev) > { > struct rcar_du_device *rcdu = dev_get_drvdata(dev); > > - /* TODO Resume the CRTC */ > - > + drm_atomic_helper_resume(rcdu->ddev, rcdu->suspend_state); > + drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, false); > drm_kms_helper_poll_enable(rcdu->ddev); > + > return 0; > } > #endif > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > b/drivers/gpu/drm/rcar-du/rcar_du_drv.h index f8cd79488ece..f400fde65a0c > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > @@ -81,6 +81,7 @@ struct rcar_du_device { > > struct drm_device *ddev; > struct drm_fbdev_cma *fbdev; > + struct drm_atomic_state *suspend_state; > > struct rcar_du_crtc crtcs[RCAR_DU_MAX_CRTCS]; > unsigned int num_crtcs; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers Date: Fri, 15 Sep 2017 20:02:46 +0300 Message-ID: <1607973.DTifMlLdNl@avalon> References: <199d29db89a7953f59e1eb4e91a3421336e3ed2a.1505493461.git-series.kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD5956EC37 for ; Fri, 15 Sep 2017 17:02:43 +0000 (UTC) In-Reply-To: <199d29db89a7953f59e1eb4e91a3421336e3ed2a.1505493461.git-series.kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDE1IFNlcHRl bWJlciAyMDE3IDE5OjQyOjA2IEVFU1QgS2llcmFuIEJpbmdoYW0gd3JvdGU6Cj4gVGhlIHBpcGVs aW5lIG5lZWRzIHRvIGVuc3VyZSB0aGF0IHRoZSBoYXJkd2FyZSBpcyBpZGxlIGZvciBzdXNwZW5k IGFuZAo+IHJlc3VtZSBvcGVyYXRpb25zLgoKSSdtIG5vdCBzdXJlIHRvIHJlYWxseSB1bmRlcnN0 YW5kIHRoaXMgc2VudGVuY2UuCgo+IEltcGxlbWVudCBzdXNwZW5kIGFuZCByZXN1bWUgZnVuY3Rp b25zIHVzaW5nIHRoZSBEUk0gYXRvbWljIGhlbHBlcgo+IGZ1bmN0aW9ucy4KPiAKPiBDQzogZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IAo+IFNpZ25lZC1vZmYtYnk6IEtpZXJhbiBC aW5naGFtIDxraWVyYW4uYmluZ2hhbStyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+CgpUaGUgcmVz dCBvZiB0aGUgcGF0Y2ggbG9va3MgZ29vZCB0byBtZS4gV2l0aCB0aGUgY29tbWl0IG1lc3NhZ2Ug Y2xhcmlmaWVkLAoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hh cnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfZHJ2LmMgfCAxOCArKysrKysrKysrKysrKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Jj YXItZHUvcmNhcl9kdV9kcnYuaCB8ICAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2Rydi5jIGluZGV4IDA5ZmJjZWFkZTZiMS4uMDFiOTFkMGMxNjljCj4gMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiBAQCAtMjIsNiArMjIsNyBAQAo+ICAjaW5jbHVk ZSA8bGludXgvd2FpdC5oPgo+IAo+ICAjaW5jbHVkZSA8ZHJtL2RybVAuaD4KPiArI2luY2x1ZGUg PGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBl ci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9jbWFfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxk cm0vZHJtX2dlbV9jbWFfaGVscGVyLmg+Cj4gQEAgLTI2Nyw5ICsyNjgsMTkgQEAgc3RhdGljIHN0 cnVjdCBkcm1fZHJpdmVyIHJjYXJfZHVfZHJpdmVyID0gewo+ICBzdGF0aWMgaW50IHJjYXJfZHVf cG1fc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCByY2FyX2R1X2Rl dmljZSAqcmNkdSA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsJc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKnN0YXRlOwo+IAo+ICAJZHJtX2ttc19oZWxwZXJfcG9sbF9kaXNhYmxlKHJjZHUtPmRk ZXYpOwo+IC0JLyogVE9ETyBTdXNwZW5kIHRoZSBDUlRDICovCj4gKwlkcm1fZmJkZXZfY21hX3Nl dF9zdXNwZW5kX3VubG9ja2VkKHJjZHUtPmZiZGV2LCB0cnVlKTsKPiArCj4gKwlzdGF0ZSA9IGRy bV9hdG9taWNfaGVscGVyX3N1c3BlbmQocmNkdS0+ZGRldik7Cj4gKwlpZiAoSVNfRVJSKHN0YXRl KSkgewo+ICsJCWRybV9mYmRldl9jbWFfc2V0X3N1c3BlbmRfdW5sb2NrZWQocmNkdS0+ZmJkZXYs IGZhbHNlKTsKPiArCQlkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZShyY2R1LT5kZGV2KTsKPiAr CQlyZXR1cm4gUFRSX0VSUihzdGF0ZSk7Cj4gKwl9Cj4gKwo+ICsJcmNkdS0+c3VzcGVuZF9zdGF0 ZSA9IHN0YXRlOwo+IAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiBAQCAtMjc4LDkgKzI4OSwxMCBAQCBz dGF0aWMgaW50IHJjYXJfZHVfcG1fcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgewo+ICAJ c3RydWN0IHJjYXJfZHVfZGV2aWNlICpyY2R1ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gCj4g LQkvKiBUT0RPIFJlc3VtZSB0aGUgQ1JUQyAqLwo+IC0KPiArCWRybV9hdG9taWNfaGVscGVyX3Jl c3VtZShyY2R1LT5kZGV2LCByY2R1LT5zdXNwZW5kX3N0YXRlKTsKPiArCWRybV9mYmRldl9jbWFf c2V0X3N1c3BlbmRfdW5sb2NrZWQocmNkdS0+ZmJkZXYsIGZhbHNlKTsKPiAgCWRybV9rbXNfaGVs cGVyX3BvbGxfZW5hYmxlKHJjZHUtPmRkZXYpOwo+ICsKPiAgCXJldHVybiAwOwo+ICB9Cj4gICNl bmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5o Cj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5oIGluZGV4IGY4Y2Q3OTQ4 OGVjZS4uZjQwMGZkZTY1YTBjCj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXIt ZHUvcmNhcl9kdV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVf ZHJ2LmgKPiBAQCAtODEsNiArODEsNyBAQCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2Ugewo+IAo+ICAJ c3RydWN0IGRybV9kZXZpY2UgKmRkZXY7Cj4gIAlzdHJ1Y3QgZHJtX2ZiZGV2X2NtYSAqZmJkZXY7 Cj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3VzcGVuZF9zdGF0ZTsKPiAKPiAgCXN0cnVj dCByY2FyX2R1X2NydGMgY3J0Y3NbUkNBUl9EVV9NQVhfQ1JUQ1NdOwo+ICAJdW5zaWduZWQgaW50 IG51bV9jcnRjczsKCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=