From: Wesley Cheng <wcheng@codeaurora.org>
To: balbi@kernel.org, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Wesley Cheng <wcheng@codeaurora.org>
Subject: [PATCH v2 0/2] Allow DWC3 runtime suspend if UDC is unbinded
Date: Tue, 29 Dec 2020 15:05:34 -0800 [thread overview]
Message-ID: <1609283136-22140-1-git-send-email-wcheng@codeaurora.org> (raw)
Changes in v2:
- Modified logic for executing the runtime PM resume. Using a sychronous get
call to avoid race conditions.
During the following scenario, the DWC3 runtime suspend routine is blocked as
the connected flag is still true:
1. Enumerate device w/ host.
2. Gadget is unbinded
- echo "" > /sys/kernel/config/usb_gadget/g1/UDC
3. Disconnect the USB cable (VBUS low)
4. No dwc3_gadget_disconnect_interrupt() seen (since controller is
halted from step#1)
5. Runtime PM autosuspend fails due to "dwc->connected" being true
(cleared in dwc3_gadget_disconnect_interrupt())
6. Gadget binded
- echo udc_name > /sys/kernel/config/usb_gadget/g1/UDC
7. No runtime suspend until cable is plugged in and out
Technically, for device initiated disconnects, there is no active session/link
with the host, so the DWC3 controller should be allowed to go into a low power
state. Also, we need to now consider when re-binding the UDC,
dwc3_gadget_set_speed() is executed before dwc3_gadget_pullup(), so if the DWC3
controller is suspended/disabled, while accessing the DCFG, that could result in
bus timeouts, etc... Change the dwc3_gadget_set_speed() to save the speed
being requested, and program it during dwc3_gadget_run_stop(), which is executed
during PM runtime resume. If not, previous setting will be overridden as we
execute a DWC3 controller reset during PM runtime resume.
Wesley Cheng (2):
usb: dwc3: gadget: Allow runtime suspend if UDC unbinded
usb: dwc3: gadget: Preserve UDC max speed setting
drivers/usb/dwc3/core.h | 1 +
drivers/usb/dwc3/gadget.c | 121 ++++++++++++++++++++++----------------
2 files changed, 71 insertions(+), 51 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2020-12-29 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 23:05 Wesley Cheng [this message]
2020-12-29 23:05 ` [PATCH v2 1/2] usb: dwc3: gadget: Allow runtime suspend if UDC unbinded Wesley Cheng
2020-12-29 23:05 ` [PATCH v2 2/2] usb: dwc3: gadget: Preserve UDC max speed setting Wesley Cheng
-- strict thread matches above, loose matches on Subject: below --
2020-11-05 23:28 [PATCH v2 0/2] Allow DWC3 runtime suspend if UDC is unbinded Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609283136-22140-1-git-send-email-wcheng@codeaurora.org \
--to=wcheng@codeaurora.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.