From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCBACC433E6 for ; Wed, 30 Dec 2020 15:41:02 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96AC822227; Wed, 30 Dec 2020 15:41:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96AC822227 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kudaw-0004wh-8f; Wed, 30 Dec 2020 15:41:02 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kudau-0004wQ-JV for linux-f2fs-devel@lists.sourceforge.net; Wed, 30 Dec 2020 15:41:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:From:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4QVTBCbyEOINEOakrEWkygBt0VvqSjw43oeJYBjPArY=; b=IN1IA0mM/NynJ7+0hLnfJbwshs w6mb2okC7wZvh+s8urAerWSEn7ezaMkNM6FDJxd4tu9akIaK8RocNecVmGAgSuAodXZ6qBh6tDH5Y HwbsQCNNxhVRvUOUGeHKMybK6yrotigIOKzE2tv95Pp9ef6j/NafBSjj1C2V/mWFH7ZI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:From:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4QVTBCbyEOINEOakrEWkygBt0VvqSjw43oeJYBjPArY=; b=MMaKPcoWVrrKHphKnzLDrWKR/e zTeqRdaPcVsPmBuE85sSJpz26FE+YMr5NwpDblEo+iZQl0cD4VRDXf9qT0YYyJAn3/Z3X9GAzahfn vH5KM6djln2OFsXpdM6+hadZGACP74LTqsW7NTjudKANjCBfnGiSxDQR/kJ6lW1qvSUk=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kudar-00DCO1-GL for linux-f2fs-devel@lists.sourceforge.net; Wed, 30 Dec 2020 15:41:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A0AFF21D1B; Wed, 30 Dec 2020 15:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609342845; bh=usovhedG93a4iaZkHPqyve6KR+G1E1NPY+mUVXbo14s=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=SxJxUvodbshQj/fsT2miesvKYZVK6BSmQB/7NVFXAp/lMX393PZrWKx0TeT89JjkN QeXn3ELFSV2Hv3bYNDhewRP2ouDt/eW+XF6fjJnBnWvLMsB3CBR4CR9c31iongsTBl 1GgZU9n7ztRhm3bEoTQnPbg2N8qRh0MV+a5nUwu8= To: ebiggers@google.com, ebiggers@kernel.org, gregkh@linuxfoundation.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org From: Date: Wed, 30 Dec 2020 16:42:03 +0100 In-Reply-To: <20201228191211.138300-4-ebiggers@kernel.org> Message-ID: <16093429237462@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-Headers-End: 1kudar-00DCO1-GL Subject: [f2fs-dev] Patch "f2fs: prevent creating duplicate encrypted filenames" has been added to the 4.19-stable tree X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable-commits@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This is a note to let you know that I've just added the patch titled f2fs: prevent creating duplicate encrypted filenames to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: f2fs-prevent-creating-duplicate-encrypted-filenames.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Wed Dec 30 04:40:58 PM CET 2020 From: Eric Biggers Date: Mon, 28 Dec 2020 11:12:10 -0800 Subject: f2fs: prevent creating duplicate encrypted filenames To: stable@vger.kernel.org Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org Message-ID: <20201228191211.138300-4-ebiggers@kernel.org> From: Eric Biggers commit bfc2b7e8518999003a61f91c1deb5e88ed77b07d upstream. As described in "fscrypt: add fscrypt_is_nokey_name()", it's possible to create a duplicate filename in an encrypted directory by creating a file concurrently with adding the directory's encryption key. Fix this bug on f2fs by rejecting no-key dentries in f2fs_add_link(). Note that the weird check for the current task in f2fs_do_add_link() seems to make this bug difficult to reproduce on f2fs. Fixes: 9ea97163c6da ("f2fs crypto: add filename encryption for f2fs_add_link") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20201118075609.120337-4-ebiggers@kernel.org Signed-off-by: Eric Biggers Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/f2fs.h | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2857,6 +2857,8 @@ bool f2fs_empty_dir(struct inode *dir); static inline int f2fs_add_link(struct dentry *dentry, struct inode *inode) { + if (fscrypt_is_nokey_name(dentry)) + return -ENOKEY; return f2fs_do_add_link(d_inode(dentry->d_parent), &dentry->d_name, inode, inode->i_ino, inode->i_mode); } Patches currently in stable-queue which might be from ebiggers@kernel.org are queue-4.19/fscrypt-add-fscrypt_is_nokey_name.patch queue-4.19/ext4-prevent-creating-duplicate-encrypted-filenames.patch queue-4.19/ubifs-prevent-creating-duplicate-encrypted-filenames.patch queue-4.19/f2fs-prevent-creating-duplicate-encrypted-filenames.patch _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB65C433DB for ; Wed, 30 Dec 2020 15:41:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A6B921D1B for ; Wed, 30 Dec 2020 15:41:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A6B921D1B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:Date:From:To: Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=tBHfOPHUy6bz0ip6jOkgrgyeceS2xEE+nYpkq+x6QH8=; b=PIdcde/FmaLLH9YAJNK6ocwIO RcVbNm96cO8hu7gFBmVPIfpk3o51kDcEzW/F5f64GTd4IHIu651nqF/vVQu/SMkPCP1PgeSCJj1Dl +owYigJtL74z+A5oLr8j8xTaLvNHMfELq3Rs/LiN1ymJZ9IFRzQP1oEpgHEVosMWr4NV+ENvUuWA6 +bgUwLmXCj4Llx3H1M4QMs+NjnHooXG1OfEcehHH5B3/taaU0LrlqPpINUPu3JUrCIgIf21eP2xev qzOo5BFoe9x2r9W7VSI84M9TmO7lE+os78DGaihZtNavJOlhZtqMq3Tv1+NXT8OUkrwfAEfQt/83x 8uIIStTvQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kudak-0004Bi-H5; Wed, 30 Dec 2020 15:40:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kudaf-0004AH-Qc for linux-mtd@lists.infradead.org; Wed, 30 Dec 2020 15:40:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A0AFF21D1B; Wed, 30 Dec 2020 15:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609342845; bh=usovhedG93a4iaZkHPqyve6KR+G1E1NPY+mUVXbo14s=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=SxJxUvodbshQj/fsT2miesvKYZVK6BSmQB/7NVFXAp/lMX393PZrWKx0TeT89JjkN QeXn3ELFSV2Hv3bYNDhewRP2ouDt/eW+XF6fjJnBnWvLMsB3CBR4CR9c31iongsTBl 1GgZU9n7ztRhm3bEoTQnPbg2N8qRh0MV+a5nUwu8= Subject: Patch "f2fs: prevent creating duplicate encrypted filenames" has been added to the 4.19-stable tree To: ebiggers@google.com, ebiggers@kernel.org, gregkh@linuxfoundation.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org From: Date: Wed, 30 Dec 2020 16:42:03 +0100 In-Reply-To: <20201228191211.138300-4-ebiggers@kernel.org> Message-ID: <16093429237462@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201230_104045_981948_3C7C2A1A X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable-commits@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled f2fs: prevent creating duplicate encrypted filenames to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: f2fs-prevent-creating-duplicate-encrypted-filenames.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Wed Dec 30 04:40:58 PM CET 2020 From: Eric Biggers Date: Mon, 28 Dec 2020 11:12:10 -0800 Subject: f2fs: prevent creating duplicate encrypted filenames To: stable@vger.kernel.org Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org Message-ID: <20201228191211.138300-4-ebiggers@kernel.org> From: Eric Biggers commit bfc2b7e8518999003a61f91c1deb5e88ed77b07d upstream. As described in "fscrypt: add fscrypt_is_nokey_name()", it's possible to create a duplicate filename in an encrypted directory by creating a file concurrently with adding the directory's encryption key. Fix this bug on f2fs by rejecting no-key dentries in f2fs_add_link(). Note that the weird check for the current task in f2fs_do_add_link() seems to make this bug difficult to reproduce on f2fs. Fixes: 9ea97163c6da ("f2fs crypto: add filename encryption for f2fs_add_link") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20201118075609.120337-4-ebiggers@kernel.org Signed-off-by: Eric Biggers Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/f2fs.h | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2857,6 +2857,8 @@ bool f2fs_empty_dir(struct inode *dir); static inline int f2fs_add_link(struct dentry *dentry, struct inode *inode) { + if (fscrypt_is_nokey_name(dentry)) + return -ENOKEY; return f2fs_do_add_link(d_inode(dentry->d_parent), &dentry->d_name, inode, inode->i_ino, inode->i_mode); } Patches currently in stable-queue which might be from ebiggers@kernel.org are queue-4.19/fscrypt-add-fscrypt_is_nokey_name.patch queue-4.19/ext4-prevent-creating-duplicate-encrypted-filenames.patch queue-4.19/ubifs-prevent-creating-duplicate-encrypted-filenames.patch queue-4.19/f2fs-prevent-creating-duplicate-encrypted-filenames.patch ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/