From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Bård Eirik Winther" <bwinther@cisco.com>
Cc: linux-media@vger.kernel.org, hansverk@cisco.com
Subject: Re: [PATCH 4/4] qv4l2: add OpenGL video render
Date: Tue, 16 Jul 2013 14:01:45 +0200 [thread overview]
Message-ID: <1609457.OFIJZjqBDN@avalon> (raw)
In-Reply-To: <5eb7b2d7de462e820ceb0698f6aa431c3eca414c.1373973770.git.bwinther@cisco.com>
Hi Bård,
Thank you for the patches.
On Tuesday 16 July 2013 13:24:08 Bård Eirik Winther wrote:
> The qv4l2 test utility now supports OpenGL-accelerated display of video.
> This allows for using the graphics card to render the video content to
> screen and to performing color space conversion.
>
> Signed-off-by: Bård Eirik Winther <bwinther@cisco.com>
> ---
> configure.ac | 8 +-
> utils/qv4l2/Makefile.am | 9 +-
> utils/qv4l2/capture-win.cpp | 559 +++++++++++++++++++++++++++++++++++++++--
> utils/qv4l2/capture-win.h | 81 ++++++-
> utils/qv4l2/qv4l2.cpp | 173 +++++++++++---
> utils/qv4l2/qv4l2.h | 8 +
> 6 files changed, 782 insertions(+), 56 deletions(-)
Is there a chance you could split the OpenGL code to separate classes, in a
separate source file ? This would allow implementing other renderers, such as
KMS planes on embedded devices.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-07-16 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 11:24 [PATCH 0/4] OpenGL render for qv4l2 Bård Eirik Winther
2013-07-16 11:24 ` [PATCH 1/4] qv4l2: move function ctrlEvent Bård Eirik Winther
2013-07-16 11:24 ` [PATCH 2/4] qv4l2: add hotkeys for common operations Bård Eirik Winther
2013-07-16 11:24 ` [PATCH 3/4] qv4l2: fix CaptureWin mimimum size to match video fram size Bård Eirik Winther
2013-07-16 11:24 ` [PATCH 4/4] qv4l2: add OpenGL video render Bård Eirik Winther
2013-07-16 12:01 ` Laurent Pinchart [this message]
2013-07-16 12:59 ` Bard Eirik Winther
2013-07-16 13:05 ` Laurent Pinchart
[not found] <201307171303.44303.hansverk@cisco.com>
2013-07-17 12:09 ` Bård Eirik Winther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609457.OFIJZjqBDN@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=bwinther@cisco.com \
--cc=hansverk@cisco.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.