All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Wolf <t.wolf@vplace.de>
To: linux-mips@linux-mips.org
Subject: [PATCH v2] MIPS: Fix memory reservation in bootmem_init for certain non-usermem setups
Date: Mon, 20 Aug 2018 12:06:40 +0200	[thread overview]
Message-ID: <1609732.rDWVQJrTVM@loki> (raw)
In-Reply-To: <1983860.23LM468bU3@loki>

Commit 67a3ba25aa95 ("MIPS: Fix incorrect mem=X@Y handling") introduced a new
issue for rt288x where "PHYS_OFFSET" is 0x0 but the calculated "ramstart" is
not. As the prerequisite of custom memory map has been removed, this results
in the full memory range of 0x0 - 0x8000000 to be marked as reserved for this
platform.

This patch adds the originally intended prerequisite again.

v2: Correctly compare that usermem is not null.

Signed-off-by: Tobias Wolf <dev-NTEO@vplace.de>
---
 arch/mips/kernel/setup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 563188ac6fa2..c3ca55128926 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -371,6 +371,8 @@ static unsigned long __init bootmap_bytes(unsigned long 
pages)
 	return ALIGN(bytes, sizeof(long));
 }
 
+static int usermem __initdata;
+
 static void __init bootmem_init(void)
 {
 	unsigned long reserved_end;
@@ -444,7 +446,7 @@ static void __init bootmem_init(void)
 	/*
 	 * Reserve any memory between the start of RAM and PHYS_OFFSET
 	 */
-	if (ramstart > PHYS_OFFSET)
+	if (usermem && ramstart > PHYS_OFFSET)
 		add_memory_region(PHYS_OFFSET, ramstart - PHYS_OFFSET,
 				  BOOT_MEM_RESERVED);
 
@@ -654,8 +656,6 @@ static void __init bootmem_init(void)
  * initialization hook for anything else was introduced.
  */
 
-static int usermem __initdata;
-
 static int __init early_parse_mem(char *p)
 {
 	phys_addr_t start, size;

  reply	other threads:[~2018-08-20 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  9:27 [PATCH] MIPS: Fix memory reservation in bootmem_init for certain non-usermem setups Tobias Wolf
2018-08-20 10:06 ` Tobias Wolf [this message]
2018-08-20 10:45   ` [PATCH v2] " Mathieu Malaterre
2018-08-20 11:10 ` [PATCH v3] " Tobias Wolf
2018-08-20 11:51   ` Mathieu Malaterre
2018-08-20 17:14   ` Greg KH
2018-08-20 23:31   ` Paul Burton
2018-08-21  7:39     ` Tobias Wolf
2018-08-21  7:41 ` [PATCH v4] " Tobias Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1609732.rDWVQJrTVM@loki \
    --to=t.wolf@vplace.de \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.