From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47512C2D0DB for ; Thu, 30 Jan 2020 17:26:34 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A554520707 for ; Thu, 30 Jan 2020 17:26:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Iqk1VYTP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eqifi7oY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A554520707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E90F3166C; Thu, 30 Jan 2020 18:25:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E90F3166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580405192; bh=Gw+ianHvLIu1GfBDcump7xH74MhYx8a4jkHVzdl+tCc=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Iqk1VYTPbBPxPmqPebLlV4/YEbJeW4tfSdEH0B0SxXBLAPHaHbImwJtneM8Wo7TVl NXKDZnS+KxN5Sxk1fPBNqtZ3/U4oD21SGjkTYc7pDBmVq7RN6ZrjcoQVnOf4UvSlzg h6X4Bx2SdWBWTI0tNzG5iBB9tXhQozUCnhI+o1ok= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5C330F8014B; Thu, 30 Jan 2020 18:25:41 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D9974F80150; Thu, 30 Jan 2020 18:25:39 +0100 (CET) Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7F3D2F80082 for ; Thu, 30 Jan 2020 18:25:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7F3D2F80082 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eqifi7oY" Received: by mail-ed1-x544.google.com with SMTP id c26so4653299eds.8 for ; Thu, 30 Jan 2020 09:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JBuUU9YguZE61sauS+J8SEajdxsJ22GtHtPHR00xnwQ=; b=eqifi7oYW1I8KdEzjX6tWdUWANaC17b2wO7MTt/xGmTrtO614Uv4fXmLjJhh8p4F/J yp3t7zsJsVXEmZ5fwhUARkHzPFSQHBbnRB0BS1rzj+9rvYy5FGxcJmA/2JWFq/+W3fSB 3vZl6mzptsIkh+HGnSMIagSOdKxQY1GFS5n1BMNL5wRx4xjPnS2nVL5ESTkLLd1zovoO Dl28aHpApC9Ks09aRj3Jrr3KK1GJnK7mKyqI5ECEXWnHM/vTAZmtbdj9y6huxdybyvYU MwFZcTN+xsHcCxpUeAtuc/Gk+6aO61iknKqiHOK8ZEfiguWLRaDxE9WwPGCu+ehMNUbn mwRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JBuUU9YguZE61sauS+J8SEajdxsJ22GtHtPHR00xnwQ=; b=Qdz146DPIiQ2fDDfkHfgmO0jb3+fUocpOz4VMis3HJPneUdanxnbfWZClpfkGa0Oz1 TmT+I5gvomO7Aiki4IS/se+2dTcGZyEV0uteKOHsxcsWk+qlgeZZeqJNaE10NXsDIjDl Pb1Vltfw+fn6tryeV2Dz0Po4do66Buec7L7SAZTsZ8JNdBgJTtX+9tiE8ZiPa0gDlHtt TUqMddJAYjJJ4NrbHoqNg+nR2ivffyR0tNj+xj22xtomhjJa4s6y1/zjXpeq1uAdPGHL 21rWJsv2nKeLQAUGLCrvPyeK3lselun/qvWk24+s4/isjZpvXw7BYgyUFbib++6jKjCM eujQ== X-Gm-Message-State: APjAAAWYExvtSxdolxUzO429+mm8CsJlZppGeW43/KHaDRT3EMtlatAG ZifFhDU7hFIWxJZVYb0Rk4U= X-Google-Smtp-Source: APXvYqxgK0mJxO0cesg5dzA/VHClKjIV8UvSjUK/BmBRNn0pMgmfqfF4AHyys5c+xx6GizIFk2gDIg== X-Received: by 2002:a17:906:4a12:: with SMTP id w18mr5231796eju.321.1580405131582; Thu, 30 Jan 2020 09:25:31 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id ks2sm597103ejb.82.2020.01.30.09.25.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2020 09:25:31 -0800 (PST) To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-6-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <160bb2ca-89bb-0ecf-a334-0fac591b439a@gmail.com> Date: Thu, 30 Jan 2020 20:25:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1580380422-3431-6-git-send-email-spujar@nvidia.com> Content-Language: en-US Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MzAuMDEuMjAyMCAxMzozMywgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6Ci4uLgo+ICsjaW5jbHVk ZSA8bGludXgvY2xrLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9kZXZpY2UuaD4KPiArI2luY2x1ZGUg PGxpbnV4L21vZHVsZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvb2ZfcGxhdGZvcm0uaD4KPiArI2lu Y2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvcG1fcnVu dGltZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvcmVnbWFwLmg+Cgo+ICsjaW5jbHVkZSA8c291bmQv c29jLmg+Cgo+ICsjaW5jbHVkZSAidGVncmEyMTBfYWh1Yi5oIgoKTml0OiBJJ2Qgc2VwYXJhdGUg dGhlIHBlci1kaXJlY3RvcnkgaW5jbHVkZXMgd2l0aCBhIGJsYW5rIGxpbmUsIGxpa2UgaXQKZG9u ZSBieSB0aGUgbW9zdCBvZiBleGlzdGluZyBkcml2ZXJzLCBmb3IgY29uc2lzdGVuY3kuCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFp bGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwczovL21haWxtYW4uYWxz YS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver Date: Thu, 30 Jan 2020 20:25:29 +0300 Message-ID: <160bb2ca-89bb-0ecf-a334-0fac591b439a@gmail.com> References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-6-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1580380422-3431-6-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 30.01.2020 13:33, Sameer Pujar пишет: ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "tegra210_ahub.h" Nit: I'd separate the per-directory includes with a blank line, like it done by the most of existing drivers, for consistency. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B897C2D0DB for ; Thu, 30 Jan 2020 17:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 137902083E for ; Thu, 30 Jan 2020 17:25:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eqifi7oY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbgA3RZd (ORCPT ); Thu, 30 Jan 2020 12:25:33 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:38912 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727285AbgA3RZd (ORCPT ); Thu, 30 Jan 2020 12:25:33 -0500 Received: by mail-ed1-f65.google.com with SMTP id m13so4669018edb.6; Thu, 30 Jan 2020 09:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JBuUU9YguZE61sauS+J8SEajdxsJ22GtHtPHR00xnwQ=; b=eqifi7oYW1I8KdEzjX6tWdUWANaC17b2wO7MTt/xGmTrtO614Uv4fXmLjJhh8p4F/J yp3t7zsJsVXEmZ5fwhUARkHzPFSQHBbnRB0BS1rzj+9rvYy5FGxcJmA/2JWFq/+W3fSB 3vZl6mzptsIkh+HGnSMIagSOdKxQY1GFS5n1BMNL5wRx4xjPnS2nVL5ESTkLLd1zovoO Dl28aHpApC9Ks09aRj3Jrr3KK1GJnK7mKyqI5ECEXWnHM/vTAZmtbdj9y6huxdybyvYU MwFZcTN+xsHcCxpUeAtuc/Gk+6aO61iknKqiHOK8ZEfiguWLRaDxE9WwPGCu+ehMNUbn mwRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JBuUU9YguZE61sauS+J8SEajdxsJ22GtHtPHR00xnwQ=; b=dJ6hw3WhUiCIKGscLHRLT6IHtlIMX/O48yNYpJl6SdJZQhP+vVfnf2yjC8E3V92yaP EUzx3Jc/yhbXnyzAS6qO+hSWEUoE0u2hRkLictqFskfh+c1XJ3P5RSt2rQO/ttoZ/x7i 9l83rYqSjbgAfKyj4HjiLlC5mNohkQTztnQRKHSMNjQyt7KnYH1+mL0GkUruA0zlqhCq 62l2x8j4N83hFXwtfJx3X35Kl9AvydbIrwAV0hlhAjkdTU7OrZWqzwWSd5uDTtT3QUaR 2BcL3GONYOJbr+xezekPpQnk2Gdyuh08oqKzAcCTzeTjNZ5V07Ld+/PC+6x5BB+xj4K4 wQgA== X-Gm-Message-State: APjAAAWjlw6yTD5Q/xD5PJKhGXRwpNyUHwFbXyzhrV9wWulUB5hKTgzU shPwSf2nhT/5WjvnT4tCOkc= X-Google-Smtp-Source: APXvYqxgK0mJxO0cesg5dzA/VHClKjIV8UvSjUK/BmBRNn0pMgmfqfF4AHyys5c+xx6GizIFk2gDIg== X-Received: by 2002:a17:906:4a12:: with SMTP id w18mr5231796eju.321.1580405131582; Thu, 30 Jan 2020 09:25:31 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id ks2sm597103ejb.82.2020.01.30.09.25.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2020 09:25:31 -0800 (PST) Subject: Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org Cc: broonie@kernel.org, lgirdwood@gmail.com, thierry.reding@gmail.com, jonathanh@nvidia.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com, rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-6-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <160bb2ca-89bb-0ecf-a334-0fac591b439a@gmail.com> Date: Thu, 30 Jan 2020 20:25:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1580380422-3431-6-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 30.01.2020 13:33, Sameer Pujar пишет: ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "tegra210_ahub.h" Nit: I'd separate the per-directory includes with a blank line, like it done by the most of existing drivers, for consistency.