From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17D9C433E0 for ; Fri, 8 Jan 2021 06:34:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3785F2339E for ; Fri, 8 Jan 2021 06:34:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3785F2339E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sOCrAt1MxmR+kDmMN7pBPbzvQK69j3n0T7EMYenQAzU=; b=2mJ3rFLJ/htOl8nIrcfGqUUlT NkguiWxFdifPi41HsDvlb08/2fXT7XCyCu+4sSK7d+z8314pcsH2wekaLsRVMkZ0u7ZKySlpgbE73 8Ju01GHus47lJ2PacbB2U4J+zu7hrzZfNldrnJDFX8v9VSz78XnG4GK+hCbmFsmOQ/QfH9OkCZViG cmcRSE/p4VH3INDgir8iVJ2XJnTuXwz93KxFDzUlbfOHO4cV06ZhXN7vPYhvkogG/H9oExTOkBIOJ JEtY8GT9njUHZMt1jHTfYG+Zlg51u1TsF/xIpedoA/Xv4RGVF3Hi42R4PrwOPrOBPvwAyybAC8thf Tostfl4eg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxlLs-0008VF-FH; Fri, 08 Jan 2021 06:34:24 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxlLn-0008UM-G6; Fri, 08 Jan 2021 06:34:20 +0000 X-UUID: c87ea4d3800a440e9c2e836de1af12f3-20210107 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FMnLCnisKI4QJNM0w1sFZfQNsdLpDgJ5G65JySoATkI=; b=avgFOjM+8Pn4d4n+HGLQNPqZ1SruwxX743zjH1KUFgtC82Pmz9rOjTZXmuvbmJDgJ3TTwxeNbkrXN46r4kz8+6zVjNWfCLu9yNN3AvBonq5kmC5XBkahAMUsih3fqQ6DXZJ9Hcdr8v5xT6fsHyzurwblAVugVhAvluT4PqCSnLk=; X-UUID: c87ea4d3800a440e9c2e836de1af12f3-20210107 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 748958017; Thu, 07 Jan 2021 22:34:14 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 Jan 2021 22:34:13 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 Jan 2021 14:34:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 Jan 2021 14:34:08 +0800 Message-ID: <1610087648.24856.41.camel@mhfsdcap03> Subject: Re: [PATCH v5] usb: xhci-mtk: fix unreleased bandwidth data From: Chunfeng Yun To: Ikjoon Jang Date: Fri, 8 Jan 2021 14:34:08 +0800 In-Reply-To: <20201229142406.v5.1.Id0d31b5f3ddf5e734d2ab11161ac5821921b1e1e@changeid> References: <20201229142406.v5.1.Id0d31b5f3ddf5e734d2ab11161ac5821921b1e1e@changeid> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 84426B80790F79195531223CD2A53D05FA1963BDE08E9CE47C2D172FE34682F02000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_013419_748926_772DF3F4 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhanyong Wang , Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tianping Fang , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-12-29 at 14:24 +0800, Ikjoon Jang wrote: > xhci-mtk has hooks on add_endpoint() and drop_endpoint() from xhci > to handle its own sw bandwidth managements and stores bandwidth data > into internal table every time add_endpoint() is called, > so when bandwidth allocation fails at one endpoint, all earlier > allocation from the same interface could still remain at the table. If failed to add an endpoint, will cause failure of its interface config, then the other endpoints in the same interface will be dropped later? you mean some endpoints in an interface may fail but without affecting its function? > > This patch adds two more hooks from check_bandwidth() and > reset_bandwidth(), and make mtk-xhci to releases all failed endpoints > from reset_bandwidth(). > > Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT") > Signed-off-by: Ikjoon Jang _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB3AC433DB for ; Fri, 8 Jan 2021 06:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63C7C233CF for ; Fri, 8 Jan 2021 06:35:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725901AbhAHGe4 (ORCPT ); Fri, 8 Jan 2021 01:34:56 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:45451 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725308AbhAHGe4 (ORCPT ); Fri, 8 Jan 2021 01:34:56 -0500 X-UUID: 55c8912c73be4b9ebcb8bec3238891e7-20210108 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FMnLCnisKI4QJNM0w1sFZfQNsdLpDgJ5G65JySoATkI=; b=soUUJ1C6hznBgM+w3yueqmo+Q4tJAZo9zIOhxZDGIG7ubUvSMl7cPvmGXuN6C+8WERRV2s3ZCTodJG056kf8nwuLhyLJ1tvbRvGLYdeBXr4VO2nsRaEDoai6ljrib4+R0Mb2Y6ca1cr47P8Nl3Fbhuu8k/Q9HR7UQCG8ZZwi5QQ=; X-UUID: 55c8912c73be4b9ebcb8bec3238891e7-20210108 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1488119658; Fri, 08 Jan 2021 14:34:12 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 Jan 2021 14:34:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 Jan 2021 14:34:08 +0800 Message-ID: <1610087648.24856.41.camel@mhfsdcap03> Subject: Re: [PATCH v5] usb: xhci-mtk: fix unreleased bandwidth data From: Chunfeng Yun To: Ikjoon Jang CC: , , "Tianping Fang" , Zhanyong Wang , Greg Kroah-Hartman , Mathias Nyman , Matthias Brugger , , Date: Fri, 8 Jan 2021 14:34:08 +0800 In-Reply-To: <20201229142406.v5.1.Id0d31b5f3ddf5e734d2ab11161ac5821921b1e1e@changeid> References: <20201229142406.v5.1.Id0d31b5f3ddf5e734d2ab11161ac5821921b1e1e@changeid> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 84426B80790F79195531223CD2A53D05FA1963BDE08E9CE47C2D172FE34682F02000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gVHVlLCAyMDIwLTEyLTI5IGF0IDE0OjI0ICswODAwLCBJa2pvb24gSmFuZyB3cm90ZToNCj4g eGhjaS1tdGsgaGFzIGhvb2tzIG9uIGFkZF9lbmRwb2ludCgpIGFuZCBkcm9wX2VuZHBvaW50KCkg ZnJvbSB4aGNpDQo+IHRvIGhhbmRsZSBpdHMgb3duIHN3IGJhbmR3aWR0aCBtYW5hZ2VtZW50cyBh bmQgc3RvcmVzIGJhbmR3aWR0aCBkYXRhDQo+IGludG8gaW50ZXJuYWwgdGFibGUgZXZlcnkgdGlt ZSBhZGRfZW5kcG9pbnQoKSBpcyBjYWxsZWQsDQo+IHNvIHdoZW4gYmFuZHdpZHRoIGFsbG9jYXRp b24gZmFpbHMgYXQgb25lIGVuZHBvaW50LCBhbGwgZWFybGllcg0KPiBhbGxvY2F0aW9uIGZyb20g dGhlIHNhbWUgaW50ZXJmYWNlIGNvdWxkIHN0aWxsIHJlbWFpbiBhdCB0aGUgdGFibGUuDQpJZiBm YWlsZWQgdG8gYWRkIGFuIGVuZHBvaW50LCB3aWxsIGNhdXNlIGZhaWx1cmUgb2YgaXRzIGludGVy ZmFjZQ0KY29uZmlnLCB0aGVuIHRoZSBvdGhlciBlbmRwb2ludHMgaW4gdGhlIHNhbWUgaW50ZXJm YWNlIHdpbGwgYmUgZHJvcHBlZA0KbGF0ZXI/IHlvdSBtZWFuIHNvbWUgZW5kcG9pbnRzIGluIGFu IGludGVyZmFjZSBtYXkgZmFpbCBidXQgd2l0aG91dA0KYWZmZWN0aW5nIGl0cyBmdW5jdGlvbj8N Cg0KPiANCj4gVGhpcyBwYXRjaCBhZGRzIHR3byBtb3JlIGhvb2tzIGZyb20gY2hlY2tfYmFuZHdp ZHRoKCkgYW5kDQo+IHJlc2V0X2JhbmR3aWR0aCgpLCBhbmQgbWFrZSBtdGsteGhjaSB0byByZWxl YXNlcyBhbGwgZmFpbGVkIGVuZHBvaW50cw0KPiBmcm9tIHJlc2V0X2JhbmR3aWR0aCgpLg0KPiAN Cj4gRml4ZXM6IDA4ZTQ2OWRlODdhMiAoInVzYjogeGhjaS1tdGs6IHN1cHBvcnRzIGJhbmR3aWR0 aCBzY2hlZHVsaW5nIHdpdGggbXVsdGktVFQiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBJa2pvb24gSmFu ZyA8aWtqbkBjaHJvbWl1bS5vcmc+DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37291C433E0 for ; Fri, 8 Jan 2021 06:37:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E139E233EA for ; Fri, 8 Jan 2021 06:37:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E139E233EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OPL+/SG1otCsG8pj0yVOL+Hm3ujnMoLBatukEaODLMg=; b=IRWv2DC9rxjN97wRIEQ6I9nAu hZPqMzgxnVuuW9pApcftP+7EcZEhZ7CJBlhVCZyx0kNGuPzPCM5FIBqgcSVeCkIZQE7joGIwjPRBM O76jPZSZPCt8vhprUuHC/x/a35DJMecvABY/XzEsXkK816mwzsLY2YbpBuNd4CB+3letG72DyEDyf uLctv9VUGz77NWP8QoFSL22/r5AmGv7fIEW6ndmE2gBdXYul78dz/TTqIPveJl/ZFtcKSFz/H+JhF PKsIQ6h20CuXOPnCD+35uLuxaLc0nizAyvrxtYrRhcu89/iZk1KbzieTVdgBZr+zx4dPUyTNSwuaA hWPagj4Sw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxlLq-0008V0-SF; Fri, 08 Jan 2021 06:34:22 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxlLn-0008UM-G6; Fri, 08 Jan 2021 06:34:20 +0000 X-UUID: c87ea4d3800a440e9c2e836de1af12f3-20210107 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FMnLCnisKI4QJNM0w1sFZfQNsdLpDgJ5G65JySoATkI=; b=avgFOjM+8Pn4d4n+HGLQNPqZ1SruwxX743zjH1KUFgtC82Pmz9rOjTZXmuvbmJDgJ3TTwxeNbkrXN46r4kz8+6zVjNWfCLu9yNN3AvBonq5kmC5XBkahAMUsih3fqQ6DXZJ9Hcdr8v5xT6fsHyzurwblAVugVhAvluT4PqCSnLk=; X-UUID: c87ea4d3800a440e9c2e836de1af12f3-20210107 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 748958017; Thu, 07 Jan 2021 22:34:14 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 Jan 2021 22:34:13 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 Jan 2021 14:34:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 Jan 2021 14:34:08 +0800 Message-ID: <1610087648.24856.41.camel@mhfsdcap03> Subject: Re: [PATCH v5] usb: xhci-mtk: fix unreleased bandwidth data From: Chunfeng Yun To: Ikjoon Jang Date: Fri, 8 Jan 2021 14:34:08 +0800 In-Reply-To: <20201229142406.v5.1.Id0d31b5f3ddf5e734d2ab11161ac5821921b1e1e@changeid> References: <20201229142406.v5.1.Id0d31b5f3ddf5e734d2ab11161ac5821921b1e1e@changeid> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 84426B80790F79195531223CD2A53D05FA1963BDE08E9CE47C2D172FE34682F02000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_013419_748926_772DF3F4 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhanyong Wang , Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tianping Fang , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-12-29 at 14:24 +0800, Ikjoon Jang wrote: > xhci-mtk has hooks on add_endpoint() and drop_endpoint() from xhci > to handle its own sw bandwidth managements and stores bandwidth data > into internal table every time add_endpoint() is called, > so when bandwidth allocation fails at one endpoint, all earlier > allocation from the same interface could still remain at the table. If failed to add an endpoint, will cause failure of its interface config, then the other endpoints in the same interface will be dropped later? you mean some endpoints in an interface may fail but without affecting its function? > > This patch adds two more hooks from check_bandwidth() and > reset_bandwidth(), and make mtk-xhci to releases all failed endpoints > from reset_bandwidth(). > > Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT") > Signed-off-by: Ikjoon Jang _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel