All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hemanth Selam <hemanth.selam@gmail.com>,
	Sebastian Reichel <sre@kernel.org>,
	Hans de Goede <hansg@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
	Purism Kernel Team <kernel@puri.sm>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] power: reset: add missing space in error message
Date: Mon, 7 Sep 2026 09:09:47 +0200	[thread overview]
Message-ID: <16106ae2-e3c8-4ecc-86ee-e9e09fc362ec@kernel.org> (raw)
In-Reply-To: <20260907063947.34852-3-hemanth.selam@gmail.com>

On 07/09/2026 08:39, Hemanth Selam wrote:
> The two string literals are concatenated, so the message prints "has to
> contain atleast one entry".  Add the missing space.
> 
> checkpatch.pl misses this one: neither literal is misspelled on its
> own, the fault only appears once they are joined.
> 
> Only the message text changes, no code changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  drivers/power/reset/keystone-reset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/keystone-reset.c b/drivers/power/reset/keystone-reset.c
> index 3c44cd6cee0a..dbf2e4274dc6 100644
> --- a/drivers/power/reset/keystone-reset.c
> +++ b/drivers/power/reset/keystone-reset.c
> @@ -112,7 +112,7 @@ static int rsctrl_probe(struct platform_device *pdev)
>  	for (i = 0; i < WDT_MUX_NUMBER; i++) {
>  		ret = of_property_read_u32_index(np, "ti,wdt-list", i, &val);
>  		if (ret == -EOVERFLOW && !i) {
> -			dev_err(dev, "ti,wdt-list property has to contain at"
> +			dev_err(dev, "ti,wdt-list property has to contain at "
>  				"least one entry\n");

Instead, string should not be wrapped.

You need to improve your interactions/prompts with your AI slop tool, so
it will follow Linux kernel coding style.

Best regards,
Krzysztof

  reply	other threads:[~2026-09-07  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  6:39 [PATCH 0/2] power: fix typos in comments Hemanth Selam
2026-09-07  6:39 ` [PATCH 1/2] power: supply: " Hemanth Selam
2026-09-07  6:39 ` [PATCH 2/2] power: reset: add missing space in error message Hemanth Selam
2026-09-07  7:09   ` Krzysztof Kozlowski [this message]
2026-09-09 20:49 ` (subset) [PATCH 0/2] power: fix typos in comments Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16106ae2-e3c8-4ecc-86ee-e9e09fc362ec@kernel.org \
    --to=krzk@kernel.org \
    --cc=hansg@kernel.org \
    --cc=hemanth.selam@gmail.com \
    --cc=kernel@puri.sm \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=sebastian.krzyszkowiak@puri.sm \
    --cc=sre@kernel.org \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.