All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: <asutoshd@codeaurora.org>, <nguyenb@codeaurora.org>,
	<hongwus@codeaurora.org>, <ziqichen@codeaurora.org>,
	<linux-scsi@vger.kernel.org>, <kernel-team@android.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	"Avri Altman" <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Bean Huo <beanhuo@micron.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Satya Tangirala" <satyat@google.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 2/3] scsi: ufs: Refactor ufshcd_init/exit_clk_scaling/gating()
Date: Wed, 20 Jan 2021 13:05:15 +0800	[thread overview]
Message-ID: <1611119115.1261.5.camel@mtkswgap22> (raw)
In-Reply-To: <1611057183-6925-3-git-send-email-cang@codeaurora.org>

Hi Can,

On Tue, 2021-01-19 at 03:53 -0800, Can Guo wrote:
> ufshcd_hba_exit() is always called after ufshcd_exit_clk_scaling() and
> ufshcd_exit_clk_gating(), so move ufshcd_exit_clk_scaling/gating() to
> ufshcd_hba_exit(). Meanwhile, add dedicated funcs to init and remove
> sysfs nodes of clock scaling/gating to make the code more readable.
> Overall functionality remains same.
> 
> Signed-off-by: Can Guo <cang@codeaurora.org>

Looks good to me.

BTW, FYI. this series has conflicts during the merge to the latest
for-next branch in Martin's tree.

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>




  reply	other threads:[~2021-01-20  5:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 11:52 [PATCH v10 0/3] Three changes related with UFS clock scaling Can Guo
2021-01-19 11:52 ` [PATCH v10 1/3] scsi: ufs: Protect some contexts from unexpected " Can Guo
2021-01-20  4:54   ` Stanley Chu
2021-01-20  8:29     ` Can Guo
2021-01-19 11:53 ` [PATCH v10 2/3] scsi: ufs: Refactor ufshcd_init/exit_clk_scaling/gating() Can Guo
2021-01-20  5:05   ` Stanley Chu [this message]
2021-01-19 11:53 ` [PATCH v10 3/3] scsi: ufs: Revert "Make sure clk scaling happens only when HBA is runtime ACTIVE" Can Guo
2021-01-19 11:53   ` Can Guo
2021-01-19 11:53   ` Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611119115.1261.5.camel@mtkswgap22 \
    --to=stanley.chu@mediatek.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=cang@codeaurora.org \
    --cc=hongwus@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nguyenb@codeaurora.org \
    --cc=satyat@google.com \
    --cc=ziqichen@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.